Mike McQuaid
7da934f7e2
Deprecate/disable/delete code.
...
The next release after this is merged will be 4.1.0.
Co-authored-by: Markus Reiter <me@reitermark.us>
2023-07-06 16:56:20 +01:00
Douglas Eichelberger
ec39fe7bb1
Merge pull request #15283 from dduugg/no-false-sigil
...
Remove `# typed: false` sigil in tests
2023-04-21 19:44:09 -07:00
Douglas Eichelberger
9075cbae62
brew style --fix
2023-04-21 09:58:50 -07:00
Douglas Eichelberger
ac1e6ded9a
git grep -l '# typed: false' | xargs gsed -i 's|# typed: false||g'
2023-04-21 09:57:47 -07:00
apainintheneck
a2f9f89d30
cask/audit_spec: fix outdated test
...
We used the binary artifact as an example of an unsigned artifact
before in this test. Now that we're adding it as a signed artifact
the test has been updated with another example of an unsigned one.
2023-04-20 23:37:05 -07:00
Issy Long
d636d2de37
Apply suggestions from review comments
...
- Rename `strictish` to `strict_only` in `add_error` method.
- Return just `errors`, a Set, not `{ errors: errors }`, a Hash,
from `Auditor.audit`.
2023-04-06 00:10:28 +01:00
Issy Long
df8e97fef6
Consolidate add_{warning,error} methods into one
...
- Specify `strictish: true` in `add_error` to specify that it's not a
super big critical error.
- These will be shown only if `brew audit --strict` is requested.
2023-04-01 01:56:47 +01:00
Issy Long
2b8127d518
Turn cask warnings into errors when --strict is passed (or implied)
...
- Ignore them and don't show them otherwise.
- Part three of issue 15074:
> As a result, I propose that all current cask audit warnings are never
> displayed as warnings but the underlying audit checks turned into
> errors displayed only with --strict (or one of the other relevant
> flags).
2023-04-01 01:56:46 +01:00
Markus Reiter
bdd6523ce8
Deprecate appcast.
2023-03-30 03:29:06 +02:00
Issy Long
3a83b5492c
rubocop: Clean up Style/BlockDelimiters excludes and autofix offenses
...
- The defaults of using "do ... end" for multi-line blocks everywhere is
good, better than switching everything to braces everywhere.
2023-03-08 23:54:22 +00:00
Markus Reiter
cd18703582
Add audit for versions containing colons or slashes.
2023-02-14 02:08:56 +01:00
Markus Reiter
b821a00bc5
Pass only and except to cask audits.
2023-02-08 08:38:32 +01:00
Alexander Regueiro
b2b7072fbe
Permit multiple uninstall stanzas in casks (temp)
...
Longer-term solution is described [here](https://github.com/Homebrew/brew/issues/14365#issuecomment-1398214354 ).
2023-01-21 18:45:58 +00:00
Sean Molenaar
f049e90e41
audit_spec: style fix
2022-09-15 15:33:25 +02:00
Sean Molenaar
5697ca79b1
audit_spec: limit stanza check
2022-09-15 15:27:43 +02:00
Sean Molenaar
ff54095b8a
Cask: automatically add cask audits
...
This reverts commit 16618374653dc5461dd971e8ed1992188cc3803d.
2022-09-13 11:19:33 +02:00
Mike McQuaid
1661837465
Revert "Cask: automatically add cask audits"
2022-09-06 11:46:40 +01:00
Sean Molenaar
86f011cefb
Cask: automatically add cask audits
2022-08-29 11:28:20 +02:00
Sean Molenaar
e90371f8ab
cask: add audit for incorrect signing
2022-08-11 09:11:29 +02:00
Sam Ford
77273fe2b3
Cask::Audit: Handle referenced cask in livecheck
...
`Cask::Audit#check_livecheck_version` was never updated to handle
a referenced cask in a `livecheck` block (e.g., `cask "other-cask"`).
As a result, this audit will wrongly give an error like `Version
'1.2.3' differs from '' retrieved by livecheck.` in this scenario.
This commit ensures that a referenced cask is handled by the audit
and it won't error when the referenced check provides a good version.
2021-11-02 12:32:38 -04:00
Sam Ford
e8f803bc75
Cask::Audit: Handle livecheck skip conditions
2021-06-14 14:28:27 -04:00
Markus Reiter
ba87bfc4e4
Only suggest adding livecheck it auto-detection fails.
2021-04-07 19:19:20 +02:00
Markus Reiter
72a79d934e
Fix audit annotations for casks.
2021-04-03 04:27:32 +02:00
Markus Reiter
c07205caf2
Adjust audit spec.
2021-04-02 01:55:36 +02:00
Markus Reiter
f0ece0432d
Fix appcast spec.
2021-04-01 01:07:28 +02:00
Mike McQuaid
9b725a5851
cask/dsl/version: reject invalid characters.
...
There was a `invalid_characters` method already but it was not being
used.
2021-03-30 14:15:14 +01:00
Bo Anderson
a8522c6db6
test/cask/audit_spec: add test for slashes in versions
2021-03-17 14:25:50 +00:00
Cassidy Marble
267040e5df
bugfix: Add args and options to lazy url block
2021-03-12 10:26:59 -07:00
Issy Long
e1ad07190e
rubocop: Fix RSpec/ContextWording offenses
...
- For some of these I changed `context` to `describe` as it fit better
rather than contriving a "when", "with" or "without", or massively
restructuring the tests.
2021-02-19 23:30:41 +00:00
Rylan Polster
af40e072b0
style: remove RSpec/NamedSubject violations
2021-02-01 20:30:51 -05:00
Mike McQuaid
03c861b7d7
Merge pull request #10428 from SeekingMeaning/cask-reverse-migration
...
cask/audit: disallow new cask to have token in tap_migrations.json
2021-01-27 15:07:13 +00:00
EricFromCanada
99ad3350ee
use single quotes around stanza and parameter names
2021-01-26 16:19:47 -05:00
Seeker
c1d2aaf13a
cask/audit: disallow new cask to have token in tap_migrations.json
2021-01-26 08:33:14 -08:00
Vítor Galvão
1ca68556e7
Cask: audit: Do not require appcast on GitHub releases
2021-01-17 00:48:33 +00:00
Markus Reiter
92b58666ef
Improve audit for livecheck in casks.
2021-01-13 08:12:11 +01:00
Markus Reiter
0ae8f0edc8
Merge pull request #9493 from reitermarkus/url-unversioned
...
Add audit for unversioned URLs with checksum.
2020-12-16 10:19:48 +01:00
Markus Reiter
44cf1041ac
Fix tests.
2020-12-16 09:45:58 +01:00
Markus Reiter
e194c86a2b
Fix audit for verified parameter.
2020-12-16 09:29:45 +01:00
Markus Reiter
287dfee35f
Properly handle ~ artifact targets.
2020-12-13 03:31:34 +01:00
linzichao
058a1c3645
add verified parameter in url
2020-12-01 01:17:21 +01:00
Markus Reiter
7a83f34dd1
Support casks in brew fetch.
2020-11-19 19:46:59 +01:00
Markus Reiter
24ae318a3d
Move type annotations into files.
2020-10-10 14:59:39 +02:00
Markus Reiter
c098ce5d16
Fix tests for cask audit.
2020-09-14 13:12:38 +02:00
Markus Reiter
f1bf6c03c3
Add tests for implications.
2020-09-04 05:29:56 +02:00
Markus Reiter
e5b56e485f
Move cask audit implications into Audit.
2020-09-04 04:47:31 +02:00
Markus Reiter
9ea1dcf4ca
Fix auditing of cask languages.
2020-08-12 00:45:01 +02:00
Markus Reiter
0d9e28d305
Don't warn about version designation in cask-versions tap.
2020-08-11 21:42:21 +02:00
Markus Reiter
549cd5b471
Ensure new casks have a description.
2020-08-10 19:51:03 +02:00
Markus Reiter
8a32954940
Move cask/all to just cask.
2020-08-09 01:34:07 +02:00
Markus Reiter
ee09df8db3
Move Download from Auditor into Audit.
2020-07-22 01:09:14 +02:00
