admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Improve audit for livecheck in casks.

Browse Source
This commit is contained in:
Markus Reiter 2021-01-08 03:48:53 +01:00
parent 99a7e2192c
commit 92b58666ef
2 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Library/Homebrew/cask/audit.rb
View File

@ -67,6 +67,7 @@ module Cask
check_single_uninstall_zap
check_untrusted_pkg
check_hosting_with_appcast
check_appcast_and_livecheck
check_latest_with_appcast_or_livecheck
check_latest_with_auto_updates
check_stanza_requires_uninstall
@ -283,18 +284,24 @@ module Cask
add_error "cannot use the sha256 for an empty string: #{empty_sha256}"
end
def check_appcast_and_livecheck
return unless cask.appcast
add_error "Cask has a `livecheck`, the `appcast` should be removed." if cask.livecheckable?
end
def check_latest_with_appcast_or_livecheck
return unless cask.version.latest?
add_error "Casks with an appcast should not use version :latest" if cask.appcast
add_error "Casks with a livecheck should not use version :latest" if cask.livecheckable?
add_error "Casks with an `appcast` should not use `version :latest`." if cask.appcast
add_error "Casks with a `livecheck` should not use `version :latest`." if cask.livecheckable?
end
def check_latest_with_auto_updates
return unless cask.version.latest?
return unless cask.auto_updates
add_error "Casks with `version :latest` should not use `auto_updates`"
add_error "Casks with `version :latest` should not use `auto_updates`."
end
def check_hosting_with_appcast

4
Library/Homebrew/test/cask/audit_spec.rb
View File

@ -647,7 +647,7 @@ describe Cask::Audit, :cask do
end
describe "latest with appcast checks" do
let(:message) { "Casks with an appcast should not use version :latest" }
let(:message) { "Casks with an `appcast` should not use `version :latest`." }
context "when the Cask is :latest and does not have an appcast" do
let(:cask_token) { "version-latest" }
@ -691,7 +691,7 @@ describe Cask::Audit, :cask do
end
describe "latest with auto_updates checks" do
let(:message) { "Casks with `version :latest` should not use `auto_updates`" }
let(:message) { "Casks with `version :latest` should not use `auto_updates`." }
context "when the Cask is :latest and does not have auto_updates" do
let(:cask_token) { "version-latest" }