admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
33,019 Commits 15 Branches 471 Tags
Commit Graph

33019 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Issy Long
f3d43110b5
test/rubocops/formula_desc: Ensure that desc allows ending with etc. 
- This was funny (and embarrassing), I was looking at my first contributions to
  Homebrew since someone asked me how long I'd been involved.
- Turns out that in 2017 I improved the formula description RuboCop rule to
  allow descriptions to end with `etc.` in
  https://github.com/Homebrew/brew/pull/3411. Apparently I didn't have time
  back then to write a test for it. So now I will remedy this 5 years later.
 2022-11-03 22:25:07 +00:00
Mike McQuaid
84caae3f8f
Merge pull request #14071 from Homebrew/tests_codespaces 
tests: fix under GitHub Codespaces.
 2022-11-03 17:04:15 +00:00
Mike McQuaid
2961132e01
tests: fix under GitHub Codespaces. 2022-11-03 16:33:04 +00:00
Sean Molenaar
e7b213c094
Merge pull request #14080 from p-linnane/sparkle-pre-el_capitan 2022-11-03 07:38:20 +01:00
Patrick Linnane
a975ad1a5c
Fix: Sparkle audit prior to el_capitan 2022-11-02 21:30:51 -07:00
Issy Long
aed0f93f60
Merge pull request #14076 from Homebrew/codespaces-add-ssh 
.devcontainer/on-create-command: Add `openssh-server` (for `gh cs ssh`)
 2022-11-03 00:08:01 +00:00
Mike McQuaid
5ef3d76c8d
Merge pull request #14070 from MikeMcQuaid/search_tty 
cmd/search: better handle non-TTY output.
 2022-11-02 15:14:46 +00:00
Issy Long
0a950a4c23
.devcontainer/on-create-command: Add openssh-server (for gh cs ssh) 
- My Codespaces workflow sometimes involves `gh cs ssh` for a terminal
  and tmux and vim (for better or for worse).
- I tried this on a `Homebrew/brew` Codespace and got this error. But it felt
  weird following that instruction to the letter and bloating the Docker image
  which we by default keep minimal.

```
❯ gh cs ssh
? Choose codespace: Homebrew/brew (master): redesigned spork
error getting ssh server details: failed to start server:
Please check if an SSH server is installed in the container.
If the docker image being used for the codespace does not have an SSH server,
install it in your Dockerfile or, for codespaces that use Debian-based images,
you can add the following to your devcontainer.json:

"features": {
    "ghcr.io/devcontainers/features/sshd:1": {
        "version": "latest"
    }
}
```
 2022-11-01 22:59:24 +00:00
Bo Anderson
73d535a206
Merge pull request #14074 from SMillerDev/fix/audit/sparkle_min_os 
fix: allow sparkle without a macOS version
 2022-11-01 21:25:19 +00:00
Bo Anderson
31e97ca500
cask/dsl/depends_on: fix type signature 2022-11-01 20:49:16 +00:00
Sean Molenaar
f5c6667980
Update Library/Homebrew/cask/audit.rb 
Co-authored-by: Bo Anderson <mail@boanderson.me>
 2022-11-01 21:13:03 +01:00
Sean Molenaar
94c0d8917e
fix: allow sparkle without a macOS version 2022-11-01 20:49:43 +01:00
Mike McQuaid
eea61a0ae9
Merge pull request #14072 from Homebrew/devcontainer-sorbet 
devcontainer/on-create-command: install Sorbet.
 2022-11-01 16:20:37 +00:00
Mike McQuaid
f977ff4892
devcontainer/on-create-command: install Sorbet. 
This doesn't take any longer and nice to have it cached.
 2022-11-01 15:49:10 +00:00
Mike McQuaid
8145d516e2
cmd/search: better handle non-TTY output. 
When `stdout` is not a TTY then using `ohai` is a bit unpleasant as it
prevents using pipes to do cool things with the output.
 2022-11-01 13:51:13 +00:00
Mike McQuaid
29e3e5906b
Merge pull request #14060 from SMillerDev/feature/cask/minos_audit 
cask: audit for minimal OS version in sparkle feeds
 2022-11-01 12:46:48 +00:00
Mike McQuaid
fa2649dde7
Merge pull request #14066 from Homebrew/devcontainer-tweaks 
devcontainer/on-create-command: do more stuff.
3.6.8 		2022-10-31 17:30:24 +00:00
Mike McQuaid
d8940d3cae
devcontainer/on-create-command: do more stuff. 
- fix permissions
- install more gems/formulae
- remove system shellcheck that won't be used
 2022-10-31 16:58:58 +00:00
Mike McQuaid
876b0dc759
Merge pull request #14065 from Bo98/cask-url-evaluate 
cask/artifact/relocated: don't evaluate URL on creation
 2022-10-31 13:39:03 +00:00
Bo Anderson
ad4730395a
cask/artifact/relocated: don't evaluate URL on creation 2022-10-31 13:07:25 +00:00
Issy Long
4c5feade88
Merge pull request #14062 from issyl0/rubocop-naming-method-parameter-name 
rubocop: Deal with some TODOs for `Naming/MethodParameterName`
 2022-10-31 12:56:04 +00:00
Mike McQuaid
9d4588cf7d
Merge pull request #14055 from Undre4m/docs/zsh-completions-reword 
Fix Oh-My-Zsh suggested completions configuration
 2022-10-31 12:21:28 +00:00
Sean Molenaar
73d124f342
audit: make min OS check depend on online? 2022-10-31 09:00:43 +01:00
Bo Anderson
4e48a9e6c1
Merge pull request #14061 from Bo98/softwareupdate 
os/mac/xcode: do not recommend `softwareupdate` CLI
 2022-10-31 01:33:54 +00:00
Issy Long
c4e6a46271
rubocop: Set inherit_mode for allowed Naming/MethodParameterName 
- As I was looking through the RuboCop configs for
  `Naming/MethodParameterName`, since there was a fairly long-standing
  TODO here, I found that in the default RuboCop configs the method
  names `to` and `io` are
  [allowed by default](41a8249b35/config/default.yml (L2794)).
- But we weren't inheriting those allowed names correctly from the
  default configuration. This fixes that so that we get future
  enhancements automatically for this particular cop allowlist.
 2022-10-30 21:49:40 +00:00
Issy Long
c53b14e955
rubocop: Remove _ from allowed Naming/MethodParameterName 
- As of RuboCop v0.67.0 (quite some time ago!), this rule allows `_` by
  default as it commonly denotes "this argument is unused". This is not
  set upstream in `AllowedNames`, the code
  [ignores underscores](4bc7d8c1bc (diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed))
  entirely.
 2022-10-30 21:48:17 +00:00
Sean Molenaar
b27aeb8f94
Update Library/Homebrew/cask/audit.rb 
Co-authored-by: Bo Anderson <mail@boanderson.me>
 2022-10-30 19:41:51 +01:00
Bo Anderson
a99323e5a6
os/mac/xcode: do not recommend softwareupdate CLI 2022-10-30 18:16:08 +00:00
Sean Molenaar
012bd1f134
cask: audit for minimal OS version in sparkle feeds 2022-10-30 15:00:56 +01:00
Lucas Astrada
a58dffc636
Reword suggestion to be more clear of command placement 
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
 2022-10-27 13:26:11 -03:00
Mike McQuaid
31758eaa02
Merge pull request #14027 from MikeMcQuaid/devcontainer 
Add VSCode devcontainers
 2022-10-27 09:43:09 +01:00
Mike McQuaid
dd39b2be64
Add VSCode devcontainers 
Should be useful for getting a development environment setup quickly.
 2022-10-27 09:18:49 +01:00
Mike McQuaid
3da846d1b1
Merge pull request #14056 from ThatsJustCheesy/cache-regexes 
Improve performance of `brew info` by caching compiled regexes
 2022-10-27 08:53:59 +01:00
Ian Gregory
cdc707fa38 Cache compiled regexes 
Improves performance of `brew info --json=v2 --eval-all` by about 15–20%
 2022-10-27 02:06:22 -04:00
Lucas Astrada
d1d332aed8 Fix Oh-My-Zsh suggested configuration breaking completions on non-login shells 2022-10-26 21:31:52 -03:00
Mike McQuaid
560f5717ad
Merge pull request #14051 from Homebrew/sponsors-maintainers-man-completions 
Update manpage and completions.
 2022-10-26 12:42:28 +01:00
BrewTestBot
666c156de0
Update manpage and completions. 
Autogenerated by the [sponsors-maintainers-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sponsors-maintainers-man-completions.yml) workflow.
 2022-10-26 11:17:55 +00:00
Mike McQuaid
7eb68835cc
Merge pull request #14033 from ThatsJustCheesy/cask-install-adopt 
Add `--adopt` switch
 2022-10-26 12:16:49 +01:00
Mike McQuaid
30f069f60a
Merge pull request #14045 from Bo98/bump-formula-pr-version 
dev-cmd/bump-formula-pr: allow --version for version formatting changes
 2022-10-26 12:12:27 +01:00
Ian Gregory
a0f915169c Remove --adopt switch from reinstall and upgrade 2022-10-25 19:07:21 -04:00
Ian Gregory
9256a01afe
Apply suggestions from code review 
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
 2022-10-25 18:58:06 -04:00
Bo Anderson
c7f1a45ece
Merge pull request #14046 from Bo98/unbottled-dependents 
dev-cmd/unbottled: fix --dependents erroring
 2022-10-25 23:04:48 +01:00
Bo Anderson
ee64886554
Merge pull request #14041 from Bo98/no-sitedir 
Remove sitedir from LOAD_PATH
 2022-10-25 23:02:10 +01:00
Bo Anderson
b500aee799
dev-cmd/bump-formula-pr: allow --version for version formatting changes 2022-10-25 15:46:27 +01:00
Bo Anderson
e47988a12b
dev-cmd/unbottled: fix --dependents erroring 2022-10-25 15:44:29 +01:00
Mike McQuaid
f9e49a89ab
Merge pull request #14044 from MikeMcQuaid/bump_nokogiri 
Gemfile: bump nokogiri.
 2022-10-25 13:27:25 +01:00
Mike McQuaid
6b1aa77ead
Gemfile: bump nokogiri. 
To address a vulnerability.
 2022-10-25 12:56:06 +01:00
Bo Anderson
4c9eee3bf8
Merge pull request #14043 from Bo98/allow-ruby-2.6.10 
os/mac/diagnostic: allow Ruby 2.6.10 on < Ventura
 2022-10-25 12:02:52 +01:00
Bo Anderson
476b5e7424
os/mac/diagnostic: allow Ruby 2.6.10 on < Ventura 2022-10-25 10:55:05 +01:00
Mike McQuaid
b9411ef8a6
Merge pull request #14035 from hmarr/git-partial-clone-sparse-checkout 
Support git partial clones with sparse checkouts (take 2)
 2022-10-25 09:28:29 +01:00