13054 Commits

Author SHA1 Message Date
Mike McQuaid
1f48e17f1b rubocop: fix brew style warnings. 2018-01-17 10:42:43 +00:00
Shaun Jackman
3f8dd656d3 publish_bottle_file_on_bintray: Use f.full_name 2018-01-16 10:41:41 -08:00
Mike McQuaid
8cd0d85afb rubocop 0.52.1 2018-01-15 16:17:32 +00:00
Markus Reiter
f90e6f82c8
Merge pull request #3680 from commitay/moved-permissions
cask moved: check target writable for move_back
2018-01-15 15:28:55 +01:00
ilovezfs
17f80a44e6
Revert "Use Homebrew's gitconfig for various commands" 2018-01-15 07:30:56 +00:00
Mike McQuaid
253a41f523
Merge pull request #3670 from MikeMcQuaid/gitconfig
Use Homebrew's gitconfig for various commands
2018-01-14 18:17:06 +00:00
Mike McQuaid
fcec5ad360
Merge pull request #3683 from MikeMcQuaid/vendor-install-mirror
vendor-install: various portable ruby tweaks.
2018-01-14 18:16:52 +00:00
Mike McQuaid
fea90825fb vendor-install: various portable ruby tweaks.
- Rename repository to homebrew-portable-ruby
- Add a new Bintray repository using new name
- Add GitHub releases mirror and try to use it
- Tell people not to file issues if they can't connect to Bintray or
  GitHub: we're not here to provide ISP/proxy support.
2018-01-14 13:49:26 +00:00
Mike McQuaid
b70b5429d0 Deprecate default_formula Requirement DSL
This has been a nightmare in terms of the complexity to our dependency
system and the whack-a-mole required on bugs. If a Requirement resolves
to a Formula it should just use `depends_on "formula"` instead. This
matches the effective behaviour all users of bottles (the vast majority
of users and installs) and what we're doing in Homebrew/homebrew-core.
2018-01-14 13:27:43 +00:00
Kevin Abel
0254605cd5
Handle reaching the top of a URL which searching for file ext
Should never reach this as most URL's will have a domain name that will
be caught as an extname.
2018-01-13 17:06:21 -06:00
commitay
8bf9484823 cask moved: check target writable for move_back 2018-01-13 21:31:00 +10:00
commitay
e870c1783f cask doctor: sip status 2018-01-13 08:47:10 +10:00
Mike McQuaid
228cbd81c9 Use Homebrew's gitconfig for various commands
Git is a transport and storage mechanism for us so we don't want to
allow arbitrary customisation of this due to user issues e.g. #3664
and #3561.

Fixes #3664.
2018-01-11 20:40:59 +00:00
Mike McQuaid
02591bdf34
Merge pull request #3662 from MikeMcQuaid/curl-executable
curl: handle more non-executable curl edge-cases.
2018-01-11 19:41:23 +00:00
Mike McQuaid
924865ec7f curl: handle more non-executable curl edge-cases.
Address some additional issues mentioned in #3624.
2018-01-11 16:33:20 +00:00
Mike McQuaid
e903a5f655
formula: tweak more depends_on examples. 2018-01-11 13:33:54 +00:00
Michihito Shigemura
f5e8b2680e docs: Fix depends_on examples in Formula page
example:

Error: depends_on :mysql
Correct: depends_on "mysql"
2018-01-11 21:05:14 +09:00
Mike McQuaid
838a3f1996 reinstall/upgrade: stop unlinked kegs being sticky
It's not possible to determine the difference between a non-keg-only
keg that failed to link and one that wasn't linked by us intentionally.

To avoid additional complexity of storing this logic in another place
let's back out this relatively new functionality; sticky keg-only links
is a better and more desirable behaviour anyway.
2018-01-10 16:43:21 +00:00
Mike McQuaid
b66010605d
Merge pull request #3651 from MikeMcQuaid/deprecate-git-svn-requirements
Deprecate Git, Subversion requirements.
2018-01-10 13:40:55 +00:00
Mike McQuaid
27be33b245 Deprecate Git, Subversion requirements.
These rely on `default_formula` to be useful and are better following
the `*_dep_if_needed` pattern.
2018-01-10 13:19:50 +00:00
Mike McQuaid
b29213a663
Merge pull request #3655 from MikeMcQuaid/formula-cop-hash-match-array
formula_cop: match any values in hash match.
2018-01-10 09:09:50 +00:00
Mike McQuaid
69b38dd9db
Merge pull request #3654 from sjackman/check_install_sanity
check_install_sanity: Use formula.runtime_dependencies
2018-01-10 09:07:17 +00:00
Kevin Abel
dca8dc5bf5
Fix audit 2018-01-09 20:11:52 -06:00
Kevin Abel
06f2b50ee4
Fix cached download file extension for certain URL
PHP URLs have the downloadable file in the middle of the pathname. If no
extension is detected, continue up the pathname.
2018-01-09 19:56:54 -06:00
Mike McQuaid
7f2fda104a formula_cop: match any values in hash match.
e.g. match an array or symbol or string.
2018-01-09 20:08:22 +00:00
Alyssa Ross
f06b54f1bb
Merge pull request #3653 from alyssais/installed_on_request
Preserve installed_on_request for dependencies
2018-01-09 20:02:45 +00:00
Mike McQuaid
2cbce1fbf0 Add more deprecations, disable some existing ones.
Add more `odeprecated` calls to places that have been deprecated for a
while in the wild and move some of the existing `odeprecated` calls to
be `odisabled` to allow deleting the compatibility code.
2018-01-09 19:52:34 +00:00
Shaun Jackman
95bf23404e check_install_sanity: Use formula.runtime_dependencies
Fix Error: wget contains conflicting version recursive dependencies:
openssl, openssl@1.1
2018-01-09 10:35:59 -08:00
Alyssa Ross
ef82b188f2
Preserve installed_on_request for dependencies
Fixes https://github.com/Homebrew/brew/issues/3642.
2018-01-09 16:37:59 +00:00
Mike McQuaid
50a84f2535 audit: allow env :std in custom taps.
This is a nicer experience than writing `Requirement`s by hand.
2018-01-09 15:26:54 +00:00
Mike McQuaid
9ed1ed3c05 upgrade: fix UnsatisfiedRequirements exit code. 2018-01-09 09:07:37 +00:00
Mike McQuaid
dbeebcaef5 upgrade: skip formula if upgrade fails.
Rather than blocking the rest of the formulae from being installed by
`brew upgrade` print the requirement failure messages (already done) and
an error stating requirements weren't satisfied and then continue to
upgrade the rest of the formulae.
2018-01-08 14:38:10 +00:00
Steven Peters
913ff483f0 Use hgpath instead of "hg" to fix --HEAD hg builds
Fixes #3628.
With environment filtering, hg was no longer in the path,
so make sure to provide the path when calling hg commands.
last_commit was the source of the problem in #3628
but I fixed source_modified_time as well.
I didn't see any others with this problem.
2018-01-08 00:24:02 -08:00
Mike McQuaid
09bfb2a8f0
Merge pull request #3633 from MikeMcQuaid/lines_cop_version
lines_cop: flag `depends_on :perl => "1.0"`.
2018-01-07 15:39:37 +00:00
Mike McQuaid
1bd7d7df04 Use parser 2.4.0.0
This matches the version that supports Ruby 2.3.3 syntax (which is the
version we use).
2018-01-07 14:29:19 +00:00
Mike McQuaid
4e29152603 formula_cop: use undeprecated add_offense form. 2018-01-07 14:25:07 +00:00
Mike McQuaid
c8b859faad lines_cop: flag depends_on :perl => "1.0".
This requires ignoring the version argument with a new `:any` mode
for this check.
2018-01-07 14:08:58 +00:00
commitay
8a419b4742 audit: pass explicit sort to handle APFS 2018-01-07 13:36:16 +10:00
Mike McQuaid
069b61029b
Merge pull request #3627 from sjackman/circleci
pathname: Use CI env variable rather than TRAVIS
2018-01-04 08:28:34 +00:00
Shaun Jackman
841dae4b8c pathname: Use CI env variable rather than TRAVIS 2018-01-03 13:17:23 -08:00
Shaun Jackman
5d9149a4b9 LD64Dependency is needed on macOS only
Move ld64_dependency.rb to os/mac/.
2018-01-03 10:52:12 -08:00
Mike McQuaid
fab0ea6fda Deprecate Homebrew/homebrew-science 2018-01-01 09:33:43 +00:00
Mike McQuaid
93a2e9fc25
Merge pull request #3612 from MikeMcQuaid/more-deprecations
requirements: move more to compat.
2017-12-31 16:11:21 +00:00
Mike McQuaid
c449bdb92c
Merge pull request #3616 from MikeMcQuaid/existing-install-options
reinstall/upgrade: document use of options.
2017-12-31 10:20:52 +00:00
Mike McQuaid
e048106624
Merge pull request #3614 from MikeMcQuaid/previously-deleted-month
missing_formula: check deleted in the last month.
2017-12-31 09:42:36 +00:00
Mike McQuaid
884a2f3667
Merge pull request #3618 from ilovezfs/python-teach-virtualenv-to-speak-@
language/python: handle python@* in virtualenv_install_with_resources
2017-12-31 09:42:23 +00:00
commitay
de4b126e5c cask manpage: upgrade 2017-12-31 09:39:47 +10:00
ilovezfs
5496a04dd9 language/python: handle python@* in virtualenv_install_with_resources 2017-12-30 15:11:14 -08:00
Mike McQuaid
7eb1fd6671 reinstall/upgrade: document use of options.
To avoid user confusion e.g. #3606.
2017-12-30 21:23:33 +00:00
Mike McQuaid
799312c5fc missing_formula: check deleted in the last month.
This speeds things up pretty dramatically and handles the case that
something was deleted recently and users haven't learned about it yet.

Fixes #3513.
2017-12-30 21:18:02 +00:00