admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

missing_formula: check deleted in the last month.

Browse Source 
This speeds things up pretty dramatically and handles the case that
something was deleted recently and users haven't learned about it yet.

Fixes #3513.
This commit is contained in:
Mike McQuaid 2017-12-30 21:18:02 +00:00
parent 176ed97d42
commit 799312c5fc
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/missing_formula.rb
View File

@ -122,7 +122,7 @@ module Homebrew
tap.path.cd do
unless silent
ohai "Searching for a previously deleted formula..."
ohai "Searching for a previously deleted formula (in the last month)..."
if (tap.path/".git/shallow").exist?
opoo <<~EOS
#{tap} is shallow clone. To get complete history run:
@ -132,7 +132,7 @@ module Homebrew
end
end
log_command = "git log --name-only --max-count=1 --format=%H\\\\n%h\\\\n%B -- #{relative_path}"
log_command = "git log --since='1 month ago' --diff-filter=D --name-only --max-count=1 --format=%H\\\\n%h\\\\n%B -- #{relative_path}"
hash, short_hash, *commit_message, relative_path =
Utils.popen_read(log_command).gsub("\\n", "\n").lines.map(&:chomp)

2
Library/Homebrew/test/missing_formula_spec.rb
View File

@ -140,6 +140,8 @@ describe Homebrew::MissingFormula do
tap_path = Tap::TAP_DIRECTORY/"homebrew/homebrew-foo"
tap_path.mkpath
(tap_path/"deleted-formula.rb").write "placeholder"
ENV.delete "GIT_AUTHOR_DATE"
ENV.delete "GIT_COMMITTER_DATE"
tap_path.cd do
system "git", "init"