2459 Commits

Author SHA1 Message Date
Mike McQuaid
c57ab279ba Use rspec-retry in flaky brew tests.
We have a few tests that are intermittently flaky. Let's try this to see
if we can get them a bit more reliable.
2018-02-13 09:34:25 +00:00
Mike McQuaid
2a9660fb2b
Merge pull request #3657 from kabel/php-cache-ext
Fix cached download file extension for certain URLs
2018-02-13 09:09:11 +00:00
joshua stein
7388acb86e Tty: if HOMEBREW_NO_COLOR env var is present, disable color
bin/brew will recognize NO_COLOR variable and copy it to
HOMEBREW_NO_COLOR
2018-02-12 14:19:25 -06:00
Alyssa Ross
8386e6a8c1
Undeclared dependencies in runtime_dependencies
Fixes https://github.com/Homebrew/brew/issues/2173.
2018-02-11 13:44:20 +00:00
William Woodruff
3f43f60a2a
audit: Warn on new formulae containing binary URLs 2018-02-06 08:44:56 -05:00
Markus Reiter
9f4b4a1699
Merge pull request #3740 from reitermarkus/cask-style
Fix `brew cask style` on Travis.
2018-01-28 17:53:49 +01:00
Markus Reiter
884c57f9f4 Fix brew cask style on Travis. 2018-01-28 07:00:20 +01:00
Markus Reiter
6760d26319 Create Hbc::Config class. 2018-01-27 21:47:18 +01:00
ilovezfs
7c07ec5fc1 resource: allow patches to be applied 2018-01-22 01:10:14 -08:00
ilovezfs
da77f23bc7 rubocop: don't always display cop names. 2018-01-21 07:23:53 -08:00
Mike McQuaid
b96ec879dc (un)linkapps: hide from manpage, use odeprecated. 2018-01-21 13:38:44 +00:00
Alyssa Ross
8874d1fb13
prepend instead of alias hacks for deprecations 2018-01-18 21:08:41 +00:00
Mike McQuaid
8a45467ad9
Merge pull request #3661 from MikeMcQuaid/deprecate-default-formula
Deprecate default_formula Requirement DSL
2018-01-18 15:30:56 +00:00
Mike McQuaid
e67b745b2f
Merge pull request #3659 from MikeMcQuaid/deprecated-requirements-harder
Deprecate requirements harder
2018-01-18 15:27:02 +00:00
Mike McQuaid
e5c82dd3d9 Deprecate requirements harder
Remove more Requirement logic to enable future removal of default
formula logic. Also, output deprecations, convert symbol requirement
usage to deps and simplify the compatibility code for the direct
Requirement usage.
2018-01-18 08:31:20 +00:00
Mike McQuaid
1f48e17f1b rubocop: fix brew style warnings. 2018-01-17 10:42:43 +00:00
Mike McQuaid
8cd0d85afb rubocop 0.52.1 2018-01-15 16:17:32 +00:00
Mike McQuaid
b70b5429d0 Deprecate default_formula Requirement DSL
This has been a nightmare in terms of the complexity to our dependency
system and the whack-a-mole required on bugs. If a Requirement resolves
to a Formula it should just use `depends_on "formula"` instead. This
matches the effective behaviour all users of bottles (the vast majority
of users and installs) and what we're doing in Homebrew/homebrew-core.
2018-01-14 13:27:43 +00:00
Mike McQuaid
27be33b245 Deprecate Git, Subversion requirements.
These rely on `default_formula` to be useful and are better following
the `*_dep_if_needed` pattern.
2018-01-10 13:19:50 +00:00
Kevin Abel
06f2b50ee4
Fix cached download file extension for certain URL
PHP URLs have the downloadable file in the middle of the pathname. If no
extension is detected, continue up the pathname.
2018-01-09 19:56:54 -06:00
Mike McQuaid
1bd7d7df04 Use parser 2.4.0.0
This matches the version that supports Ruby 2.3.3 syntax (which is the
version we use).
2018-01-07 14:29:19 +00:00
Mike McQuaid
fab0ea6fda Deprecate Homebrew/homebrew-science 2018-01-01 09:33:43 +00:00
Mike McQuaid
93a2e9fc25
Merge pull request #3612 from MikeMcQuaid/more-deprecations
requirements: move more to compat.
2017-12-31 16:11:21 +00:00
Mike McQuaid
799312c5fc missing_formula: check deleted in the last month.
This speeds things up pretty dramatically and handles the case that
something was deleted recently and users haven't learned about it yet.

Fixes #3513.
2017-12-30 21:18:02 +00:00
Mike McQuaid
f9b6407110 lines_cop: deprecate 'needs :openmp'. 2017-12-30 20:56:55 +00:00
Mike McQuaid
d54e670a64 requirements: move more to compat. 2017-12-30 20:56:55 +00:00
Mike McQuaid
c6eaa73db1
Merge pull request #3604 from alyssais/cask_no_arguments
cask: exit successfully when given no arguments.
2017-12-29 15:53:39 +00:00
Alyssa Ross
78fe082a2b
cask: exit successfully when given no arguments
Fixes https://github.com/Homebrew/brew/issues/3601.
2017-12-24 15:06:49 +00:00
Mike McQuaid
38ce994007 Deprecate more requirements.
These are ones that were either already deprecated due to audit rules
or are just a simple `which` with a `default_formula` so should just
be a dependency.
2017-12-23 16:53:25 +00:00
Mike McQuaid
b4d43e950f
Merge pull request #3401 from DomT4/vendor_or_na
go: various tweaks to recommendations
2017-12-16 13:34:22 +00:00
Mike McQuaid
8ed1425ed7 tests: don't output seed multiple times.
This clutters up the output. Instead, hide it with a RSpec formatter and
generate and output it ourselves.
2017-12-15 09:14:44 +00:00
Mike McQuaid
837ea74f44
Merge pull request #3543 from MikeMcQuaid/remove-env-unsets
Remove some unset/checked environment checks
2017-12-10 17:46:29 +00:00
Mike McQuaid
b41eb9d306
Merge pull request #3510 from MikeMcQuaid/remove-bottle-hooks
hooks/bottles: remove bottle hooks.
2017-12-10 17:46:10 +00:00
Mike McQuaid
6b9ca5dbf5 Remove some unset/checked environment checks
These will be redundant once environment filtering is on by default
in #3529.
2017-12-08 16:33:33 +00:00
Mike McQuaid
b9cf7b2bbc formula_installer: avoid irrelevant build deps.
If dependents are already installed ensure their build dependencies (and
requirements) don't end up in the dependency/requirement tree.

Fixes #3033.
2017-12-07 14:56:12 +00:00
Markus Reiter
0ad42ebbcb
Merge pull request #3522 from reitermarkus/caskroom
Remove unused writer methods for `Hbc.caskroom` and `Hbc.cache`.
2017-12-03 19:35:51 +01:00
Mike McQuaid
8b9ac2b2e0 x11_requirement: remove custom minimum version.
This isn't desired or needed. Ensure older code still works, though.
2017-12-03 13:33:16 +00:00
Mike McQuaid
0d53831b90
Merge pull request #3515 from sjackman/popen
Utils.popen_read: Nonexistent program should fail
2017-12-03 09:23:01 +00:00
Markus Reiter
a02ce4f8e9 Also remove writer method for Hbc.binarydir. 2017-12-03 10:09:09 +01:00
Markus Reiter
e4bb09dd40 Remove unused writer methods for Hbc.caskroom and Hbc.cache. 2017-12-03 09:58:01 +01:00
Shaun Jackman
7adee6d62f Utils.popen_read: Nonexistent program should fail
Ensure that $CHILD_STATUS.success? is false when the command does not exist.
2017-12-02 15:52:01 -08:00
Mike McQuaid
780e86904b
Merge pull request #3518 from GauthamGoli/audit_bug_fix
lines_cop: Convert ARGV audit to negative look ahead
2017-12-02 17:22:14 +00:00
Shaun Jackman
7c6d2c95f6 Fix a test failure when svn is not installed 2017-12-02 09:04:42 -08:00
Gautham Goli
fb85ed01bc lines_cop: Convert ARGV audit to negative look ahead 2017-12-02 17:03:11 +05:30
Mike McQuaid
8bbe9b744f hooks/bottles: remove bottle hooks.
These were removed from Boxen in:
https://github.com/boxen/puppet-homebrew/pull/108
2017-12-01 09:51:10 +00:00
Mike McQuaid
959538caf5 cleaner_spec: have a single "cleans files" test.
This avoids noting the the Linux test as "pending" on Mac.
2017-11-29 18:27:16 +00:00
L. E. Segovia
10a0662dc0 Test upgrade for Casks with version :latest 2017-11-28 00:29:45 +00:00
Markus Reiter
f50ae44980
Merge pull request #3396 from amyspark/hacktoberfest-upgrade
Implement `brew cask upgrade`
2017-11-27 23:41:03 +01:00
Mike McQuaid
fb6cf0c3f8 More environment filtering fixes
- Make `brew pull` pass through Git environment variables
- Whitelist all `TRAVIS_` variables.
2017-11-27 10:48:03 +00:00
L. E. Segovia
8abe60d2dc Remove redundant --greedy 2017-11-27 10:15:13 +00:00