13531 Commits

Author SHA1 Message Date
Markus Reiter
9d82acbf30 Separate Homebrew::TestCase from testing_env. 2016-11-16 23:52:38 +01:00
Markus Reiter
7b9fd538fa Move integration_mocks to test/support/helper. 2016-11-16 23:52:38 +01:00
Markus Reiter
4db1317f38 Move all remaining fixtures to test/support/fixtures. 2016-11-16 23:52:38 +01:00
Markus Reiter
4efdbbde06 Rename fs_leak_log to fs_leak.log and move to tmp. 2016-11-16 23:52:37 +01:00
Markus Reiter
e3be9c068b Update .rubocop_todo.yml. 2016-11-16 23:52:37 +01:00
Markus Reiter
6b6b27126d Reorder and rename test files. 2016-11-16 23:52:37 +01:00
Mike McQuaid
edf042ee97 Merge pull request #1522 from MikeMcQuaid/audit-one-previous-commit
audit: only check previous formula version.
1.1.1
2016-11-16 10:25:11 +00:00
Mike McQuaid
768a08ae63 Merge pull request #1517 from MikeMcQuaid/audit-stable-version-empty
audit: check that there are any stable revisions.
2016-11-16 09:41:44 +00:00
Mike McQuaid
31caa8ef93 audit: only check previous formula version.
For calculating the stable/devel versions this should be sufficient as
it's looking at `origin/master` so for a e.g. unmerged pull request this
will stop complaining about mistakes outside the pull request itself.

This will silence all warnings for historic version mistakes (i.e.
before these audit checks were all enabled) which is normally a bad
thing but as this case would rely on modifying history to complete is a
good one.
2016-11-16 09:03:20 +00:00
Mike McQuaid
27ea94adb8 audit: check that there are any stable revisions.
Fixes the exception if `revision_map[formula.stable.version]` is `nil`.
2016-11-16 08:59:52 +00:00
Uladzislau Shablinski
715caea79b cmd/list: follow aliases
Closes #1514
2016-11-16 02:08:38 +03:00
Josh Hagins
34f08a9512 Merge pull request #1513 from Homebrew/jawshooah-patch-1
hbc/cmd/style: bump rubocop-cask to 0.10.6
2016-11-15 13:08:24 -05:00
Josh Hagins
c20d50fc7a hbc/cmd/style: bump rubocop-cask to 0.10.6 2016-11-15 11:57:10 -05:00
Mike McQuaid
f4f90cad75 Merge pull request #1510 from MikeMcQuaid/uninstall-no-nils
uninstall: remove nil requireds/dependents
2016-11-15 15:29:15 +00:00
Mike McQuaid
a92da09609 Merge pull request #1509 from MikeMcQuaid/development-tools-no-nil-versions
development_tools: don't create Versions from `nil`
2016-11-15 15:29:03 +00:00
Mike McQuaid
673c4c78bd Merge pull request #1508 from MikeMcQuaid/uninstall-skip-flaky-tests
uninstall: skip some flaky tests for now.
2016-11-15 14:50:43 +00:00
Mike McQuaid
727263e906 development_tools: don't create Versions from nil
This cause issues when e.g. using `debrew.rb` on a failing `system`
command in a formula.
2016-11-15 14:43:56 +00:00
Mike McQuaid
d7e72899e6 uninstall: remove nil requireds/dependents
These shouldn’t get here in the first place so this is a bit of a hack
pending a better fix.
2016-11-15 14:34:49 +00:00
Mike McQuaid
50c964df2e uninstall: skip some flaky tests for now.
These will be fixed properly later but this will avoid causing
unnecessary CI failures.
2016-11-15 14:32:13 +00:00
Mike McQuaid
c1af8fba55 Merge pull request #1506 from MikeMcQuaid/audit-fix-version-not-decrease-again
audit: fix "version should not decrease" (again).
2016-11-15 12:36:06 +00:00
Mike McQuaid
5e0b3d24e5 audit: fix "version should not decrease" (again).
- output the max version and current version to make the message more
  obvious.
- Don't compare the development spec version to the formula version and
  then complain the formula version is lower (it should always be!)
2016-11-15 09:02:50 +00:00
Mike McQuaid
484e3e0769 Merge pull request #1498 from alyssais/uninstall_developer_warning
Warn developers when uninstalling a dependency
2016-11-15 08:15:42 +00:00
Misty De Meo
30fdbe089b Merge pull request #1435 from mistydemeo/dev_tools_version
Add "null version" class, and return compiler versions/build versions as Version objects
2016-11-14 13:44:03 -08:00
Markus Reiter
3a01fbadcd Merge pull request #1362 from reitermarkus/rubocop
Update RuboCop to 0.45.0.
2016-11-14 16:50:24 +01:00
Markus Reiter
ee143482e4 Merge pull request #1504 from reitermarkus/exe-cab-containers
Fix detection of self-extracting `.exe` files.
2016-11-14 16:49:25 +01:00
Markus Reiter
ff96f7ec26 Fix detection of self-extracting .exe files. 2016-11-14 15:30:48 +01:00
Alyssa Ross
ca3562645c uninstall: style fixes
Works around Rubycop not liking method names that start with `is_`
by changing convention from singular to plural.

I think it's better that way anyway.
2016-11-14 13:39:17 +00:00
Alyssa Ross
c77040b346 uninstall: clean up warnings 2016-11-14 13:09:40 +00:00
Alyssa Ross
14099ffaf3 utils: fix capture_stderr style 2016-11-14 12:28:45 +00:00
Alyssa Ross
3c310b2e3d Warn developers when uninstalling a dependency
Suggested in #1084.

Made the existing warning output entirely to STDERR, because
previously the first line went to STDERR and subsequent ones went
to STDOUT.
2016-11-14 12:13:34 +00:00
Mike McQuaid
c4c9c6bc0c Merge pull request #1501 from MikeMcQuaid/no-complain-brew-install-args
Don't warn about unused `brew install` arguments.
2016-11-14 12:09:44 +00:00
Mike McQuaid
cc3bf7bcb5 Don't warn about unused brew install arguments.
This is a step closer to better argument handling but for now just
fixes the issue in #1217 where it starts complaining about options like
`--build-from-source` being used.
2016-11-14 09:28:28 +00:00
Markus Reiter
6c1d42386d Remove flat_map compatibility layer. 2016-11-14 09:45:44 +01:00
Markus Reiter
353b67a6b2 No empty whens. 2016-11-14 09:45:44 +01:00
Mike McQuaid
5294b99d6f Merge pull request #1500 from JCount/formula_versions-devel-fix
formula_versions: fix erroneous :stable in version_attributes_map
2016-11-14 08:15:14 +00:00
Mike McQuaid
bffa38308b Merge pull request #1494 from aw1621107/add-frounding-math
cc: Add -frounding-math to list of ignored flags
2016-11-14 08:09:55 +00:00
Mike McQuaid
5a5cbe41bd Merge pull request #1497 from alyssais/uninstall_keg_to_formula
keg: don't rely on #to_formula
2016-11-14 08:02:51 +00:00
JCount
cfdbe9c645 formula_versions: fix erroneous :stable in version_attributes_map 2016-11-13 22:27:45 -05:00
Alyssa Ross
f7f72093a8 keg: don't rely on #to_formula
It doesn't always work.
For example, a keg could have been installed with a formula from a
URL, which Homebrew now does not know how to access.

Fixes #1496.
2016-11-13 23:20:38 +00:00
Markus Reiter
59e2d67721 No if/unless-modifier on multiline blocks. 2016-11-13 23:37:40 +01:00
Markus Reiter
c648518f35 Rename single line block parameters to acc/elem. 2016-11-13 23:36:04 +01:00
Markus Reiter
e9391481a8 Update RuboCop to 0.45.0. 2016-11-13 23:18:08 +01:00
Markus Reiter
84b2276fd8 Use guard clauses. 2016-11-13 23:00:47 +01:00
Alex Wang
d2e2110e80 cc: Add -frounding-math to list of ignored flags 2016-11-13 16:18:19 -05:00
Mike McQuaid
fc3d586584 Merge pull request #1493 from MikeMcQuaid/audit-version-decrease-fix
audit: fix "version should not decrease" check.
2016-11-13 14:05:59 +00:00
Mike McQuaid
c78aa43386 audit: fix "version should not decrease" check.
Fix the "version should not decrease" check so it correctly handles
`version_scheme`s.

Fixes #1489.
2016-11-13 13:35:25 +00:00
Mike McQuaid
694cc876ef Merge pull request #1415 from robinkunde/semver
Update macOS Xcode tool checks do use Version class for comparisons
2016-11-13 10:53:34 +00:00
Mike McQuaid
2a53d14b51 Merge pull request #1217 from MatzFan/invalid_build_option_warnings
Invalid build option warnings - supersedes #1088
2016-11-13 10:50:51 +00:00
Mike McQuaid
b34bd4fa12 Merge pull request #1488 from MikeMcQuaid/filter-formula-options
Filter formula build options based on those that exist.
2016-11-13 10:50:16 +00:00
Robin Kunde
e97ce7e7ae move semantic version comparisons into separate class 2016-11-12 15:37:32 -05:00