Alyssa Ross
c9d7bab6ca
Merge pull request #1889 from alyssais/clear_tab_cache_in_teardown
...
tests: clear tab cache in global teardown
2017-01-21 14:55:12 +00:00
Alyssa Ross
2d550b5008
tests: clear tab cache in global teardown
2017-01-21 14:24:19 +00:00
Alyssa Ross
ab9d8df792
Merge pull request #1888 from alyssais/tests_enforce_lifecycle
...
tests: enforce `super` in lifecycle hooks
2017-01-21 13:24:54 +00:00
Alyssa Ross
70a381a00f
tests: enforce super
in lifecycle hooks
...
This will allow us to have global setup and teardown for tests.
For example, we can automatically clear caches after each test, to avoid
annoying intermittent failures like #1879 and #1886 .
2017-01-21 11:34:52 +00:00
ilovezfs
cebe137499
audit: exempt wine's deps from the universal deprecation
...
This can be reverted when wine's dependencies are all vendored.
2017-01-20 07:18:51 -08:00
Alyssa Ross
d7c463ad2c
Merge pull request #1878 from alyssais/keg_cleanup
...
Simplify Keg class
2017-01-19 19:24:24 +00:00
Alyssa Ross
245944d359
keg: use Forwardable to methods delegated to #path
2017-01-19 17:06:38 +00:00
Alyssa Ross
34e13fc527
keg: don't conditionally switch alias target
...
This seems to be a remnant of Ruby 1.8.
2017-01-19 17:06:38 +00:00
Mike McQuaid
0810039868
Merge pull request #1879 from alyssais/formulary_cache_clear
...
tests: add a missing Tab cache clear
2017-01-19 17:04:10 +00:00
Alyssa Ross
366ee0b267
tests: revert modification to ARGV at end of test
...
Similar to 6fc1747e0550545b4fe80f5a1854d16dd2b08afe. I hadn't seen any
test failures caused by this, but I noticed it in the process of
trackign that down and it's an accident waiting to happen.
2017-01-19 13:21:39 +00:00
Alyssa Ross
6fc1747e05
tests: add a missing Tab cache clear
...
This was responsible for the sporadic failures I encountered in #1878 .
2017-01-19 13:16:08 +00:00
Gautham Goli
0b3d9031e2
Add --fix option to brew audit command
2017-01-18 22:35:37 +05:30
Mike McQuaid
f0249643d4
formula_installer: use attr_accessor for installed_*
2017-01-18 16:10:28 +00:00
Mike McQuaid
5424db1263
upgrade: temporarily comment out for fix.
2017-01-18 15:25:17 +00:00
Mike McQuaid
aa926a1bdf
Merge pull request #1813 from MikeMcQuaid/installed_as_dependency
...
tab: store installed_as_dependency, installed_on_request.
2017-01-18 14:56:48 +00:00
Mike McQuaid
89d8864b6b
upgrade: tab installed_{as_dependency,on_request}
2017-01-18 11:23:22 +00:00
Mike McQuaid
ee43c09f7a
install: set installed_{as_dependency,on_request}.
2017-01-18 11:23:21 +00:00
Mike McQuaid
16293c0a68
formula_installer: use installed_* variables.
...
Also, report formulae installed on request. This is useful in
differentiating between those formulae that are popular because they
are widely requested and those that are popular because they are widely
depended on.
2017-01-18 11:23:21 +00:00
Mike McQuaid
44f1c9752a
formula: installed_{as_dependency,on_request} hash
...
Which, in turn, provides them for `brew info --json=v1` so other tools
such as e.g. `brew bundle` can make use of this information.
2017-01-18 11:23:21 +00:00
Mike McQuaid
b99fb56275
tab: store installed_{as_dependency,on_request}.
...
These are used to determine whether or not a formula’s install was
specifically requested by a user and/or pulled in as a dependency.
2017-01-18 11:23:21 +00:00
Gautham Goli
483c40fb03
Add custom cop to refactor revision to rebuild in bottle block
2017-01-18 15:54:47 +05:30
Mike McQuaid
22e8ddc743
Merge pull request #1872 from MikeMcQuaid/improve_integration_test_failure_output
...
integration_command_test_case: improve fail output
2017-01-18 10:22:33 +00:00
Mike McQuaid
4d2201b8be
integration_command_test_case: improve fail output
...
Instead of `puts`ing when the failure occurs save it until the error
message and print a prose description of what the failure was and the
output from the command. This makes the output from failing tests
significantly easier to read.
2017-01-18 08:36:36 +00:00
Mike McQuaid
9f183be358
Merge pull request #1868 from zmwangx/bottle-add-improve-regexp
...
bottle: add: improve regexp to recognize comments
2017-01-18 08:02:45 +00:00
Mike McQuaid
950e27927b
Merge pull request #1869 from MikeMcQuaid/versioned_formula_conflicts_fix
...
audit: only warn on versioned conflicts_with.
2017-01-17 21:12:37 +00:00
Mike McQuaid
ffa5ebde53
Merge pull request #1863 from alyssais/uses_ignore_untapped
...
uses: properly handle untapped formulae in recursive dependency expansion (again!)
2017-01-17 19:58:52 +00:00
Mike McQuaid
1497dfaced
Merge pull request #1862 from alyssais/uses_include_optional
...
uses: fix recursive requirement resolution
2017-01-17 19:58:30 +00:00
Zhiming Wang
f0e5ebce06
rubocop_todo: bump max module length to 400
2017-01-17 14:55:00 -05:00
Mike McQuaid
4f0505f759
audit: only warn on versioned conflicts_with.
...
Rather than all versioned formulae regardless. Oops.
2017-01-17 19:09:41 +00:00
Zhiming Wang
42486c1181
bottle: add: improve regexp to recognize comments
...
This would have eliminated the need for Homebrew/homebrew-core#9000 , for
instance.
2017-01-17 10:26:01 -05:00
Mike McQuaid
a5019d281e
Merge pull request #1851 from MikeMcQuaid/keg-only-version
...
Add `keg_only :versioned_formula`.
2017-01-17 14:22:03 +00:00
Mike McQuaid
d8730ecf0b
Merge pull request #1866 from MikeMcQuaid/cask-skip-flaky-test
...
suite_test: skip flaky test.
2017-01-17 14:21:43 +00:00
Mike McQuaid
fa3d459f5b
suite_test: skip flaky test.
2017-01-17 11:18:45 +00:00
Mike McQuaid
dac66c4ada
Add keg_only :versioned_formula
.
...
This is used to indicate a formula is a version of another formula.
This will be used to provide a consistent interface for older formulae
versions and replaces the use of `conflicts_with`.
2017-01-17 10:50:04 +00:00
Mike McQuaid
eece7706d1
Merge pull request #1815 from MikeMcQuaid/dependency_to_formula
...
requirement: get formula from satisfy.
2017-01-17 10:09:05 +00:00
Mike McQuaid
aa104137e5
Merge pull request #1844 from MikeMcQuaid/audit-universal
...
audit: don't allow universal for new formulae.
2017-01-17 10:08:44 +00:00
Mike McQuaid
052d6077dd
Merge pull request #1859 from MikeMcQuaid/brew-create-null-version
...
create: handle null versions.
2017-01-17 10:07:40 +00:00
Mike McQuaid
85a3940dfa
Merge pull request #1861 from MikeMcQuaid/unset-grep-options
...
Unset GREP_OPTIONS.
2017-01-17 10:07:29 +00:00
Mike McQuaid
3d37e3b67f
Merge pull request #1849 from alyssais/requirement_tests
...
tests: test Formula#recursive_requirements
2017-01-17 09:12:47 +00:00
Alyssa Ross
9475622c07
uses: restore formula-level exception handler
...
This is a temporary measure until:
- #1862 is merged
- I can a test on `brew uses` against every formula in the official
taps to verify that exceptions are no longer raised.
2017-01-16 23:28:26 +00:00
Alyssa Ross
0b216798bb
Revert "Revert "uses: properly handle untapped fo…
...
…rmulae in recursive dependency expansion""
This reverts commit dc9819b86c60b5c6fd10373ff318d8ef60f97d52.
2017-01-16 23:28:26 +00:00
Alyssa Ross
36c1c8e9b0
uses: fix recursive requirement resolution
...
Fixes #1848 by sharing recursive dependency resolution between
dependencies and requirements.
Coincidentally, this also fixes the errors introduced by #1784 that
necessitated it being reverted in #1797 .
2017-01-16 23:04:26 +00:00
Alyssa Ross
33b955a3f2
tests: fix style of recursive_requirements tests
2017-01-16 21:58:59 +00:00
Doug Hazell
e78b31905d
fixup
2017-01-16 21:48:27 +00:00
Doug Hazell
90b3f9b19a
fixup
2017-01-16 21:47:58 +00:00
Doug Hazell
eca3f117ba
Update with comments in the code
2017-01-16 21:25:25 +00:00
Mike McQuaid
6040456ea9
Unset GREP_OPTIONS.
...
Users may have this set, breaking grep's output.
Fixes #1430 .
2017-01-16 20:35:56 +00:00
Mike McQuaid
10b8d27d11
Merge pull request #1840 from ahundt/patch-1
...
clarify what should be in brew create url
2017-01-16 20:16:15 +00:00
Mike McQuaid
feea90c0dd
create: handle null versions.
...
Fixes #1821
2017-01-16 20:15:32 +00:00
Mike McQuaid
133e59724a
Merge pull request #1763 from minamijoyo/add-feature-github-release-download-strategy
...
New feature: Allow download from private GitHub repository
2017-01-16 18:52:47 +00:00