Lionell Loh Jian An
52321b4fcd
Apply suggestions from code review
...
Code review changes
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-07-28 21:01:36 +08:00
lionellloh
3982810eab
brew style --fix
2020-07-28 21:01:36 +08:00
lionellloh
797a07d555
All tests adapted to pass
2020-07-28 21:01:36 +08:00
lionellloh
557b1d09a2
correct logic for standard license checking
2020-07-28 21:01:36 +08:00
lionellloh
b91587d171
audit-license: adapt code to use Array of licenses
2020-07-28 21:01:36 +08:00
Dawid Dziurla
7279e6f465
Merge pull request #8116 from dawidd6/workflow-dispatch-publish
...
pr-publish: use workflow_dispatch trigger
2020-07-28 12:36:33 +02:00
Dawid Dziurla
7d7b80774e
pr-publish: use workflow_dispatch trigger
2020-07-28 12:06:16 +02:00
Markus Reiter
c0d42dd922
Remove --force
from global_options
.
2020-07-28 10:31:11 +02:00
Markus Reiter
276c570c16
Pass individual args explicitly to ENV
extensions.
2020-07-28 02:52:45 +02:00
Dawid Dziurla
fddeceda3c
Merge pull request #8110 from dawidd6/with-label
...
pr-automerge: fix variable name
2020-07-27 23:21:22 +02:00
Dawid Dziurla
367de3523a
pr-automerge: fix variable name
2020-07-27 22:39:54 +02:00
Seeker
69ca7c5cd7
pr-upload: fix for non-homebrew-core taps
2020-07-27 13:13:56 -07:00
Dawid Dziurla
5c87a909ea
Merge pull request #7888 from dawidd6/pr-stuff
...
dev-cmd/pr-*: allow to run on other taps too
2020-07-27 21:04:48 +02:00
Dawid Dziurla
a0bf5c9ead
pr-publish: check if url repo equals provided tap arg
...
Co-authored-by: Jonathan Chang <jchang641@gmail.com>
2020-07-27 20:07:21 +02:00
Dawid Dziurla
a8e524d334
bottle: fix inreplace string
2020-07-27 17:23:08 +02:00
Mike McQuaid
97cf1750f3
Merge pull request #8101 from vidusheeamoli/fix-StringInreplaceExtension-usage
...
dev-cmd/bump-formula-pr.rb: fix StringInreplaceExtension usage
2020-07-27 16:07:09 +01:00
Jonathan Chang
80b62d8c2c
pr-upload: style tweaks
...
Co-authored-by: Dawid Dziurla <dawidd0811@gmail.com>
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-07-27 23:55:45 +10:00
Jonathan Chang
ebfd308241
pr-upload: ensure bottle and formula version match
2020-07-27 23:55:45 +10:00
vidusheeamoli
cff79348c9
dev-cmd/bump-formula-pr.rb: fix StringInreplaceExtension usage
2020-07-27 14:55:31 +01:00
Baffour Adu Boampong
119bc54e58
Removed duplicate method in bump-formula-pr
2020-07-26 22:47:32 +00:00
Baffour Adu Boampong
9e88b44bd7
Merge fixes
2020-07-26 22:39:46 +00:00
Dawid Dziurla
886d2edec2
Merge pull request #8082 from dawidd6/bump
...
bump-formula-pr: fix when no 'version' stanza in formula found
2020-07-26 19:20:06 +02:00
Issy Long
fdbb2ac16a
Merge pull request #7985 from vidusheeamoli/utils-inreplace-to-true
...
sorbet: set utils/inreplace.rb to true
2020-07-26 10:37:30 +01:00
Dawid Dziurla
1e805e04f9
bump-formula-pr: fix when no 'version' stanza in formula found
...
Without this fix, a command like:
`brew bump-formula-pr --version=0.3.3 --tag=v0.3.3 --revision=... test-formula-git-revision`
will fail because:
```
Error: no implicit conversion of nil into String
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/bump-formula-pr.rb:281:in `escape'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/bump-formula-pr.rb:281:in `bump_formula_pr'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:111:in `<main>'
```
Additionally, reject all `nil` replacement pairs by calling `compact`
method.
2020-07-26 10:26:39 +02:00
vidusheeamoli
fd382d2ecd
srb: set utils/inreplace.rb to true and refactor
...
- Sorbet gives preference to class methods over methods defined in
included modules, hence Sorbet was unavailable to resolve the
definition of the gsub! method.
- The gsub! method in StringInreplaceExtension conflicts with the definition in String.
- This PR refactors the call to the gsub! method so that a custom object
is exposed instead of a string.
2020-07-26 12:43:31 +05:30
Markus Reiter
b50eea6849
Merge pull request #8068 from reitermarkus/cli-parser
...
Refactor usages of global `Homebrew.args`.
2020-07-25 21:01:39 +02:00
Adrian Ho
ad4fd55b78
audit: add gitless and telegram-cli to prerelease list
...
In support of #8075 . Both formulae been on prerelease up till now.
2020-07-25 22:13:30 +08:00
Dawid Dziurla
62ca046390
pr-automerge: pass proper tap variable
...
Co-authored-by: Jonathan Chang <jchang641@gmail.com>
2020-07-25 08:42:39 +02:00
Markus Reiter
76cc31f134
Pass args
in pr-pull
instead of using global args
.
2020-07-25 04:28:02 +02:00
Markus Reiter
25b3632c4c
Pass args
to ENV
instead of using global args
.
2020-07-25 03:57:43 +02:00
Markus Reiter
e669949659
Pass args
to create
instead of using global args
.
2020-07-25 02:37:10 +02:00
Markus Reiter
6b0b25cd00
Pass keep_tmp?
and interactive?
instead of using global args
.
2020-07-25 02:37:10 +02:00
Markus Reiter
bf13db3367
Make Parser#parse
return args
.
2020-07-25 02:37:10 +02:00
Markus Reiter
adc36a05ff
Refactor Bintray
not to depend on args
.
2020-07-25 02:37:10 +02:00
Dawid Dziurla
8be563c5cd
pr-automerge: pass --tap arg down
2020-07-24 18:48:28 +02:00
Dustin Rodrigues
90cc4aefa5
create: use https rubydoc url
2020-07-23 16:18:52 -04:00
Elizabeth Tackett
ef8af4b070
add limit flag to reduce response size
2020-07-23 11:21:12 -05:00
Seeker
ab39e625af
Merge pull request #8043 from SeekingMeaning/bump-formula-pr-cleanup
...
bump-formula-pr: cleanup
2020-07-22 10:44:02 -07:00
Seeker
2e5d79a64a
Merge pull request #8033 from SeekingMeaning/allow-libressl
...
dev-cmd/audit: add libressl to uses_from_macos allow list
2020-07-22 10:43:01 -07:00
Elizabeth Tackett
6d4bce4baa
fix syntactical issues
2020-07-22 10:06:54 -05:00
Sean Molenaar
dab18076fa
audit: error on archived repos
2020-07-22 11:57:50 +02:00
Baffour Adu Boampong
9ec93f78d6
Merge branch 'master' into mlh-outdated-packages
2020-07-21 17:49:24 +00:00
Baffour Adu Boampong
d86c4d7b7a
Feedback changes and fix for pull_request join
2020-07-21 17:09:53 +00:00
Seeker
e77c156690
dev-cmd/audit: rename USES_FROM_MACOS_ALLOWLIST
...
Rename to PROVIDED_BY_MACOS_DEPENDS_ON_ALLOWLIST
2020-07-21 08:21:09 -07:00
Seeker
e5cc33ae8a
bump-formula-pr: cleanup
2020-07-20 08:16:30 -07:00
Jonathan Chang
a4b4c52ce8
Merge pull request #8022 from SeekingMeaning/bump-check-early
...
bump-formula-pr: check duplicate PRs as early as possible
2020-07-19 13:39:39 +10:00
Jonathan Chang
9156154b72
Merge pull request #7990 from SeekingMeaning/node
...
dev-cmd/create: add --node option
2020-07-19 13:36:43 +10:00
Seeker
25b7d28f91
dev-cmd/audit: add libressl to uses_from_macos allow list
2020-07-18 15:23:27 -07:00
Seeker
06d9152098
bump-formula-pr: check duplicate PRs as early as possible
2020-07-17 21:33:58 -07:00
Seeker
a3f1e09bce
dev-cmd/create: add --node option
2020-07-17 20:46:00 -07:00