lionellloh
37541704b8
update-license-data: style fixes
2020-06-25 05:10:29 +08:00
lionellloh
3f267a8fc9
audit: fix callers to call get_repo_data only if @new_formula
2020-06-25 05:09:56 +08:00
Lionell
4832a5aa05
audit: modified problem statement to match
2020-06-24 20:43:33 +08:00
Lionell Loh Jian An
9845091f4d
Apply suggestions from code review
...
license: code review changes
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-06-24 18:32:53 +08:00
lionellloh
127d67e745
license: update tests and license checking logic
2020-06-23 02:59:55 +08:00
lionellloh
e4e55c5cb3
update-license-data: wrote rspec test and added one more parseable arg
2020-06-23 02:25:46 +08:00
lionellloh
8d7a9d51d3
audit: rename spdx_id to spdx_data
2020-06-23 01:42:24 +08:00
lionellloh
de7edd403d
brew update-license-data: checks if it is outdated. If so, save new ver
2020-06-23 01:39:10 +08:00
Jonathan Chang
2b990aa53c
pr-pull: pass verbose and debug to subcommands
2020-06-22 00:25:57 +10:00
Jonathan Chang
17c20c0e11
pr-pull: dupe logic moved to mirror and pr-upload
2020-06-21 19:55:10 +10:00
Mike McQuaid
6049227c0a
Merge pull request #7771 from alebcay/extract-typo
...
extract: fix typo
2020-06-19 20:00:42 +01:00
Lionell
ec2391100a
Merge branch 'license' of https://github.com/MLH-Fellowship/brew into license
2020-06-19 04:24:39 +08:00
Lionell
4287ea74d1
remove json from gemfile and modified get_repo_data
2020-06-19 04:20:19 +08:00
Lionell Loh Jian An
a58905000c
Update Library/Homebrew/dev-cmd/audit.rb
...
audit license: suppress missing license problem unless it is a new_formula
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-06-19 04:17:35 +08:00
Lionell Loh Jian An
b2cccfcf68
Apply suggestions from code review
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-06-19 04:00:08 +08:00
Lionell Loh Jian An
a0b0c77ee8
audit license: use present instead of blank
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-06-19 03:58:34 +08:00
Lionell Loh Jian An
b08d958064
"license id" -> "license"
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-06-19 03:39:05 +08:00
Lionell Loh Jian An
7744f181b9
Update Library/Homebrew/dev-cmd/audit.rb
...
Formatting change
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-06-19 03:37:31 +08:00
Caleb Xu
2e6b8d65b3
extract: fix typo
2020-06-18 11:19:04 -04:00
Caleb Xu
a53c92bd7f
Cache commands list for faster shell completions
2020-06-18 11:06:31 -04:00
Issy Long
2608755ac5
Merge pull request #7709 from dawidd6/auto-mirroring
...
bintray: automatically run brew mirror if needed
2020-06-17 20:09:30 +01:00
Lionell
7b2e6644a7
Merge branch 'license' into license-create
2020-06-18 00:47:00 +08:00
Lionell
610dfe0fc2
audit: fixed with PR comments. Refactored get_repo_license api call and audit_license only new_formula
2020-06-18 00:44:33 +08:00
Lionell
12566a7466
Merge branch 'license' into license-create
2020-06-17 23:03:20 +08:00
Lionell
f1cd404839
Merge branch 'master' into license
2020-06-17 22:58:12 +08:00
Lionell
d92f747b1e
create: add license field as parsable arg
2020-06-17 22:52:25 +08:00
lionellloh
0b95f030fd
audit: fix code review changes
2020-06-17 22:13:04 +08:00
lionellloh
3bfca5bcee
audit: change location of spdx.json file
2020-06-17 21:45:51 +08:00
lionellloh
03fc6b2c15
audit_spec: override core-tap attribute in online test
2020-06-17 05:19:38 +08:00
Lionell
ba824d9488
audit: remove spdx-id as a attr_reader attribute
2020-06-17 04:14:57 +08:00
Lionell
ac6ea4de46
audit: check if a license field is empty
2020-06-17 03:38:06 +08:00
lionellloh
52c6e5de76
Fixed brew style offences
2020-06-16 01:00:47 +08:00
lionellloh
ff1016b729
Modify code to load spdx data once
2020-06-16 00:19:32 +08:00
Dawid Dziurla
3b0359706f
bintray: automatically run brew mirror if needed
2020-06-13 12:55:03 +02:00
lionellloh
998ab162d4
brew audit: Included json gem, does conditional check on github
2020-06-13 03:43:02 +08:00
lionellloh
803f9dd4a3
brew audit: check if license data exists
2020-06-13 02:43:02 +08:00
lionellloh
c10b6bcc3c
brew audit: Checks if a formula has a spdx license
2020-06-13 02:34:34 +08:00
Issy Long
7ad7834b15
audit: Supress pre-release audits for known pre-release formulae
...
- This safelists one formula that has only ever shipped pre-releases,
from before we had the GitHub pre-release audit. So it won't fail CI
and cause maintainers more work to determine if it's always been that
way, or if it's new. Then, we don't have to keep comments at the top
of files to say so for the next contributors.
- We should check this list from time to time to make sure that the
formulae here have graduated to actual releases and we can remove
them.
2020-06-12 15:59:30 +01:00
Mike McQuaid
f94a38e4b1
tap-new: restrict new tap names.
...
Don't want to restrict this for all taps otherwise existing ones may
explode.
Fixes #7734
2020-06-12 11:42:40 +01:00
Mike McQuaid
ae7e58ef78
Merge pull request #7488 from danielbayley/master
...
cat: Allow 'bat' to find existing configuration
2020-06-12 10:45:11 +01:00
Jonathan Chang
b99bfe1b8c
Merge pull request #7717 from jonchang/preserve-trailers
...
pr-pull: preserve trailers when signing off commit
2020-06-10 21:15:56 +10:00
Jonathan Chang
ee9c335b51
pr-pull: preserve trailers when signing off commit
2020-06-10 19:27:05 +10:00
Mike McQuaid
0dd004f53d
dev-cmd/audit: handle nil newest_committed_revision.
...
Fixes #7712 .
2020-06-10 08:39:41 +01:00
Mike McQuaid
2a94d382ac
audit: make audit_revision_and_version_scheme faster.
...
This is really, really slow at the moment for a few reasons:
- it goes through the list of revisions twice
- it checks many more revisions than it needs to
Even after these improvements it's still by far the slowest audit so
am also making it a `--git` only audit.
Additionally, to further improve default `brew audit` performance do not
run `brew style` checks when doing `brew audit` with no arguments.
`brew style` can be run quickly and efficiently on all of a tap (and is
cached) so no need to duplicate it here.
2020-06-08 15:00:09 +01:00
Issy Long
8eba9b86ab
Change occurrences of "blacklist" to "denylist" or "disallow"
...
- Depending on context, I've gone for either "denylist" or "disallow"
here. "Disallow" for things in sentences, or actions, and "denylist"
for list of things.
2020-06-06 22:38:33 +01:00
Issy Long
0041ea21f5
Change occurrences of "whitelist" to "allowlist"
2020-06-06 22:38:32 +01:00
Mike McQuaid
80c1a166b1
dev-cmd/pull: deprecate.
...
We no longer use this and `hub checkout` does what we want better.
2020-06-05 08:53:03 +01:00
Thierry Moisan
7a285cf476
Fix audit online release variable
2020-06-04 09:09:12 -04:00
Mike McQuaid
8b24d8c5e9
dev-cmd/audit: don't check GitHub releases without --online.
...
This both is more accurate and making `brew audit` without `--online` a
bit faster.
2020-06-03 17:50:57 +01:00
Mike McQuaid
aa81982aba
brew style --fix
2020-06-02 09:49:23 +01:00