admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
33,496 Commits 15 Branches 471 Tags
Commit Graph

2555 Commits

Author SHA1 Message Date
Gautham Goli
b8adc1a8aa audit: Port audit_options non-strict rules to rubocop and add tests 2017-07-13 12:41:43 +05:30
Mike McQuaid
f1fa475c4f Merge pull request #2843 from GauthamGoli/audit_conflicts_rubocop 
audit: Port audit_conflicts method to rubocop and add tests
 2017-07-08 07:44:16 +01:00
Gautham Goli
4ed34f91c2 audit: Port audit_conflicts method to rubocop and add tests 2017-07-07 20:46:57 +05:30
Mike McQuaid
ddb1fd7981 Merge pull request #2841 from mistydemeo/formula_assertions_constant 
Define a custom assertion failure error for cross-version compat
 2017-07-07 10:14:21 +01:00
Mike McQuaid
5c2fa1fc1f test: use Test::Unit class. 2017-07-07 09:44:02 +01:00
Mike McQuaid
bddafe4d54 audit: don't suggest non-stable versioned alias. 
Additionally handle the case where a formula has been installed as
devel/HEAD rather than just e.g. `brew audit --devel`.
 2017-07-07 09:30:18 +01:00
Mike McQuaid
2b3717a5a0 Merge pull request #2842 from GauthamGoli/audit_only_cops_option 
audit: Don't run audit methods when `--only-cops` option is passed
 2017-07-02 14:45:29 +01:00
ilovezfs
a94a938285 Merge pull request #2829 from mislav/bump-formula-pr-unshallow 
Fix `bump-formula-pr` when working with a shallow git clone
 2017-07-01 09:15:07 -07:00
Gautham Goli
8c167b23cc audit: Don't run audit methods when --only-cops is passed 2017-06-30 20:25:12 +05:30
Misty De Meo
5b464babf8 Define a custom assertion failure error for cross-version compat 
Fixes #2840.
 2017-06-29 17:40:04 -07:00
Mislav Marohnić
f8ec2332a2 Strip trailing newline 2017-06-29 13:28:55 +02:00
Misty De Meo
87fa20076c
audit: ask for full_index patches 2017-06-28 20:49:37 -07:00
Mislav Marohnić
3701b11e42 Fix unshallowing taps in bump-formula-pr 
Never try to unhshallow full clones.
 2017-06-27 23:45:57 +02:00
Mislav Marohnić
b3ef9ccb8a Fix bump-formula-pr when working with a shallow git clone 
Creating a fork and pushing to it doesn't work when the repository in
question is a shallow clone. By default, Homebrew clones all taps in
shallow mode unless `--full` was passed or $HOMEBREW_DEVELOPER was set.
 2017-06-27 14:32:09 +02:00
Mike McQuaid
3ce667f3b9 Merge pull request #2823 from MikeMcQuaid/test-simplify-minitest 
test: simplify minitest inclusion.
 2017-06-25 13:30:47 +01:00
Mike McQuaid
c45cca8e36 test: simplify minitest inclusion. 
The previous version seems needlessly complicated given we only support
a single Ruby version. It was also blowing up on Bundler 1.15.X.
 2017-06-25 13:04:36 +01:00
Mike McQuaid
f4cdd7a051 Merge pull request #2790 from GauthamGoli/audit_legacy_patches_rubocop 
audit: Port audit_legacy_patches method to rubocop and add tests
 2017-06-25 08:54:59 +01:00
Mike McQuaid
5f8a86c178 Merge pull request #2816 from MikeMcQuaid/test-needs-link 
test: require non-keg-only formulae to be linked.
 2017-06-24 13:30:21 +01:00
Gautham Goli
2e82754776 audit: Port audit_legacy_patches method to rubocop and add tests 2017-06-24 17:06:26 +05:30
Mike McQuaid
b9e3daac70 audit: don't use Fossies as a primary URL. 
As requested in:
https://github.com/Homebrew/homebrew-core/issues/14486#issuecomment-307753234
 2017-06-23 19:34:25 +01:00
Mike McQuaid
7d5cce569d test: require non-keg-only formulae to be linked. 
This can be overridden with `--force`.

As mentioned in:
https://github.com/Homebrew/homebrew-core/pull/14525#issuecomment-307838164
 2017-06-23 17:42:09 +01:00
Gautham Goli
4d7a983415 audit: Port audit_checksum method to rubocop and add tests 2017-06-16 19:45:16 +05:30
Mike McQuaid
ed9942fbd1 Merge pull request #2769 from MikeMcQuaid/rubocop-no-perl-backrefs 
rubocop: don’t allow Perl regex backrefs.
 2017-06-12 16:47:28 +01:00
Mike McQuaid
22c431d221 Merge pull request #2767 from MikeMcQuaid/rubocop-no-special-global-vars 
rubocop: don’t allow special global variables.
 2017-06-12 16:16:37 +01:00
Mike McQuaid
021cef4b2b Autocorrect Rubocop Style/SpecialGlobalVars. 2017-06-12 09:11:42 +01:00
Mike McQuaid
5d8b96a0c7 create: specify homebrew-core test requirements. 
As requested in https://github.com/Homebrew/homebrew-core/pull/14419.
 2017-06-10 20:27:44 +03:00
Mike McQuaid
7a0aff1080 Autocorrect Rubocop Style/PerlBackrefs. 2017-06-10 20:23:20 +03:00
Mike McQuaid
113a7a81d0 Revert "audit: Port audit_checksum method to rubocop and add tests" 2017-06-09 11:16:11 +03:00
Gautham Goli
d09d5ecc55 audit: Port audit_checksum method to rubocop and add tests 2017-06-08 21:53:46 +05:30
Mike McQuaid
2269518768 Merge pull request #2746 from MikeMcQuaid/cleanup-tests 
tests: cleanup tests.
 2017-06-08 16:16:55 +03:00
Mike McQuaid
cc8bc44286 audit: ensure curl always has an HTTP url. 
This makes using `HOMEBREW_CURL` significantly nicer as then the system
`curl` (that, on old versions, sucks at SSL) can download a version of
`curl` that it can build from source.
 2017-06-08 14:20:04 +03:00
Mike McQuaid
7d5b8a5cea tests: cleanup tests. 
Remove pending tests that are never run on CI (i.e. require `--online`),
remove fixtures for those tests and just make `--official-cmd-taps`
run by `--online` instead.
 2017-06-07 16:25:07 +01:00
Mike McQuaid
486d3d84b1 edit: tweak default editors. 
Add `atom` (not my editor of choice [TextMate for life!]) but widely
used enough to probably warrant it. Also, reorder based on my best
guestimates of current usage and cleanup the editor code while we're
here.
 2017-06-07 16:07:53 +01:00
Mike McQuaid
98959f1fb9 release-notes: fix style complaint. 2017-06-03 20:52:36 +01:00
Mike McQuaid
3a08f81470 audit: fix pypi strict audit capture group. 2017-06-03 20:25:12 +01:00
Mike McQuaid
4676e2f35a release-notes: include PR author names. 
Attribution is love.
 2017-06-03 19:06:19 +01:00
Mike McQuaid
1d034265af Merge pull request #2726 from MikeMcQuaid/audit-pypi-urls 
audit: check pypi URLs
 2017-06-03 10:01:22 +01:00
Mike McQuaid
d6c4dfc783 Merge pull request #2725 from MikeMcQuaid/audit-formulae-options-fix 
audit: fix false negative for formulae options.
 2017-06-03 10:01:10 +01:00
Mike McQuaid
cbfc83309f audit: check pypi URLs 
#373 implemented as a strict check (thanks nijikon)
 2017-06-02 22:28:07 +01:00
Mike McQuaid
6a0086a0a7 audit: fix false negative for formulae options. 
Handle the case where an if/unless is detected and then write off this
line for option handling.
 2017-06-02 22:26:37 +01:00
Markus Reiter
2d6ae61314 Re-revert "Fix operator spacing." 2017-06-02 19:22:05 +02:00
Gautham Goli
cf848a14d2 audit: Port audit_caveats method to rubocop and add tests 2017-05-31 22:59:48 +05:30
Mike McQuaid
90c971625e Merge pull request #2704 from MikeMcQuaid/jenkins-brew-sh 
Update jenkins.brew.sh links.
 2017-05-30 20:28:50 +01:00
Mike McQuaid
9032574038 Update jenkins.brew.sh links. 
These previously, incorrectly pointed to bot.brew.sh.

Fixes #2703.
 2017-05-30 19:14:40 +01:00
Gautham Goli
51f2338dd5 audit: Port audit_text method to rubocop and add tests 2017-05-30 15:28:05 +05:30
Mike McQuaid
2cbbdb51bf tests: install specific Bundler version. 
Otherwise `brew tests` fails with the latest. See the failing
Homebrew/homebrew-test-bot `master` build as an example.
 2017-05-29 20:52:17 +01:00
Mike McQuaid
7a38bab333 Fixup all RuboCop warnings. 2017-05-29 18:43:18 +01:00
Mike McQuaid
4356016b4a Use parallel RuboCop 
This requires updating to Rubocop 0.49.0 which will require some fixes
to rules, in Homebrew/brew and Homebrew/homebrew-core but opening this
for now so I remember.
 2017-05-29 18:42:02 +01:00
Mike McQuaid
d7e2d5be36 update-test: tweak more edge cases. 
Don't try to `fetch --depth=1` unless we've confirmed the repository is
already shallow. Otherwise this can discard history from a full clone.

Additionally, if the repository wasn't shallow but there's no tags found
assume that Git is too old and try a naive sort if on Linux where `sort`
is able to sort versions.
 2017-05-29 15:13:08 +01:00
Mike McQuaid
224d2c21ca update-test: improve no tags found messaging. 
Currently you just get `Could not find start commit!` which is not as
explicit as it could be.
 2017-05-29 10:06:04 +01:00