697 Commits

Author SHA1 Message Date
Mike McQuaid
2c370f3677 audit: check for more universal usage.
Also check for `ENV.universal_binary` and `build.universal?`. The prior
is still required for `wine` and the latter should never be required any
longer.
2017-04-10 22:36:39 +01:00
Mike McQuaid
3f51406212 Merge pull request #2242 from GauthamGoli/audit_custom_cops
Port audit_desc audit rules to a cop
2017-04-05 08:37:43 +01:00
Mike McQuaid
57b230dd5c audit: fix core formula alias check.
Was missing a formula object being passed.
2017-04-04 18:38:18 +01:00
Mike McQuaid
566d3cb58b Document all short flags. 2017-04-02 10:14:58 +01:00
Mike McQuaid
bfcfdb4f01 man: strip </?var> from Markdown output. 2017-04-02 10:14:57 +01:00
Mike McQuaid
3805850eb3 Merge pull request #2414 from sjackman/update-test-fetch-shallow
update-test: Use git fetch --tags --depth=1
2017-03-30 19:58:42 +01:00
Mike McQuaid
7d66e29927 Merge pull request #2399 from MikeMcQuaid/unversioned-formulae-check
audit: check for unversioned formulae.
2017-03-30 19:06:47 +01:00
Mike McQuaid
490252d063 Merge pull request #2392 from MikeMcQuaid/cleanup-taps
Update all references to taps.
2017-03-30 19:06:14 +01:00
William Woodruff
e7554b0b3f
audit: Fix cctools invocation check regular expression.
Additionally, ignore the cctools formula itself, since it obviously
needs to check cctools invocations.
2017-03-29 09:52:35 -04:00
William Woodruff
8608d1ea78 Merge pull request #1828 from woodruffw/audit-cctools
audit: Check for invocations of cctools.
2017-03-28 22:03:57 -04:00
Shaun Jackman
89f3b6d6a6 update-test: Use git fetch --tags --depth=1
Use git fetch --tags --depth=1 to fetch fewer commits.
2017-03-28 09:36:50 -07:00
Mike McQuaid
c3bf9bda58 update-test: improve error handling.
Fail if the start or end commit are missing and retry finding the
previous tag by fetching all tags if they are missing.

This should fix CI on the current Homebrew/brew `master` branch.

Closes #2404.
2017-03-28 15:31:16 +01:00
ilovezfs
70685f3017 audit: bump whitelisted elm-format version to 0.6.0-alpha 2017-03-26 22:43:08 -07:00
Mike McQuaid
181275c016 audit: check for unversioned formulae.
If we're adding a versioned formulae we want to ensure that there's also
an unversioned one too.
2017-03-26 20:36:37 +01:00
Mike McQuaid
09231dd52b Merge pull request #2393 from raza15/raza2
updating the exception for "kibana" for the "@" naming scheme. File changed: audit.rb
2017-03-26 19:51:25 +01:00
Mike McQuaid
2047dbd50e Update all references to taps.
- Remove taps that are (or will shortly be) deprecated.
- Remove commands that are only relevant to the boneyard (which will
  shortly be removed).
2017-03-26 19:42:35 +01:00
Raza Hussain
543529c054 indenting 2017-03-26 14:29:38 -04:00
Raza Hussain
86cf8873b6 changing if condition 2017-03-26 12:54:25 -04:00
Raza Hussain
94769652e0 simplify the regex and make a line max 80 char long 2017-03-26 12:43:09 -04:00
Mike McQuaid
e723131438 pull: optionally warn (not die) on bottle publish failure.
This is useful when you're pulling PRs where individual bottles can't be
uploaded/built but you still want to pull the PR as a whole anyway.
2017-03-23 10:00:33 +00:00
Mike McQuaid
08a22d013e Merge pull request #2383 from MikeMcQuaid/docs-manpage
man: generate Markdown man page.
2017-03-23 08:09:49 +00:00
Mike McQuaid
650c33e73b man: generate Markdown man page.
The existing `brew.1.html` wasn't particularly pleasant to read and
given everything else in `docs/` is a Markdown file it makes sense to
generate a post-processed Markdown file that can in turn be used by
Jekyll to generate a nicely themed HTML file.
2017-03-22 21:38:41 +00:00
Mike McQuaid
5fc4cabdeb tap-new: fix symlink creation.
Ensure the full HOMEBREW_TAP_DIR path is created before deleting and
creating the symlink for it. This ensures that non-`homebrew` taps will
have the necessary username/organisation folder created.

Fixes #2378.
2017-03-22 21:23:00 +00:00
Mike McQuaid
411172b9ad Merge pull request #2375 from maxim-belkin/tests-no-temp
tests: unset HOMEBREW_TEMP
2017-03-21 17:32:39 +00:00
Mike McQuaid
4117d198cc Merge pull request #1732 from zmwangx/hint-migrations
Hint at new location of migrated formulae
2017-03-21 17:31:31 +00:00
Maxim Belkin
8fa99fb879 tests: unset HOMEBREW_TEMP
Setting `HOMEBREW_TEMP` env. var [currently] breaks tests (`brew
tests`). Although this behavior looks like a bug, the solution is
straightforward: unset `HOMEBREW_TEMP`.
2017-03-21 09:31:09 -05:00
Mike McQuaid
7d068d468d Merge pull request #2365 from MikeMcQuaid/audit-provided-by-macos
audit: check system dupe deps on new formulae.
2017-03-21 14:49:22 +01:00
Mike McQuaid
80e95b684e blacklist: move to missing_formula class instead.
This will allow extending this class so it can be used by more than
just blacklisting.
2017-03-20 18:20:31 +02:00
Mike McQuaid
8efc0a608d audit: deprecate depends_on :tex.
This has known issues with our `ghostscript` formula, we can't test it
on CI and is a ludicrously heavy dependency that in many cases can be
avoided by upstream providing prebuilt documentation.
2017-03-19 20:46:31 +02:00
Mike McQuaid
eadbd95d2c audit: check system dupe deps on new formulae.
Provide a gentle nudge to users to check if these dependencies are
definitely required.
2017-03-19 20:45:21 +02:00
JCount
09a926f449 Merge pull request #2338 from JCount/audit-online-file-download
audit: online - limit download time based on HTTPS determination
2017-03-18 16:03:17 -04:00
JCount
5e8a9fa3f3 audit: online - limit download time based on HTTPS determination
Previously, the http_content_headers_and_checksum method always
downloaded the entire url, including headers. These downloads
periodically hang, outputting false positives or wreaking havoc on
the CI. Therefore, use curl's --max-time arg to prevent this by
setting a hard limit of 600 seconds when the entire file is going
to be used to detect whether the url can be changed to use the HTTPS
protocol instead of HTTP. Otherwise, if the url already is HTTPS, limit
the download time to 25 seconds since only the headers, not contents, matter.
2017-03-16 17:37:22 -04:00
Mike McQuaid
4d88cc4c41 Merge pull request #2326 from vszakats/sprot
secure urls + remove -k from in-doc curl command
2017-03-15 15:11:35 +00:00
Viktor Szakats
cc8f029f22 secure urls + remove -k from in-doc curl command 2017-03-14 17:27:11 +00:00
ilovezfs
45aa7b9a14 Revert "audit: exempt wine's deps from the universal deprecation" 2017-03-12 13:59:43 -07:00
Markus Reiter
c594ffefbc Add Formatter::pluralize. 2017-03-11 21:12:51 +01:00
Mike McQuaid
c4c3588de8 Merge pull request #2252 from zmwangx/audit-no-warn-brew-mirror-url
audit: do not warn about reachability of `brew mirror`ed URL
2017-03-08 09:32:37 +00:00
Zhiming Wang
10a235d6ab
pull: check Bintray mirror URLs 2017-03-07 20:45:08 -05:00
Shaun Jackman
0d3e1119a1 bottle: Remove superfluous odie 2017-03-06 11:35:48 -08:00
Mike McQuaid
3aa088dcaf Merge pull request #2272 from EricFromCanada/master
Add more flags and descriptions to man pages.
2017-03-06 18:00:39 +00:00
JCount
bd444dda43 Merge pull request #2269 from JCount/audit-conflicts-whitelist-bash-completion
audit: whitelist bash-completion@* to use conflicts_with
2017-03-06 12:05:43 -05:00
EricFromCanada
aee23ccb03 Add more flags and descriptions to man pages. 2017-03-05 21:45:15 -05:00
Markus Reiter
18d4220cbf Remove BUNDLE_PATH from brew tests. 2017-03-05 23:33:36 +01:00
JCount
3db3b08d72 audit: freeze versioned_conflicts_whitelist 2017-03-05 15:44:03 -05:00
JCount
460c4a3200 audit: deconstruct versioned_conflicts_whitelist using splat 2017-03-05 15:06:02 -05:00
JCount
4e50562424 audit: whitelist bash-completion@* to use conflicts_with
this is necessary because they install conflicting scripts into
HOMEBREW_PREFIX/etc/profile.d
2017-03-05 14:19:32 -05:00
Mike McQuaid
dbf3630a53 Merge pull request #2262 from MikeMcQuaid/subversion-https-audit
Don't check Subversion HTTPS pre-Sierra.
2017-03-05 15:30:16 +01:00
ilovezfs
a1da909dea audit: whitelist node@* to use conflicts_with
Add exceptions for node@* versioned formulae to use conflicts_with
instead of keg_only :versioned_formula since they, and the main node
formula, all currently overwrite npm during postinstall.
2017-03-05 03:15:22 -08:00
Mike McQuaid
e26cf3a83f Don't check Subversion HTTPS pre-Sierra.
The system Subversion doesn't handle new certificate authorities (e.g.
Let's Encrypt) well enough for this check to be useful.
2017-03-05 11:42:59 +01:00
Zhiming Wang
475cade1a3
audit: do not warn about reachability of brew mirrored URL
A `brew mirror`ed URL is usually not yet reachable at the time of pull request.
2017-03-04 10:12:45 -05:00