mansimarkaur
53be6bb4bd
Added check for svn availability
2017-08-29 16:16:17 +05:30
Viktor Szakats
1c2c390c6f
try addressing style issues #2
2017-08-27 18:00:59 +00:00
Viktor Szakats
11b267a7cf
try addressing style issues
2017-08-27 17:52:26 +00:00
Viktor Szakats
923c84d4f7
add some heuristics to https upgrade check
2017-08-27 09:39:28 +00:00
Mike McQuaid
8b7defb3eb
Merge pull request #3086 from MikeMcQuaid/audit-taps-shush
...
audit: don't output when searching taps.
2017-08-24 11:17:31 +01:00
JCount
6023e408da
Merge pull request #2995 from GauthamGoli/audit_line_rubocop_part_2
...
audit: Port line_problems to rubocop and add tests part 2
2017-08-23 16:16:07 -04:00
Mike McQuaid
f0605f4a30
audit: don't output when searching taps.
...
This messaging was added for the `brew search` command and having it in
audit is annoying:
(https://github.com/Homebrew/brew/pull/3059#issuecomment-323638672 )
As a side note: this is why randomly including `cmd/*` is a bad idea.
2017-08-23 18:40:30 +01:00
Markus Reiter
15e572702e
Fix pull.
2017-08-21 22:41:13 +02:00
Mislav Marohnić
80ae5b2660
bump-formula-pr: forward compatibility with hub fork
...
Due to limitations of `hub fork` in hub 2.2, scripts had to repeat the
command at least two times; the 2nd time was to read the fork name from
the "fatal: remote MYNAME already exists" message output from git.
In upcoming hub 2.3, the `hub fork` command is improved to always output
the remote name, regardless of whether one already existed or not. With
this approach, only one `hub fork` call will ever be necessary when hub
is up to date.
2017-08-15 17:32:12 +02:00
Gautham Goli
087c1ca8d6
audit: Port rules from line_problems to rubocop part 4(WIP-3)
2017-08-12 20:50:43 +05:30
Gautham Goli
4295a4ca78
audit: Port rules from line_problems to rubocop part 4(WIP-2)
2017-08-10 19:57:53 +05:30
Mike McQuaid
ea33958e03
Merge pull request #3031 from JCount/audit-fix-tap-versioned-aliases
...
audit: fix mismatch in versioned alias names in non-core taps
2017-08-09 20:46:13 +01:00
Bob W. Hogg
0ae22c0e36
dev-cmd/bump-formula-pr: search for tar
...
We first search for gtar in PATH, then
check if Homebrew's gtar is available,
then finally search for tar in PATH.
Signed-off-by: Bob W. Hogg <rwhogg@linux.com>
2017-08-08 23:07:27 -07:00
JCount
e1ebaab0cb
audit: fix mismatch in versioned alias names in non-core taps
...
Fixes #3022
2017-08-08 16:56:19 -04:00
Markus Reiter
ae4bafdb36
Simplify CurlDownloadStrategy.
2017-08-08 18:10:13 +02:00
ilovezfs
986887b413
Revert "Refactor SVN and cURL download strategies."
2017-08-07 14:31:56 -07:00
Markus Reiter
dc5a2c1764
Simplify CurlDownloadStrategy.
2017-08-07 21:31:17 +02:00
Mike McQuaid
12c454822a
sandbox: stop printing message.
...
We’re always using the sandbox where possible now so this is just
noise for the vast majority of our users.
2017-08-07 11:16:36 +01:00
Gautham Goli
a92e1eda27
audit: Port rules from line_problems to rubocop part 4(WIP)
2017-08-07 14:08:22 +05:30
Gautham Goli
b8f811cca6
audit: Port rules from line_problems to rubocop part 3
2017-08-06 18:36:09 +05:30
Gautham Goli
b5da76e28d
audit: Port FileUtils, inreplace audit rules in audit_lines to rubocop
2017-08-06 18:36:09 +05:30
Gautham Goli
bc2bcef1ba
audit: Port classname and template comments audit rules from line_problems method to rubocop
2017-08-06 18:36:09 +05:30
Gautham Goli
7614d2cc8b
audit: Port FileUtils, inreplace audit rules in audit_lines to rubocop
2017-08-06 02:28:58 +05:30
Gautham Goli
affd9055c2
audit: Port classname and template comments audit rules from line_problems method to rubocop
2017-08-06 02:28:58 +05:30
Gautham Goli
43cec10000
audit: Port patches audit code to a rubocop
2017-08-05 21:51:24 +05:30
Mike McQuaid
f4983ab16b
Merge pull request #2975 from GauthamGoli/audit_urls_rubocop_strict
...
audit: Port audit_urls strict rules to rubocop, add tests, autocorrect
2017-08-01 11:39:01 +01:00
Mike McQuaid
43d68b6dda
Merge pull request #2980 from GauthamGoli/audit_style_check_bug_fix
...
audit: fix bug where `brew audit foo` runs every style check.
2017-08-01 11:36:18 +01:00
Mike McQuaid
c3c3575b70
Merge pull request #2964 from GauthamGoli/audit_line_rubocop_part_1
...
audit: Port dependency rules from line_problems to rubocop and add tests
2017-08-01 11:29:26 +01:00
Gautham Goli
5e8e705b50
audit: fix bug where brew audit foo runs every style check.
2017-07-30 22:03:43 +05:30
Gautham Goli
c575f34d5f
audit: Port audit_urls strict rules to rubocop, add tests and autocorrect
2017-07-30 12:59:37 +05:30
Gautham Goli
e1cb0b43d7
audit: Port dependency rules from line_problems to rubocop and add tests
2017-07-29 16:36:32 +05:30
Gautham Goli
0c04b9041a
audit: Check for style violations when --new-formula is passed
2017-07-28 05:05:34 +05:30
Mike McQuaid
baa61f5a6e
Use https for all docs.brew.sh links.
...
May as well use the more secure link when possible.
2017-07-27 15:59:37 +01:00
Gautham Goli
2639b6c556
audit: Update Urls Cop with more rules of audit_urls and corresponding tests
2017-07-25 19:06:36 +05:30
Gautham Goli
b7ddd271e1
audit: Port audit_urls partially to rubocop and add corresponding tests
2017-07-21 20:50:28 +05:30
Mike McQuaid
ce1b26d58d
Merge pull request #2905 from GauthamGoli/audit_option_rubocop_3
...
audit: Port audit_options rules for new formulae to rubocop and add test
2017-07-15 13:40:45 +01:00
Mike McQuaid
f5cc8daa39
Merge pull request #2900 from MikeMcQuaid/improve-docs
...
Documentation improvements
2017-07-15 13:39:32 +01:00
Gautham Goli
a8f1b02be9
audit: Port audit_options rules for new formulae to rubocop and add test
2017-07-15 17:35:10 +05:30
Mike McQuaid
4fd8aea015
Documentation improvements
...
- Document ilovezfs as the official lead maintainer of
Homebrew/homebrew-core. This is a role he's been doing unofficially
(and brilliantly) for a while and explicit documentation of power
structures makes it easier for non-Homebrew-maintainers to understand.
- Document the contents of some of Homebrew's subdirectories for people
clicking around in the GitHub UI looking to contribute.
- Remove update bug mention from README. Enough time has passed that we
can remove this disappointment.
2017-07-15 12:57:34 +01:00
Gautham Goli
f3923f23ef
audit: Port audit_options strict rules to rubocop and add tests
2017-07-14 21:43:16 +05:30
Mike McQuaid
20db5470e3
Merge pull request #2879 from GauthamGoli/audit_option_rubocop_1
...
audit: Port audit_options non-strict rules to rubocop and add tests
2017-07-14 15:32:52 +01:00
Mike McQuaid
ec574c0e7f
tests: unpin bundler.
...
These issues were fixed by https://github.com/Homebrew/brew/pull/2872
and https://github.com/Homebrew/brew/pull/2823 .
2017-07-13 17:15:03 +01:00
Gautham Goli
b8adc1a8aa
audit: Port audit_options non-strict rules to rubocop and add tests
2017-07-13 12:41:43 +05:30
Mike McQuaid
f1fa475c4f
Merge pull request #2843 from GauthamGoli/audit_conflicts_rubocop
...
audit: Port audit_conflicts method to rubocop and add tests
2017-07-08 07:44:16 +01:00
Gautham Goli
4ed34f91c2
audit: Port audit_conflicts method to rubocop and add tests
2017-07-07 20:46:57 +05:30
Mike McQuaid
ddb1fd7981
Merge pull request #2841 from mistydemeo/formula_assertions_constant
...
Define a custom assertion failure error for cross-version compat
2017-07-07 10:14:21 +01:00
Mike McQuaid
5c2fa1fc1f
test: use Test::Unit class.
2017-07-07 09:44:02 +01:00
Mike McQuaid
bddafe4d54
audit: don't suggest non-stable versioned alias.
...
Additionally handle the case where a formula has been installed as
devel/HEAD rather than just e.g. `brew audit --devel`.
2017-07-07 09:30:18 +01:00
Mike McQuaid
2b3717a5a0
Merge pull request #2842 from GauthamGoli/audit_only_cops_option
...
audit: Don't run audit methods when `--only-cops` option is passed
2017-07-02 14:45:29 +01:00
ilovezfs
a94a938285
Merge pull request #2829 from mislav/bump-formula-pr-unshallow
...
Fix `bump-formula-pr` when working with a shallow git clone
2017-07-01 09:15:07 -07:00
