Jack Nagel
3e9a88c365
Assert that the broken symlink is actually overwritten
2014-03-27 09:59:54 -05:00
Jack Nagel
e9ee640024
Don't let broken symlinks halt linking
2014-03-27 09:35:10 -05:00
Jack Nagel
f6b5c83482
Fix conflicting symlink advice
...
Closes Homebrew/homebrew#27899 .
2014-03-27 09:35:10 -05:00
Jack Nagel
714bfee8d9
Add missing newline to link and unlink in verbose mode
2014-03-26 21:53:34 -05:00
Jack Nagel
7b389fbfed
Replace files atomically in inreplace
2014-03-26 16:07:49 -05:00
Jack Nagel
4fe0be37c0
Drop intermediate variable
2014-03-26 16:07:49 -05:00
Jack Nagel
91d31ae1f4
Replace files atomically when relocating
2014-03-26 16:07:49 -05:00
Jack Nagel
976bf3f60b
Tab#write always overwrites, no need to unlink
2014-03-26 16:07:49 -05:00
Jack Nagel
e5fbc9c92e
Fall back to Process.gid if we aren't a member of the file's group
2014-03-26 13:45:46 -05:00
Jack Nagel
03fca453c4
Put tempfile into binmode before writing
2014-03-26 13:45:46 -05:00
Misty De Meo
3943a77832
CLT.installed?: base result on version detection
...
CLT.installed? previously returned false if the user had outdated dev
tools installed after a 10.9 upgrade, which was confusing to users.
2014-03-26 10:35:30 -07:00
Jack Nagel
b5e2996365
Failing to install plist shouldn't prevent linking
2014-03-25 23:47:37 -05:00
Jack Nagel
50f394032f
Write plists atomically
2014-03-25 23:45:23 -05:00
Mike McQuaid
6e86976920
Revert "doctor: use double quotes for setting PATH."
...
I'm an idiot.
This reverts commit f890e4973840a66a522189c8e5530bff61d17162.
2014-03-25 16:20:53 +00:00
Mike McQuaid
7846ed4f76
audit: don't warn about tarball in non-GitHub URL.
2014-03-25 16:14:03 +00:00
Mike McQuaid
0d898edc37
doctor: use double quotes for setting PATH.
...
Closes Homebrew/homebrew#27619 .
2014-03-25 16:02:19 +00:00
Jack Nagel
25c7b49eee
Don't load the full debugger when readline is the formula being installed
...
Fixes Homebrew/homebrew#27842 .
2014-03-25 01:39:43 -05:00
Jack Nagel
a72061c59a
Check existence of target keg instead of hiding exceptions
2014-03-24 11:00:55 -05:00
Mike McQuaid
e4f291084a
bottle_version: handle pazpar2 style.
2014-03-24 09:56:14 +00:00
Misty De Meo
0475dbe5cc
LD64Dependency: super before setting env proc
...
Otherwise super will overwrite @env_proc with the default value.
2014-03-23 15:32:34 -07:00
Jack Nagel
da0df8eabe
Expose some keg methods
2014-03-23 16:01:44 -05:00
Misty De Meo
497123f7ec
LD64Dependency: adjust initializer signature
...
The method signature of Dependency changed in
1fdf69b90382c43493a5f62f0020729289db6c70, however LD64Dependency was
missed in the update. This resulted in failures in merge_repeats(),
which creates many dependency objects using all three arguments.
2014-03-22 18:50:54 -07:00
Jack Nagel
543f2a68e9
Don't send, just call the method directly
2014-03-22 13:16:16 -05:00
Jack Nagel
26c93c9544
Drop inaccurate comment
...
require "time"
Time.parse(Time.now.to_s)
2014-03-22 13:16:16 -05:00
Jack Nagel
f0966cf6b6
Use canonicalized path for loaded install receipts
2014-03-22 11:48:49 -05:00
Jack Nagel
b4e5401e66
Try to find install receipt when keg is unlinked
...
This roughly matches the logic we use to determine the active keg in
ARGV.kegs.
2014-03-22 11:47:07 -05:00
Jack Nagel
a8eb84812a
Write install receipts atomically
2014-03-22 11:13:33 -05:00
Jack Nagel
26fe9df9b2
Preserve permissions when using Pathname#atomic_write
2014-03-22 10:58:28 -05:00
Mike McQuaid
c34ed98eaf
dependency_collector: use ArgumentError exception.
...
Avoids errors with `brew versions` when bottling.
References Homebrew/homebrew#27615 .
2014-03-22 10:31:00 +00:00
Mike McQuaid
3b0eef09e9
Remove unnecessary swearing.
2014-03-22 10:14:20 +00:00
Jack Nagel
f760ee2751
audit: #{prefix}/Frameworks -> #{frameworks}
2014-03-21 20:09:56 -05:00
Ian Lancaster
58456a5469
audit: suggest proper if build.with(out)
usage
...
Closes Homebrew/homebrew#27759 .
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-03-21 17:07:27 +00:00
Jack Nagel
04f887dc18
Always build from source when given --interactive
...
Closes Homebrew/homebrew#27716 .
2014-03-19 22:46:15 -05:00
Jack Nagel
dc8218fdb5
audit: catch new style gist URLs
2014-03-19 18:24:10 -05:00
Geoff Nixon
9bbe38aa59
audit: fix gist patch URL regex
...
Closes Homebrew/homebrew#27255 .
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
Conflicts:
Library/Homebrew/cmd/audit.rb
2014-03-19 18:24:08 -05:00
Jack Nagel
7f33a84ce6
Expand paths before making relative symlink
...
Fixes Homebrew/homebrew#27702 .
Fixes Homebrew/homebrew#27704 .
2014-03-19 15:57:39 -05:00
Jack Nagel
c613ff0fad
Fix copy/paste error
...
Fixes Homebrew/homebrew#27685 .
2014-03-18 22:59:44 -05:00
Jack Nagel
45bdeadd94
Set bottle download strategy directly
...
We know what strategy we want, so going through DownloadStrategyDetector
is wasted work. Now we can remove those patterns from the detector and
have two fewer branches each time through.
2014-03-18 21:28:33 -05:00
Jack Nagel
aaea4d236a
Reorder download strategy symbols by frequency
2014-03-18 21:28:33 -05:00
Jack Nagel
eace29a50e
Reorder download strategy regexps by frequency
2014-03-18 21:28:29 -05:00
Jack Nagel
aa7ed10968
Make relative symlinks in Pathname#install_symlink
...
Closes Homebrew/homebrew#27672 .
2014-03-18 19:03:25 -05:00
Jack Nagel
4353f4fc97
Detect absolute symlinks during bottle relocation check
2014-03-18 19:03:24 -05:00
Jack Nagel
e0c1f5aef6
Remove redundant method
...
This already happens in the superclass.
2014-03-18 14:46:43 -05:00
Jack Nagel
7af46a5ed0
Always use CurlDownloadStrategy for legacy patches
...
Fixes Homebrew/homebrew#27671 .
2014-03-18 14:24:32 -05:00
Mike McQuaid
8dcadc54d2
python_dependency: no brewed python for bottles
2014-03-18 12:08:12 +00:00
Misty De Meo
ab4f9e57ae
Don't check issues on Ruby 1.8.6
...
The system certs are too old to be able to read from Github, so
don't try to use the Github API on 1.8.6 either.
2014-03-17 11:52:11 -07:00
Mike McQuaid
f115260a29
bottle_version: support lz4 style.
2014-03-17 10:35:53 +00:00
Adam Vandenberg
6a13c9e434
which is supposed to return a pathname
2014-03-16 16:05:15 -07:00
Adam Vandenberg
844e94526e
return found path directly in which
2014-03-16 11:52:11 -07:00
kynnjo
5f8e78150e
utils.rb:which: bug fix
...
Closes Homebrew/homebrew#27524 .
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2014-03-16 11:49:35 -07:00