4470 Commits

Author SHA1 Message Date
Clemens Müller
fab77a8cbd Add missing '`' to message of blacklisted rubinius
As pointed out by @mikemcquaid in http://git.io/Q5b9wg

Closes Homebrew/homebrew#28106.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-04-03 09:34:40 -05:00
Jack Nagel
63da62c6d0 Revert "Audit gnome URLs, prefer download.gnome.org"
This reverts commit 557ef8df05a8ea28ed903f08b2009ebc0e218f5a.
2014-04-03 09:29:23 -05:00
Jack Nagel
6b001f1e3b Add keg-only reason symbols for Xcode 4.3 and Xcode 5
Closes Homebrew/homebrew#28095.
2014-04-03 09:12:51 -05:00
Jack Nagel
d22ad92a84 Remove special behavior of autotools symbol deps
Closes Homebrew/homebrew#28094.
2014-04-03 09:12:25 -05:00
Jack Nagel
c13311ca09 Cache MacOS.version comparison results
MacOS.version#<=> is called many, many times during formula loading with
the same half dozen or so arguments. A typical call to this method
involves:

 * a hash lookup to convert a symbol argument to a string
 * creation of a throw-away Version object wrapping the argument
 * the actual version comparison, which is not cheap

This makes it a prime candidate to be memoized.
2014-04-02 20:29:20 -05:00
Jack Nagel
bb5e0812fb Add fast path for CVS dep
The search mechanism in MacOS::Xcode is very slow. It requires shelling
out at least twice, and possibly a third time (in the CLT-only case).

Calling provides_cvs? activates this in order to determine the Xcode
version. But if we know that there isn't an Xcode available for the
current OS that meets the criteria, we can avoid this check entirely.
2014-04-02 19:58:15 -05:00
Jack Nagel
55b0ee787a Remove dead code 2014-04-01 22:54:15 -05:00
Jack Nagel
8f1f1d8d8a Make keg_only validation lazy 2014-04-01 21:35:22 -05:00
Jack Nagel
4830bdb5b7 The argument to pkgutil_info is always a string 2014-04-01 20:49:11 -05:00
Jack Nagel
0d3121f781 Batch up mdfind calls when possible 2014-04-01 20:47:26 -05:00
Jack Nagel
97ca3baedc Avoid calling xcodebuild twice 2014-04-01 18:51:34 -05:00
Jack Nagel
2932bc5347 Remove unused parameter 2014-04-01 16:03:08 -05:00
Jack Nagel
7d3215c9f4 Extract tag and checksum selection from DSL method 2014-04-01 16:03:08 -05:00
Jack Nagel
7552669719 Remove now unnecessary branching from bottle DSL methods 2014-04-01 16:03:07 -05:00
Jack Nagel
f1601f6d8a Stop jumping through hoops to get at the collector object 2014-04-01 16:03:07 -05:00
Jack Nagel
d88c79f3cf Use resolved_path instead of dirname and readlink directly 2014-03-31 22:39:41 -05:00
Jack Nagel
b29be4c9a5 Remove default value from Keg#link_dir mode parameter
Now that this is always called with an explicit mode argument, let's
make sure it stays that way.
2014-03-31 21:33:37 -05:00
Jack Nagel
75af625c17 Pass the link mode to resolve_any_conflicts 2014-03-31 21:33:37 -05:00
Jack Nagel
5123f0c802 Move dnsiff to the boneyard
Closes Homebrew/homebrew#27642.
2014-03-31 12:57:31 -05:00
Mike McQuaid
d38d2e3308 pocl: move to homebrew/science. 2014-03-31 11:54:58 -05:00
Mike McQuaid
bf8ff2dcb7 audit: check the use of Dir[]
Sometimes `Dir[]` is used with single files/directories unnecessarily.
2014-03-31 11:52:59 -05:00
Jack Nagel
94f324d778 Audit gnome URLs, prefer download.gnome.org 2014-03-30 18:00:00 -05:00
Jack Nagel
7584b2ca2b Aliases never point at symlinks, so just use resolved_path 2014-03-30 15:55:37 -05:00
Jack Nagel
be46fc3a48 Relocate files in share/pkgconfig too 2014-03-29 22:18:48 -05:00
Jack Nagel
3ddd7b8ebb Calling find on nonexistent directories only works on 1.8 2014-03-29 22:18:48 -05:00
Jack Nagel
c8c85b4ac4 Always call Process.wait with an argument 2014-03-29 17:47:42 -05:00
Jack Nagel
fcb9c4d5fb Future-proof the build process fork/wait 2014-03-29 10:23:43 -05:00
Jack Nagel
809c804499 Make sure we wait for the correct child
Fixes Homebrew/homebrew#27962.
2014-03-29 02:24:01 -05:00
Jack Nagel
c27eed10bd Simplify collecting options 2014-03-28 20:42:55 -05:00
Jack Nagel
a487909e9a Don't rely on Dependency#to_s 2014-03-28 20:42:20 -05:00
Jack Nagel
3871165c58 Add revision to brew info --json
Closes Homebrew/homebrew#27820.
2014-03-28 20:41:02 -05:00
Jack Nagel
1c558d49dd Filter arguments for setup.py and build.py 2014-03-28 19:04:31 -05:00
Jack Nagel
56feb978b8 Make ENV changes in the child so we don't have to roll them back 2014-03-28 19:04:05 -05:00
Misty De Meo
0ec7e39287 Add ENV.refurbish_args helper
Rationale: our arg refurbishment is normally only turned on when
called via the `make` wrapper, for compatibility reasons. However,
there are numberous places we'd like this to be turned on elsewhere,
like software that builds via `python setup.py` where bad flags from
the system python can be pulled in.

This helper appends 'O' to CCCFG, which enables refurbishment for
all calls of the compiler shims.
2014-03-28 17:02:14 -07:00
Dominique Orban
05d759606a Move hwloc to homebrew/science.
Closes Homebrew/homebrew#27949.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-03-28 15:03:44 -05:00
Adam Vandenberg
2faeafd89d Migrate dotwrp, qrupdate, slicot to homebrew-science
Closes Homebrew/homebrew#27743.
2014-03-28 07:55:23 -07:00
Jack Nagel
e21a1fab51 Move initializer after constants and class methods 2014-03-27 22:35:08 -05:00
Jack Nagel
685bf070d1 Fix class definition so we can require files first 2014-03-27 22:34:22 -05:00
Jack Nagel
b25156ca4a Only write files if we actually made a change 2014-03-27 21:42:09 -05:00
Jack Nagel
4e918666d7 Return early so we can reduce nesting of conditionals 2014-03-27 18:42:19 -05:00
Jack Nagel
ed0be26c77 Fix overly defensive handling of src parameter in make_relative_symlink
This method is for internal use only. It is unsuitable for use in
formulae, which should use install_symlink to create relative symlinks.
Thus callers are required to pass a Pathname, not a string, and we can
remove this conditional.

Further, if src is not absolute, then src.relative_path_from(dirname)
will fail. All callers currently pass absolute pathnames. Therefore we
don't need to call expand_path when printing it.
2014-03-27 17:54:07 -05:00
Jack Nagel
02a1d71871 Don't mix boolean operator types 2014-03-27 17:37:38 -05:00
Jack Nagel
7c5e0eb507 Put constant strings in a constant 2014-03-27 17:14:55 -05:00
Jack Nagel
cb9ee747e0 Fix Keg#find so we don't have to deal with it everywhere
lol inheritance
2014-03-27 17:06:05 -05:00
Jack Nagel
1f0d424459 link: fix output ordering when exceptions are raised 2014-03-27 16:27:46 -05:00
Jack Nagel
3a48d7ab9b link: print wrapper is not always required 2014-03-27 16:27:46 -05:00
Jack Nagel
ad7911bb75 Replace files atomically when relocating, take two 2014-03-27 14:23:49 -05:00
Jack Nagel
0c99e64851 Revert "Replace files atomically when relocating"
There are some weird interactions with ensure_writable and atomic_write
that need to be sorted out.

Fixes Homebrew/homebrew#27917.

This reverts commit 41c21e6ea5647823a9e589a56f0494b622e26fb2.
2014-03-27 13:45:37 -05:00
Misty De Meo
38e26ed929 extend/string: backport #rpartition 2014-03-27 10:14:08 -07:00
Jack Nagel
a0851c1380 Assert that Keg#link produces relative symlinks 2014-03-27 09:59:54 -05:00