admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
6,689 Commits 15 Branches 471 Tags
Commit Graph

245 Commits

Author SHA1 Message Date
Adam Vandenberg
a68152fc7d Audit: warn about head-only formulae 2011-12-18 16:24:56 -08:00
Jack Nagel
e4bd231680 audit: hard wrap dep warning 
The warning is lengthy, and usually wraps on 80-column terminals.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2011-12-15 16:59:02 -06:00
Jack Nagel
18bdd72827 audit: check for hard-coded compilers 
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2011-12-08 23:08:42 -06:00
Jack Nagel
6f83e20f49 audit: only perform GNU URL check on primary URLs 
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2011-11-30 13:14:24 -06:00
Jack Nagel
1657bb1fcf audit: disable GNU url check 
It needs to be reworked to only check the primary URLs, as we are now
using ftp.gnu.org as a mirror.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2011-11-30 12:57:29 -06:00
Adam Vandenberg
f059e9624c audit: smake is also a build tool 2011-11-29 18:55:55 -08:00
Adam Vandenberg
7278eaec51 audit: check for DB deps too 2011-11-29 18:50:44 -08:00
Jack Nagel
45a87ab8d9 audit: warn about more "forbidden" dependencies 
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2011-11-29 19:57:26 -06:00
Jack Nagel
7f7391243a audit: check for build-time dependencies 
This can be made more robust in the future when we stop throwing away
the ':build' type flag in Formula#depends_on.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2011-11-29 19:40:14 -06:00
Adam Vandenberg
a494f9a3e0 audit: remove --strict 2011-11-27 08:39:44 -08:00
Jack Nagel
17d83b735a audit: check for MacPorts patches from trunk 
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2011-11-23 13:38:38 -06:00
Charlie Sharpsteen
31eba09830 audit.rb: Check version strings by default 
Tired of telling people that version numbers are redundant. Just check it by
default since the `--strict` flag to `brew audit` is not well advertised.
 2011-11-21 09:00:34 -08:00
Jack Nagel
7e57847793 audit: check for ARGV.flag? in formulae 
We don't want single letter options like '-v' or '-d' to unintentionally
trigger formula-specific options.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2011-11-18 15:27:09 -06:00
Jack Nagel
ebfa4d5dc0 audit: don't check duplicate URLs 
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2011-11-15 18:06:26 -06:00
Oleg Oshmyan
323c30978f audit: check for build_universal? calls if --universal unused 
Closes Homebrew/homebrew#8123.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2011-11-02 19:02:53 -05:00
Jack Nagel
2c3b107d93 audit: check for empty sha256 checksums 
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2011-11-02 18:55:27 -05:00
Adam Vandenberg
cbdb603838 Remove debian mirror check; it is just noise 2011-10-22 09:37:10 -07:00
Adam Vandenberg
0dbf06bbc8 audit: complain more about tabs 2011-10-18 10:00:45 -07:00
Jack Nagel
8848857cea audit: check mirror URLs 
This will actually throw some possibly unwanted warnings, e.g. whining
about using mirrors.kernel.org for Debian software; we might only want
that warning for the default URL.

Perhaps mirrors deserve their own audit_formula_mirrors, but rather than
duplicate code, let's just check them against the standard criteria for
now.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2011-10-15 00:39:05 -05:00
Jack Nagel
e0c53c56e4 audit: improve SF 'use_mirror' detection 
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2011-10-02 15:46:09 -05:00
Jack Nagel
be9d91b2b8 audit: match #{prefix}/libexec and prefix+'libexec' 
These were being picked up as just "#{prefix}/lib" and prefix+'lib' due
to the eagerness of the regex. Reordering "lib" and "libexec" will take
care of it; I couldn't think of a more clever solution.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2011-09-28 14:42:04 -05:00
Jack Nagel
51f010ac39 audit: recognize options used with 'ARGV.flag?' 
A few formula use ARGV.flag? instead of ARGV.include?. This made `audit`
recognize a few undocumented instances of a '--devel' option, but we can
just ignore that like '--HEAD' for now, and change the behavior if we
decide they need to be documented explicitly in each formula.

cf. Homebrew/homebrew#7456.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2011-09-21 15:25:28 -05:00
Jack Nagel
f4c301a827 audit: improve GNU url check 
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2011-09-13 23:35:31 -05:00
Jack Nagel
ff9042f650 audit: correctly match SourceForge https URLs 
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2011-09-13 23:35:31 -05:00
Jack Nagel
346a973848 audit: check GNU urls 
We now prefer "ftpmirror.gnu.org" over the main FTP site.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2011-09-12 15:43:02 -05:00
Adam Vandenberg
8c50cb54c0 audit: make version checks strict only 2011-07-29 08:34:00 -07:00
Adam Vandenberg
ea35d749af be more ruby-like 2011-06-16 20:35:09 -07:00
Adam Vandenberg
00b7e07f45 audit: check for redundant 'version' 2011-06-16 20:31:55 -07:00
Adam Vandenberg
db76c21aee brew audit: check for git://github.com/ urls and warn 2011-06-13 14:20:55 -07:00
Adam Vandenberg
fd533881a6 brew audit: also check for spaces in Amazon formulae 2011-06-06 07:25:00 -07:00
Adam Vandenberg
cf13c6ddf3 brew-audit: do not abort after first brew with errors 2011-05-31 13:32:47 -07:00
Jack Nagel
8f59c84ab2 audit exits with status 1 if there are problems 
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
 2011-05-27 22:03:20 -07:00
Adam Vandenberg
175228b416 Fix audit for new universal handling 2011-04-23 09:06:41 -07:00
Adam Vandenberg
e788de8cf8 brew audit: --strict warning for using $ in caveats 
For multiple lines of commands to enter at a prompt, don't use
$ as a prompt marker to make it easier to copy/paste.
 2011-04-04 16:40:38 -07:00
Charlie Sharpsteen
7776f7ee11 Fix brew-audit Fortran check 
The Fortran regex only allowed for trailing whitespace after:

    depends_on 'gfortran'

This missed conditional dependencies, such as:

    depends_on 'gfortran' if something?

Such a dependency was present in the NetCDF formula.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
 2011-04-01 13:00:07 -07:00
Adam Vandenberg
8f7972c194 reword audit 2011-03-28 11:08:42 -07:00
Adam Vandenberg
84fbdd795f update manpage for brew audit --strict 
This removes the single use of 'brew audit --warn' and
changes it to --strict as well.
 2011-03-21 13:07:14 -07:00
Adam Vandenberg
716da2dfbd brew audit: add strict check for <Formula spacing 2011-03-21 13:07:14 -07:00
Adam Vandenberg
ace8723caf Add audit for xcodebuild. 
xcodebuild should be passed an explicit SYMROOT, since the user
can override this.

Also added --strict, so certain audits can be ignored in most
cases (including this one.)
 2011-03-21 12:54:00 -07:00
Adam Vandenberg
2eb0065ced brew audit: check that homepage includes the protocol 2011-03-15 21:40:09 -07:00
Adam Vandenberg
749b91c6ba brew audit: check for missing deps 2011-03-12 17:40:40 -08:00
Charlie Sharpsteen
0e5436d4ab brew audit - check for depends_on 'gfortran' 
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
 2011-03-12 13:30:12 -08:00
Adam Vandenberg
4812dd1b89 audit - check formula permissions 2011-03-12 11:55:07 -08:00
Max Howell
c1a3b724fd Some Cleanup 2011-03-12 11:55:03 -08:00
Adam Vandenberg
c5c1f40d0a Move brew-audit to cmds 2011-03-12 11:55:03 -08:00