Sam Ford
77273fe2b3
Cask::Audit: Handle referenced cask in livecheck
...
`Cask::Audit#check_livecheck_version` was never updated to handle
a referenced cask in a `livecheck` block (e.g., `cask "other-cask"`).
As a result, this audit will wrongly give an error like `Version
'1.2.3' differs from '' retrieved by livecheck.` in this scenario.
This commit ensures that a referenced cask is handled by the audit
and it won't error when the referenced check provides a good version.
2021-11-02 12:32:38 -04:00
Rylan Polster
e24703e58d
Rename :cert_error_allowlist to :secure_connection_audit_skiplist
2021-10-21 21:11:06 -04:00
Rylan Polster
fa4bb7d74a
Refactor audit exception handling
2021-10-21 21:11:05 -04:00
Rylan Polster
d124d8eae8
cask/audit: allow the homepage https audit to have exceptions
2021-10-21 21:01:52 -04:00
Michael Cho
b44ecaceb7
docs: fix cask doc urls to use docs.brew.sh
2021-06-25 13:20:40 -07:00
Sam Ford
e8f803bc75
Cask::Audit: Handle livecheck skip conditions
2021-06-14 14:28:27 -04:00
Kenneth Chew
af594739dc
audit: specify which URL has a content problem in problem message
2021-04-22 13:52:18 +01:00
Markus Reiter
ba87bfc4e4
Only suggest adding livecheck it auto-detection fails.
2021-04-07 19:19:20 +02:00
Markus Reiter
72a79d934e
Fix audit annotations for casks.
2021-04-03 04:27:32 +02:00
Markus Reiter
d2a3944e70
Skip url do URLs in offline audit.
2021-04-02 01:55:35 +02:00
Markus Reiter
3f4706d9e6
Don't suggest adding unnecessary appcast.
2021-03-31 08:13:48 +02:00
Mike McQuaid
9b725a5851
cask/dsl/version: reject invalid characters.
...
There was a `invalid_characters` method already but it was not being
used.
2021-03-30 14:15:14 +01:00
Rylan Polster
b4a36bef64
audit: fix --display-failures-only failure messaging
2021-03-22 22:20:04 -04:00
Rylan Polster
2b8d19e0bd
audit: limit non-failure cask output
2021-03-22 22:16:54 -04:00
Markus Reiter
3c6a7b39e2
Merge pull request #10894 from reitermarkus/mandatory-livecheck
...
Make `livecheck` audit mandatory for versioned casks.
2021-03-23 01:34:00 +01:00
Markus Reiter
41fec99591
Make livecheck audit mandatory for versioned casks.
2021-03-23 01:11:35 +01:00
Markus Reiter
b0fd4831d5
New casks should use livecheck.
2021-03-20 22:20:55 +01:00
Markus Reiter
65d1747b29
Check homepage with both browser and default user agent.
2021-03-11 16:19:21 +01:00
Mike McQuaid
9663567501
Fix brew style.
2021-03-01 13:43:47 +00:00
nandahkrishna
8e5451df2f
style: use parentheses for assignment in conditions
2021-02-12 18:33:37 +05:30
Mike McQuaid
851bf9aab9
Merge pull request #10465 from vitorgalvao/no-desc-fonts
...
cask audit: do not require description for fonts
2021-02-02 16:35:26 +00:00
Vítor Galvão
e3d515105b
cask audit: do not require description for fonts
2021-02-02 14:06:11 +00:00
Mike McQuaid
861da37f55
Merge pull request #10456 from SeekingMeaning/cask-audit-format-url
...
cask/audit: underline URLs in audit errors
2021-02-01 09:05:53 +00:00
Seeker
571a13b99e
cask/audit: underline URLs in audit errors
2021-01-28 16:17:40 -08:00
Seeker
00e5e1f9fc
cask/audit: error if verified does not match, regardless of url
2021-01-28 15:27:00 -08:00
Mike McQuaid
03c861b7d7
Merge pull request #10428 from SeekingMeaning/cask-reverse-migration
...
cask/audit: disallow new cask to have token in tap_migrations.json
2021-01-27 15:07:13 +00:00
EricFromCanada
99ad3350ee
use single quotes around stanza and parameter names
2021-01-26 16:19:47 -05:00
EricFromCanada
a6643b4adf
fix odebug calls
2021-01-26 12:02:30 -05:00
Seeker
c1d2aaf13a
cask/audit: disallow new cask to have token in tap_migrations.json
2021-01-26 08:33:14 -08:00
Vítor Galvão
1ca68556e7
Cask: audit: Do not require appcast on GitHub releases
2021-01-17 00:48:33 +00:00
Markus Reiter
92b58666ef
Improve audit for livecheck in casks.
2021-01-13 08:12:11 +01:00
Seeker
b9854bd4cf
rubocops: add unless_multiple_conditions
2021-01-08 10:33:54 -08:00
Rylan Polster
ec4fe89a94
audit: migrate shared audits to taps
2020-12-21 14:45:02 -05:00
Markus Reiter
8fa5a8e832
Don't suggest adding appcast if livecheck exists.
2020-12-19 19:34:24 -05:00
Markus Reiter
0ae8f0edc8
Merge pull request #9493 from reitermarkus/url-unversioned
...
Add audit for unversioned URLs with checksum.
2020-12-16 10:19:48 +01:00
Markus Reiter
44cf1041ac
Fix tests.
2020-12-16 09:45:58 +01:00
Markus Reiter
1064678d3d
Add audit for unversioned URLs with checksum.
2020-12-16 09:36:21 +01:00
Markus Reiter
e194c86a2b
Fix audit for verified parameter.
2020-12-16 09:29:45 +01:00
Markus Reiter
f711352cfd
Add audit for livecheck in casks.
2020-12-14 15:44:35 +01:00
Markus Reiter
6e5cf565e3
Ignore verified for url do blocks.
2020-12-12 06:01:26 +01:00
Markus Reiter
9e0a54fd37
Reuse curl_http_content_headers_and_checksum for appcast audit.
2020-12-08 23:29:01 +01:00
Mike McQuaid
9216d8abe6
rubocop-rails: make fixes.
2020-12-02 10:43:04 +00:00
linzichao
058a1c3645
add verified parameter in url
2020-12-01 01:17:21 +01:00
Markus Reiter
7a83f34dd1
Support casks in brew fetch.
2020-11-19 19:46:59 +01:00
Markus Reiter
da9289eff0
Add more type signatures.
2020-11-13 12:26:36 +01:00
Markus Reiter
d66ca60cdb
Only warn if repo of discontinued cask is archived.
2020-11-08 18:08:02 +01:00
Markus Reiter
24ae318a3d
Move type annotations into files.
2020-10-10 14:59:39 +02:00
Maxim Belkin
0d3cc7cd82
cask/audit.rb: minor cleanup
2020-09-21 04:40:32 -05:00
Markus Reiter
b72e7ee34d
Only treat cask audit warnings as errors if --strict is passed.
2020-09-14 13:12:38 +02:00
Markus Reiter
e4356e85d1
Treat more things as errors in cask audit.
2020-09-14 13:12:38 +02:00
