admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
14,765 Commits 15 Branches 471 Tags
Commit Graph

13212 Commits

Author SHA1 Message Date
Mike McQuaid
8c6defd9cf diagnostic: simplify version checks. 2017-11-05 15:39:43 +00:00
Mike McQuaid
b69d71edea system_config: handle new non-string Xcode version 2017-11-05 15:39:43 +00:00
Mike McQuaid
77e3e7e4d9 version: support to_i. 
This is needed for existing MacOS::Xcode.version calls that relied on
this returning a string. It mirrors similar behaviour for to_f.
 2017-11-05 15:39:43 +00:00
Mike McQuaid
389188ac4f mac/xquartz: compare with existing Version class. 2017-11-05 15:39:43 +00:00
Mike McQuaid
600d58f4ca mac/xcode: compare with existing Version class. 
Additionally, return null versions when it makes sense to do so. This
means that comparisons on the Xcode/CLT version do not need to be
guarded on whether Xcode/CLT is installed.
 2017-11-05 15:39:43 +00:00
Mike McQuaid
7a68b4a3f9 Refactor command handling code 
Don’t rely on having external commands always present in the PATH in
order to find them. Instead, provide an accessory method to Tap so
they can be added and used when needed.

While we’re here, do some general refactoring and cleanup of the
command code in these places.
 2017-11-05 15:37:57 +00:00
Mike McQuaid
5bf0584308
Merge pull request #3420 from MikeMcQuaid/config-env-output 
system_config: output most HOMEBREW_* variables.
 2017-11-05 15:36:06 +00:00
Mike McQuaid
4892465fc4 system_config: output most HOMEBREW_* variables. 
Exclude the boring ones and exclude some that are already printed that
are just using their default values. HOMEBREW_PREFIX is the only one
where we’re always interested in the output to quickly communicate it.
 2017-11-05 14:45:36 +00:00
Mike McQuaid
1b69848119 system_config: output curl path and version. 2017-11-05 14:45:36 +00:00
Mike McQuaid
b369593cbd utils: correctly handle empty user gem env. 2017-11-05 14:45:36 +00:00
Mike McQuaid
f999a57620 brew.sh: cleanup some environment pollution. 2017-11-05 14:45:36 +00:00
Mike McQuaid
a7d74e0f53 curl: unset SSL_CERT_FILE. 2017-11-05 14:45:26 +00:00
Mike McQuaid
b9d9e63743 spec_helper: fix etc leak. 
Fix the `etc/bash_completion.d/_brew_services` leak from the new
bash completion in the Homebrew/homebrew-services tap.
 2017-11-05 13:20:08 +00:00
Mike McQuaid
2af98133ba
Merge pull request #3407 from DomT4/x11 
xquartz: add new versions + mark latest
 2017-11-03 18:28:46 +00:00
Mike McQuaid
872bd4f703
Merge pull request #3395 from GauthamGoli/parameters-audit-regex-fix 
lines_cop: Update regex patterns to prevent false positives
 2017-11-03 17:48:09 +00:00
Mike McQuaid
c6f40d5864
Merge pull request #3385 from MikeMcQuaid/path-fixes-cleanup 
Fix and cleanup some PATH usage.
 2017-11-03 17:45:57 +00:00
Mike McQuaid
29f81812cc brew.rb: cleanup PATH setup. 
Avoid adding all the tap commands to the PATH when not necessary.
 2017-11-03 14:50:17 +00:00
Mike McQuaid
f0b25b5482 requirement: convert Cellar path to opt path. 2017-11-03 14:50:17 +00:00
Mike McQuaid
5de7ec394b requirement: don't add /usr/local/{bin,sbin}. 
This should be considered a requirement bug if it's added.
 2017-11-03 14:50:17 +00:00
Mike McQuaid
c843fd2f12 requirement: prepend rather than append PATH. 
Otherwise this ends up behind e.g. `/usr/bin` so is pretty useless.
 2017-11-03 14:50:17 +00:00
Zhiming Wang
04367c4daf
bump-formula-pr: --message: add newlines before and after hr 
Without an empty line before the horizontal rule (---), "Created with `brew
bump-formula-pr`." is treated as a setext header.

The newline before the hr is not part of the heredoc because putting it in
would trip up Rubocop.
 2017-11-03 10:02:26 -04:00
Markus Reiter
4eeac6f884
Merge pull request #3389 from amyspark/hacktoberfest-single-zap 
Check that a single uninstall_* and zap stanza is defined
 2017-11-03 13:23:08 +01:00
commitay
a8788015b6 Cask doctor: add macOS & Java versions 2017-11-03 08:37:10 +10:00
ilovezfs
3769bcc523 formula: fix safe navigation bug 
Safe navigation needs to be chained to preserve equivalence.

Fixes a bug introduced by 01e9ec9a in #3183.
 2017-11-02 07:26:00 -07:00
L. E. Segovia
eaae7f3a5b Fix last remaining style issues 2017-11-02 09:56:51 -03:00
L. E. Segovia
7f398d01b8 Turn ifs into multiple lines 2017-11-01 22:35:41 -03:00
Isabell Long
5cbb414797 formula_desc_cop: Fix the 'full stop at end of description' autocorrect 
- It wasn't working because desc strings end in quotes, not just full
  stops.
 2017-11-01 19:50:56 +00:00
Isabell Long
0786d41693 formula_desc_cop: If desc ends with 'etc.', it's not a violation 2017-11-01 19:50:56 +00:00
Dominyk Tiller
50c09f8c57
xcode: expect Xcode 9.1 on Sierra & High Sierra 2017-11-01 04:48:52 +00:00
Dominyk Tiller
6937f6fa55
mac: update for Xcode 9.1 2017-11-01 04:46:23 +00:00
Dominyk Tiller
bdc7657456
xquartz: mark 2.7.11 as latest release 2017-10-31 16:21:03 +00:00
Dominyk Tiller
eb950644c5
xquartz: add 2.7.10 & 2.7.11 releases 2017-10-31 16:20:47 +00:00
L. E. Segovia
c636be07f9 Separate do end into multiple lines 2017-10-31 09:54:30 -03:00
L. E. Segovia
7f2e4f583a Finalize metadata handling and uninstall logic 2017-10-30 23:29:00 -03:00
Dominyk Tiller
bff4762d36
text_cop_spec: update go get tests 2017-10-31 01:01:42 +00:00
Dominyk Tiller
883fee78ad
text_cop: warn against go_resource usage for strict audit 2017-10-31 00:55:00 +00:00
Dominyk Tiller
8fd18eab21
text_cop: drop go_resource recommendation 2017-10-31 00:47:57 +00:00
L. E. Segovia
917c138eeb Add tests for uninstall_* and zap stanzas 2017-10-30 20:47:40 -03:00
L. E. Segovia
9b6b0bfed7 Use #count, rewrite warning, and add pre/postflight checks too 2017-10-30 20:47:22 -03:00
Markus Reiter
2eb366ff38 Fix SystemCommand without arguments. 2017-10-30 22:04:54 +01:00
Mike McQuaid
2d5bb029a5
Merge pull request #3387 from MikeMcQuaid/env-std-homebrew-paths 
ENV/std: fully extend from HOMEBREW_PATH.
 2017-10-30 16:09:01 +00:00
Mike McQuaid
6ddf3f8796 bump-formula-pr: add --no-browse option. 
If `--no-browse` is passed, don't pass the `--browse` argument to `hub`
which opens the pull request URL in a browser. Instead, output it to the
command line.
 2017-10-30 09:14:53 +00:00
Mike McQuaid
7a0fdc3d03
Merge pull request #3393 from MikeMcQuaid/with_env_tweaks 
Tweak use of with_env
 2017-10-30 08:17:06 +00:00
L. E. Segovia
55727b7895 Hack a first working version of upgrade 2017-10-29 17:34:53 -03:00
Mike McQuaid
4c44266aa5
Merge pull request #3394 from MikeMcQuaid/sh-no-ps1 
cmd/sh: set working PS1 for zsh
 2017-10-29 19:17:26 +00:00
Gautham Goli
f648dd03ff lines_cop: Update regex patterns to prevent false positives 2017-10-29 23:40:04 +05:30
Mike McQuaid
3549377478 cmd/sh: set working PS1 for zsh. 
The `bash`, default one is broken on `zsh`.
 2017-10-29 17:23:05 +00:00
Mike McQuaid
c59c0d6820
Merge pull request #3376 from tomjonandy/fix/keychain-credentials 
Fix issue where keychain github credentials wouldn't work
 2017-10-29 16:57:21 +00:00
Mike McQuaid
215f49684b
Merge pull request #2795 from issyl0/desc_no_full_stops 
formula_desc_cop: ensure no full stops at the end of desc
 2017-10-29 16:56:00 +00:00
Isabell Long
640b1e9dcb formula_desc_cop: ensure no full stops at the end of desc 
- This was a suggestion by Mike McQuaid in my `homebrew-core` audit
  description PR. Based on ilovezfs's incantation `grep -r -E 'desc
  ".*\."' *.rb`, some formulae descriptions do end in full stops. (My
  initial assessment of this failed to account for the fact that
  descriptions are strings and so end in `"`.)
- Add an autocorrect for this cop, too.
 2017-10-29 15:19:31 +00:00