209 Commits

Author SHA1 Message Date
Shaun Jackman
a4033c7196 Do not specify absolute paths to utilities
Specifying an absolute path to utilities is no longer needed,
since environment filtering uses a default PATH.
2017-12-12 09:25:16 -08:00
Martin Schimandl
0db069602e Refactor: Move FormulaAudit.check_http_content to utils/curl 2017-12-03 14:02:55 +01:00
Shaun Jackman
7adee6d62f Utils.popen_read: Nonexistent program should fail
Ensure that $CHILD_STATUS.success? is false when the command does not exist.
2017-12-02 15:52:01 -08:00
Mike McQuaid
fb6cf0c3f8 More environment filtering fixes
- Make `brew pull` pass through Git environment variables
- Whitelist all `TRAVIS_` variables.
2017-11-27 10:48:03 +00:00
Shaun Jackman
5920c0b2ae setup-analytics: Handle missing /proc/.../uuid 2017-11-23 08:55:15 -08:00
Shaun Jackman
48ed28a154 Change the generic bottle tag to processor-system 2017-11-22 23:06:26 -08:00
Mike McQuaid
5241d07474 environment filtering: pass through TRAVIS vars.
We use these internally so let's map them to `HOMEBREW_` variables.
2017-11-13 10:01:54 +00:00
Mike McQuaid
a7d74e0f53 curl: unset SSL_CERT_FILE. 2017-11-05 14:45:26 +00:00
Mike McQuaid
c59c0d6820
Merge pull request #3376 from tomjonandy/fix/keychain-credentials
Fix issue where keychain github credentials wouldn't work
2017-10-29 16:57:21 +00:00
Michka Popoff
b93ed4124c lock.sh: suppress error output when looking for flock
Fixes (on centos6):
which: no flock in (/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin)
2017-10-27 15:54:24 +02:00
Thomas Andrew
0e991095f1 Fix issue where keychain github credentials wouldn't work 2017-10-26 18:54:48 +01:00
ilovezfs
1937625d86 github: require formula name to be in issue title 2017-10-24 03:07:33 -07:00
Mike McQuaid
76cd7c7949 Merge pull request #3319 from reitermarkus/squiggly-heredocs
Use “squiggly” heredocs.
2017-10-20 14:10:50 +01:00
Markus Reiter
9bee9ca575 Use “squiggly” heredocs. 2017-10-18 14:39:09 +02:00
Shaun Jackman
7a0488e803 setup-ruby-path: Ensure that Ruby is installed
Fix the error:
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.sh: line 372:
exec: : not found
2017-10-17 15:14:58 -07:00
Markus Reiter
175ca909ee Clean up code style and remove .rubocop_todo.yml. 2017-10-08 16:10:37 +02:00
Shaun Jackman
2e77de3b58 Fix installing a local bottle from source
Factor Utils::Bottles.formula_contents out of BottleLoader.
2017-09-28 12:29:23 -07:00
Shaun Jackman
1e57445eca receipt_path: Ensure the bottle contains INSTALL_RECEIPT.json 2017-09-27 09:36:41 -07:00
Mike McQuaid
a589303616 Merge pull request #3183 from MikeMcQuaid/rubocop-upgrade
Rubocop: 0.50.0 and Ruby 2.3
2017-09-25 21:29:03 +01:00
Mike McQuaid
598ea0cdec portable-ruby: fix installation on Leopard.
Download it insecurely there and require `rubygems` for `Gem::Version`.
2017-09-25 15:46:58 +01:00
Mike McQuaid
cf5fdeef1d Rubocop: manual rule fixes. 2017-09-24 21:23:59 +01:00
Mike McQuaid
3d876f7d70 utils/git: cache less aggressively.
This should avoid weird test ordering failures with specs on Linux (but
there's no real reason this can't occur on macOS too).
2017-09-24 20:39:06 +01:00
Mike McQuaid
7f93d816a3 utils/git: don't fail when CoreTap is untapped.
This produces test failures on Linux where we intentionally avoid having
it tapped.
2017-09-23 21:53:20 +01:00
Mike McQuaid
6b3bb666e8 Merge pull request #3174 from sjackman/popen-options
popen: Do not suppress stderr when HOMEBREW_STDERR
2017-09-23 16:31:52 +01:00
Mike McQuaid
aa665b9458 portable-ruby: improve installation messaging.
- Use “Pouring” to be more consistent with our normal messaging.
- Don’t be silent by default.
2017-09-22 15:54:29 +01:00
Mike McQuaid
b2b413165f Upgrade vendored Ruby to 2.3.3.
Use this version whenever 2.3.3 isn't installed. Also, remove the Linux
portable Ruby for now until it's built to be the same version.
2017-09-21 14:27:17 +01:00
Shaun Jackman
58a1bd6dbf popen: Do not suppress stderr when HOMEBREW_STDERR 2017-09-20 13:25:36 -07:00
Shaun Jackman
8bf28477a3 popen: Add an options argument
Useful for selectively enabling or silencing stderr, for example.
popen_read("foo", err: :err)
2017-09-20 13:25:29 -07:00
ilovezfs
6fb9fed693 Revert "popen: Do not suppress stderr" 2017-09-19 07:40:29 -07:00
Mike McQuaid
6bde1de309 Merge pull request #3099 from sjackman/popen_read_stderr
popen: Do not suppress stderr
2017-09-18 19:22:17 +01:00
Markus Reiter
1f66c9c9e0 Let curl_download handle HTTP 416 error. 2017-09-10 07:23:18 +02:00
Shaun Jackman
78d3112df2 popen: Do not suppress stderr unless -d or -v 2017-09-08 09:39:33 -07:00
Mike McQuaid
3bb98714af Merge pull request #2955 from mansimarkaur/git_tests
Added tests for utils/git
2017-09-02 15:53:32 +01:00
Dominyk Tiller
0ea4da4ef6
github: limit PR search to Homebrew
Not sure whether this is the way you want to handle this problem but
it's really darn irritating so here's a PR that handles it one way.

Fixes: https://github.com/Homebrew/brew/pull/3086#issuecomment-324519156
2017-08-31 03:59:33 +01:00
Misty De Meo
156bca7dfb Merge pull request #2950 from mansimarkaur/svn
Added tests for utils/svn
2017-08-29 15:08:05 -07:00
mansimarkaur
784250d550 Used already existing clear_git_available_cache to remove @git 2017-08-29 22:53:10 +05:30
mansimarkaur
1dd7e9d95b Modified clear_anonymous_os_prefix_ci_cache 2017-08-29 16:36:46 +05:30
mansimarkaur
413d35b82f Added clear_anonymous_os_prefix_ci_cache 2017-08-29 16:24:19 +05:30
mansimarkaur
d9c0b8ce9f Added clear_svn_version_cache 2017-08-29 16:16:17 +05:30
mansimarkaur
53be6bb4bd Added check for svn availability 2017-08-29 16:16:17 +05:30
mansimarkaur
cf96d8d970 Improved tests for svn_available? 2017-08-29 16:16:17 +05:30
mansimarkaur
c695dffd37 Added clear git version cache method 2017-08-27 01:23:32 +05:30
mansimarkaur
372a422305 Added tests for ensure_git_installed when git is available or homebrew/core is unavailable 2017-08-27 01:23:32 +05:30
mansimarkaur
657b6ef7fb Added tests for git_available? 2017-08-27 01:23:32 +05:30
mansimarkaur
d91036e891 Added tests for last_revision_commit_of_file 2017-08-27 01:23:32 +05:30
Shaun Jackman
7b96fd008e safe_fork: Improve the error message 2017-08-25 12:43:07 -07:00
Markus Reiter
15e572702e Fix pull. 2017-08-21 22:41:13 +02:00
Markus Reiter
56ef168e70 Move fix from #3070 inside GitHub module. 2017-08-20 16:31:46 +02:00
Ben Muschol
ca05c7f010 Change var name 2017-08-17 14:38:50 -04:00
Ben Muschol
5f8d212ccc Unify vocabulary in github module, remove unnecessary logic
Fix duplication bug
2017-08-14 14:45:24 -04:00