20731 Commits

Author SHA1 Message Date
Mike McQuaid
c88d587b5b
Merge pull request #7508 from MikeMcQuaid/pkgetc
formula: add pkgetc method.
2020-05-06 11:04:54 +01:00
Mike McQuaid
be5bbcd78a
Merge pull request #7509 from MikeMcQuaid/cli_refactoring
Refactor CLI to remove `unless args_parsed`
2020-05-06 11:04:22 +01:00
Mike McQuaid
20a1199375
Refactor CLI to remove unless args_parsed
Refactor the CLI::Args module so it doesn't have different paths to
check arguments depending on whether the arguments have been parsed or
not. Instead, set the values we need from the global ARGV at
first, global initialisation time where they will be thrown away when
the actual arguments are parsed.

To do this some other general refactoring was needed:
- more methods made private when possible
- e.g. `HEAD?` used consistently instead of `head` before arguments
  are parsed.
- formula options are only parsed after named arguments are extracted
2020-05-05 17:47:51 +01:00
Mike McQuaid
a5a5a1a83a
Merge pull request #7510 from MikeMcQuaid/disable-rspec-filepath
rubocop_rspec: disable RSpec/FilePath.
2020-05-05 16:17:54 +01:00
Mike McQuaid
60c9472b14
rubocop_rspec: disable RSpec/FilePath.
We keep adding to the list of exceptions and this fails if it isn't run
in the right directory.
2020-05-05 15:50:10 +01:00
Mike McQuaid
316da98140
Merge pull request #7503 from Bo98/since-fix
os/mac/software_spec: fix argument error in valid  use case
2020-05-05 09:10:33 +01:00
Mike McQuaid
34978edd90
Merge pull request #7460 from vidusheeamoli/port-keg-only-rubocop
audit: Port audit_keg_only to RuboCop and add tests
2020-05-05 09:05:18 +01:00
Mike McQuaid
8e318d81bc
formula: add pkgetc method.
This should provide a more "type-safe" way of referring to the `etc`
directories of other formulae e.g.
https://github.com/Homebrew/homebrew-core/pull/54257 so that the output
will change if the formula name changes.
2020-05-05 08:34:07 +01:00
vidusheeamoli
f851688541 audit: Port audit_keg_only to rubocop and add tests
audit: add test

audit: fixed test

audit: added another test case

audit: fix test

audit: fix test

audit: fix keg only
2020-05-05 10:47:49 +05:30
Shaun Jackman
e10e955525
Merge pull request #7506 from sjackman/docker
docker.yml: Set persist-credentials: false
2020-05-04 16:46:18 -07:00
Shaun Jackman
f4e32ebcb1 docker.yml: Set persist-credentials: false 2020-05-04 16:16:18 -07:00
Shaun Jackman
6065dd1f1a
Merge pull request #7504 from sjackman/docker-hub
docker.yml: Fix a typo
2020-05-04 15:27:25 -07:00
Shaun Jackman
3a9e12efac docker.yml: Fix a typo 2020-05-04 15:00:36 -07:00
Shaun Jackman
b06a7af604
Merge pull request #7494 from sjackman/docker-hub
docker.yml: Deploy the tagged image to Docker Hub
2020-05-04 12:57:33 -07:00
Shaun Jackman
305ecfd66e docker.yml: Deploy tagged image to Docker Hub 2020-05-04 12:34:59 -07:00
Bo Anderson
16141e7eff os/mac/software_spec: fix argument error in valid use case 2020-05-04 17:16:39 +01:00
Mike McQuaid
e1f3b0b971
Merge pull request #7500 from MikeMcQuaid/deps_args_spec
deps_spec: check args.
2.2.15
2020-05-04 13:28:13 +01:00
Mike McQuaid
b73beaba91
Merge pull request #7502 from MikeMcQuaid/cmdline_args_trim
cli: readability improvements.
2020-05-04 13:04:39 +01:00
Mike McQuaid
f567302ebf
deps_spec: check args. 2020-05-04 12:59:56 +01:00
Mike McQuaid
9324a85955
cli: readability improvements.
- Rename `cmdline_args` to `argv` to make it more obvious where they
  come from.
- Make the `if args_parsed` early return into `unless args_parsed` to
  (hopefully) make it clearer that this is not the "normal" case and
  to not check `argv` unless arguments haven't been parsed.
2020-05-04 12:42:29 +01:00
Mike McQuaid
ee108f5b26
Merge pull request #7499 from Homebrew/revert-7490-argv-cleanup-25
Revert "ARGV: Deprecate ARGV.flags_only and replace with Homebrew.args.flags_only"
2020-05-04 11:56:16 +01:00
Mike McQuaid
ae353ff42e
Revert "ARGV: Deprecate ARGV.flags_only and replace with Homebrew.args.flags_only" 2020-05-04 11:12:25 +01:00
Mike McQuaid
53fe2c94db
Merge pull request #7495 from Homebrew/dependabot/bundler/Library/Homebrew/rspec-support-3.9.3
build(deps): bump rspec-support from 3.9.2 to 3.9.3 in /Library/Homebrew
2020-05-04 08:56:05 +01:00
Mike McQuaid
dcd48b0357
Merge pull request #7496 from Homebrew/dependabot/bundler/Library/Homebrew/rspec-core-3.9.2
build(deps): bump rspec-core from 3.9.1 to 3.9.2 in /Library/Homebrew
2020-05-04 08:55:47 +01:00
dependabot-preview[bot]
417bdca22d
build(deps): bump rspec-core from 3.9.1 to 3.9.2 in /Library/Homebrew
Bumps [rspec-core](https://github.com/rspec/rspec-core) from 3.9.1 to 3.9.2.
- [Release notes](https://github.com/rspec/rspec-core/releases)
- [Changelog](https://github.com/rspec/rspec-core/blob/master/Changelog.md)
- [Commits](https://github.com/rspec/rspec-core/compare/v3.9.1...v3.9.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-04 05:59:23 +00:00
dependabot-preview[bot]
35869b917d
build(deps): bump rspec-support from 3.9.2 to 3.9.3 in /Library/Homebrew
Bumps [rspec-support](https://github.com/rspec/rspec-support) from 3.9.2 to 3.9.3.
- [Release notes](https://github.com/rspec/rspec-support/releases)
- [Changelog](https://github.com/rspec/rspec-support/blob/master/Changelog.md)
- [Commits](https://github.com/rspec/rspec-support/compare/v3.9.2...v3.9.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-04 05:58:51 +00:00
Mike McQuaid
9befd55d5e
Merge pull request #7492 from Bo98/docker-fix
Dockerfile: restore git-core PPA
2020-05-03 14:49:31 +01:00
Bo Anderson
5935da6c6c Dockerfile: restore git-core PPA 2020-05-03 14:29:09 +01:00
Mike McQuaid
9e5932c214
Merge pull request #7485 from MikeMcQuaid/formula_cellar_check_plist
formula_cellar_checks: check plist.
2020-05-03 14:21:21 +01:00
Mike McQuaid
c5267f1c75
formula_cellar_checks: check plist.
Check plists so https://github.com/Homebrew/homebrew-services/issues/219 does not occur.
2020-05-03 13:59:08 +01:00
Mike McQuaid
92f26e991c
Merge pull request #7490 from GauthamGoli/argv-cleanup-25
ARGV: Deprecate ARGV.flags_only and replace with Homebrew.args.flags_only
2020-05-03 13:41:07 +01:00
Mike McQuaid
6175f477bb
Merge pull request #7456 from sjackman/docker
Build Docker images for Ubuntu 18.04 and 20.04
2020-05-03 13:40:14 +01:00
Gautham G
66ac96acde ARGV: Depercate ARGV.flags_only and replace with Homebrew.args.flags_only 2020-05-03 13:55:51 +05:30
Shaun Jackman
5052f49f40 Build Docker images for Ubuntu 18.04 and 20.04 2020-05-02 21:04:08 -07:00
Mike McQuaid
3247f26a34
Merge pull request #7479 from sjackman/requirements
docs/Homebrew-on-Linux.md: Requirements
2020-05-02 14:43:40 +01:00
Mike McQuaid
4019f62e61
Merge pull request #7483 from Bo98/std-cpu-flags
ENV/std: fix error when using older/no clang
2020-05-02 14:16:26 +01:00
Mike McQuaid
b2571d42eb
Merge pull request #7484 from MikeMcQuaid/cleanup-sandbox
Cleanup Sandbox code
2020-05-02 14:16:09 +01:00
Mike McQuaid
677b987903
Merge pull request #7476 from MikeMcQuaid/improve-portable-ruby-messaging
Improve Homebrew Portable Ruby messaging
2020-05-02 14:15:15 +01:00
Mike McQuaid
6123cdb767
Improve Homebrew Portable Ruby messaging
As-of https://github.com/Homebrew/homebrew-portable-ruby/pull/100 we've
removed ARM builds for Portable Ruby due to months of breakage.
Similarly, when we last bumped Portable Ruby the ARM build was much
delayed but, despite Homebrew/brew being completely unusable to anyone
using it on ARM in that case, no-one complained or filed issues.

Instead of attempting to maintain and update a Portable Ruby on niche
(Homebrew) platforms like ARM (or, in past/future PPC) improve the
messaging to provide users with a workaround.

Now we allow only a major/minor version match it should be pretty
doable for those users to install e.g. a prebuilt Ruby binary from a PPA
or built it from source if needed using `ruby-build` and `rbenv`.

The messaging could be improved further but we're somewhat limited by
`ruby.sh` and `vendor-install.sh` being separate. I'm tempted to combine
them (or at least have `vendor-install.sh` not be so generic as to not
be able to give Ruby-specific advice).
2020-05-02 13:53:45 +01:00
Mike McQuaid
40ec8e69cc
Cleanup Sandbox code
Remove unused code and methods.
2020-05-02 13:45:04 +01:00
Mike McQuaid
330f1c1c39
Merge pull request #7481 from GauthamGoli/argv-cleanup-24
ARGV: Deprecate ARGV.casks and replace with Homebrew.args.casks
2020-05-02 13:33:58 +01:00
Mike McQuaid
010663fb12
Merge pull request #7477 from runlevel5/ppc64le-patch-2
Update Hardware::CPU.oldest_family with ppc64
2020-05-02 13:33:39 +01:00
Bo Anderson
3717815ade ENV/std: fix error when using older/no clang
Fixes #7482.
2020-05-02 13:33:32 +01:00
Mike McQuaid
79ac5c5a7d
Merge pull request #7480 from Bo98/cache-fix
workflows/tests: fix gem caching
2020-05-02 13:31:06 +01:00
Gautham G
38c24d134c ARGV: Deprecate ARGV.casks and replace with Homebrew.args.casks 2020-05-02 13:21:16 +05:30
Gautham Goli
bffe4dde96
Merge pull request #7478 from GauthamGoli/argv-cleanup-23
ARGV: Deprecate ARGV.formulae, replace with Homebrew.args.formulae
2020-05-02 11:05:09 +05:30
Bo Anderson
fe0d45b123 workflows/tests: fix gem caching 2020-05-02 00:42:06 +01:00
Shaun Jackman
ab1d03c5b1 docs/Homebrew-on-Linux.md: Requirements
Linux/WSL is redundant.
2020-05-01 15:08:39 -07:00
Gautham G
f6abc6fe19 ARGV: Deprecate ARGV.formulae, replace with Homebrew.args.formulae 2020-05-01 22:50:59 +05:30
Mike McQuaid
7f69550e00
Merge pull request #7475 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-rspec-1.39.0
build(deps): bump rubocop-rspec from 1.38.1 to 1.39.0 in /Library/Homebrew
2020-05-01 16:02:45 +01:00