admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
7,541 Commits 15 Branches 471 Tags
Commit Graph

317 Commits

Author SHA1 Message Date
Baptiste Fontaine
d87f9d4359 singular/plural phrasing in audit report 
Closes Homebrew/homebrew#40395.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
 2015-06-05 19:32:23 +02:00
Xu Cheng
4cc21fb1f7 audit: audit formulae with the same name 
Closes Homebrew/homebrew#40216.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-06-01 20:08:41 +08:00
Xu Cheng
9bf4bf5fee audit: use Formula#full_name 2015-05-29 17:01:53 +08:00
Viktor Szakats
26d1683039 audit: enforce gnome urls 
Closes Homebrew/homebrew#40172.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-05-29 08:22:37 +01:00
Dominyk Tiller
6db8e1c5a9 audit: simplify ssl/tls audit failure messages 
This cuts the amount of custom code fairly drastically, applying the
same generic syntax across the different SSL/TLS enforced areas.

It also makes the failure message fit onto one terminal line, which
looks cleaner than the multi-line message we currently print
for standard-size Terminals.

Changes something like:

`ftp.gnu.org urls should be https://, not http:// (url is http://ftp.gnu.org/gnu/gawk/gawk-4.1.1.tar.xz)`

Into:

`Please use https:// for http://ftp.gnu.org/gnu/gawk/gawk-4.1.1.tar.xz`

References: Homebrew/homebrew#39421 Homebrew/homebrew#39306

Closes Homebrew/homebrew#40054.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
 2015-05-27 11:44:29 +01:00
Xu Cheng
ef3f0f0945 audit: handle TapFormulaAmbiguityError 2015-05-27 13:53:41 +08:00
Nikolaus Wittenstein
39498af1c6 audit looks for and validates 'desc' 2015-05-25 17:23:50 +01:00
Xu Cheng
60f2377853 audit: formula version string should have digit 
Closes Homebrew/homebrew#40025.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-05-24 20:07:44 +08:00
Xu Cheng
78ccd41251 audit: add rules for non-ascii character and encoding comment 
Closes Homebrew/homebrew#40042.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-05-24 20:07:33 +08:00
Xu Cheng
e4ff0a2f2e audit: move audit_java_home inside audit_line 2015-05-24 16:27:54 +08:00
Xu Cheng
cc0c9cf619 audit: don't complain ENV.fortran if depends_on :fortran 
Fix the audit problem in Homebrew/homebrew#40000.

Closes Homebrew/homebrew#40012.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-05-23 19:40:55 +08:00
Viktor Szakats
a054005883 audit: fix two message typos 
Originally submitted as part of https://github.com/Homebrew/homebrew/pull/38824/files,
later reverted due another hunk.

Closes Homebrew/homebrew#39753.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-05-14 21:24:49 +01:00
Jack Nagel
f242381e2a Tweak audit copy 
URLs are not links.
 2015-05-14 00:15:41 -04:00
Jack Nagel
c16a1d9aba Extend gnome stable/unstable audit to download.gnome.org URLs 2015-05-14 00:01:00 -04:00
Misty De Meo
ce6885e784 Audit: stop warning about Github .patch URLs 
These no longer have a git version appended; e.g.:
ddb966061f.patch
 2015-05-12 20:20:13 -07:00
Dominyk Tiller
a80c2ae06f audit: tweak ftp.gnu.org language for clarity 
Closes Homebrew/homebrew#39421.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2015-05-09 13:26:52 -04:00
Viktor Szakats
6199da8fc7 audit: enforce SSL/TLS MetaCPAN urls 
Closes Homebrew/homebrew#39513.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2015-05-08 00:44:01 -04:00
Jack Nagel
3895a0ae23 Rename method 2015-05-07 23:18:01 -04:00
Jack Nagel
41ecce7898 Push URL audits down to ResourceAuditor 2015-05-07 22:44:45 -04:00
Jack Nagel
5c8ceaa458 Warn about duplicated URLs 
Closes Homebrew/homebrew#39486.
 2015-05-07 22:15:57 -04:00
Xu Cheng
355e358ce0 audit: Don't complain about untapped conflicts 
Closes Homebrew/homebrew#39304.
 2015-05-05 23:26:11 +08:00
Dominyk Tiller
9dc8db12e4 audit: flag incorrect automake/autoconf/libtool dep handling 
Just makes the audit cough out this:
```
 * :libtool is deprecated. Usage should be "libtool"
 * :autoconf is deprecated. Usage should be "autoconf"
 * :automake is deprecated. Usage should be "automake"
```

Closes Homebrew/homebrew#39303.
Closes Homebrew/homebrew#39322.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2015-05-04 20:55:22 -04:00
Viktor Szakats
2e3a0263d4 audit: require https for all *.googlecode.com resources 
Closes Homebrew/homebrew#39206.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2015-05-04 20:51:45 -04:00
Jack Nagel
d6bca69347 Revert "audit: enforce new https url style for gnome downloads" 
I would like there to be more discussion before making this change.

This reverts commit f16ffd2a9ee5d29c7c0ae672c17bd129240adbb5.
 2015-04-19 12:48:09 -04:00
Viktor Szakats
86ee198af9 audit: enforce new https url style for gnome downloads 
also delete extra closing parenthesis in two problem messages

Closes Homebrew/homebrew#38824.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-04-19 15:32:04 +01:00
Xu Cheng
64e07fc990 audit: version string should not be ambiguous with revision part 
Closes Homebrew/homebrew#38810.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-04-19 20:29:52 +08:00
Baptiste Fontaine
8363b35216 audit: don't split shell commands when using a glob pattern 
Without this, `brew audit <some formula>` may ask people to change:

    system "./script.sh foo-*"

into:

    system "./script.sh", "foo-*"

These are not the same. In the first example the shell expansion occurs
while it doesn’t in the second one, breaking the build.

Closes Homebrew/homebrew#38540.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-04-12 21:34:53 -07:00
Viktor Szakáts
1b5fc1fb02 audit: enforce https for bare bintray.com domain 
Closes Homebrew/homebrew#38302.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-04-02 16:39:00 +01:00
Viktor Szakáts
f6946cd9f6 audit: enforce https on *.bintray.com urls 
Closes Homebrew/homebrew#38209.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-03-31 12:55:24 +01:00
Viktor Szakáts
3d23580ff2 audit: fix to enforce https for apache homepage 
It was failing to recognize the URL without an ending slash.

Closes Homebrew/homebrew#37808.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-03-18 12:29:00 +00:00
Viktor Szakáts
02cb05f22b audit: enforce https for apache.org 
- including all apache.org subdomains
- for `homepage` as well

Closes Homebrew/homebrew#37778.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-03-17 13:31:08 +00:00
Xu Cheng
e2994bb078 audit: suggest to not using git as dependency 
Closes Homebrew/homebrew#37696
Closes Homebrew/homebrew#37703

Closes Homebrew/homebrew#37735.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-03-15 20:55:55 +08:00
chdiza
21314474cd audit: Clarify GNU url warning message 
"ftpmirror.gnu.org" must have a protocol prefix of "http", not
"https".

Closes Homebrew/homebrew#37567.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-03-12 08:19:37 +00:00
Xu Cheng
7d7081a18b audit: whitelist pipe, redirect etc in the system check 
Closes Homebrew/homebrew#37523.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-03-10 00:57:21 +08:00
Mike McQuaid
3b15382029 audit: git tags should also specify revisions. 2015-03-08 10:48:58 +00:00
Dominyk Tiller
12861686b8 checksums: switch to sha256 for bottles and new formulae 
Closes Homebrew/homebrew#37164.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-03-05 14:45:39 +00:00
Xu Cheng
ce5d4a3b03 audit: deprecate ScriptFileFormula 
Closes Homebrew/homebrew#37356.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-03-04 00:34:21 +08:00
Xu Cheng
67554a7338 audit: deprecate AmazonWebServicesFormula 
Closes Homebrew/homebrew#37355.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-03-03 21:18:01 +08:00
Viktor Szakáts
10d5c4f97b brew audit: req https for archive.apache.org urls 
Closes Homebrew/homebrew#37313.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-03-02 11:53:53 +00:00
Mike McQuaid
0161d50d7a audit: handle head/devel-only correctly. 2015-02-27 16:13:04 +00:00
Xu Cheng
be15a514eb audit: suggest setting JAVA_HOME by depends_on :java 
Closes Homebrew/homebrew#37174.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-02-25 16:44:25 +08:00
Xu Cheng
589de2f26a fix audit 2015-02-24 17:20:55 +08:00
Xu Cheng
39473f7694 audit: fix FormulaText match 
It's used in `audit_text`

Closes Homebrew/homebrew#37139.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-02-24 17:04:29 +08:00
Xu Cheng
40e6426322 audit: give better suggestion on git/hg dependency 
Closes Homebrew/homebrew#36959.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-02-19 18:49:15 +08:00
Mike McQuaid
6dd51ff399 audit: check for setuid in caveats. 2015-02-19 09:29:17 +00:00
Dominyk Tiller
51956d343a audit: extend ssl checks 
Extends the audit checks to GnuPG, a significant chunk of Freedesktop
domains, and Github Pages. I’ve somewhat hardened my stance towards
Github Pages from the last time we extended this, hence the new
inclusion - I did a pretty thorough check through the Homebrew formulae
that use Github Pages for homepage links and found very few places
where enforcing SSL/TLS would cause issues - I think a wider
enforcement is worthwhile.

I’ve also fixed the capitalisation of the taps, if only because at the
moment it disagrees with what ` puts formula.tap ` outputs (We get
Homebrew/homebrew-head-only rather than homebrew/homebrew-head-only for
example).

Closes Homebrew/homebrew#36719.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-02-17 12:06:17 +00:00
Xu Cheng
f204e2e608 audit: more information on build deps audit 
Closes Homebrew/homebrew#36892.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-02-17 10:30:32 +00:00
Xu Cheng
d0e2d126a1 audit: catch empty installations 
Closes Homebrew/homebrew#36794.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-02-14 15:10:35 +00:00
Dominyk Tiller
2abd3298f9 audit: catch more examples from example_formula 
See
https://github.com/Homebrew/homebrew/pull/36629#discussion_r24293912
amongst other recent examples. The example formula isn’t as strongly
policed as the ` brew create ` default, this tries to do something
about that.

Closes Homebrew/homebrew#36639.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-02-08 12:24:17 +00:00
Dominyk Tiller
40ddea637a audit: stop red-flagging devel-only 
Currently the bot is failing certain devel-only formulae because it
thinks having ` devel ` defined with an added ` head ` defined
as well = a head-only formula.

```
==> audit problems
docker-machine:
 * Head-only (no stable download)
```

This is a pretty simple fix for that problem:

```
==> brew style docker-machine
1 file inspected, no offenses detected
```

Closes Homebrew/homebrew#36197.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-01-26 14:39:12 +00:00