admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: enforce https for apache.org

Browse Source 
- including all apache.org subdomains
- for `homepage` as well

Closes Homebrew/homebrew#37778.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
This commit is contained in:
Viktor Szakáts 2015-03-16 23:55:11 +01:00 committed by Mike McQuaid
parent 3933b84dea
commit 02cb05f22b
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Library/Homebrew/cmd/audit.rb
View File

@ -301,6 +301,10 @@ class FormulaAuditor
problem "Github Pages links should be https:// (URL is #{homepage})."
end
if homepage =~ %r[^http://[^/]*\.apache\.org/]
problem "Apache homepages should be https:// links (URL is #{homepage})."
end
# There's an auto-redirect here, but this mistake is incredibly common too.
# Only applies to the homepage and subdomains for now, not the FTP links.
if homepage =~ %r[^http://((?:build|cloud|developer|download|extensions|git|glade|help|library|live|nagios|news|people|projects|rt|static|wiki|www)\.)?gnome\.org]
@ -326,8 +330,8 @@ class FormulaAuditor
case p
when %r[^http://ftp\.gnu\.org/]
problem "ftp.gnu.org urls should be https://, not http:// (url is #{p})."
when %r[^http://archive\.apache\.org/]
problem "archive.apache.org urls should be https://, not http (url is #{p})."
when %r[^http://[^/]*\.apache\.org/]
problem "Apache urls should be https://, not http (url is #{p})."
when %r[^http://code\.google\.com/]
problem "code.google.com urls should be https://, not http (url is #{p})."
when %r[^http://fossies\.org/]