Mike McQuaid
c5dbd3ca24
Rearrange requires
...
This improves the load time of most brew commands. For an example of
one of the simplest commands this speeds up:
Without Bootsnap:
```
$ hyperfine 'git checkout master; brew help' 'git checkout optimise_requires; brew help'
Benchmark 1: git checkout master; brew help
Time (mean ± σ): 525.0 ms ± 35.8 ms [User: 229.9 ms, System: 113.1 ms]
Range (min … max): 465.3 ms … 576.6 ms 10 runs
Benchmark 2: git checkout optimise_requires; brew help
Time (mean ± σ): 383.3 ms ± 25.1 ms [User: 133.0 ms, System: 72.1 ms]
Range (min … max): 353.0 ms … 443.6 ms 10 runs
Summary
git checkout optimise_requires; brew help ran
1.37 ± 0.13 times faster than git checkout master; brew help
```
With Bootsnap:
```
$ hyperfine 'git checkout master; brew help' 'git checkout optimise_requires; brew help'
Benchmark 1: git checkout master; brew help
Time (mean ± σ): 386.0 ms ± 30.9 ms [User: 130.2 ms, System: 93.8 ms]
Range (min … max): 359.5 ms … 469.3 ms 10 runs
Benchmark 2: git checkout optimise_requires; brew help
Time (mean ± σ): 330.2 ms ± 32.4 ms [User: 93.4 ms, System: 73.0 ms]
Range (min … max): 302.9 ms … 413.9 ms 10 runs
Summary
git checkout optimise_requires; brew help ran
1.17 ± 0.15 times faster than git checkout master; brew help
```
2024-07-14 08:49:39 -04:00
Mike McQuaid
0f9ca1d627
Merge pull request #17699 from Homebrew/ww/rm-marshal-from-spec
2024-07-13 15:53:00 -04:00
Mike McQuaid
2ee6f29934
Merge pull request #17700 from Homebrew/filter-special-chars-from-sandbox
2024-07-13 15:52:33 -04:00
Bo Anderson
37883714f5
Merge pull request #17704 from Homebrew/ww/silence-stderr
...
attestation: don't dupe stderr
2024-07-13 20:40:57 +01:00
William Woodruff
2d216174fb
Merge branch 'master' into ww/rm-marshal-from-spec
2024-07-13 15:36:51 -04:00
William Woodruff
419d4f7ab6
curl_spec: use deep_dup
...
Signed-off-by: William Woodruff <william@yossarian.net>
2024-07-13 15:36:34 -04:00
William Woodruff
695f080ba8
Revert "curl_spec: remove no-op Marshal use"
...
This reverts commit f3847d263f69a9a36e004c75c4969f939a66de3b.
2024-07-13 15:33:16 -04:00
William Woodruff
6cfe118ae3
attestation: don't dupe stderr
...
Silences `system_command!`'s own stderr handling,
since we do it independently.
Signed-off-by: William Woodruff <william@yossarian.net>
2024-07-13 15:30:21 -04:00
William Woodruff
6a5bcb339d
Merge pull request #17692 from Homebrew/ww/attestations-for-dev
2024-07-13 15:09:30 -04:00
Rylan Polster
f4e5e0c716
Don't allow special characters in sandbox rule paths
...
Co-authored-by: Thierry Moisan <thierry.moisan@gmail.com>
2024-07-13 14:41:05 -04:00
William Woodruff
f3847d263f
curl_spec: remove no-op Marshal use
...
Signed-off-by: William Woodruff <william@yossarian.net>
2024-07-13 14:38:57 -04:00
Ruoyu Zhong
7c90c2df92
Merge pull request #17698 from Homebrew/better-input-handling
...
workflows/vendor-gems: handle input string more robustly
2024-07-13 14:24:23 -04:00
Ruoyu Zhong
5d6be12732
workflows/vendor-gems: handle input string more robustly
...
See also: Homebrew/actions#562 .
2024-07-13 14:10:18 -04:00
Mike McQuaid
d4b7ed66e8
Merge pull request #17696 from Homebrew/portable_ruby_3.3.4
2024-07-13 14:06:35 -04:00
William Woodruff
255e75068e
Merge branch 'master' into ww/attestations-for-dev
2024-07-13 14:05:15 -04:00
William Woodruff
c7d5e02334
workflows/tests: drop my changes
...
Signed-off-by: William Woodruff <william@yossarian.net>
2024-07-13 13:59:16 -04:00
Mike McQuaid
f45eefdb38
Merge pull request #17697 from Homebrew/restrict-install-from-url
2024-07-13 13:42:30 -04:00
Rylan Polster
8b0a4a98bf
Restrict direct url installs to the file:// scheme
2024-07-13 13:30:36 -04:00
Mike McQuaid
ab7e49c462
Merge pull request #17695 from reitermarkus/from-bottle-loader-downloadable
2024-07-13 13:13:36 -04:00
Markus Reiter
2601551f3a
Only allow loading local bottles.
2024-07-13 11:57:44 -04:00
Mike McQuaid
6abdbd1fe0
vendor-install: cleanup bootsnap.
2024-07-13 11:57:37 -04:00
Mike McQuaid
b25cdbabba
Portable Ruby 3.3.4
...
Update to the latest and greatest Ruby version.
2024-07-13 11:43:17 -04:00
Markus Reiter
643fa83a28
Use Downloadable API in FromBottleLoader.
2024-07-13 11:36:13 -04:00
Issy Long
0a7b61a0a9
Merge pull request #17691 from Moisan/pin_workflows
...
workflows: pin actions
2024-07-13 11:24:41 -04:00
Ruoyu Zhong
57588408ec
Merge pull request #17693 from Homebrew/sponsors-maintainers-man-completions
...
Update manpage and completions.
2024-07-13 11:09:07 -04:00
William Woodruff
6d8067dc2f
workflows/tests: add some tokens
...
Signed-off-by: William Woodruff <william@yossarian.net>
2024-07-13 10:58:00 -04:00
BrewTestBot
ff02bc46f8
Update manpage and completions.
...
Autogenerated by the [sponsors-maintainers-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sponsors-maintainers-man-completions.yml ) workflow.
2024-07-13 14:55:53 +00:00
Mike McQuaid
f39b5c1426
Merge pull request #17554 from Homebrew/cask-install-receipt
2024-07-13 10:55:06 -04:00
William Woodruff
570cf65523
attestations: widen the beta
...
This widens the beta to include people with developer mode enabled,
as well as those with HOMEBREW_DEVELOPER set in their environment.
Signed-off-by: William Woodruff <william@yossarian.net>
2024-07-13 10:51:49 -04:00
Thierry Moisan
e2e9565984
workflows: pin actions
2024-07-13 10:50:43 -04:00
Sam Ford
f5adff9d90
Merge pull request #17690 from Homebrew/sponsors-maintainers-man-completions
...
Update maintainers.
2024-07-12 21:08:55 -04:00
BrewTestBot
d42fc2e04e
Update maintainers.
...
Autogenerated by the [sponsors-maintainers-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sponsors-maintainers-man-completions.yml ) workflow.
2024-07-13 00:57:09 +00:00
Ruoyu Zhong
a9d4b7284e
Merge pull request #17689 from Homebrew/sponsors-maintainers-man-completions
2024-07-13 08:56:33 +08:00
BrewTestBot
072047779a
Update manpage and completions.
...
Autogenerated by the [sponsors-maintainers-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sponsors-maintainers-man-completions.yml ) workflow.
2024-07-13 00:07:00 +00:00
Issy Long
9383cfa67b
Merge pull request #17688 from Homebrew/boo-more-type-errors
...
formula_assertions: Fix type of `cmd` param in `shell_output`
2024-07-12 16:43:15 -04:00
Carlo Cabrera
85625f5516
Merge pull request #17683 from Homebrew/one-more-sorbet-strict-unpack-strategy
2024-07-12 22:35:21 +02:00
Issy Long
ecdd45e73e
formula_assertions: Fix type of cmd param in shell_output
...
- This can be either a String or a Pathname, per
the part of the `noseyparker` test that failed
(in a different part of the test, the command is
passed as a string).
```
==> Testing noseyparker
==> /opt/homebrew/Cellar/noseyparker/0.18.1/bin/noseyparker -V
Error: noseyparker: failed
An exception occurred within a child process:
TypeError: Parameter 'cmd': Expected type String, got type Pathname with value #<Pathname:/opt/homebrew/Ce...ps://github.com/Homebrew/brew>
Caller: /opt/homebrew/Library/Taps/homebrew/homebrew-core/Formula/n/noseyparker.rb:35
```
2024-07-12 16:28:35 -04:00
Patrick Linnane
0bd23979cb
Merge pull request #17684 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-0.5.11481
2024-07-12 12:58:23 -07:00
Issy Long
fb2fcc47c2
Merge pull request #17686 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-rspec-3.0.3
...
build(deps-dev): bump rubocop-rspec from 3.0.2 to 3.0.3 in /Library/Homebrew
2024-07-12 15:18:31 -04:00
BrewTestBot
d8fb35e075
brew vendor-gems: commit updates.
2024-07-12 18:56:54 +00:00
BrewTestBot
18d614ecc7
brew vendor-gems: commit updates.
2024-07-12 18:56:12 +00:00
dependabot[bot]
f22dc0c47d
build(deps-dev): bump rubocop-rspec in /Library/Homebrew
...
Bumps [rubocop-rspec](https://github.com/rubocop/rubocop-rspec ) from 3.0.2 to 3.0.3.
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases )
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rspec/compare/v3.0.2...v3.0.3 )
---
updated-dependencies:
- dependency-name: rubocop-rspec
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-07-12 18:55:56 +00:00
dependabot[bot]
1b40b3791a
build(deps-dev): bump sorbet in /Library/Homebrew
...
Bumps [sorbet](https://github.com/sorbet/sorbet ) from 0.5.11480 to 0.5.11481.
- [Release notes](https://github.com/sorbet/sorbet/releases )
- [Commits](https://github.com/sorbet/sorbet/commits )
---
updated-dependencies:
- dependency-name: sorbet
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-07-12 18:55:22 +00:00
Issy Long
868c3dc9cd
Merge pull request #17680 from Homebrew/building-bottles-needs-network-for-sboms
2024-07-12 17:28:37 +01:00
Issy Long
1479013710
Merge pull request #17636 from Homebrew/sorbet-strict-public-apis
2024-07-12 17:25:41 +01:00
Mike McQuaid
d9da0ca6ba
Merge pull request #17681 from Homebrew/core-cask-priority
2024-07-12 08:17:28 +01:00
Bo Anderson
ae9d5f9f14
cli/named_args: raise priority of core casks
2024-07-12 05:27:57 +01:00
Issy Long
af6e1194d2
unpack_strategy/dmg: Convert to Sorbet typed: strict
...
- I missed this, whoops.
2024-07-11 21:34:26 -04:00
Issy Long
edb8055c76
unpack_strategy/*: Convert to Sorbet typed: strict
2024-07-11 21:18:27 -04:00
Issy Long
d7123d43c7
test/dev-cmd/bottle: Mark the bottling test as needs_network
...
- I was on a plane and this failed with:
```
expected block to not output to stderr, but output
"curl: (6) Could not resolve host: spdx.github.io\nWarning: Failed to fetch SBOM schema, cannot perform SBOM validation!
Warning: Could not fetch JSON schema to validate SBOM!\nWarning: SBOM is not valid, not writing to disk!"
```
2024-07-11 21:16:14 -04:00
