16616 Commits

Author SHA1 Message Date
Mike McQuaid
c46cecf277
tests: set HOME.
This is the only way to override the user's Git configuration which can
break tests when e.g. `gpg` cannot be found but signing is requested.
2018-09-02 12:56:31 +01:00
Mike McQuaid
794fe5d21d
Merge pull request #4778 from DomT4/gocache_follow_up
cleanup: fix go_cache cleanup
2018-09-02 10:16:37 +01:00
Dominyk Tiller
9102c120bb
cleanup: fix go_cache cleanup 2018-09-02 04:27:22 +01:00
Markus Reiter
449c3ffac3
Merge pull request #4791 from reitermarkus/fix-apache-mirror-download-strategy
Fix `CurlApacheMirrorDownloadStrategy` URL resolution.
2018-09-02 03:57:01 +02:00
Markus Reiter
e377bdb6fe Fix CurlApacheMirrorDownloadStrategy URL resolution. 2018-09-02 03:30:37 +02:00
Markus Reiter
93430e6ae2
Merge pull request #4789 from reitermarkus/avoid-network-call
Avoid network call in `#initialize`.
2018-09-01 16:47:20 +02:00
Markus Reiter
b54682f709 Avoid network call in #initialize. 2018-09-01 16:20:10 +02:00
Markus Reiter
f66ce9ce5d
Merge pull request #4788 from reitermarkus/no-cache-no-migration
Skip migration if cache is empty or doesn’t exist.
2018-09-01 16:17:54 +02:00
Markus Reiter
b954391214 Skip migration if cache is empty or doesn’t exist. 2018-09-01 15:29:17 +02:00
Vítor Galvão
ad66d54143
Merge pull request #4782 from amyspark/fix-quarantine-broken-symlinks
quarantine: do not automatically follow symlinks
2018-09-01 10:41:47 +01:00
Markus Reiter
0853fe14b2
Merge pull request #4787 from reitermarkus/fix-update
Only migrate cache files containing `--`.
2018-09-01 11:19:15 +02:00
Markus Reiter
3d15c7cb75 Only migrate cache files containing --. 2018-09-01 11:04:51 +02:00
Markus Reiter
d8dc1f7fe0
Merge pull request #4785 from reitermarkus/fix-cleanup-non-existent-sysmlink
Skip `mtime` for non-existent symlink.
2018-09-01 07:09:15 +02:00
Markus Reiter
ae18bdf161 Skip mtime for non-existent symlink. 2018-09-01 06:42:54 +02:00
Markus Reiter
9a699ccf54
Merge pull request #4662 from reitermarkus/resolve-url
Resolve URL to get real file extension.
2018-09-01 04:58:44 +02:00
Mike McQuaid
c83c2bc867
Merge pull request #4783 from Homebrew/dependabot/bundler/docs/rubyzip-1.2.2
[Security] Bump rubyzip from 1.2.1 to 1.2.2 in /docs
2018-08-31 19:11:39 +01:00
dependabot[bot]
6575240169
[Security] Bump rubyzip from 1.2.1 to 1.2.2 in /docs
Bumps [rubyzip](https://github.com/rubyzip/rubyzip) from 1.2.1 to 1.2.2. **This update includes security fixes.**
- [Release notes](https://github.com/rubyzip/rubyzip/releases)
- [Changelog](https://github.com/rubyzip/rubyzip/blob/master/Changelog.md)
- [Commits](https://github.com/rubyzip/rubyzip/compare/v1.2.1...v1.2.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-08-31 17:43:27 +00:00
L. E. Segovia
4c47a4b76d
quarantine: do not automatically follow symlinks
This prevents failure when Casks have broken framework symlinks.
2018-08-31 15:31:00 +00:00
Markus Reiter
f287214699 Just use resolved_path.file?. 2018-08-31 16:51:23 +02:00
Markus Reiter
9b50fd81d7 Move everything into one file. 2018-08-31 16:51:23 +02:00
Markus Reiter
443111896e Share common logic. 2018-08-31 16:51:23 +02:00
Markus Reiter
ccf396887a Add comment about refinement scope. 2018-08-31 16:51:23 +02:00
Markus Reiter
2773ce6156 Don’t clean up symlink target. 2018-08-31 16:51:23 +02:00
Markus Reiter
b63ac557bc Update symlink even if cached_location already exists. 2018-08-31 16:51:23 +02:00
Markus Reiter
9edc355052 Don’t glob for .incomplete downloads. 2018-08-31 16:51:23 +02:00
Markus Reiter
b7847e4657 Don’t migrate symlinks. 2018-08-31 16:51:23 +02:00
Markus Reiter
3988458919 Use real basename for output. 2018-08-31 16:51:23 +02:00
Markus Reiter
516a39f5a4 Move migrations into UpdateMigrator module. 2018-08-31 16:51:23 +02:00
Markus Reiter
fbcaa8c85a Resolve URL to get real file extension. 2018-08-31 16:51:23 +02:00
Claudia
47d3bbee1c
Merge pull request #4656 from amyspark/com-apple-quarantine
Enable quarantining of Homebrew-Cask's downloads
2018-08-31 15:50:29 +02:00
L. E. Segovia
f7cafb50ad
Enable quarantining of Homebrew-Cask's downloads 2018-08-31 13:16:11 +00:00
Michka Popoff
6e31c662f5
Merge pull request #4773 from iMichka/o2flag
superenv: Use 02 optimization flag for Linux builds
2018-08-30 11:09:50 +02:00
Mike McQuaid
2b9fead932
Merge pull request #4759 from MikeMcQuaid/lead-maintainer-guidelines
docs/Maintainer-Guidelines: add lead maintainer guidelines.
2018-08-30 09:00:55 +01:00
Dominyk Tiller
baab9d841f
Merge pull request #4774 from DomT4/GOCACHE
go: support & use aggressive caching
2018-08-30 04:44:37 +01:00
commitay
e4049b3005
Merge pull request #4775 from commitay/cargo-install
text_cop: update `cargo build` cop
2018-08-30 08:03:42 +10:00
Markus Reiter
801ec6e0a5
Merge pull request #4771 from reitermarkus/rubocop-path
Add `$LOAD_PATH` for RuboCop cops.
2018-08-29 23:51:11 +02:00
Mike McQuaid
8d13ef33e1
Maintainer-Guidelines: mention code of conduct. 2018-08-29 19:52:08 +01:00
Markus Reiter
eddd864a7d
Merge pull request #4776 from reitermarkus/system-command-with-spaces
Fix executable with spaces.
2018-08-29 19:58:01 +02:00
Markus Reiter
ad7054cc88 Fix executable with spaces. 2018-08-29 19:30:08 +02:00
commitay
0ce583964e text_cop: update cargo build cop 2018-08-29 23:06:53 +10:00
Dominyk Tiller
b333f7abe6
cleanup_spec: test go_cache cleanup 2018-08-29 13:16:56 +01:00
Dominyk Tiller
318eb5054f
cleanup: cleanup go_cache 2018-08-29 13:16:55 +01:00
Dominyk Tiller
4598995a41
formula: always set GOCACHE
I hadn't planned to move on this so quickly but impressively core
today had its first Go Module using PR, so this has become more useful
than it would've been. Useful reading on the Modules system can be found
via https://golang.org/doc/go1.11#modules.

`GOCACHE` has been a thing for a while but it hasn't really been
especially beneficial to us, so I've ignored it, but with the Go Modules
system it can be incredibly useful in reducing build times & thus CI
burden. A lot of this is explained rather nicely here:
  https://groups.google.com/forum/#!msg/golang-dev/RjSj4bGSmsw/KMHhU8fmAwAJ

The upsides here for us are obvious:
1) We do a *lot* of go-based builds, and the more things move over to the
module system the more comprehensive that cache will become and we'll
need to remotely fetch less dependencies, which massively speeds up
build times even on high-speed connections.
2) Module dependencies aren't limited per formula. If `hugo` fetches a
dependency that is the same version as, for example, `wiki` also needs
`wiki` won't bother to fetch that version remotely but instead will
simply pluck it out of the cache.

If we look at `hugo`, because it's the only formula so far with Module
support:

First build: `built in 1 minute 41 seconds`
Second build: `built in 14 seconds`.

It's worth noting perhaps that we can use just the module cache rather
than the build cache + module cache combination, but doing so leads to
a significant reduction in regained build time. A build under that
system pops an average build time with `hugo` (after the first build)
of ~70 seconds, which is only a 30 second saving on the first build.
However, if we wanted to speed up builds whilst also not eating big chunks
of disk space that is an option.

The downside of a build cache + module cache system is disk usage.
`go` does not exactly eat up disk space sparingly, and the cache size
from `hugo` alone is 258.8MB. That could be an issue on CIs where disk
space is already a squeeze at times, but it's not much different to how
we let the `java_cache` behave now.

All Module-supporting formulae need to do to use the shared cache is
instead of deleting the `GOPATH` env we set everywhere replace it with
this:
```
ENV["GOPATH"] = "#{HOMEBREW_CACHE}/go_cache"
```
2018-08-29 13:16:36 +01:00
Michka Popoff
b7b5fb930d superenv: Use 02 optimization flag for Linux builds
`-Os` produces sometimes bigger binaries on Linux.
Also, llvm built with `-Os` is really slow at runtime for Linux.

Using `-02` aligns us with what Debian does, and as we are compiling most of our stuff with gcc (and not clang), it makes sense to use `-02` on Linux.
`-Os` does probably slightly different things when used on mac with llvm, compared to when it is used with gcc on Linux.
2018-08-29 13:40:39 +02:00
Markus Reiter
f6e7a3ed9d Fix style. 2018-08-29 01:44:47 +02:00
Markus Reiter
444e3d2a78 Add $LOAD_PATH for RuboCop cops. 2018-08-29 01:44:47 +02:00
Gautham Goli
0af24cf8bc
Merge pull request #4770 from GauthamGoli/style-results-npe-fix-3
style: Fix npe and add test for corrected offense results
2018-08-29 00:03:46 +05:30
Gautham Goli
32bc5535b6
style: Fix npe and add test for corrected offense results 2018-08-28 23:31:35 +05:30
Mike McQuaid
ff711fcfad
Maintainer-Guidelines: note consensus and final say. 2018-08-28 09:13:41 +01:00
Gautham Goli
b707d2a232
Merge pull request #4765 from GauthamGoli/style-results-npe-fix-2
audit: Use `fetch` with default value prevent NPE
2018-08-28 13:42:13 +05:30