Bo Anderson
c32a1b8104
dev-cmd/tests: ignore BuildPulse failures for now
2023-03-01 22:21:45 +00:00
Bo Anderson
f4067ac5fe
dev-cmd/tests: better output for BuildPulse failures
2023-03-01 20:42:50 +00:00
Mike McQuaid
d43824d49f
Merge pull request #14849 from bayandin/fix-alias-loading
...
formula: fix alias loading
2023-03-01 12:36:17 +00:00
Mike McQuaid
c0bae192e5
Merge pull request #14624 from DenizUgur/service_run_at_load
...
dedicated `run_at_load` property
2023-03-01 12:35:15 +00:00
Mike McQuaid
cae7aad141
Merge pull request #14713 from apainintheneck/cask-to-h-without-api
...
cask: `to_h` without api
2023-03-01 12:34:41 +00:00
Mike McQuaid
a3cc4bcc59
Merge pull request #14850 from issyl0/rubocop-consolidation
...
rubocop: Consolidate more rules into the right files
2023-03-01 12:25:40 +00:00
Mike McQuaid
9296db0c41
Merge pull request #14839 from hyuraku/move-cask/cmd/info-to-cask/info
...
Move `cask/cmd/info` to `cask/info`
2023-03-01 12:25:26 +00:00
Issy Long
d16b241f4c
rubocop: Consolidate Style/BlockDelimiters config into one file
2023-03-01 11:46:54 +00:00
hyuraku
3e3ba7642c
remove useless method
2023-03-01 20:37:04 +09:00
Alexander Bayandin
9b4f29e47c
formula: fix alias loading
2023-03-01 09:44:57 +00:00
apainintheneck
64ef2f1899
cask/cmd/upgrade: fix missing versions variable
...
This reference to the versions variable is unnecessary.
2023-02-28 22:58:00 -08:00
apainintheneck
9087afba74
Add baseline test for Cask#to_h
...
Also, added a test for loading JSON files in the cask loader.
2023-02-28 21:43:02 -08:00
apainintheneck
c19017c6bd
Make Cask#to_h work without the API
...
Set metadata when we load casks from the source API.
Set `@tap_git_head` manually.
Also, allow `auto_update` to receive false.
This is only done for consistency.
Stop double printing the `kext` caveat.
Handle Array elements correctly when substituting
path elements in artifacts. This affected how the
Uninstall Signal keys were evaluated (they are
represented as arrays of arrays).
2023-02-28 19:36:20 -08:00
apainintheneck
39dd7e987d
stop loading Cask#to_h from api
2023-02-28 18:00:38 -08:00
Issy Long
b1eaf8bbd2
rubocop: Move Style/DocumentationMethod into the other file
2023-03-01 00:02:22 +00:00
Mike McQuaid
7c15dce285
Merge pull request #14798 from MikeMcQuaid/deprecate_shell
...
Deprecate `preferred_shell` and `shell_profile`.
2023-02-28 15:18:00 +00:00
Mike McQuaid
32463227ac
Deprecate preferred_shell and shell_profile.
...
I know that we're outside our normal deprecation cycle but: these are
totally broken with the API and it doesn't make sense to support them
only for non-core formulae.
2023-02-28 15:02:06 +00:00
hyuraku
198c6f6b8c
move cask/cmd/info_spec to cask/info_spec
2023-03-01 00:01:28 +09:00
hyuraku
efdef5f26c
move cask/cmd/info to cask/info
2023-03-01 00:00:54 +09:00
Carlo Cabrera
1201f18db0
Merge pull request #14667 from carlocab/update-reset-tap-names
...
cmd/update-reset: improve arg parsing
2023-02-28 22:05:10 +08:00
Issy Long
a2b488cd10
Merge pull request #14818 from issyl0/rubocop-documentation
...
rubocop: Only enable `Style/Documentation` for `@api public` code
2023-02-28 13:47:13 +00:00
Issy Long
b8b7e6350d
dev-cmd/contributions: Only count approving reviews
...
- The `reviewed-by` filter retrieved all reviews for a user, including
those they'd added to their own PRs. Since it's impossible to click
the "approve" button on one's own PR, filter this to `review:approved`
to get "further project goals" kinds of reviews.
- Suggested in https://github.com/Homebrew/brew/pull/14813#discussion_r1118696385 .
2023-02-28 12:58:21 +00:00
Issy Long
267d72a9d0
More comments and TODOs
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2023-02-28 12:50:05 +00:00
Carlo Cabrera
53053e0625
cmd/update-reset: improve arg validation
...
This is based on feedback from #14667 .
2023-02-28 20:38:00 +08:00
Carlo Cabrera
12364d70d2
Revert "cmd/update-reset: accept tap names as arguments"
...
This reverts commit ac7dbc008284e1a85353548eb8e15c008be902ec.
2023-02-28 20:30:40 +08:00
Mike McQuaid
eeadcc8ded
Merge pull request #14632 from bevanjkay/cask-sample-languages-audit
...
cask/auditor: only audit 10 languages by default on casks with many languages
2023-02-28 12:16:51 +00:00
Rylan Polster
f6af334397
Merge pull request #14825 from MikeMcQuaid/more_sharding_fixes
...
More Formula/Casks sharding fixes
2023-02-28 07:08:29 -05:00
Bevan Kay
0589ac427d
Update Library/Homebrew/cask/auditor.rb
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2023-02-28 23:00:43 +11:00
Mike McQuaid
4cbc4f64d1
Merge pull request #14834 from reitermarkus/livecheck-skip-latest
...
Allow `version :latest` if `livecheck` is `skip`.
2023-02-28 11:59:29 +00:00
Mike McQuaid
0406279ad3
More Formula/Casks sharding fixes
...
- Stop `brew style` from complaining
- Fix message reference in `brew edit`
2023-02-28 11:52:38 +00:00
Mike McQuaid
d0e03fc425
Merge pull request #14820 from apainintheneck/delay-loading-from-cask-source-api
...
Delay loading from cask source api
2023-02-28 11:50:10 +00:00
Mike McQuaid
b339caf744
Merge pull request #14831 from Homebrew/sorbet-files-update
...
sorbet: Update RBI files.
2023-02-28 11:41:53 +00:00
Mike McQuaid
4986a1aa26
Merge pull request #14830 from samford/livecheck/rework-json-match
...
Strategy#from_url: Amend conditions for Json
2023-02-28 11:41:41 +00:00
Issy Long
0f2270e9ef
Merge pull request #14819 from issyl0/signoffs-were-just-a-stepping-stone-to-reviews
...
dev-cmd/contributions: Stop counting signoffs now we have "real" reviews
2023-02-28 11:37:14 +00:00
Issy Long
6b76e5e66f
dev-cmd/contributions: Stop counting signoffs now we have "real" reviews
...
- Signoffs were just a stopgap until we implemented getting "real"
reviews for a user via the GitHub API. They were a suboptimal way of getting
reviews because they only really exist in Homebrew/homebrew-core where
BrewTestBot adds signoffs for each maintainer who reviewed the PR.
2023-02-28 11:12:51 +00:00
Markus Reiter
a2a68292ae
Allow version :latest if livecheck is skip.
2023-02-28 10:35:07 +01:00
Bevan Kay
48a7282458
fix style
2023-02-28 19:02:08 +11:00
Bevan Kay
295a3539a5
Update with-many-languages.rb
2023-02-28 18:55:12 +11:00
Bevan Kay
d1b09a90da
cask/auditor: only audit 10 languages by default on casks with many languages
2023-02-28 18:54:27 +11:00
apainintheneck
b91e93cda0
Load cask source with tap info
...
This info is used in the installer to
decide whether to report analytics.
2023-02-27 23:51:43 -08:00
Douglas Eichelberger
2073e70696
brew style --fix
2023-02-27 21:43:10 -08:00
Douglas Eichelberger
f9f73f3ef6
Tidy up
2023-02-27 21:42:47 -08:00
Douglas Eichelberger
1ab278f74c
Fix style/type violations
2023-02-27 20:34:07 -08:00
Douglas Eichelberger
82dad857a8
Restore global
2023-02-27 20:31:01 -08:00
Douglas Eichelberger
6ea501b59f
Add tests
2023-02-27 20:30:55 -08:00
Douglas Eichelberger
325994a60c
Move inflection utils to Utils module
2023-02-27 20:20:56 -08:00
Douglas Eichelberger
0eccc0e987
git grep -l Utils::Inflection | xargs gsed -i 's|Utils::Inflection|Utils|g'
2023-02-27 20:18:27 -08:00
Douglas Eichelberger
86c500fdcc
Try removing inflections require
2023-02-27 20:18:10 -08:00
Douglas Eichelberger
8d788ec98c
Try removing String monkey-patched types
2023-02-27 20:18:10 -08:00
Douglas Eichelberger
cfdb0c2e4b
Fix type error
2023-02-27 20:18:10 -08:00