3270 Commits

Author SHA1 Message Date
Jack Nagel
ba202df70b onoe and opoo print to stderr
This may result in some undesired output for things that suppress
stdout, but we'll fix those as we go.

Fixes Homebrew/homebrew#18650.
2013-03-31 15:20:12 -05:00
Jack Nagel
7af5a74c4e DRY ohai truncation 2013-03-31 15:18:38 -05:00
Simon Sigurdhsson
4cd95652ea brew-pin: Fix bug in FormulaPin#pinned?
Since `pinned?` was using `File#exists?`, broken symlinks left by force-upgraded
formulae made `pinned?` return false while `pin` returned with an error because
it could not overwrite the broken link. This is fixed by using `File#symlink?`
instead, which returns true for broken symlinks and false only when they do not
exist.

Closes Homebrew/homebrew#18858.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2013-03-31 19:27:17 +01:00
Simon Sigurdhsson
040138164b brew-info: Add pinned status to info.
Closes Homebrew/homebrew#18851.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2013-03-31 19:27:17 +01:00
Jaime Marquínez Ferrándiz
249b777684 Fix typo for pin command in bash_completion
Closes Homebrew/homebrew#18849.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2013-03-30 16:22:55 -07:00
Jack Nagel
ec7dc78ba4 Simplify destructuring this array 2013-03-30 15:16:44 -05:00
Simon Sigurdhsson
f8a88b5f28 brew-pin: prevent selected formulae from upgrade.
* Added `pin` et. al. to manpage.
* Added `brew pin` to `brew.1` * Added `brew unpin` to `brew.1`
* Added `brew list --pinned` to `brew.1`
* Added information about frozen formulae to `brew upgrade` in `brew.1`
* Added `pin` et.al. to completion scripts.
* Unpin formulae when uninstalling them
* Unpin and re-pin formulae when upgrading (avoids stale symlink)

References Homebrew/homebrew#18386.
Closes Homebrew/homebrew#18515.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2013-03-30 19:50:47 +00:00
Jack Nagel
4a52bf1c31 Use each_key instead of keys.each 2013-03-29 21:59:02 -05:00
Adam Vandenberg
3320b15609 doctor: restore newlines between checks
Closes Homebrew/homebrew#18060.
2013-03-29 11:14:46 -07:00
Samuel John
261ca7aa6a superenv: Filter out -isysroot
Closes Homebrew/homebrew#16576.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2013-03-29 11:10:18 -07:00
Jack Nagel
da5a4223e8 brew.rb: drop constant reassignment
Closes Homebrew/homebrew#18807.
2013-03-28 18:26:47 -05:00
Jack Nagel
c3c4a8b913 brew-readall: remove unused variable 2013-03-28 17:51:55 -05:00
Jack Nagel
891cfe454b Remove circular require
Will this break anything? It shouldn't; Formula will always be loaded
before Tab anyway. But really there is a design problem here, Tab
shouldn't have any hardcoded references to Formula. I think this is
fixable, but callers of for_formula will need to be checked first.
2013-03-28 17:37:29 -05:00
Jack Nagel
0d45c3c0f2 Suppress uninitialized instance variable warnings 2013-03-28 17:37:29 -05:00
Jack Nagel
f0db242591 extend/fileutils: suppress discarded method definition warnings 2013-03-28 17:37:29 -05:00
Jack Nagel
d994c6cdda Suppress ambiguous argument and grouped expression warnings 2013-03-28 17:37:29 -05:00
Jack Nagel
593289a018 Make clear that this method discards arguments 2013-03-28 17:37:28 -05:00
Adam Vandenberg
dd112ef579 audit: don't complain about postgis using postgresql 2013-03-28 13:10:41 -07:00
Jack Nagel
ad58cd88ab info: make use of Tab#to_s
Closes Homebrew/homebrew#18788.
2013-03-28 14:21:52 -05:00
Jack Nagel
5e5e82f9ef Tab#to_s returns a one-line summary of the receipt 2013-03-28 14:16:15 -05:00
Adam Vandenberg
d9f64a1574 doctor: check for all DYLD env vars 2013-03-26 16:19:55 -07:00
Max Howell
3d0318c913 New Homepage: brew.sh 2013-03-25 23:55:04 -03:00
Sebastian Staudt
5c17405982 LinuxCPUs: Fix method alias
Closes Homebrew/homebrew#18683.

Signed-off-by: Misty De Meo <mistydemeo@gmail.com>
2013-03-23 14:23:03 -05:00
Misty De Meo
2476801613 Hardware: separate out CPU values into CPU module
* CPU functions now exist in Hardware::CPU
* Added compatibility functions in compat/hardware_compat.rb
* Names are less specific to Mac hardware, e.g. CPU.family instead of
  Hardware.intel_family
* Hardware::CPU.family works for both Intel and PowerPC
* New helper methods on CPU, like .sse4? and .altivec?

Signed-off-by: Misty De Meo <mistydemeo@gmail.com>
2013-03-23 13:40:18 -05:00
Jack Nagel
21f566b662 Turn double modifier into a single conditional 2013-03-21 17:20:57 -05:00
Jack Nagel
688ae72919 utils: remove obsolete comment 2013-03-21 17:12:56 -05:00
Jack Nagel
47a8a312e3 versions: add debug output 2013-03-21 17:05:02 -05:00
Jack Nagel
d274f7a8a0 versions: remove unnecessary variable 2013-03-21 17:04:54 -05:00
Russell Teabeault
ad622a9e87 versions: unload constant before calling Formula.factory
Closes Homebrew/homebrew#18634.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2013-03-21 13:26:56 -05:00
Samuel John
c6b0b563e8 Better superenv support for Xcode elsewhere
- The Library/ENV/4.3/xcrun shim now respects
  ENV['DEVELOPER_DIR'] instead assuming the location
  of /Applications/Xcode.app/Contents/Developer.
- The env var DEVELOPER_DIR is set if it is not
  already. So, during superenv this var is always set
  and we no longer have to care about people with unset
  or wrongly set xcode-select stuff. This has been
  a major PITA in the past.
- determine_developer_dir (which is used to set
  the DEVELOPER_DIR var) now uses MacOS::Xcode.prefix
  which is proven and very capable and uses splotlight
  correctly.
- Replace (and remove) MacSystem.xcode43_developer_dir
  with Xcode.prefix

Closes Homebrew/homebrew#18618
2013-03-21 17:10:32 +01:00
Misty De Meo
29af53d451 Replace remaining shelled-out whiches 2013-03-21 08:37:51 -05:00
Mike McQuaid
8a33564cab Fix local installation of bottles.
Fixes Homebrew/homebrew#18631.
2013-03-21 10:33:17 +00:00
Jack Nagel
46476ae4d0 Fix brew options --all
Fixes Homebrew/homebrew#18625.
2013-03-20 22:32:56 -05:00
Jack Nagel
8d000110cc Move this method somewhere more appropriate 2013-03-20 22:32:56 -05:00
Jack Nagel
c79d7272c8 Move Formula.all to compat 2013-03-20 22:32:56 -05:00
Misty De Meo
edeb5e2397 superenv: fix xcode43_developer_dir check 2013-03-20 21:50:32 -05:00
Mike McQuaid
b578a47bb9 brew-info: specify whether poured or built.
- Store in the tab if a bottle was poured for the build.
- Add an additional line of output to `brew info` outputting whether
  the formula was built from source or poured from a bottle.

Closes Homebrew/homebrew#18430.
Closes Homebrew/homebrew#18475.
2013-03-20 23:06:38 +00:00
Misty De Meo
81f9aef245 superenv?: fail when xcode43_developer_dir raises 2013-03-20 10:52:51 -05:00
Misty De Meo
16672b9d82 superenv: move check logic into superenv?
Fixes Homebrew/homebrew#16292.
2013-03-20 10:52:51 -05:00
Misty De Meo
5c746bf855 superenv: move MacSystem into separate file
This makes it requirable before superenv becomes active.
2013-03-20 10:52:51 -05:00
Jack Nagel
6486c94932 versions: remove FIXME
I understand how this works now, and it is definitely necessary.
2013-03-18 15:10:37 -05:00
Jack Nagel
c8168d8a4a Simplify SoftwareSpec checksum methods
Reader methods for specific checksum types have been absent from the
Formula class for some time, so there isn't any reason to expose them in
SoftwareSpec, either.

Thus, these methods now only act as setters, and #checksum should be
used to access the constructed Checksum object.
2013-03-18 15:10:36 -05:00
Jack Nagel
456386c9b1 Reduce footprint of fails_with_llvm compat code 2013-03-18 13:29:33 -05:00
Jack Nagel
581e766809 Fix fails_with_llvm compatibility
Fixes Homebrew/homebrew#18565.
2013-03-18 13:00:47 -05:00
Samuel John
ac68de8a7e doctor: Tweak git-clean suggestion for empty dirs
git clean -f is not enough. Needs `-d` somtimes to
handle cases when we rename a dir.

Fixes Homebrew/homebrew#18544 and fixes Homebrew/homebrew#14224
2013-03-18 12:09:15 +01:00
Jack Nagel
56fa23e07e cleaner: simplify verbose pathname extension 2013-03-18 00:11:49 -05:00
Mike McQuaid
43a8e896e8 Temporarily omit bottle source warning.
Pending a decent fix.

Fixes Homebrew/homebrew#18540.
2013-03-17 14:49:08 +00:00
Peter Aronoff
c9563cce95 Fix brew update so that it doesn't show doubles
Under certain conditions, `brew update` will show doubles. It's a rare
edge-case, but if you have a tap where the name of the formula is identical
with the name of the insalled file, then you see output like this:

    ==> Updated Formulae
    aalib				   ssh-copy-id
    casperjs				   sshuttle
    jack				   telemachus/anytap/brew-any-tap
    mogenerator				   telemachus/anytap/brew-any-tap

I believe this should fix that.

Closes Homebrew/homebrew#18495.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2013-03-16 16:27:46 -05:00
Jack Nagel
e463016428 ENV: clear influential include path vars 2013-03-16 13:51:30 -05:00
Jack Nagel
a55fa2c359 Decouple CompilerSelector from ENV 2013-03-16 13:05:02 -05:00