10663 Commits

Author SHA1 Message Date
Markus Reiter
b957a1b7e6 Enable Style/EmptyElse cop. 2016-09-23 15:30:05 +02:00
Markus Reiter
2a1788484a Remove dependency on rubocop-cask. 2016-09-23 15:30:05 +02:00
Mike McQuaid
4cbeb1e981 Merge pull request #1103 from MikeMcQuaid/update-upstream-tag-strict
update.sh: only update to semver tags.
2016-09-23 14:26:04 +01:00
Mike McQuaid
8989275473 Merge pull request #1084 from penman/fast_integration_tests
tests: speed up integration tests coverage
2016-09-23 11:35:45 +01:00
Mike McQuaid
b0dfd2d435 update.sh: only update to semver tags.
Otherwise random e.g. `pr-123` tags may cause `brew update` to update
to the wrong version.
2016-09-23 11:26:24 +01:00
Mike McQuaid
597a92af44 Merge pull request #1101 from MikeMcQuaid/sandbox-repository
sandbox: tweak HOMEBREW_REPOSITORY handling.
2016-09-23 11:12:08 +01:00
Alyssa Ross
5f6a8d407a tests: speed up integration tests coverage
Previously, .simplecov called `SimpleCov.result` to store the coverage
result, and ignored the return value. `SimpleCov.result`'s return can be
slow to calculate, which wastes a lot of time when it's ignored.

This commit extracts the code needed to store the SimpleCov result from
`SimpleCov.result`, and calls it directly, without doing the busywork to
compute the return value every time.

In my testing, this more than halves the time taken to run all the
integration tests.
2016-09-23 10:40:08 +01:00
Mike McQuaid
9001855d64 Merge pull request #1086 from woodruffw/macho-cosmetics
Remove old cctools references now that only ruby-macho is used.
2016-09-23 10:40:08 +01:00
Markus Reiter
759ee585d5 Merge pull request #1089 from reitermarkus/coverage
Fix coverage reporting.
2016-09-23 10:33:42 +02:00
Mike McQuaid
bc52932e5a Merge pull request #1014 from rwhogg/upstream-ant-dep-linux-fix
dependency_collector: Fix ant_dep for Linux
2016-09-23 08:41:45 +01:00
Mike McQuaid
289cd0580e Merge pull request #1085 from penman/docs-update_test
docs: more accurate update-test parameter name
2016-09-23 08:34:20 +01:00
Mike McQuaid
536c48e804 sandbox: tweak HOMEBREW_REPOSITORY handling.
If we have a HOMEBREW_REPOSITORY and HOMEBREW_PREFIX mismatch (now the
default) then we can block access to the whole of HOMEBREW_REPOSITORY
rather than just the HOMEBREW_LIBRARY and `.git`.
2016-09-23 08:29:05 +01:00
Markus Reiter
6b85593895 Fix coverage reporting. 2016-09-23 09:17:55 +02:00
Mike McQuaid
5cf3838f42 Merge pull request #1041 from penman/parallel_tests
Parallelise test suite
2016-09-23 07:57:35 +01:00
Dominyk Tiller
b7e7434bdb Merge pull request #1093 from rwhogg/most-formulae-have-tests
test: most formulae have tests now
2016-09-23 04:20:12 +01:00
Dominyk Tiller
d3a2934d8b Merge pull request #1090 from MikeMcQuaid/brew-version-repository
brew.sh: fix brew --version outside HOMEBREW_REPOSITORY.
2016-09-23 03:56:13 +01:00
Bob W. Hogg
aae4dfaec0 automated rubocop fixup 2016-09-22 22:10:32 -04:00
Dominyk Tiller
559cea7fa9
Revert "diagnostic: make using outdated development tools fatal"
This reverts commit a124680b189f50ebeb550845e3c0efd34db66247.

Will need to be smarter than this, since people can't force Travis to
update. I'm losing count of the amount of times Travis has forced a change
of plans around Homebrew this year.

Closes https://github.com/Homebrew/brew/issues/1096.
2016-09-22 23:37:12 +01:00
Bob W. Hogg
1de9f3baf3 make linux behaviour the default. override only for macos 2016-09-22 17:47:50 -04:00
Bob W. Hogg
0029ad2929 add the other test back in 2016-09-22 17:36:57 -04:00
Bob W. Hogg
709a20e2a0 test: most formulae have tests now 2016-09-22 17:12:13 -04:00
Mike McQuaid
5af52410ab brew.sh: fix brew --version outside HOMEBREW_REPOSITORY. 2016-09-22 21:46:11 +01:00
Mike McQuaid
889c400be4 Merge pull request #956 from DomT4/oh_no_not_this_time_of_year_again
Xcode 8.0 changes.
2016-09-22 21:26:04 +01:00
William Woodruff
846a5b79b6
Remove old cctools references now that only ruby-macho is used. 2016-09-22 14:36:24 -04:00
Alyssa Ross
b81dcea043 update-test: more accurate variable names 2016-09-22 19:26:41 +01:00
Alyssa Ross
5ba04b0cc6 docs: more accurate update-test parameter name
`sha1` isn't a very accurate description of what this value can be
because it can be any git commit reference. For example, `brew test-bot`
uses `brew update-test --commit=HEAD`.
2016-09-22 19:26:24 +01:00
Dominyk Tiller
a124680b18
diagnostic: make using outdated development tools fatal 2016-09-22 18:15:48 +01:00
Dominyk Tiller
5575c17629
xcode: prefer Utils.popen_read 2016-09-22 18:15:47 +01:00
Dominyk Tiller
b089520682
xcode: revert expectation of 10.11 8.0 CLT 2016-09-22 18:15:47 +01:00
Dominyk Tiller
9fda6d2ec9
docs/Xcode: there is no 10.11 CLT 8.0
From the 8.1 Xcode Beta:
```
There is no Command Line Tools (OS X 10.11) for Xcode 8 package. Xcode 8 contains
SDKs that are incompatible with earlier toolchains. Developers who want to make
use of the Xcode 8 SDKs from the command line must choose the SDK with `xcode-select`.
Developers on OS X El Capitan who have installed versions of the Command Line Tools
(OS X 10.11) for Xcode 8 Beta should install Command Line Tools (OS X 10.11)
for Xcode 7.3.1.
```

Thanks Apple.
2016-09-22 18:15:40 +01:00
Dominyk Tiller
2e808ff2e3
Xcode.md: update 10.11 expectation 2016-09-22 17:30:57 +01:00
Dominyk Tiller
860f4bd11f
xcode: expect Xcode 8.0 on OS X 10.11 2016-09-22 17:30:56 +01:00
Alyssa Ross
5c5c416d1c cask-tests: remove Travis seed
This hack has been in Homebrew Cask for more than two years
(since 51f93e6dc9c3da4ab2118459ea95e45c104386ec), and it originated even
earlier (6d2f7bc55af0b2aa915b2396d213e30a4446256c).

Cask tests apparently aren't even run on Travis anymore,
so this can be safely removed.
2016-09-22 14:32:04 +01:00
Bob W. Hogg
57c2c560a1 one less block in mac dep 2016-09-22 08:36:10 -04:00
Bob W. Hogg
fc1f4e4193 use newer ruby hash style 2016-09-22 08:31:50 -04:00
Bob W. Hogg
d02c8a46df add missing method to test_os_mac_dependency_collector 2016-09-22 08:31:50 -04:00
Bob W. Hogg
769cab7e4f follow the pattern more closely 2016-09-22 08:31:50 -04:00
Bob W. Hogg
01b93117cd move os checks to extend/os 2016-09-22 08:31:50 -04:00
Bob W. Hogg
ddccbf22ae remove comment about brewed ant on Linux; not necessary 2016-09-22 08:31:50 -04:00
Bob W. Hogg
25b6c0c236 Remove unnecessary skips 2016-09-22 08:31:50 -04:00
Bob W. Hogg
2a82770f70 move mac-specific tests elsewhere 2016-09-22 08:31:50 -04:00
Bob W. Hogg
f65217f61e Oops, forgot to rename it in-code 2016-09-22 08:31:50 -04:00
Bob W. Hogg
5c926b1db3 make names more generic 2016-09-22 08:31:50 -04:00
Bob W. Hogg
0a4bc8494d switch to using extend pattern 2016-09-22 08:31:50 -04:00
Bob W. Hogg
54a086e2fe dependency_collector: Fix ant_dep for Linux.
Signed-off-by: Bob W. Hogg <rwhogg@linux.com>
2016-09-22 08:31:50 -04:00
ilovezfs
bbed7246bc Merge pull request #1078 from ilovezfs/cmake-weak-symbols
formula: help CMake with 10.12 SDK on 10.11
1.0.2
2016-09-22 04:36:24 -07:00
Mike McQuaid
635375060c Merge pull request #1076 from MikeMcQuaid/homebrew-version-git-describe
Use git describe to get the HOMEBREW_VERSION.
2016-09-22 12:25:39 +01:00
Mike McQuaid
9784fa4122 Merge pull request #1077 from MikeMcQuaid/no-checkout-branch-message
update.sh: don't print "checkout branch" message.
2016-09-22 11:43:13 +01:00
ilovezfs
4c358d66a9 formula: help CMake with 10.12 SDK on 10.11
This adds a CMake cache entry to std_cmake_args specifying that the
function clock_gettime is not available on 10.11 in order to avoid
runtime errors such as

  dyld: lazy symbol binding failed: Symbol not found: _clock_gettime

when the build system is confused by Xcode 8's weak symbols.

Other weak symbols on 10.11, which may merit the same treatment in the
future, can be found with

  grep 'weak$os10.11' MacOSX.sdk/usr/lib/system/libsystem_c.tbd
2016-09-22 01:37:28 -07:00
Markus Reiter
c310557236 Merge pull request #1064 from reitermarkus/migrate-caskroom
Ask for `sudo` when moving Caskroom.
2016-09-22 10:20:54 +02:00