Markus Reiter
f0dc1d96c5
Merge pull request #2537 from reitermarkus/pathname-to_str
...
Remove `to_s` from some `Pathname`s.
2017-05-18 09:39:07 +02:00
Shaun Jackman
175c2e9303
replace_text_in_files: Regex match is greedy
...
The regex matches the longest possible string. Order does not matter.
2017-05-17 23:55:29 -07:00
JCount
cd8d7a8a44
audit: fix full versioned alias name resolution in taps
...
This fixes an issue where audit would prompt for the creation
of an already existing versioned alias while at the same time
declaring the existing alias invalid.
2017-05-17 15:18:59 -04:00
Mike McQuaid
2b726383f1
info: fix conflicts formatting.
2017-05-16 10:05:05 +01:00
Mike McQuaid
aeaf9af711
Merge pull request #2470 from johnhawkinson/conflicts-info
...
Display formula conflict reasons
2017-05-16 08:45:45 +01:00
Markus Reiter
3cdf8f938a
Use scoped RSpec matchers.
2017-05-15 17:23:40 +02:00
Mike McQuaid
8e2198ff01
info: tweak conflicts output code.
2017-05-15 10:40:07 +01:00
Mike McQuaid
ea8be174f6
Merge pull request #2631 from GauthamGoli/audit_homepage_rubocop
...
audit: Port audit_homepage method to rubocop and add tests
2017-05-15 10:02:47 +01:00
Mike McQuaid
9889b42ec4
Merge pull request #2628 from GauthamGoli/formula_desc_cop_fix
...
audit: Detect multiline and interpolated strings in formula desc cop
2017-05-15 10:01:38 +01:00
John Hawkinson
33d4c95a28
info: use more string interpolation
2017-05-14 15:09:01 -04:00
Gautham Goli
91efcb045e
Port audit_homepage method to rubocop and add tests
2017-05-14 22:05:46 +05:30
Mike McQuaid
75d230318a
Merge pull request #2627 from MikeMcQuaid/audit-fix-option-detection
...
audit: fix dependency option detection.
2017-05-14 15:09:07 +01:00
Mike McQuaid
80df74893a
Merge pull request #2621 from MikeMcQuaid/rubocop-module-length
...
rubocop: don't always care about module length.
2017-05-14 15:08:58 +01:00
Mike McQuaid
13efa8656e
Merge pull request #2620 from MikeMcQuaid/more-env-filtering-tweaks
...
More environment filtering tweaks
2017-05-14 15:08:47 +01:00
Mike McQuaid
d0e3f3574f
Merge pull request #2619 from MikeMcQuaid/more-audit-versioned-aliases
...
audit: more checks for versioned aliases.
2017-05-14 15:08:27 +01:00
Mike McQuaid
e8ef21252d
Merge pull request #2617 from MikeMcQuaid/interactive-home-access
...
Allow --interactive to access HOME
2017-05-14 15:08:16 +01:00
Mike McQuaid
25e9e658af
Merge pull request #2616 from MikeMcQuaid/devel-opt-aliases
...
keg: skip opt versioned aliases for devel/head.
2017-05-14 15:08:06 +01:00
Gautham Goli
80572939b4
Update string_content method to support multiline strings, add test for same
2017-05-13 18:48:40 +05:30
Mike McQuaid
d5006ef012
audit: fix dependency option detection.
...
Instead of trying to do this all with a single regex give up and do a
two stage process. Eventually I'll end up implementing a full ruby
parser here 🧌 .
2017-05-13 13:00:00 +01:00
Mike McQuaid
8205e61e64
More environment filtering tweaks
...
- only document HOMEBREW_* variables in the manpage (although still
read from all the original environment variables).
- resort manpage environment variables in alphabetical order
- check the original path for trailing slashes
2017-05-13 11:42:01 +01:00
Gautham Goli
d04f295de3
Add autocorrect method for ComponentsOrder rubocop and tests
2017-05-13 03:09:55 +05:30
Reinhard Pointner
5c59b3352f
Support GPG (signed data) container in Homebrew Cask (test case)
2017-05-11 16:27:45 +08:00
Reinhard Pointner
b0987ffb33
Support GPG (signed data) container in Homebrew Cask
2017-05-11 16:26:16 +08:00
Reinhard Pointner
3668a7abb1
Support GPG (signed data) container in Homebrew Cask
2017-05-10 23:18:42 +08:00
mansimarkaur
45754a1888
diagnostic_spec.rb: check_access_lock_dir test
...
Added assertion to check `HOMEBREW_LOCK_DIR.stat.mode` changes after `HOMEBREW_LOCK_DIR.chmod 0555`
2017-05-10 03:02:55 +05:30
Mike McQuaid
7055abc436
Allow --interactive to access HOME
...
This may result in a slightly varied build but it’s generally just far
less annoying to be able to access all your e.g. shell configuration.
2017-05-09 20:00:11 +01:00
Mike McQuaid
76f48d338e
keg: skip opt versioned aliases for devel/head.
...
These versioned aliases don’t correspond to the correct version if not
Installed from stable.
Fixes #2596 .
2017-05-09 15:10:57 +01:00
Mike McQuaid
b14f1572b7
audit: more checks for versioned aliases.
...
Check that a required versioned alias has a valid name (rather than
assuming it’s fine based on it’s existence alone) and check for
the presence of invalid version aliases.
This should handle the case where someone bumps a formula but forgets
to rename the alias that’s mentioned in #2596 .
2017-05-09 15:10:29 +01:00
Mike McQuaid
0fb1fb51be
rubocop: don't always care about module length.
...
We don't care about this in external taps as this is more about code
architecture than code style.
2017-05-09 12:58:49 +01:00
Markus Reiter
5828eefd01
Remove to_s
from some Pathname
s.
2017-05-08 13:37:28 +02:00
Mike McQuaid
f1d4c4be78
Merge pull request #2607 from MikeMcQuaid/travis-ci-tweaks-2
...
Travis CI tweaks.
2017-05-08 09:51:06 +01:00
Mike McQuaid
9853a78397
Travis CI tweaks.
...
Attempt to improve Travis CI. This time without any vendoring gems
nonsense.
2017-05-08 08:38:25 +01:00
Mike McQuaid
e4ecf6d6bc
Merge pull request #2591 from retokromer/patch-1
...
fix date-based versioning
2017-05-07 21:13:52 +01:00
Mike McQuaid
57db2e539e
Revert "Merge pull request #2597 from MikeMcQuaid/vendor-gems"
...
This reverts commit 3e4547f52e7ebec633f8bfefc8a396d944edf908, reversing
changes made to 6edf9382bcc1240ad6f97c8b752cfe56cef9965d.
2017-05-07 17:28:39 +01:00
Mike McQuaid
e1bbab6ca6
Revert "Merge pull request #2603 from MikeMcQuaid/tweak-gem-vendoring"
...
This reverts commit 2372872974d1049c2beafe7dedb7f8f882502058, reversing
changes made to 3e4547f52e7ebec633f8bfefc8a396d944edf908.
2017-05-07 17:28:37 +01:00
Mike McQuaid
a76392dd5f
Revert "Merge pull request #2602 from MikeMcQuaid/travis-ci-tweaks"
...
This reverts commit 8d948e4b0b55912c592d34cb5ea83c649b1f9d5e, reversing
changes made to 2372872974d1049c2beafe7dedb7f8f882502058.
2017-05-07 17:28:34 +01:00
Mike McQuaid
5cdb0d0a6d
Travis CI tweaks
...
Tweak our Travis CI configuration and the one we suggest for taps to
be faster and use caching.
2017-05-07 16:00:04 +01:00
Mike McQuaid
33f83be10e
Tweak Gem vendoring.
...
If people have `HOMEBREW_RUBY_PATH` set then things explode in a rather
confusing fashion. Instead, run `bundle` for them with the arguments
that they'd want.
Also, move `macho` requires into the module itself; it's a pain having
to do everything for Bundler before requiring `pathname` which is a core
Ruby class.
2017-05-07 15:33:54 +01:00
Mike McQuaid
ee253e465b
Vendor all Homebrew's gems.
...
Homebrew's actually ended up using a fair few gems. While we want to
avoid Bundler at runtime (and this PR still does that, in fact uses
Bundler even less at runtime than it did before) writing our own version
to use at build-time seems redundant.
2017-05-07 13:52:57 +01:00
Tim D. Smith
22d3a67b73
Relocate virtualenv orig-prefix.txt
...
Virtualenvs remember the path to the stdlib in a file named
orig_prefix.txt. This file wasn't being relocated because Homebrew skips
files that look like they're intended for human consumption by matching
against the list of metafile extensions. This led to the bug described
in https://github.com/Homebrew/homebrew-core/issues/12869 . This fixes
relocation by creating an exception for orig-prefix.txt.
2017-05-06 15:56:55 -07:00
Markus Reiter
6b5171de30
Remove unused e
from rescue Interrupt
.
2017-05-05 20:50:11 +02:00
pseudoku
77728abbfc
Remove unused command_args
...
Extra command_args in gain_permissions_remove caused silent failure and path never gets deleted.
2017-05-04 00:17:56 -07:00
Mike McQuaid
6a15cea0b4
style: fix audit --online
...
This passed a symbol to `:except_cops` which caused a 💥 .
2017-05-03 12:58:08 +01:00
Mike McQuaid
56413f6f6d
Merge pull request #2582 from MikeMcQuaid/style-fix-rubocop-require
...
style: don't require rubocop until installed.
2017-05-03 12:40:45 +01:00
Mike McQuaid
790a113371
brew.sh: >v1.2.0 now.
2017-05-03 12:10:25 +01:00
Mike McQuaid
1c43070e69
style: don't require rubocop until installed.
...
This avoids an error when RuboCop installed installed yet.
CC @GauthamGoli FYI.
2017-05-03 12:09:18 +01:00
Mike McQuaid
a25cd9d8ba
Merge pull request #2580 from reitermarkus/gem-path
...
Remove `existing` from PATH when adding `Gem.bindir`.
2017-05-03 11:37:18 +01:00
Mike McQuaid
555505ec54
Merge pull request #2531 from GauthamGoli/audit_cops_options_refactor
...
audit: Allow skipping/selective running of cops and cops refactor
2017-05-03 11:28:25 +01:00
Mike McQuaid
ffa45521f4
Merge pull request #2406 from sjackman/install-bottle-url
...
Install a bottle from an URL
2017-05-03 11:25:12 +01:00
Mike McQuaid
e1ef37953f
Merge pull request #2577 from DomT4/keg_only_style_tweaks
...
caveats: tweak keg_only style
2017-05-03 11:19:33 +01:00