12095 Commits

Author SHA1 Message Date
Isabell Long
b2f2fbfa63 format_desc_cop: whitelist more lowercase words
- From `homebrew-core` PR 14229, we decided to whitelist more words so
  that reordering to appease "description must start with a capital
  letter" wasn't so clunky.
2017-06-13 12:37:22 +01:00
Mike McQuaid
ed9942fbd1 Merge pull request #2769 from MikeMcQuaid/rubocop-no-perl-backrefs
rubocop: don’t allow Perl regex backrefs.
2017-06-12 16:47:28 +01:00
Mike McQuaid
22c431d221 Merge pull request #2767 from MikeMcQuaid/rubocop-no-special-global-vars
rubocop: don’t allow special global variables.
2017-06-12 16:16:37 +01:00
Mike McQuaid
aa364fbf15 Merge pull request #2766 from MikeMcQuaid/rubocop-no-percent-x
rubocop: don’t allow %x.
2017-06-12 09:27:09 +01:00
Mike McQuaid
021cef4b2b Autocorrect Rubocop Style/SpecialGlobalVars. 2017-06-12 09:11:42 +01:00
Mike McQuaid
5d8b96a0c7 create: specify homebrew-core test requirements.
As requested in https://github.com/Homebrew/homebrew-core/pull/14419.
2017-06-10 20:27:44 +03:00
Mike McQuaid
7a0aff1080 Autocorrect Rubocop Style/PerlBackrefs. 2017-06-10 20:23:20 +03:00
Mike McQuaid
564b03aa01 rubocop: don’t allow Perl regex backrefs.
Even if shell/perl users recognise these variables the explicit versions
are significantly more readable for everyone.
2017-06-10 20:20:02 +03:00
Mike McQuaid
c21abf0e3a rubocop: don’t allow special global variables.
Even if shell/perl users recognise these variables the English
versions are significantly more readable for everyone.
2017-06-10 20:01:59 +03:00
Mike McQuaid
139f44f013 rubocop: don’t allow %x.
It’s confusing for non-Rubyists (and some Rubyists) and that’s a major
number of our current and future contributors.
2017-06-10 20:01:53 +03:00
Mike McQuaid
f3970b52b6 Merge pull request #2758 from MikeMcQuaid/build-error-options
BuildError: report options to analytics.
2017-06-10 18:42:12 +03:00
Markus Reiter
4af1d2265b Add symlink for High Sierra test bottle. 2017-06-09 14:02:57 +02:00
Mike McQuaid
99c897acad BuildError: report options to analytics.
Without this it's not easy to make much sense of these failures.
2017-06-09 14:53:01 +03:00
Mike McQuaid
113a7a81d0 Revert "audit: Port audit_checksum method to rubocop and add tests" 2017-06-09 11:16:11 +03:00
Mike McQuaid
e83e394a73 Merge pull request #2755 from GauthamGoli/audit_checksum_rubocop
audit: Port audit_checksum method to rubocop and add tests
2017-06-09 09:46:05 +03:00
Mike McQuaid
0e2b043c12 Merge pull request #2752 from MikeMcQuaid/remove-unused-analytics
analytics: remove unused analytics.
2017-06-09 08:59:40 +03:00
Gautham Goli
d09d5ecc55 audit: Port audit_checksum method to rubocop and add tests 2017-06-08 21:53:46 +05:30
Gautham Goli
134da5b8c2 Add methods in FormulaCop to find block nodes 2017-06-08 19:50:04 +05:30
Mike McQuaid
b6e1dde7c9 Merge pull request #2753 from leedm777/gcc7-shim
Adding shims for GCC 7
2017-06-08 16:53:35 +03:00
Mike McQuaid
18fb81906e reinstall: keg.rmtree isn't a method. 2017-06-08 16:24:55 +03:00
Mike McQuaid
2269518768 Merge pull request #2746 from MikeMcQuaid/cleanup-tests
tests: cleanup tests.
2017-06-08 16:16:55 +03:00
Mike McQuaid
e25b1a3a96 Merge pull request #2748 from MikeMcQuaid/desc-cop-tweaks
formula_desc_cop: tweak some rules.
2017-06-08 15:44:30 +03:00
Markus Reiter
e287c83d8b Merge pull request #2708 from JCount/codecov-move-path
.codecov.yml: move root so files are tracked
2017-06-08 14:42:47 +02:00
Mike McQuaid
c572081f8b formula_desc_cop: tweak some rules.
Allow some specific lowercase words and provide an autocorrect for some
of these rules.
2017-06-08 15:13:10 +03:00
Mike McQuaid
cc8bc44286 audit: ensure curl always has an HTTP url.
This makes using `HOMEBREW_CURL` significantly nicer as then the system
`curl` (that, on old versions, sucks at SSL) can download a version of
`curl` that it can build from source.
2017-06-08 14:20:04 +03:00
Mike McQuaid
fd4aaf030f Merge pull request #2749 from MikeMcQuaid/edit-default-editors
edit: tweak default editors.
2017-06-08 12:46:56 +03:00
Mike McQuaid
8b29a07cfa Merge pull request #2750 from MikeMcQuaid/no-auto-update-no-report-issue-prompt
brew: no issue report prompt unless autoupdating.
2017-06-08 12:46:40 +03:00
Mike McQuaid
882f64169c Merge pull request #2751 from MikeMcQuaid/reinstall-remove-partial-keg
reinstall: remove partially installed keg.
2017-06-08 12:46:17 +03:00
David M. Lee
69f3c8320f
Adding shims for GCC 7 2017-06-07 23:37:59 -05:00
Mike McQuaid
10549d13f4 brew: no issue report prompt unless autoupdating.
Otherwise: you may be on an old enough version that we don't care.
2017-06-07 16:37:39 +01:00
Mike McQuaid
5367f1b408 analytics: remove unused analytics.
We didn't end up using the `screenview` and `exception` analytics as
much as expected so let's remove them and focus on stuff that's
formula-specific.
2017-06-07 16:34:54 +01:00
Mike McQuaid
7d5b8a5cea tests: cleanup tests.
Remove pending tests that are never run on CI (i.e. require `--online`),
remove fixtures for those tests and just make `--official-cmd-taps`
run by `--online` instead.
2017-06-07 16:25:07 +01:00
Mike McQuaid
486d3d84b1 edit: tweak default editors.
Add `atom` (not my editor of choice [TextMate for life!]) but widely
used enough to probably warrant it. Also, reorder based on my best
guestimates of current usage and cleanup the editor code while we're
here.
2017-06-07 16:07:53 +01:00
Mike McQuaid
838bb38b3e reinstall: remove partially installed keg.
Previously if a `brew reinstall` was Ctrl-Cd after some files had been
installed it wouldn't try to remove the partially installed keg and the
renaming of the backed-up keg would fail. Alternatively, remove the
partially installed keg as if it has been Ctrl-Cd or otherwise failed
then it's not desirable to keep it.
2017-06-07 15:58:13 +01:00
Markus Reiter
e2e578fd83 Merge pull request #2729 from reitermarkus/cask-require-sha
Fix parsing `--require-sha` and `HOMEBREW_CASK_OPTS`.
2017-06-07 13:22:59 +02:00
Mike McQuaid
1627df997c Merge pull request #2744 from DomT4/this_time_of_year_again
High Sierra: more initial support
2017-06-07 09:46:10 +01:00
Mike McQuaid
2cf2c020ba tty: handle non-tty stdin.
When stdin is not a tty then the message `stty: stdin isn't a terminal`
will be produced. Silence this message and fall back to `tput` when it
fails and default to 80 if we get no results at all.

Follow-up from #2714.
2017-06-07 06:57:50 +01:00
Dominyk Tiller
bcdd919b84
pkgconfig: add initial files for 10.13 2017-06-07 05:12:45 +01:00
Dominyk Tiller
08cee5a0d5
os/mac/xcode: add CLT Clang for 10.13 2017-06-07 04:39:29 +01:00
Markus Reiter
b40e4afac5 Fix parsing --require-sha and HOMEBREW_CASK_OPTS. 2017-06-06 16:40:03 +02:00
Markus Reiter
2fa8596302 Sort Hbc::installed. 2017-06-06 15:53:02 +02:00
Mike McQuaid
d9abe6552d Merge pull request #2738 from constXife/master
undefined local variable or method `ruby_version' on macOS 10.13 beta
2017-06-06 08:25:25 +01:00
Mike McQuaid
29d2268252 Merge pull request #2734 from rwhogg/fix-reinstall-without-bottle
cmd/reinstall: Fix reinstallation of formulae without bottles
2017-06-06 08:07:15 +01:00
Mike McQuaid
24d39430b5 diagnostic_spec: tweak_formatting. 2017-06-06 08:03:06 +01:00
constXife
4f5643a676 Fix undefined variable ruby_version 2017-06-06 13:45:09 +07:00
Dominyk Tiller
cc86d4184d
os/mac/xcode: recognise Xcode 9.0 2017-06-06 04:33:55 +01:00
Dominyk Tiller
a0ae034654
os/mac: add Xcode 9.0 Beta recognition 2017-06-06 04:30:29 +01:00
Dominyk Tiller
a88350425b
os/mac/xcode: expect Xcode 8.3.3 2017-06-06 04:15:36 +01:00
Dominyk Tiller
04184ebc02
os/mac: add Xcode 8.3.3 support 2017-06-06 04:14:55 +01:00
Bob W. Hogg
51e83cdf91 cmd/reinstall: Fix reinstallation of formulae without bottles
Reinstallation of non-bottled formulae was failing because it
used a deprecated method.

Signed-off-by: Bob W. Hogg <rwhogg@linux.com>
2017-06-05 18:35:43 -07:00