12095 Commits

Author SHA1 Message Date
Mike McQuaid
90c6d5f40a upgrade: perform rename migrations when needed. 2017-03-31 10:01:46 +01:00
Mike McQuaid
61ebc128af reinstall: perform rename migrations when needed. 2017-03-31 10:01:46 +01:00
Mike McQuaid
d82522060e install: perform rename migrations when needed. 2017-03-31 10:01:46 +01:00
Mike McQuaid
ffd706d997 update-report: more forceful rename migration.
Migrate between different taps and delete relevant subdirectories if
they can be safely. Also, tweak some naming and use utility methods.
2017-03-31 10:01:45 +01:00
Mike McQuaid
f3743e98b6 migrator: make headers more consistent.
Use `oh1` for moving kegs to a new directory.
2017-03-31 10:01:45 +01:00
Mike McQuaid
1606e5db6f migrator: move around some migration logic.
Move the checks for moving kegs to a new directory into the relevant
method (`move_to_new_directory`) instead. Also, delete duplicated
directories when we’ve confirmed they are definitely duplicated rather
than telling users to do so.
2017-03-31 10:01:45 +01:00
Mike McQuaid
5d1f4dd531 migrator: add more helper methods.
Add methods to determine if a migration is needed and perform it if so
(and no-op if not). Additionally, make `ARGV.force?` get passed as a
parameter so it can be overridden without requiring users to pass
`—force`.
2017-03-31 10:01:45 +01:00
Mike McQuaid
80b39bb239 Merge pull request #2374 from joshka/cleanup-command-continue-on-error
Cleanup: Continue on error removing keg
2017-03-31 09:43:47 +01:00
Joshua McKinney
48fdd163bc Brew cleanup: Continue on error removing keg
Fixes #2355
Create unremovable_kegs instance var
Check cellar cleanup failure after full cleanup completes
Use module_function in Homebrew::Cleanup as we never instantiate the
class
2017-03-31 01:44:04 -05:00
Mike McQuaid
1ba401039e Merge pull request #2422 from MikeMcQuaid/formula-missing-dependencies-handle-unavailable-formula
formula: handle missing deps when formula missing.
2017-03-30 20:25:18 +01:00
Mike McQuaid
a582be06c2 Merge pull request #2421 from MikeMcQuaid/formula-check-alias-exists
formula: check installed_alias_path exists.
2017-03-30 20:25:05 +01:00
Mike McQuaid
b22407972f Merge pull request #2419 from MikeMcQuaid/fix-tap-cask-migration
Fix handling of tap migrations to new cask names.
2017-03-30 20:24:58 +01:00
Mike McQuaid
b6792fc7be Merge pull request #2401 from wjlroe/print-pinned-on-outdated
Include the pinned version in brew outdated output for pinned formulae
2017-03-30 20:24:30 +01:00
Mike McQuaid
3805850eb3 Merge pull request #2414 from sjackman/update-test-fetch-shallow
update-test: Use git fetch --tags --depth=1
2017-03-30 19:58:42 +01:00
Mike McQuaid
8b682e22cd Merge pull request #2418 from MikeMcQuaid/formula-installer-another-test
formula_installer_spec: add default formula test.
2017-03-30 19:39:52 +01:00
Mike McQuaid
8472d6a40e formula: check installed_alias_path exists.
Otherwise return `nil`.

Fixes https://github.com/Homebrew/brew/issues/2417
2017-03-30 19:39:26 +01:00
Mike McQuaid
45357ef0dd Fix handling of tap migrations to new cask names.
Need to check for two `/`s rather than one.
2017-03-30 19:18:40 +01:00
Mike McQuaid
7d66e29927 Merge pull request #2399 from MikeMcQuaid/unversioned-formulae-check
audit: check for unversioned formulae.
2017-03-30 19:06:47 +01:00
Mike McQuaid
490252d063 Merge pull request #2392 from MikeMcQuaid/cleanup-taps
Update all references to taps.
2017-03-30 19:06:14 +01:00
Mike McQuaid
689c1d5aa1 formula: handle missing deps when formula missing.
We could try and get a partial result but given it'll also be wrong it
feels simpler to just return an empty array.

Fixes #1928.
Fixes #2027.
Closes #2058.
Fixes https://github.com/Homebrew/homebrew-core/issues/11827.
2017-03-30 18:54:47 +01:00
Vítor Galvão
0882e9ddbc Merge pull request #2410 from reitermarkus/container-exectuable
Add `Container::Executable`.
2017-03-30 15:40:20 +01:00
William Woodruff
e7554b0b3f
audit: Fix cctools invocation check regular expression.
Additionally, ignore the cctools formula itself, since it obviously
needs to check cctools invocations.
2017-03-29 09:52:35 -04:00
Mike McQuaid
51ca9025a5 formula_installer_spec: add default formula test.
Test the situation where a requirement is satisfied by a non-formula
but the `default_formula` is also installed.
2017-03-29 09:34:52 +01:00
William Woodruff
8608d1ea78 Merge pull request #1828 from woodruffw/audit-cctools
audit: Check for invocations of cctools.
2017-03-28 22:03:57 -04:00
Mike McQuaid
b757c927af diagnostic: also accept trailing / on git urls. 2017-03-28 19:44:30 +01:00
Mike McQuaid
46a91428f7 Merge pull request #2413 from JCount/increase-minimum-git-version
diagnostic: increase minimum git version to 1.8.5
2017-03-28 19:35:15 +01:00
Mike McQuaid
a543cb2f9e Merge pull request #2398 from MikeMcQuaid/doctor-check-homebrew-core
diagnostic: check homebrew/core git remote.
2017-03-28 19:34:45 +01:00
Shaun Jackman
89f3b6d6a6 update-test: Use git fetch --tags --depth=1
Use git fetch --tags --depth=1 to fetch fewer commits.
2017-03-28 09:36:50 -07:00
JCount
08523d393f diagnostic: increase minimum git version to 1.8.5
older versions do not support the 'git -C <path>' option
2017-03-28 12:05:06 -04:00
EricFromCanada
c5bac087b3 update latest versions of Xcode for 10.11 & 10.12 2017-03-28 11:16:02 -04:00
EricFromCanada
60f6dfea14 update suggested Xcode/CLT download URLs 2017-03-28 11:12:34 -04:00
Mike McQuaid
c3bf9bda58 update-test: improve error handling.
Fail if the start or end commit are missing and retry finding the
previous tag by fetching all tags if they are missing.

This should fix CI on the current Homebrew/brew `master` branch.

Closes #2404.
2017-03-28 15:31:16 +01:00
Markus Reiter
1be120f4c1 Add Container::Executable. 2017-03-28 15:34:34 +02:00
Carlo Rosati
1f89a33213 ruby_requirement: fix path prepend 2017-03-27 16:44:42 -04:00
William Roe
996dcdee2c Add pinned version to outdated json output
The structure should be consistent, so there are always pinned and
pinned_version fields even if there are no pinned versions for a given formula.
2017-03-27 11:41:08 +01:00
William Roe
70446d9112 Add pinned version to outdated output 2017-03-27 11:30:36 +01:00
William Roe
755d43d46d Add test for verbose brew outdated output
Split the tests up into quiet and verbose output with contexts.
2017-03-27 11:27:48 +01:00
Joshua McKinney
a90d1e1699 Installer#reinstall instead of #install :reinstall
Call an explicit method on Installer to reinstall rather than using a
flag to indicate when we're reinstalling a cask
2017-03-27 01:32:53 -05:00
ilovezfs
70685f3017 audit: bump whitelisted elm-format version to 0.6.0-alpha 2017-03-26 22:43:08 -07:00
Mike McQuaid
181275c016 audit: check for unversioned formulae.
If we're adding a versioned formulae we want to ensure that there's also
an unversioned one too.
2017-03-26 20:36:37 +01:00
Mike McQuaid
677db79c29 diagnostic: check homebrew/core git remote.
Check the remote for homebrew/core as well as homebrew/brew as we've
seen a few cases (e.g. #2387) where it was misconfigured.

While we're here, tweak the messaging to tell people what to do and how
to do so with a single command.
2017-03-26 20:28:11 +01:00
Mike McQuaid
09231dd52b Merge pull request #2393 from raza15/raza2
updating the exception for "kibana" for the "@" naming scheme. File changed: audit.rb
2017-03-26 19:51:25 +01:00
Mike McQuaid
2047dbd50e Update all references to taps.
- Remove taps that are (or will shortly be) deprecated.
- Remove commands that are only relevant to the boneyard (which will
  shortly be removed).
2017-03-26 19:42:35 +01:00
Raza Hussain
543529c054 indenting 2017-03-26 14:29:38 -04:00
Raza Hussain
86cf8873b6 changing if condition 2017-03-26 12:54:25 -04:00
Raza Hussain
94769652e0 simplify the regex and make a line max 80 char long 2017-03-26 12:43:09 -04:00
Gautham Goli
a693ca332e Wrap rubocop specific code into methods inside FormulaCop 2017-03-26 15:26:41 +05:30
Gautham Goli
febc108598 Encapsulate formula desc offense checking logic into methods 2017-03-26 15:26:41 +05:30
Gautham Goli
4e57f4279a Add RSpec tests for bottle_block and formula_desc cops 2017-03-26 15:26:41 +05:30
William Woodruff
024264c381
vendor: Update ruby-macho to 1.1.0. 2017-03-26 01:25:32 -04:00