32059 Commits

Author SHA1 Message Date
Issy Long
ae73f28d0f
dev-cmd/contributions: Use a named arg for required repositories
- This is apparently "more in-keeping with how we do required arguments
  (never requiring flags)" across Homebrew.
- New usage: `brew contributions me@issyl0.co.uk all`, `brew
  contributions me@issyl0.co.uk brew,core`
2022-08-03 16:53:56 +01:00
Issy Long
c02e03a179
dev-cmd/contributions: Use methods to get arguments
- I got these with hash syntax because I couldn't figure out Sorbet, but
  there's `args.rbi` to add the CLI args methods to. Nice!
- In doing this I realised that `--repositories` is required again, we
  no longer infer `--repositories=all` from no `--repositories` passed
  as we did in a previous version of this.
2022-08-03 16:53:55 +01:00
Issy Long
5d312d25d0
dev-cmd/contributions: Properly auto-tap 2022-08-03 16:53:54 +01:00
Issy Long
63a1a078b9
dev-cmd/contributions: Improve SUPPORTED_REPOS array syntax
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2022-08-03 16:53:53 +01:00
Issy Long
f5d5778186
dev-cmd/contributions: Use --repositories not --repos
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2022-08-03 16:53:52 +01:00
Issy Long
1ac1097203
dev-cmd/contributions: Better usage banner
Co-authored-by: Rylan Polster <rslpolster@gmail.com>
2022-08-03 16:53:51 +01:00
Issy Long
dd986f7705
dev-cmd/contributions: Use .to_sentence not .join(", ")
Co-authored-by: Rylan Polster <rslpolster@gmail.com>
2022-08-03 16:53:50 +01:00
Issy Long
6974faa29b
dev-cmd/contributions: Appease brew style 2022-08-03 16:53:49 +01:00
Issy Long
5fa192c261
dev-cmd/contributions: Use --repos=all not a separate --all flag 2022-08-03 16:53:48 +01:00
Issy Long
be08b773f1
dev-cmd/contributions: Add --all to scan everything, plus auto-tapping 2022-08-03 16:53:47 +01:00
Issy Long
8e5a5672fb
dev-cmd/contributions: Better shell argument handling, plus stop piping to grep 2022-08-03 16:53:46 +01:00
Issy Long
5a34bc86c4
dev-cmd/contributions: RuboCop has opinions on where spaces should go 2022-08-03 16:53:45 +01:00
Issy Long
70c300daf2
dev-cmd/contributions: Use Utils.safe_popen_read not backticks 2022-08-03 16:53:45 +01:00
Issy Long
f6b2fe5093
dev-cmd/contributions: Improve sentence string line wrapping
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2022-08-03 16:53:44 +01:00
Issy Long
33d3aef295
dev-cmd/contributions: Only one email is allowed currently
Co-authored-by: Rylan Polster <rslpolster@gmail.com>
2022-08-03 16:53:43 +01:00
Issy Long
8a67ce76b5
dev-cmd/contributions: Appease brew typecheck 2022-08-03 16:53:42 +01:00
Issy Long
441df3d866
dev-cmd/contributions: Switch --email to be a named arg
- This way we can do the more intuitive:

```
$ brew contributions --repos=brew,core rslpolster@gmail.com
Person rslpolster@gmail.com directly authored 1580 commits and co-authored 125 commits to brew, core in all time.
```
2022-08-03 16:53:41 +01:00
Issy Long
c330ea4e3b
dev-cmd/contributions: Split git_log_cmd into two methods
- Otherwise it's quite involved and a bit hard to read.
2022-08-03 16:53:40 +01:00
Issy Long
fef9a286fe
dev-cmd/contributions: Simplify find_repo_path_for_repo
Co-authored-by: Rylan Polster <rslpolster@gmail.com>
2022-08-03 16:53:39 +01:00
Issy Long
503b51c54f
dev-cmd/contributions: Better error messages for bad --repos
```
$ brew contributions --email=me@issyl0.co.uk --repos=coreeeee
Error: Unsupported repo: coreeeee. Try one of brew, core, cask, bundle.

$ brew untap homebrew/bundle
$ brew contributions --email=me@issyl0.co.uk --repos=bundle
Error: Couldn't find repo bundle locally. Do you have it tapped?
```
2022-08-03 16:53:38 +01:00
Issy Long
0355c60787
dev-cmd/contributions: Retrieve a user's repo contributions over time
- Before each AGM it's currently a manual process for a PLC member to
  search commit logs and GitHub to figure out who contributed to
  Homebrew, so who should remain a member.
- I noticed that [looking at commits for a
  user](https://github.com/Homebrew/homebrew-core/commits?author=issyl0&since=2022-01-01&until=2023-01-01)
  would not count `Co-Authored-By`, which happens a lot now there's an
  autosquash action on PRs in `Homebrew/homebrew-core`, say if someone
  fixed a formula's build or tests or whatever and then the PR got
  auto-merged.
- Here's `brew contributions` that uses `git log` to be able to go back
  through all time or a specific time period (`--from`, `--to`). It's up
  to individual PLC discretion for "activity", but it does at least go
  some way to automating the data retrieval.
- Example (I can use my username as `--email` because my username is in
  all of the email addresses that I use for committing to Homebrew):

```
$ brew contributions --email=issyl0 --repos=brew,core
Person issyl0 directly authored 732 commits and co-authored 31 commits to brew, core in all time.
```
2022-08-03 16:53:37 +01:00
Mike McQuaid
cb4ac65f26
Merge pull request #13637 from Homebrew/official-cask-taps-versions
official_taps: Refer to `Homebrew/homebrew-cask-versions` properly
2022-08-03 12:51:41 +01:00
Issy Long
0232610381
official_taps: Refer toHomebrew/homebrew-cask-versions properly
- This is needed for https://github.com/Homebrew/brew/pull/13603 because `Homebrew/homebrew-versions` is deprecated (legitimately), but `OFFICIAL_CASK_TAPS` spits out `versions` as a repo, which could then be interpreted as `Homebrew/versions` rather than `Homebrew/cask-versions` which it actually is.
2022-08-03 11:19:23 +01:00
Kevin
ba7e146eef
Merge pull request #13546 from apainintheneck/remove-staged-from-cask
cask/installer.rb: stop including Staged module
2022-08-02 18:29:20 -07:00
Carlo Cabrera
8a153de2bc
Merge pull request #13632 from carlocab/proc
pr-pull: fix typo
2022-08-02 23:26:34 +08:00
Carlo Cabrera
b2cf1822fa
Fix brew style 2022-08-02 22:53:29 +08:00
Carlo Cabrera
8a169364a8
pr-pull: fix typo
Error: tried to create Proc object without a block
    Do not report this issue until you've run `brew update` and tried again.
    /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:372:in `proc'
    /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:372:in `pr_check_conflicts'
    /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:439:in `block in pr_pull'
    /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:429:in `each'
    /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:429:in `pr_pull'
    /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:93:in `<main>'
    Error: Process completed with exit code 1.

https://github.com/Homebrew/homebrew-core/runs/7634004090?check_suite_focus=true#step:10:15
2022-08-02 22:46:30 +08:00
Michka Popoff
3b38695efa
Merge pull request #13512 from iMichka/conflicts
pr-pull: check for conflicts with long running builds
2022-08-02 14:42:08 +02:00
Carlo Cabrera
716136bfc5
Merge pull request #13631 from carlocab/gcc-rpaths
keg_relocate (linux): prepend `gcc/lib/current` to `RPATH` when needed
2022-08-02 19:40:40 +08:00
Carlo Cabrera
1c0eac7874
Exclude GCC formulae from RPATH modification for GCC 2022-08-02 19:09:38 +08:00
Carlo Cabrera
532460c098
keg_relocate: fix new GCC lib directory
Also add comment explaining what this line does, along with a TODO
suggesting a replacement once we've shipped the GCC PR.
2022-08-02 13:29:14 +08:00
Carlo Cabrera
53fdb64113
keg_relocate (linux): prepend gcc/lib/current to RPATH when needed
This should help keep bottles that require GCC working when
Homebrew/homebrew-core#106755 is merged.

This only works on freshly-poured bottles. Previously installed bottles
will still break on systems with a host GCC older than GCC 11.
2022-08-02 11:02:47 +08:00
Michka Popoff
374c3985d6
pr-pull: check for conflicts with long running builds
This change will prevent us having to run some long running builds
multiple times and to rely on luck to get things merged without conflicts.

The check takes less than 30 secondes on my local setup.
2022-08-01 23:34:06 +02:00
Mike McQuaid
4baff3eec1
Merge pull request #13624 from iMichka/core
docs: delete Homebrew-linuxbrew-core-Maintainer-Guide.md
2022-08-01 14:03:27 +01:00
Carlo Cabrera
ce8ef89ec0
Merge pull request #13617 from carlocab/bzr-breezy
download_strategy: replace `bazaar` with `breezy`
3.5.7
2022-08-01 20:03:08 +08:00
Michka Popoff
e28a102812
docs: delete Homebrew-linuxbrew-core-Maintainer-Guide.md
In e1120549e58dfeb088bcda85897c30e87128229b this file was emptied,
but should have been deleted instead.
Nothing references this file anymore
2022-07-31 23:01:57 +02:00
Carlo Cabrera
e217fd35c2
Merge pull request #12770 from carlocab/deprecated-dependencies
formula_auditor: audit for deprecated dependencies
2022-07-30 13:23:57 +08:00
Shaun Jackman
4f02c5de99
Merge pull request #13618 from sjackman/sj/audit_glibc
audit_glibc: Permit glibc 2.27, 2.31, or 2.35 and fix the error message
2022-07-29 14:57:45 -07:00
Shaun Jackman
7d1197e8eb audit_glibc: Permit glibc 2.27, 2.31, or 2.35 2022-07-29 14:06:51 -07:00
Shaun Jackman
1ac5fc05bd audit_glibc: Permit glibc 2.35
See https://github.com/Homebrew/brew/issues/13619
2022-07-29 10:13:09 -07:00
Shaun Jackman
291eacd482 audit_glibc: Fix the error message
"The glibc version must be 2.35" should have read
"The glibc version must be 2.23".
2022-07-29 09:30:18 -07:00
Carlo Cabrera
7c7a92e8fb
formula_auditor: clean up error wording 2022-07-29 20:10:05 +08:00
Carlo Cabrera
467a45421f
dependency_collector: replace bazaar with breezy 2022-07-29 18:10:12 +08:00
Carlo Cabrera
e1ba143d88
download_strategy: replace bazaar with breezy
Bazaar is no longer maintained, and Breezy seems to be a drop-in
replacement.

I've tested the commands used in the download strategy and they seem to
work.

We need this in order to properly deprecate the `bazaar` formula.

See Homebrew/homebrew-core#106848.
2022-07-29 17:02:39 +08:00
Carlo Cabrera
43a34706ed
Merge pull request #13615 from Homebrew/dependabot/bundler/Library/Homebrew/bootsnap-1.13.0
build(deps): bump bootsnap from 1.12.0 to 1.13.0 in /Library/Homebrew
2022-07-29 15:14:10 +08:00
Carlo Cabrera
cbff83898e
formula_auditor: audit for deprecated dependencies
Closes #12748.
2022-07-29 15:07:16 +08:00
Carlo Cabrera
72880dea35
Merge pull request #13586 from carlocab/git-fsmonitor 2022-07-29 04:28:15 +08:00
BrewTestBot
f45114cfae
brew vendor-gems: commit updates. 2022-07-28 18:07:46 +00:00
dependabot[bot]
506daa1a09
build(deps): bump bootsnap from 1.12.0 to 1.13.0 in /Library/Homebrew
Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.12.0 to 1.13.0.
- [Release notes](https://github.com/Shopify/bootsnap/releases)
- [Changelog](https://github.com/Shopify/bootsnap/blob/main/CHANGELOG.md)
- [Commits](https://github.com/Shopify/bootsnap/compare/v1.12.0...v1.13.0)

---
updated-dependencies:
- dependency-name: bootsnap
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-07-28 18:03:51 +00:00
Carlo Cabrera
5e60d54e70
update: disable Git fsmonitor for all Homebrew repositories
Stopping the fsmonitor doesn't seem to work, so let's just prevent the
fsmonitor from watching our repositories.
2022-07-28 22:20:07 +08:00