3522 Commits

Author SHA1 Message Date
Jack Nagel
d298e54e50 doctor: check access on HOMEBREW_PREFIX/opt 2015-01-12 21:29:22 -05:00
Jack Nagel
d0a1800e37 doctor: check access on all important HOMEBREW_PREFIX subdirs 2015-01-12 21:26:18 -05:00
Jack Nagel
b1514c1c40 doctor: check cellar access 2015-01-12 21:26:18 -05:00
Jack Nagel
aa4ff175ff doctor: fix grammar 2015-01-12 21:26:18 -05:00
Jack Nagel
9ff211f212 doctor: remove incorrect statement from HOMEBREW_LOGS check 2015-01-12 21:26:18 -05:00
Mike McQuaid
3f08b8881b cleanup-installed: use uninstall --force. 2015-01-11 10:12:44 +00:00
Xu Cheng
1818799634 test-bot: unlink conflict formulae during the test
Closes Homebrew/homebrew#35697.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-09 15:37:29 +00:00
Mike McQuaid
26b80ecccc test-bot: improve output of dependent testing. 2015-01-09 11:35:03 +00:00
Mike McQuaid
424ded8fdb test-bot: ignore changed dependents. 2015-01-09 11:35:03 +00:00
Jack Nagel
459f92b065 Remove another use of the direct url writer
masgn is hard to grep for :/
2015-01-08 14:28:43 -05:00
Dominyk Tiller
50d64da1ec audit: improve ssl/tls detection
I don’t know how maintainers are going to feel about this, to be
honest. If it’s too clunky, perhaps we could externalise the entire two
main blocks here and then require that file into the audit instead?

Basically, I’m pushing changes here to better detect a wide-array of
SSL/TLS available links that either have no auto-redirect in place or
is a common linking error in formulae. I haven’t spotted any false
positives yet, but obviously, feel free to try and break the changes
and I’ll fix as necessary ;).

IMO, this would allow us gradual updates without having to mass-update
everything at once and stress the bot and inform users they have
hundreds of updates pending when really it’s just style/basic changes.

Closes Homebrew/homebrew#35551.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-06 08:16:25 +00:00
Jack Nagel
dcad08339e Fix syntax error 2015-01-05 15:28:31 -05:00
Jack Nagel
d79a7c0fcf Always use exec_editor to exec the editor 2015-01-05 15:27:07 -05:00
Mike McQuaid
3821c190f9 style: explicitly point to config file.
Closes Homebrew/homebrew#35556.
2015-01-05 08:01:20 +00:00
Mike McQuaid
980cad0717 audit (strict): only run brew style with Ruby 2. 2015-01-05 07:52:47 +00:00
Dominyk Tiller
e871a91958 install: fail on devel where devel doesn't exist
Just equalises a little how we treat HEAD and devel. The former already
fails if there isn’t a head defined, It seemed logical that devel
should fail in the same way.

Closes Homebrew/homebrew#35554.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2015-01-05 00:04:23 -05:00
Jack Nagel
f937e5f920 Forward arguments in IRB formula helpers 2015-01-04 21:37:27 -05:00
Jack Nagel
4398660cdd Checkout outdatedness in brew upgrade <formula>
Fixes Homebrew/homebrew#35523.
2015-01-04 14:03:56 -05:00
Mike McQuaid
c294ce22a7 audit: also run brew style on --strict.
Closes Homebrew/homebrew#35465.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-04 11:05:34 +00:00
Mike McQuaid
e0cacd3008 style: run Rubocop on formulae (new command) 2015-01-04 11:05:34 +00:00
Mike McQuaid
1cd0a47067 tests.rb: use Homebrew.failed to send exit code. 2015-01-04 11:05:34 +00:00
Viktor Szakats
fc2818b7a5 Use more https in urls and updated some lost links
Closes Homebrew/homebrew#35531.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2015-01-04 02:13:16 -05:00
Jack Nagel
9db8580414 Explicitly pass formulae to outdated_brews 2015-01-04 00:41:24 -05:00
Baptiste Fontaine
fe0c57cd0f brew irb --help replaced with --examples
The --help flag is intercepted by brew.rb and prints the global usage
string. `irb` is never called when `brew irb --help` is executed.

Closes Homebrew/homebrew#35466.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2015-01-03 21:31:26 -05:00
Jack Nagel
43aa00227a Get rid of mixed operator styles 2015-01-03 17:54:07 -05:00
Mike McQuaid
9e8103cf38 Add Homebrew.install_gem_setup_path! function.
This uses the logic from tests.rb in man.rb too so that this can be
shared in a few places.
2015-01-02 12:42:02 +00:00
Baptiste Fontaine
81986ee7a7 audit: system check fixed for multiple arguments
Closes Homebrew/homebrew#35459.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-02 10:36:36 +00:00
Shaun Jackman
c01e6b81d3 test-bot: do not --cleanup outside CI.
Closes Homebrew/homebrew#35424.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-02 09:50:28 +00:00
Mike McQuaid
e87b377add pull: fix tap URL regex for devel/head-only. 2015-01-02 09:24:25 +00:00
Jack Nagel
8ebaa9c0a9 Handle newer ruby versions correctly in config output
Since Ruby 2.1, patch releases take the form "2.x.y" rather than
"2.x.y-pnum".
2014-12-31 09:54:44 -05:00
Jack Nagel
accd72b290 Log build environment on failure 2014-12-30 23:47:07 -05:00
Jack Nagel
77c0f60434 Always dump full configuration 2014-12-30 23:33:50 -05:00
Xu Cheng
b10c58d6e2 brew-config: always show XCode/CLT state
Closes Homebrew/homebrew#33860.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-12-30 23:18:05 -05:00
Mike McQuaid
4d584d37f7 test-bot: don't try to retap TapDependency taps. 2014-12-29 12:28:43 +00:00
Mike McQuaid
95ccf53a49 test-bot: tap TapDependency's tap. 2014-12-29 12:20:30 +00:00
Mike McQuaid
eb51f8a5fa test-bot: init added/modified formulae arrays. 2014-12-29 07:55:01 +00:00
Mike McQuaid
bff259330c test-bot: clean up harder on failure (before). 2014-12-29 07:51:50 +00:00
Misty De Meo
d57fe3eded search: add homebrew-x11 to default taps 2014-12-28 18:42:20 -08:00
Mike McQuaid
8c19b2a13e test-bot: clean harder if first clean fails. 2014-12-28 18:17:12 +00:00
Mike McQuaid
af4a156885 test-bot: tweak readability. 2014-12-28 18:17:02 +00:00
Mike McQuaid
b5439b6f7a test-bot: check if dependents are installed.
Before fetching or installing with no args.
2014-12-28 18:16:49 +00:00
Jack Nagel
9e335fa0b8 Revert "audit (strict): check for use double-quotes."
This reverts commit 8fe14451842dea92bca04116ba043421b4f44a6b.

Conflicts:
	Library/Homebrew/cmd/audit.rb
2014-12-27 17:07:30 -05:00
Jack Nagel
ba48d8c5b9 Use version attribute directly in cache comparisons
The bug that prompted the two relevant commits has since been addressed.

Squashed commit of the following:

commit ecca17ede8324efd1175a42300ace8e1e2df30fa
Author: Jack Nagel <jacknagel@gmail.com>
Date:   Sat Dec 27 16:16:12 2014 -0500

    Revert "Don't use pkg_version when cleaning the cache"

    This reverts commit 4d511b5169d78a5d44bbf6c36c17f0c28014a614.

commit e8935de08f6440ae1874ce523f93b19da6b68df3
Author: Jack Nagel <jacknagel@gmail.com>
Date:   Sat Dec 27 16:16:12 2014 -0500

    Revert "Fix cleanup for head-only formulae"

    This reverts commit 510267ffd314c296c0b0969dd27d130a249f16e2.
2014-12-27 16:16:16 -05:00
Mike McQuaid
e1c6a4614f Rename HEAD only tap. 2014-12-27 20:55:21 +00:00
Mike McQuaid
8458540afb audit: simplify test defined check. 2014-12-27 20:46:01 +00:00
Mike McQuaid
13239276f0 audit: improve FileUtils check.
Match the parens properly and only interpolate once.

Closes Homebrew/homebrew#35288.
Closes Homebrew/homebrew#35291.
2014-12-27 20:35:26 +00:00
Mike McQuaid
b43876d4a2 create: recommend brew audit --strict. 2014-12-27 16:51:53 +00:00
Mike McQuaid
c4f7217811 audit (strict): add require formula check. 2014-12-27 16:31:44 +00:00
Mike McQuaid
f3a5a83452 audit (strict): check a test is present. 2014-12-27 16:31:44 +00:00
Mike McQuaid
d263c73cc4 audit (strict): whitelist 32-bit in options check. 2014-12-27 16:31:43 +00:00