This cuts the amount of custom code fairly drastically, applying the
same generic syntax across the different SSL/TLS enforced areas.
It also makes the failure message fit onto one terminal line, which
looks cleaner than the multi-line message we currently print
for standard-size Terminals.
Changes something like:
`ftp.gnu.org urls should be https://, not http:// (url is http://ftp.gnu.org/gnu/gawk/gawk-4.1.1.tar.xz)`
Into:
`Please use https:// for http://ftp.gnu.org/gnu/gawk/gawk-4.1.1.tar.xz`
References: Homebrew/homebrew#39421Homebrew/homebrew#39306ClosesHomebrew/homebrew#40054.
Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
Just makes the audit cough out this:
```
* :libtool is deprecated. Usage should be "libtool"
* :autoconf is deprecated. Usage should be "autoconf"
* :automake is deprecated. Usage should be "automake"
```
ClosesHomebrew/homebrew#39303.
ClosesHomebrew/homebrew#39322.
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
Without this, `brew audit <some formula>` may ask people to change:
system "./script.sh foo-*"
into:
system "./script.sh", "foo-*"
These are not the same. In the first example the shell expansion occurs
while it doesn’t in the second one, breaking the build.
ClosesHomebrew/homebrew#38540.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
"ftpmirror.gnu.org" must have a protocol prefix of "http", not
"https".
ClosesHomebrew/homebrew#37567.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
Extends the audit checks to GnuPG, a significant chunk of Freedesktop
domains, and Github Pages. I’ve somewhat hardened my stance towards
Github Pages from the last time we extended this, hence the new
inclusion - I did a pretty thorough check through the Homebrew formulae
that use Github Pages for homepage links and found very few places
where enforcing SSL/TLS would cause issues - I think a wider
enforcement is worthwhile.
I’ve also fixed the capitalisation of the taps, if only because at the
moment it disagrees with what ` puts formula.tap ` outputs (We get
Homebrew/homebrew-head-only rather than homebrew/homebrew-head-only for
example).
ClosesHomebrew/homebrew#36719.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
Currently the bot is failing certain devel-only formulae because it
thinks having ` devel ` defined with an added ` head ` defined
as well = a head-only formula.
```
==> audit problems
docker-machine:
* Head-only (no stable download)
```
This is a pretty simple fix for that problem:
```
==> brew style docker-machine
1 file inspected, no offenses detected
```
ClosesHomebrew/homebrew#36197.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
