25765 Commits

Author SHA1 Message Date
Mike McQuaid
a83848d24f
Merge pull request #10439 from MikeMcQuaid/fix_retry
spec_helper: fix and improve retry logic.
2021-01-27 19:37:10 +00:00
Mike McQuaid
03c861b7d7
Merge pull request #10428 from SeekingMeaning/cask-reverse-migration
cask/audit: disallow new cask to have token in tap_migrations.json
2021-01-27 15:07:13 +00:00
Mike McQuaid
3724c739f8
cleanup_spec: inline path creation.
Let's see if this makes the test more reliable.
2021-01-27 15:06:06 +00:00
Mike McQuaid
3ebc64a71d
rubocop_rspec: don't autocorrect focus.
It's annoying to have these autoremoved.
2021-01-27 15:04:35 +00:00
Mike McQuaid
da94957b01
tests: verbose tests with --verbose or --debug.
The `VERBOSE_TESTS` variable was from cask and never gets set (and
is unset by `bin/brew`). Replace it with `HOMEBREW_VERBOSE_TESTS` and
set it by `--verbose` or `--debug`.

While we're here, remove an unneeded `VERBOSE` delete (as it's already
done by `bin/brew`).
2021-01-27 15:04:13 +00:00
Mike McQuaid
f38707e92a
spec_helper: fix and improve retry logic.
- always retry each test at least once (confusingly this means a retry
  count of 2 rather than 1)
- always wait at least 1 second between retries
- set a default retry metadata for integration tests rather than
  overriding any specified values
- use `example.run` rather than `example.run_with_retry` for integration
  tests because, confusingly, this avoids having the retry count be
  half what it should be (because the attempts increases by one for
  each `run_with_retry` call)
- use 4 retries for integration tests with 2**attempts*retry_wait
  (retry wait now being 2) to actually have more retries than before
  this commit (but with exponential backoff)

This should generally improve test flakiness in CI but particularly
improve the cleanup test flake we've seen recently.
2021-01-27 12:43:30 +00:00
Mike McQuaid
10a5434ef1
Merge pull request #10429 from MikeMcQuaid/yamllint
Autoformat YAML files
2021-01-27 12:15:27 +00:00
Mike McQuaid
6c68e4bcb9
Merge pull request #10432 from iMichka/shared2
ENV.shared: deprecate ncurses_define
2.7.6
2021-01-27 08:55:10 +00:00
Jonathan Chang
1862fa7854
Merge pull request #10436 from Homebrew/dependabot/bundler/Library/Homebrew/codecov-0.4.1
build(deps): bump codecov from 0.4.0 to 0.4.1 in /Library/Homebrew
2021-01-27 18:57:35 +11:00
Seeker
bd7a660328
Merge pull request #10422 from SeekingMeaning/named-args-unreadable-tests
named_args_spec: add tests for unreadable formulae/casks
2021-01-26 22:45:28 -08:00
BrewTestBot
bd7b57d2fe Update RBI files for codecov. 2021-01-27 06:18:08 +00:00
BrewTestBot
486b58b303 brew vendor-gems: commit updates. 2021-01-27 06:17:14 +00:00
dependabot[bot]
58cbc18f4f
build(deps): bump codecov from 0.4.0 to 0.4.1 in /Library/Homebrew
Bumps [codecov](https://github.com/codecov/codecov-ruby) from 0.4.0 to 0.4.1.
- [Release notes](https://github.com/codecov/codecov-ruby/releases)
- [Changelog](https://github.com/codecov/codecov-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/codecov/codecov-ruby/compare/v0.4.0...v0.4.1)

Signed-off-by: dependabot[bot] <support@github.com>
2021-01-27 06:15:04 +00:00
Michka Popoff
acb77e71f9 ENV.shared: deprecate ncurses_define
This was only used by 2 formuale in homebrew-core.
One formula did not need the flag anymore and the flag was removed
The other formula (rogue) still needs it, the flag was directly
added to the formula.

There is no reason for us to keep this method.
2021-01-26 23:09:57 +01:00
Eric Knibbe
f7a718c1fc
Merge pull request #10412 from EricFromCanada/adjust-messaging
Adjustments for message output
2021-01-26 16:50:23 -05:00
EricFromCanada
6fc116318e fixes for grammar and wording 2021-01-26 16:19:47 -05:00
EricFromCanada
99ad3350ee use single quotes around stanza and parameter names 2021-01-26 16:19:47 -05:00
EricFromCanada
2ed324ebc0 use backticks around suggested input, flags, and binaries 2021-01-26 16:19:47 -05:00
EricFromCanada
cd3cb6928b indent suggested commands on subsequent line
and combine sequential puts calls
2021-01-26 15:36:44 -05:00
EricFromCanada
2ae4f11963 reorder command flags 2021-01-26 15:36:44 -05:00
EricFromCanada
a427de5bee capitalization fixes
"curl" is the binary, while "cURL" is the umbrella project.
2021-01-26 15:36:44 -05:00
EricFromCanada
c0a753edd3 pluralize "artifacts" 2021-01-26 15:36:43 -05:00
EricFromCanada
d0ad829e43 use arrow character for UI prompts 2021-01-26 15:36:43 -05:00
EricFromCanada
2e982cd2a2 use odie when commands encounter errors 2021-01-26 15:36:43 -05:00
EricFromCanada
a72ddfdc67 remove duplicate "Error" in onoe/odie arguments 2021-01-26 15:36:43 -05:00
EricFromCanada
f5e1557154 use ofail to set Homebrew.failed 2021-01-26 15:36:43 -05:00
EricFromCanada
571179ff0e pass second argument to ohai when applicable 2021-01-26 15:36:43 -05:00
EricFromCanada
a6643b4adf fix odebug calls 2021-01-26 12:02:30 -05:00
Mike McQuaid
565becc904
Merge pull request #10430 from hyuraku/delete_HOMEBREW_REPOSITORY_and_some_variables
delete some variables after Homebrew 2.7.0 is released.
2021-01-26 16:34:08 +00:00
Seeker
c1d2aaf13a cask/audit: disallow new cask to have token in tap_migrations.json 2021-01-26 08:33:14 -08:00
hyuraku
e6eeb2cbed delete HOMEBREW_REPOSITORY & some variables 2021-01-27 00:29:43 +09:00
Nanda H Krishna
5f5930255e
Merge pull request #10417 from nandahkrishna/bump-tests
dev-cmd/bump: increase test coverage
2021-01-26 18:58:43 +05:30
Mike McQuaid
4bb1c5d546
Merge pull request #10427 from Homebrew/dependabot/bundler/Library/Homebrew/simplecov-0.21.2
build(deps): bump simplecov from 0.20.0 to 0.21.2 in /Library/Homebrew
2021-01-26 11:21:26 +00:00
Mike McQuaid
8a06a5ea4c
Merge pull request #10319 from dcow/master
install: add workaround for rosetta2 path error to msg
2021-01-26 11:18:29 +00:00
BrewTestBot
a189117bfb Update RBI files for simplecov. 2021-01-26 10:24:50 +00:00
BrewTestBot
73f5e8366a brew vendor-gems: commit updates. 2021-01-26 10:24:03 +00:00
Mike McQuaid
786a06d3ed
Library/Homebrew/install: fix whitespace. 2021-01-26 10:21:55 +00:00
Mike McQuaid
703e34f85c
Merge pull request #10420 from vszakats/patch-1
cmd/update: suppress curl warnings in certain envs
2021-01-26 10:21:23 +00:00
Mike McQuaid
00fab0294b
Merge pull request #10403 from Rylan12/zsh-completions
Generate zsh completions automatically
2021-01-26 10:19:59 +00:00
dependabot[bot]
3d8bc1d8ac
build(deps): bump simplecov from 0.20.0 to 0.21.2 in /Library/Homebrew
Bumps [simplecov](https://github.com/simplecov-ruby/simplecov) from 0.20.0 to 0.21.2.
- [Release notes](https://github.com/simplecov-ruby/simplecov/releases)
- [Changelog](https://github.com/simplecov-ruby/simplecov/blob/main/CHANGELOG.md)
- [Commits](https://github.com/simplecov-ruby/simplecov/compare/v0.20.0...v0.21.2)

Signed-off-by: dependabot[bot] <support@github.com>
2021-01-26 10:19:22 +00:00
Mike McQuaid
85b5c9d71f
Merge pull request #10425 from Homebrew/dependabot/bundler/Library/Homebrew/codecov-0.4.0
build(deps): bump codecov from 0.3.0 to 0.4.0 in /Library/Homebrew
2021-01-26 10:18:37 +00:00
Mike McQuaid
a6541dd07c
Merge pull request #10426 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-0.5.6239
build(deps): bump sorbet from 0.5.6231 to 0.5.6239 in /Library/Homebrew
2021-01-26 10:18:28 +00:00
Mike McQuaid
92d107d666
Autoformat YAML files
Extracted the `.rubocop_todo.yml` change from #10397 so thought I'd do
this to all committed (non-vendor) YAML files.
2021-01-26 10:16:32 +00:00
BrewTestBot
a6f55a5e82 Update RBI files for sorbet. 2021-01-26 07:33:15 +00:00
BrewTestBot
4c866811fc Update RBI files for codecov. 2021-01-26 07:33:05 +00:00
BrewTestBot
ddaf495715 brew vendor-gems: commit updates. 2021-01-26 07:32:24 +00:00
BrewTestBot
02b82a3362 brew vendor-gems: commit updates. 2021-01-26 07:32:16 +00:00
dependabot[bot]
de938d82dd
build(deps): bump sorbet from 0.5.6231 to 0.5.6239 in /Library/Homebrew
Bumps [sorbet](https://github.com/sorbet/sorbet) from 0.5.6231 to 0.5.6239.
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

Signed-off-by: dependabot[bot] <support@github.com>
2021-01-26 07:27:33 +00:00
dependabot[bot]
a55cb98f5c
build(deps): bump codecov from 0.3.0 to 0.4.0 in /Library/Homebrew
Bumps [codecov](https://github.com/codecov/codecov-ruby) from 0.3.0 to 0.4.0.
- [Release notes](https://github.com/codecov/codecov-ruby/releases)
- [Changelog](https://github.com/codecov/codecov-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/codecov/codecov-ruby/compare/v0.3.0...v0.4.0)

Signed-off-by: dependabot[bot] <support@github.com>
2021-01-26 07:27:09 +00:00
Jonathan Chang
b9550e25a6
Merge pull request #10367 from Homebrew/sorbet-files-update
sorbet: Update RBI files.
2021-01-26 17:23:27 +11:00