28224 Commits

Author SHA1 Message Date
Carlo Cabrera
a29098c813
Use #partition to simplify extracting compatible_universal_binaries 2021-07-21 12:05:54 +08:00
Carlo Cabrera
699051b3c3
Use #present? instead of #any? 2021-07-20 18:53:53 +08:00
Carlo Cabrera
663aee0a67
Fix style
The linter complained about useless assignment to
`universal_binaries_expected`. It wasn't useless, but ok.
2021-07-20 18:48:40 +08:00
Carlo Cabrera
239fd06728
Enforce universal binary check only for Homebrew/core
Also, prefer `if` to `unless`.
2021-07-20 18:40:19 +08:00
Carlo Cabrera
55cc1eb8b0
Check tap_audit_exception only if tap is present 2021-07-20 13:08:15 +08:00
Carlo Cabrera
1678a3785e
Fix logic in check_binary_arches 2021-07-20 12:35:09 +08:00
Carlo Cabrera
7b74730f9d
formula_cellar_checks: fix universal binary handling
The `check_binary_arches` audit will fail any formula that produces
universal binaries. We have a handful of formulae in Homebrew/core that
do this (see any formula that does `ENV.permit_arch_flags`, for
example). Moreover, some third party taps may have their own formulae
that build universal binaries.

I've updated the check so that it ignores a formula that produces
universal binaries whenever the formula is in the appropriate allowlist.
We'll need to create one in Homebrew/core for the handful of formulae
that do (expectedly) build universal binaries.

If we don't want to maintain an allowlist, we can easily modify this to
pass over any formulae that builds compatible universal binaries.

I've also fixed the spacing of the error this audit produces whenever
there is more than one file that fails the audit.
2021-07-20 12:15:59 +08:00
Carlo Cabrera
608e501756
Merge pull request #11736 from carlocab/search-repology
cmd/search: add repology
2021-07-20 08:03:13 +08:00
Carlo Cabrera
16b01d6e01
Merge pull request #11737 from carlocab/audit-arches
formula_cellar_checks: check keg for mismatched arches
3.2.3
2021-07-19 20:15:08 +08:00
Mike McQuaid
4c3a8c7e5a
Merge pull request #11740 from ylht/master
cmd/doctor: repair `xattr` not find
2021-07-19 12:53:30 +01:00
ylht
75a38b7187 refactor the format 2021-07-19 10:02:19 +08:00
ylht
e5986dba6c cmd/doctor: repair xattr not find 2021-07-19 09:55:30 +08:00
Carlo Cabrera
d696250ddb
Fix ELF architecture offset for x86_64
The current offset results in ELF binaries returning an `#arch` of
`:dunno`.

Also, skip the `check_binary_arches` audit on the generic OS.
2021-07-18 16:55:57 +08:00
Carlo Cabrera
488ccfdf70
formula_cellar_checks: check keg for mismatched arches
There have been a few instances I've noticed that we've been silently
installing binaries built for x86_64 on ARM. There's probably more that
I haven't found yet, so it seems useful to check this with an audit.
2021-07-18 11:44:37 +08:00
Carlo Cabrera
822170a766
cmd/search: add repology
I often find myself checking Repology to quickly reference how other
package managers handle certain things, so it seems useful to be able to
do so with `brew search`.

While we're here, let's fix the query URL for MacPorts.
2021-07-18 09:22:34 +08:00
Rylan Polster
12d272abe8
Merge pull request #11733 from Rylan12/fix-update-report-reporting
update-report: still report homebrew/core changes if they are updated
2021-07-17 13:17:01 -04:00
Rylan Polster
aaaf92b905
update-report: still report homebrew/core changes if they are updated 2021-07-17 12:48:02 -04:00
Rylan Polster
dbcd764968
Merge pull request #11730 from Rylan12/fix-latest-version-installed
formula: fix `latest_version_installed?` for `HOMEBREW_JSON_CORE`
2021-07-16 12:52:56 -04:00
Rylan Polster
672f6dc3d7
formula: fix latest_version_installed? for HOMEBREW_JSON_CORE 2021-07-16 12:14:15 -04:00
Rylan Polster
9de68d7dce
Merge pull request #11729 from Rylan12/fix-update-report
update-report: don't try to report Homebrew/core if not needed
2021-07-16 12:05:58 -04:00
Rylan Polster
a1ecb02736
update-report: don't try to report Homebrew/core if not needed 2021-07-16 11:35:51 -04:00
Eric Knibbe
fba8dd6705
Merge pull request #11713 from EricFromCanada/version-new-suffix
version: check for both cases in suffix
2021-07-16 08:48:04 -04:00
Mike McQuaid
d79cd8bd28
Merge pull request #11726 from hyuraku/installed_dependents-reject_build_formula
installed_dependents: reject build formula
2021-07-16 13:42:03 +01:00
EricFromCanada
5519a0b379
version: check for both cases in suffix 2021-07-16 08:28:15 -04:00
Mike McQuaid
ba8c4ce89f
installed_dependents: tweak comment. 2021-07-16 13:13:12 +01:00
hyuraku
2888d050f7 reject build and test dependency 2021-07-16 21:02:38 +09:00
Rylan Polster
a7c49bfa44
Merge pull request #11728 from Homebrew/sync-triage-config
Synchronize triage configuration
2021-07-16 02:31:46 -04:00
BrewTestBot
f4c6bfdf37
triage-issues.yml: update to match main configuration 2021-07-16 05:56:27 +00:00
Rylan Polster
a4e093ded0
Merge pull request #11715 from Rylan12/json-improvements
Improvements to JSON bottle handling
2021-07-16 01:50:59 -04:00
Nanda H Krishna
83821cf4df
Merge pull request #11719 from nandahkrishna/commands
commands: remove `diy`, add `lc` alias for `livecheck`
2021-07-15 23:32:15 +05:30
hyuraku
a61d1a7072 repair CaskDependent#runtime_dependencies 2021-07-15 23:49:41 +09:00
hyuraku
3a6c998ad7 repair style and comment 2021-07-15 22:40:32 +09:00
Mike McQuaid
331fe33e6d
Merge pull request #11717 from MikeMcQuaid/docs-usr-local
docs: update /usr/local references.
2021-07-15 14:24:34 +01:00
hyuraku
5de162f71a installed_dependents: reject build formula 2021-07-15 21:48:21 +09:00
Rylan Polster
2524e80196
Revert outdated changes to brew info 2021-07-14 18:20:23 -04:00
Rylan Polster
fb04053833
info: show accurate bottle information 2021-07-14 18:16:23 -04:00
Nanda H Krishna
030d8df400
Merge pull request #11721 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-ast-1.8.0
build(deps): bump rubocop-ast from 1.7.0 to 1.8.0 in /Library/Homebrew
2021-07-15 00:01:42 +05:30
BrewTestBot
c9ddbc3780
Update RBI files for rubocop-ast. 2021-07-14 18:09:38 +00:00
BrewTestBot
f455c3a3a9
brew vendor-gems: commit updates. 2021-07-14 18:07:33 +00:00
dependabot[bot]
44677fe373
build(deps): bump rubocop-ast from 1.7.0 to 1.8.0 in /Library/Homebrew
Bumps [rubocop-ast](https://github.com/rubocop-hq/rubocop-ast) from 1.7.0 to 1.8.0.
- [Release notes](https://github.com/rubocop-hq/rubocop-ast/releases)
- [Changelog](https://github.com/rubocop/rubocop-ast/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-ast/compare/v1.7.0...v1.8.0)

---
updated-dependencies:
- dependency-name: rubocop-ast
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-07-14 18:03:20 +00:00
Nanda H Krishna
72e9aef88f
Update manpages and completions 2021-07-14 22:00:01 +05:30
Nanda H Krishna
5ec685951e
commands: remove diy, add lc for livecheck 2021-07-14 21:55:38 +05:30
Rylan Polster
3e01e02a02
Improvements based on code review 2021-07-14 10:19:29 -04:00
Rylan Polster
c5df900936
BottleAPI: support :all bottles 2021-07-14 10:14:48 -04:00
Mike McQuaid
f76ffa2eaa
docs: tweak wording/formatting.
Co-authored-by: Eric Knibbe <enk3@outlook.com>
2021-07-14 14:22:31 +01:00
Mike McQuaid
f06354a633
Merge pull request #11718 from MikeMcQuaid/bottle_chmod_symlinks_macos
dev-cmd/bottle: fixup macOS symlink permissions.
2021-07-14 12:12:25 +01:00
Mike McQuaid
82c5756690
dev-cmd/bottle: use native Ruby.
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
2021-07-14 11:45:03 +01:00
Mike McQuaid
721ed8542b
dev-cmd/bottle: fixup macOS symlink permissions.
These can be changed on macOS but not on Linux so we need to make them
consistent in both places for `all:` bottles to have consistent
checksums.

I investigated adding to `cleaner.rb` to fix these symlink permissions
on installation but it seems it already happens by default when
extracting so there's no need.
2021-07-14 10:31:25 +01:00
Mike McQuaid
0a8167d2dc
docs: update /usr/local references.
Update or remove these based on our latest state.
2021-07-14 10:11:27 +01:00
Mike McQuaid
cb84000e72
Merge pull request #11716 from MikeMcQuaid/update_sponsors
README: update sponsors.
2021-07-14 09:12:22 +01:00