Sam Ford
9bfe423a5a
Xml: Add #element_text method
...
This refactors verbose code in the `Sparkle` strategy where we access
element text into a reusable `Xml#element_text` method, replacing
chained calls like `item.elements["title"]&.text&.strip&.presence`
with `Xml.element_text(item, "title")`.
`#element_text` is only used to retrieve the text of a child element
in the `Sparkle` strategy but it can also retrieve the text from the
provided element if the `child_path` argument is omitted (i.e.,
`Xml.element_text(item)`). This will allow us to also avoid similar
calls like `item.text.strip.presence` in the future.
2023-11-17 22:34:12 -05:00
Bo Anderson
5fa5f3b0aa
Merge pull request #16230 from Homebrew/dependabot/bundler/Library/Homebrew/public_suffix-5.0.4
...
build(deps): bump public_suffix from 5.0.3 to 5.0.4 in /Library/Homebrew
2023-11-17 18:36:13 +00:00
BrewTestBot
2a3341acb3
Update RBI files for public_suffix.
...
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml ) workflow.
2023-11-17 18:16:48 +00:00
BrewTestBot
a4962a6677
brew vendor-gems: commit updates.
2023-11-17 18:10:48 +00:00
dependabot[bot]
dfb7a6371e
build(deps): bump public_suffix from 5.0.3 to 5.0.4 in /Library/Homebrew
...
Bumps [public_suffix](https://github.com/weppos/publicsuffix-ruby ) from 5.0.3 to 5.0.4.
- [Changelog](https://github.com/weppos/publicsuffix-ruby/blob/main/CHANGELOG.md )
- [Commits](https://github.com/weppos/publicsuffix-ruby/compare/v5.0.3...v5.0.4 )
---
updated-dependencies:
- dependency-name: public_suffix
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-11-17 18:06:41 +00:00
Bo Anderson
e9f05fea44
Merge pull request #16232 from Bo98/vendor-gems-lock-add
...
dev-cmd/vendor-gems: git add Gemfile.lock
2023-11-17 17:58:26 +00:00
Bo Anderson
34b1f37846
dev-cmd/vendor-gems: git add Gemfile.lock
2023-11-17 17:48:26 +00:00
Mike McQuaid
78b7d7e2d6
Merge pull request #16231 from Bo98/vendor-gem-workaround
...
dev-cmd/vendor-gems: workaround Dependabot removing lockfile platforms
2023-11-17 17:02:07 +00:00
Bo Anderson
58ff22eb55
dev-cmd/vendor-gem: workaround Dependabot removing lockfile platforms
2023-11-17 16:51:03 +00:00
Mike McQuaid
b2716f09df
Merge pull request #16229 from Homebrew/sponsors-maintainers-man-completions
...
Update manpage and completions.
2023-11-17 11:53:36 +00:00
BrewTestBot
b8f9c93881
Update manpage and completions.
...
Autogenerated by the [sponsors-maintainers-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sponsors-maintainers-man-completions.yml ) workflow.
2023-11-17 11:42:12 +00:00
Bo Anderson
efc71abf97
Merge pull request #16228 from Bo98/setup_path-ruby3-fix
...
standalone/init: don't pollute environment on Ruby 3 startup
2023-11-17 11:41:49 +00:00
Mike McQuaid
41d67bb28d
Merge pull request #16196 from samford/cask/rework-livecheck_min_os-audit
...
Use Sparkle sorting/filtering in #livecheck_min_os
2023-11-17 11:41:21 +00:00
Mike McQuaid
68c660f49c
Merge pull request #16227 from Bo98/determine-all-runners
...
dev-cmd/determine-test-runner: add `--all-supported`
2023-11-17 11:41:08 +00:00
Bo Anderson
585f5cdeb3
standalone/init: don't pollute environment on Ruby 3 startup
2023-11-17 02:17:13 +00:00
Bo Anderson
508fc2a0e3
workflows/doctor: use brew determine-test-runners
2023-11-17 02:11:01 +00:00
Bo Anderson
ca549fa10d
dev-cmd/determine-test-runner: add --all-supported
2023-11-17 02:11:01 +00:00
Bo Anderson
146b987faa
Merge pull request #16226 from Bo98/lockfile-platform
...
Gemfile.lock: restore missing platform
2023-11-17 01:57:55 +00:00
Bo Anderson
71f0533b17
Gemfile.lock: restore missing platform
2023-11-17 01:46:43 +00:00
Sam Ford
75ce7240fc
Sparkle: Refactor macOS os strings into constant
2023-11-16 12:05:25 -05:00
Sam Ford
491e2c4a80
Reorder #audit_min_os array for consistency
...
This change doesn't affect the behavior of the `#audit_min_os`
method and simply reorders the array members to place `plist_min_os`
before `sparkle_min_os` for the sake of consistency (using the same
order as the preceding lines).
2023-11-16 12:05:25 -05:00
Sam Ford
28451bd2bc
Use Sparkle sorting/filtering in #livecheck_min_os
...
The `#livecheck_min_os` cask audit method manually replicates some of
the `Sparkle` strategy's behavior but in an incomplete way that has
lead to inappropriate audit failures at times. This reimplements it
to use `Livecheck` methods, so it will align with the `Sparkle`
strategy's behavior.
2023-11-16 12:05:24 -05:00
Sam Ford
d376b46a7d
Skip items strategy blocks in #livecheck_min_os
...
The `#livecheck_min_os` cask audit method should be skipped when a
`Sparkle` `livecheck` block contains a `strategy` block that uses
the `items` argument (instead of `item`). These `strategy` blocks
contain arbitrary logic that ignores/overrides the strategy's sorting,
so we can't identify which item would be first/newest.
2023-11-16 12:05:24 -05:00
Sam Ford
bc2ce97e5d
Sparkle: Move sorting/filtering into methods
...
We need to be able to replicate the `Sparkle` strategy's sorting
and filtering behavior in a related cask audit, so this extracts
the logic into reusable methods.
This also stores `item.minimum_system_version` as a `MacOSVersion`
object (instead of a string), so we can do proper version comparison
(instead of naive string comparison) wherever needed.
2023-11-16 12:05:24 -05:00
Sam Ford
4f469234d0
Sparkle: Ensure empty strings become nil
...
Sometimes appcasts contain empty elements/attributes and the `Item`
values end up as an empty string because of how they're handled in
`#items_from_content`. It's reasonable to expect that empty values
would be `nil` instead, so this adds `#presence` calls to ensure this
is the case.
2023-11-16 12:05:24 -05:00
Mike McQuaid
25d1f1064a
Merge pull request #16225 from Homebrew/dependabot/bundler/Library/Homebrew/unf_ext-0.0.9.1
...
build(deps-dev): bump unf_ext from 0.0.9 to 0.0.9.1 in /Library/Homebrew
2023-11-16 16:50:41 +00:00
BrewTestBot
d9c7b9f70d
Update RBI files for unf_ext.
...
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml ) workflow.
2023-11-16 16:40:04 +00:00
BrewTestBot
0f22f4ed90
brew vendor-gems: commit updates.
2023-11-16 16:35:26 +00:00
dependabot[bot]
e3355faa4d
build(deps-dev): bump unf_ext from 0.0.9 to 0.0.9.1 in /Library/Homebrew
...
Bumps [unf_ext](https://github.com/knu/ruby-unf_ext ) from 0.0.9 to 0.0.9.1.
- [Changelog](https://github.com/knu/ruby-unf_ext/blob/master/CHANGELOG.md )
- [Commits](https://github.com/knu/ruby-unf_ext/compare/v0.0.9...v0.0.9.1 )
---
updated-dependencies:
- dependency-name: unf_ext
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-11-16 16:31:25 +00:00
Patrick Linnane
e137891de4
Merge pull request #16221 from Homebrew/dependabot/github_actions/actions/github-script-7
...
build(deps): bump actions/github-script from 6 to 7
2023-11-14 18:33:12 -08:00
dependabot[bot]
f68654a77e
build(deps): bump actions/github-script from 6 to 7
...
Bumps [actions/github-script](https://github.com/actions/github-script ) from 6 to 7.
- [Release notes](https://github.com/actions/github-script/releases )
- [Commits](https://github.com/actions/github-script/compare/v6...v7 )
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-11-14 18:08:02 +00:00
Mike McQuaid
8df40f4a41
Merge pull request #16220 from Bo98/dep-install-fix
...
Don't reinstall dependency when latest already installed
2023-11-14 17:36:12 +00:00
Bo Anderson
7c20e1ef7c
Don't reinstall dependency when latest already installed
2023-11-14 17:13:34 +00:00
Mike McQuaid
75e8376816
Merge pull request #16219 from Homebrew/sync-triage-config
...
Synchronize triage configuration
2023-11-14 12:47:28 +00:00
Carlo Cabrera
d26056bd9f
Merge pull request #16210 from carlocab/vendor-symlinks
...
dev-cmd/vendor-gems: fix creation of broken symlinks
2023-11-14 20:36:03 +08:00
BrewTestBot
4d5eedcd4d
triage-issues.yml: update to match main configuration
2023-11-14 12:35:36 +00:00
Carlo Cabrera
d15ccaf92f
dev-cmd/vendor-gems: fix creation of broken symlinks
...
When the target symlink already points to an existing directory, the
`#ln_sf` call creates the symlink inside the intended target directory
(which is not what we intend to do here).
Let's fix that.
Closes #16205
2023-11-14 16:25:26 +08:00
Bo Anderson
6de29c2f65
Merge pull request #16218 from Bo98/env-shared-macos-fix
...
ENV/shared: fix macOS code not applying under HOMEBREW_SORBET_RUNTIME
2023-11-14 02:27:38 +00:00
Bo Anderson
63a8474ad7
ENV/shared: fix macOS code not applying under HOMEBREW_SORBET_RUNTIME
2023-11-14 02:10:26 +00:00
Rylan Polster
b58c93a234
Merge pull request #16217 from Homebrew/sponsors-maintainers-man-completions
...
Update manpage and completions.
2023-11-13 19:19:35 -05:00
BrewTestBot
9387085798
Update manpage and completions.
...
Autogenerated by the [sponsors-maintainers-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sponsors-maintainers-man-completions.yml ) workflow.
2023-11-14 00:06:09 +00:00
Mike McQuaid
8f49b3ae19
Merge pull request #16216 from Rylan12/api-tap-loader-fix
...
Pass original tap to formula when loaded from the API via `TapLoader`
2023-11-13 22:41:38 +00:00
Rylan Polster
fb50cfa13d
Simplify tap assignment
2023-11-13 14:12:35 -05:00
Rylan Polster
74996ab32c
Remove new tap parameter to FormulaAPILoader
2023-11-13 14:07:34 -05:00
Rylan Polster
aa316109d9
Pass new tap to TapLoader
...
Co-authored-by: Alexander Mancevice <alexander.mancevice@hey.com>
2023-11-13 14:02:50 -05:00
Rylan Polster
237a42974b
Pass original tap to formula when loaded from the API via TapLoader
2023-11-13 13:40:44 -05:00
Mike McQuaid
d72ee37f60
Merge pull request #16207 from Rylan12/api-tap-migrations
...
Refactor `TapLoader` to fix tap migrations with API
2023-11-13 13:30:25 +00:00
Rylan Polster
97b411906d
Refactor TapLoader to fix tap migrations with API
2023-11-11 16:48:05 -05:00
Patrick Linnane
d3d51d3448
Merge pull request #16206 from Homebrew/dependabot/bundler/Library/Homebrew/unf_ext-0.0.9
...
build(deps-dev): bump unf_ext from 0.0.8.2 to 0.0.9 in /Library/Homebrew
2023-11-11 10:15:47 -08:00
BrewTestBot
95da53d7d7
Update RBI files for unf_ext.
...
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml ) workflow.
2023-11-11 17:58:02 +00:00
