Jack Nagel
95ab813b35
Fix Formula#installed_prefix logic
...
Due to the precedence of "and" relative to "||", this was not working as
intended; but because #version influences #prefix, the outcome was still
correct. So we can simplify this method quite a bit, and take the
opportunity to share code with #prefix.
2013-05-25 19:24:08 -05:00
Jack Nagel
8407ad2356
Add tests for Formula#installed_prefix
2013-05-25 17:19:19 -05:00
Jack Nagel
4adecd73b6
tests: extract common formula helper
2013-05-25 17:19:18 -05:00
Jack Nagel
05f92b5c98
build: expand dependencies only once
...
Closes Homebrew/homebrew#20081 .
2013-05-25 15:27:10 -05:00
Jack Nagel
12158b201d
build: expand requirements only once
2013-05-25 15:26:55 -05:00
Jack Nagel
f264d5a93c
build: make deps an attribute of Build
2013-05-25 15:26:55 -05:00
Jack Nagel
67694b8c60
build: move build methods into a class
2013-05-25 15:26:55 -05:00
Jack Nagel
439a2f4fae
Dependency: use instanceof? in eql?
...
This matches the eql? definition for requirements.
2013-05-25 14:25:24 -05:00
Mike McQuaid
a75aff246e
Remove cat_without_underscores bottle methods.
2013-05-25 16:02:18 +01:00
Jack Nagel
6f6d4e5894
doctor: style nits
2013-05-24 19:53:39 -05:00
Jack Nagel
dd9346ada2
outdated: yield version list rather than recreate it
2013-05-24 11:13:27 -05:00
Jack Nagel
92857a7bd8
Define inspect on Option and Options
2013-05-24 10:56:02 -05:00
Jack Nagel
5f38c19ba8
upgrade: fix expansion of options for top-level formula objects
...
Fixes Homebrew/homebrew#20045 .
2013-05-24 10:33:08 -05:00
Mike McQuaid
404845eaeb
Remove default_formula from MPIDependency.
...
Closes Homebrew/homebrew#19966 .
2013-05-24 11:47:07 +01:00
Jack Nagel
04d0cea01c
Directory, not folder
2013-05-23 23:33:36 -05:00
Jack Nagel
8b98e83347
doctor: reorganize check_for_macgpg2
2013-05-23 23:28:16 -05:00
Jack Nagel
187b9c9d59
doctor: simplify trailing slash checks
2013-05-23 23:07:20 -05:00
Jack Nagel
6a020239d1
doctor: extract helper from stray file checks
2013-05-23 22:57:00 -05:00
Misty De Meo
8559725645
MacOS::Xcode.latest_version: add Tiger
2013-05-23 18:44:50 -05:00
Adam Vandenberg
aec45a6ee6
correct an indent
2013-05-23 12:50:31 -07:00
Jack Nagel
1194880cf2
doctor: fix check_for_broken_symlinks
...
Fixes Homebrew/homebrew#20000 .
2013-05-23 11:28:16 -05:00
Adam Vandenberg
46d2b2165a
Allow brew log on deleted formulae.
...
Closes Homebrew/homebrew#19995 .
2013-05-23 09:21:33 -07:00
Jack Nagel
42c02a894d
doctor: remove stale OS version check
...
Closes Homebrew/homebrew#19959 .
2013-05-22 23:33:22 -05:00
Jack Nagel
dd280cc0b1
MacOS.version in case statement doesn't work with ranges
2013-05-22 22:59:38 -05:00
Jack Nagel
3755b33a97
Refactor Xcode/CLT version checks
2013-05-22 22:30:38 -05:00
Jack Nagel
b2ff6e934b
Use implicit begin
2013-05-22 19:58:11 -05:00
Jack Nagel
b24f8e2c9e
Hoist requires out of methods
2013-05-22 19:53:05 -05:00
Daniel Lee Harple
471502bc06
Remove unnecessary rescue-all exception handling
...
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2013-05-22 19:53:05 -05:00
Daniel Lee Harple
08388b149e
Added support for a GitHub Personal API Access token
...
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2013-05-22 19:53:05 -05:00
Daniel Lee Harple
0fa5c47d7f
Check GitHub API rate limit instead of silently failing
...
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2013-05-22 19:53:04 -05:00
Daniel Lee Harple
222f96d37b
Pass a User-Agent when fetching data from the GitHub API
...
See <http://developer.github.com/v3/#user-agent-required >.
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2013-05-22 19:53:01 -05:00
Jack Nagel
0bf35a05a9
Favor equality check over nil check
2013-05-22 19:42:43 -05:00
Jack Nagel
da2b5cf5ab
Extract name repair logic from fix_install_names
2013-05-22 11:40:57 -05:00
Jack Nagel
2488cfa55a
Factor out MacOS.locate("install_name_tool") calls
2013-05-22 11:11:32 -05:00
Jack Nagel
0147ac70c6
Fix CompilerSelector tests on systems that have gcc 4.0
2013-05-21 22:44:23 -05:00
Jack Nagel
0e81c4de9c
Formula: move pin methods somewhere less intrusive
2013-05-21 22:41:21 -05:00
Misty De Meo
6e3cb9f735
Add gcc 4.0 to CompilerSelector compiler queue
2013-05-20 23:25:15 -05:00
Misty De Meo
4fdbb2d685
CompilerSelector: raise when no compatible compiler
...
This replaces the old behaviour of falling back to the original
compiler with no messaging.
Fixes Homebrew/homebrew#19170 .
Fixes mistydemeo/tigerbrew#45 .
2013-05-20 23:25:15 -05:00
Jack Nagel
c9ce32d0f1
Simplify implementation of ARGV.flag? and .switch?
2013-05-20 22:34:54 -05:00
Jack Nagel
863d2b253a
Add test for ARGV.flag?
2013-05-20 22:34:53 -05:00
Jack Nagel
007d174f43
build: use ARGV.interactive? instead of .flag?
2013-05-20 22:34:53 -05:00
Jack Nagel
92b6bcb77d
link: extract keg-only check into a helper method
2013-05-20 21:55:01 -05:00
Misty De Meo
5d48f46178
MacOS::Version: add :tiger
2013-05-20 18:41:49 -05:00
Jack Nagel
bf935a1fa5
Version: dup @version in #to_s
2013-05-19 20:51:25 -05:00
Jack Nagel
4276d03fe4
Fix set_cpu_flags invocations in ENV.fortran
...
Fixes Homebrew/homebrew#19013 .
Fixes Homebrew/homebrew#19862 .
Fixes Homebrew/homebrew#19921 .
2013-05-19 11:18:53 -05:00
Jack Nagel
40dedcec70
upgrade: fix typo
2013-05-18 22:11:19 -05:00
Jack Nagel
a10cda77be
upgrade: use a method rather than a boolean flag
2013-05-18 22:09:15 -05:00
Jack Nagel
26a076eef5
upgrade: tighten installed precondition
2013-05-18 22:09:15 -05:00
Jack Nagel
3687cbc21b
Remove gsutil
...
This is now available from PyPI, and the github tarball does not contain
all of the necessary dependencies, so remove it and recommend "pip
install gsutil".
Closes Homebrew/homebrew#19874 .
Closes Homebrew/homebrew#19895 .
2013-05-18 20:27:15 -05:00
Jack Nagel
277f3d3c30
Stop running "prune" as part of "cleanup"
...
Rationale: "prune" is slow, does not need to be run as often as
"cleanup", and is potentially destructive to things like empty
directories that Homebrew did not create. Thus we should let users run
`brew prune` only when they wish to, while still being able to use `brew
cleanup`.
Closes Homebrew/homebrew#19863 .
2013-05-18 20:22:24 -05:00
