lionellloh
7358dd7bba
style fixes
2020-06-30 23:25:51 +08:00
lionellloh
1422542a07
components_order and test
2020-06-30 23:18:04 +08:00
Rylan Polster
35a8c33690
Update shell metacharacter list
2020-06-30 10:18:49 -04:00
Michka Popoff
8d55c87adb
components order: fix audit and add test
2020-06-30 08:36:11 +01:00
Rylan Polster
d921e94a2b
rubocop: separate args for shell commands
...
Use `system "foo", "bar"` instead of `system "foo bar"`. Also applies to
`Utils.popen_read` and `Utils.popen_write` commands. RuboCop can
automatically fix these problems.
2020-06-29 13:26:58 -04:00
Mike McQuaid
58de51f2ce
Merge pull request #7837 from FTLam11/7392-migrate-audit-rules-to-rubocop
...
audit: Move patch checks from brew audit to rubocop
2020-06-27 13:11:51 +01:00
Mike McQuaid
21069e3797
Merge pull request #7696 from Rylan12/audit-shell-variables
...
style: set shell variables in hash
2020-06-27 13:10:35 +01:00
Rylan Polster
e82084583a
style: set shell variables in hash
...
When running Utils.popen (or similar popen command), having a line like
"SHELL=bash ..." doesn't work properly. Instead, use:
`Utils.popen({ "SHELL" => "bash" }, "...")`
2020-06-26 16:39:39 -04:00
Frank Lam
ffb1cc8e19
Find patch nodes nested inside blocks
2020-06-27 03:13:50 +08:00
Frank Lam
afb8445380
Add inline patch checks to patches cop
2020-06-27 01:10:52 +08:00
Rylan Polster
9520eabc35
style: enforce ISO-8601 in deprecation date
2020-06-26 11:53:42 -04:00
Rylan Polster
59f622d4ba
Merge pull request #7823 from Rylan12/rubocop-dstr-string-content
...
RuboCop string_content keep string interpolation
2020-06-25 12:19:27 -04:00
Rylan Polster
cb187f6846
RuboCop string_content keep string interpolation
2020-06-25 09:05:43 -04:00
Mike McQuaid
ac0665daff
Refer to default branch in links with HEAD
...
Anywhere we can use `blob/master` we can use `blob/HEAD` instead. This
will make life easier if we ever rename our default branch in future
(once/if Git and GitHub provides the necessary tooling to do so).
2020-06-25 11:38:40 +01:00
Rylan Polster
0faf17b1e6
use safe_popen_read instead of popen_read
...
RuboCop requires using Utils.safe_popen_read and Utils.safe_popen_write
instead of Utils.popen_read and Utils.popen_write respectively.
Using the "safe" version means that an error will be shown if the
command fails. Previously, when using `popen_read`, a failed command can
go unnoticed and have negative consequences that go undetected (as
happened for pipend in
https://github.com/Homebrew/homebrew-core/pull/55682 )
RuboCop does not require Utils.safe_popen_read in a test do block
because there can be some legitimate uses for Utils.popen_read in these
cases.
2020-06-23 13:57:33 -04:00
Dario Vladovic
8a62f891e1
formula: add std_cargo_args
2020-06-22 14:39:49 +02:00
Michka Popoff
7b25b99995
uses_from_macos: allow ed
2020-06-15 23:50:54 +02:00
Issy Long
0041ea21f5
Change occurrences of "whitelist" to "allowlist"
2020-06-06 22:38:32 +01:00
Michka Popoff
c494528f15
on_os_blocks: add audit
2020-06-04 17:36:28 +02:00
Mike McQuaid
aa81982aba
brew style --fix
2020-06-02 09:49:23 +01:00
nandahkrishna
6f37dc4c41
livecheck: modified urls cop
2020-05-24 20:16:44 +05:30
Mike McQuaid
ca47992a6c
Fix rubocop-performance brew style.
2020-05-22 08:52:26 +01:00
Mathäus Zingerle
bb9665ced8
Migrate scheme checks for cvs, bzr, hg, fossil, and svn+http to Rubocop
2020-05-20 20:52:00 -05:00
Mathäus Zingerle
82ba0475ad
audit: Port version checks that do not rely on Formula state to RuboCop and add tests
2020-05-18 10:12:13 -05:00
nandahkrishna
a4f9a66406
livecheck: add component order rubocop
2020-05-15 19:00:14 +05:30
Mike McQuaid
12bdb38663
rubocop: brew style --fix autocorrections.
2020-05-12 08:32:27 +01:00
vidusheeamoli
f851688541
audit: Port audit_keg_only to rubocop and add tests
...
audit: add test
audit: fixed test
audit: added another test case
audit: fix test
audit: fix test
audit: fix keg only
2020-05-05 10:47:49 +05:30
Mike McQuaid
e6dffdd006
Merge pull request #7458 from Bo98/uses_since
...
software_spec: add uses_from_macos since bound
2020-05-01 12:53:59 +01:00
Luke Lau
0500dd572c
rubocops/urls: whitelist ghc@8.8
2020-04-30 15:05:14 +01:00
Bo Anderson
eb303dd654
software_spec: add uses_from_macos since bound
2020-04-28 16:45:32 +01:00
Shaun Jackman
ffb405019d
uses_from_macos: Add gzip rsync to the white list
...
/usr/bin/gzip and /usr/bin/rsync are provided by macOS.
2020-04-20 11:52:58 -07:00
Mike McQuaid
cddc67b451
rubocops/uses_from_macos: update list.
...
Also, provide details on how to update this in future and split it into
two.
Fixes #7396
2020-04-20 10:36:42 +01:00
Mike McQuaid
8eed72cd8b
Move file mode audit to RuboCop.
2020-04-18 15:44:24 +01:00
Jonathan Chang
d6cf14fd1e
audit: add libiconv to uses_from_macos whitelist
...
This lives at /usr/lib/libiconv.dylib
2020-04-18 21:39:39 +10:00
Mike McQuaid
604434566f
rubocops/text: whitelist goose.
2020-04-14 11:59:56 +01:00
Mike McQuaid
3b9a8cb8c1
rubocops/lines: fix rule.
...
This stops stuff like `clang=1` from being matched incorrectly.
2020-04-14 11:59:41 +01:00
Mike McQuaid
d52e870b07
rubocop: remove NewFormulaAudit.
...
This is no longer used anywhere.
2020-04-13 16:01:26 +01:00
Mike McQuaid
44c22dd7e3
rubocops/text: re-add strict cop.
2020-04-13 16:01:26 +01:00
Mike McQuaid
632813d969
rubocops/patches: reduce required revision length.
2020-04-13 16:01:26 +01:00
Mike McQuaid
ea77fce409
rubocops/lines: move strict cop.
2020-04-13 16:01:25 +01:00
Mike McQuaid
9b5a0767cb
rubocops/formula_desc: merge cops, slim whitelist.
2020-04-13 16:01:25 +01:00
Mike McQuaid
476a61f51c
rubocops/class: rename, move cops, readd strict.
2020-04-13 16:01:25 +01:00
Mike McQuaid
b75733f1bd
rubocops: downgrade strict cops (passing in core).
2020-04-12 14:17:06 +01:00
Mike McQuaid
45908d8ff2
uses_from_macos: update openssl in whitelist.
2020-04-12 14:17:05 +01:00
Mike McQuaid
fbeeae96ef
rubocops/text: check openssl and openssl@1.1.
2020-04-12 14:17:05 +01:00
Mike McQuaid
3ded55aec2
rubocops/options: refactor unless ==.
2020-04-12 14:17:05 +01:00
Mike McQuaid
20998ed6e3
rubocop/lines: extract whitelist to constant.
2020-04-12 14:17:05 +01:00
Mike McQuaid
2e74e50f82
rubocop/conflicts: use full name in whitelist.
2020-04-12 14:17:05 +01:00
Mike McQuaid
c5b8983da4
rubocops/class: refactor unless &&
2020-04-12 14:17:04 +01:00
Sean Molenaar
84181f2068
Audit: allow make check for nettle
2020-04-08 19:08:15 +02:00
