332 Commits

Author SHA1 Message Date
Rylan Polster
97b1b75dc5 style: forbid one line nested license expressions 2020-08-20 11:20:04 -04:00
Rylan Polster
ef447a38c6 style: convert from license array to license hash 2020-08-20 10:58:36 -04:00
Mike McQuaid
3a91c37e66
Fix RuboCop checks. 2020-08-19 17:12:32 +01:00
Markus Reiter
750e299d49 Don't take name into account when calculating description length. 2020-08-15 00:16:56 +02:00
Markus Reiter
62ae16bfa8 Allow iOS and iPhone at the beginning of descriptions. 2020-08-13 18:18:03 +02:00
Alexander Bayandin
8142bf2797 rubocop/urls: add go@1.14 to binary URLs allowlist 2020-08-12 15:35:20 +01:00
Markus Reiter
9ed16681f3 Fix Desc cop for casks. 2020-08-12 01:07:03 +02:00
Waldir Pimenta
c66fa42efd Add language stanza to cask rubocops
Also fix the corresponding test
2020-08-09 22:07:31 +01:00
Waldir Pimenta
1b71d99f45 Fix order and grouping of cask stanzas
- Put `desc` stanza after the `name` stanza
- Add missing `vst3_plugin` stanza to the group containing `vst_plugin`
2020-08-09 18:27:59 +01:00
Markus Reiter
3b86e1f9c1 Implement RuboCop for cask desc stanza. 2020-08-08 23:04:24 +01:00
Waldir Pimenta
fc6813f094 Extract formula desc auditing code to a separate module
The extracted module will be used for Cask descs as well.

Co-authored-by: Markus Reiter <me@reitermark.us>
2020-08-08 23:02:39 +01:00
Waldir Pimenta
ffed8fdbb3 Add a desc stanza to the cask DSL 2020-08-08 23:02:23 +01:00
Waldir Pimenta
db7ffe21f1 Fix URL of the documentation for stanza order and grouping 2020-08-08 23:01:52 +01:00
Markus Reiter
5d3881e1ab Don't skip RuboCop on non-existent ARGV methods. 2020-08-06 16:28:07 +02:00
Dustin Rodrigues
5157c08327 style: clarify GitHub .git error message 2020-08-05 01:00:36 -04:00
Dustin Rodrigues
1c5e73a578 style: autocorrect readthedocs and GitHub .git homepages 2020-08-04 09:45:18 -04:00
Dustin Rodrigues
de8cc4106a style: don't allow PR/MR urls for patches 2020-08-01 16:20:46 -04:00
Dustin Rodrigues
af3ea7d5aa Revert "style: don't allow PR/MR urls for patches"
This reverts commit 7a2483728c18e9cfb45e4b3f079687ec5a8e1503.
2020-07-28 21:20:46 -04:00
Dustin Rodrigues
7a2483728c style: don't allow PR/MR urls for patches 2020-07-28 10:18:26 -04:00
Mike McQuaid
25db60ebbb
Unify (mostly) Homebrew code style
Make the Homebrew/cask and Homebrew/homebrew-core style more closely
match the rest of Homebrew.

To accomplish this:
- Run `brew cask style` to ensure we don't break style there when
  making changes or upgrading RuboCop in Homebrew/brew.
- Fix the HomepageMatchesUrl cop to better handle weird input.
- Remove the now unneeded `.rubocop_shared.yml`
- Fix the cask fixtures with `brew cask style --fix`.
- Share more style between Homebrew/brew, casks and formulae.
2020-07-27 12:57:40 +01:00
Dawid Dziurla
2cd72908bc
Merge pull request #7863 from iMichka/single-resource
on_os resources: allow linux-only or mac-only resources
2020-07-20 16:58:30 +02:00
Rylan Polster
70dfaf3b42 Add link to pypi downloads page to problem message 2020-07-18 14:22:05 -04:00
Rylan Polster
5f3f7d010b Require long urls for pypi and pythonhosted urls 2020-07-18 14:05:46 -04:00
Rylan Polster
936f4bbff4 refactor share path node matcher 2020-07-12 16:06:50 -04:00
Rylan Polster
d8fb850fa9 fix pkgshare missing slash issue 2020-07-12 14:20:50 -04:00
Rylan Polster
55246d720e improve style in pattern matcher 2020-07-12 14:20:05 -04:00
Rylan Polster
6119934efb style: refactor pkgshare cop 2020-07-12 12:12:36 -04:00
Rylan Polster
8c0c713d6b style: don't use build.with? for dependencies 2020-07-12 12:12:36 -04:00
Rylan Polster
074f79840c style: refactor prefix path check 2020-07-12 12:12:36 -04:00
Michka Popoff
edd1685d37 on_os resources: allow linux-only or mac-only resources
This is now allowed since #7833 has been fixed.
2020-07-10 23:16:43 +02:00
Rylan Polster
69e89d7a01 add TODOs for future refactoring 2020-07-10 15:08:20 -04:00
Rylan Polster
9e52712b08 style: don't need require "formula" 2020-07-10 11:17:37 -04:00
Rylan Polster
1a703a1234 regex_match_group: handle non UTF-8 encoded strings 2020-07-10 11:17:37 -04:00
Rylan Polster
e0b5c2093a style: refactor OptionDeclarations cop 2020-07-10 11:17:37 -04:00
Rylan Polster
1859162735 style: use pkgshare instead of share/foo 2020-07-10 11:17:37 -04:00
Rylan Polster
792533462a style: don't use prefix + directory 2020-07-10 11:17:37 -04:00
Rylan Polster
b4a9565b8b style: require java dependency for JAVA_HOME 2020-07-10 11:17:37 -04:00
Rylan Polster
9ad342eba0 style: don't concatenate in string interpolation 2020-07-10 11:17:37 -04:00
Rylan Polster
63b81d847a style: env :userpaths is deprecated 2020-07-10 11:17:37 -04:00
Rylan Polster
1e943d7b6f style: env :std deprecated in homebrew-core 2020-07-10 11:17:37 -04:00
Rylan Polster
bd8805b14f style: separate make commands 2020-07-10 11:17:37 -04:00
Michka Popoff
9c3cc31cb4 uses_from_macos: move cpio to shadowed by macos list 2020-07-08 22:59:41 +02:00
EricFromCanada
8540aaf218 audit: disallow capitalization and period in conflicts_with reason 2020-07-07 13:25:54 -04:00
Mike McQuaid
fa760a2f26
Fix brew style. 2020-07-07 13:12:37 +01:00
Mike McQuaid
720a00e68e
formula_desc: handle nil first character. 2020-07-07 12:23:29 +01:00
Michka Popoff
5b82005829 uses_from_macos: allow cpio
as it is provided by macOS
2020-07-06 23:31:39 +02:00
Mike McQuaid
6211d0da13
Merge pull request #7691 from Rylan12/popen_read-audit
style: separate shell command arguments
2020-07-06 09:15:52 +01:00
Rylan Polster
ae0d37e911 Transfer to FormulaAuditStrict 2020-07-05 13:57:49 -04:00
Rylan Polster
0786003fe9 Add tests for autocorrect 2020-07-05 12:12:36 -04:00
Rylan Polster
e252de5295 style: improve keg_only style checks 2020-07-03 14:35:32 -04:00