456 Commits

Author SHA1 Message Date
Jack Nagel
051061827c Remove outdated comment 2013-10-08 23:47:35 -05:00
Jack Nagel
424187fc15 Prefer interpolation to concatenation 2013-10-08 23:44:23 -05:00
Jack Nagel
b2516f9989 doctor: avoid using MACOS_VERSION 2013-10-08 23:32:22 -05:00
Adam Vandenberg
a126946a9b move paths to utils 2013-09-17 06:44:25 -07:00
Samuel John
a260bb1906 doctor: be more helpful with suggestion about PATH
- Show a one liner that will append to
  the user's ~/.bash_profile. In 95% this will be
  ok and we assume zsh people are smart enough
  to know what they have to do.
2013-09-03 11:44:48 +02:00
Dan Hughes
51d1a8e3c5 Use system path for more tools, for Linux compat.
Closes Homebrew/homebrew#22196.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2013-08-30 13:02:19 -07:00
Amos Wenger
52ace99f14 Use File::PATH_SEPARATOR globally instead of ':'
On Unix, the path separator is ':', whereas on Windows,
it is ';'. This is the first of a series of patch to bring
macbrew's and winbrew's codebases closer together.

The main places the magic constant ':' was being used were:
  - the $PATH environment variable
  - CMAKE-related environment variables
  - pkg-config related environment variables

Closes Homebrew/homebrew#21921.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2013-08-19 13:35:44 -05:00
Misty De Meo
f960cf94d1 Doctor: missed CLT URL replacement 2013-08-10 22:30:15 -07:00
Misty De Meo
49cd13406b Update URL for CLT download
http://connect.apple.com is still down, but
https://developer.apple.com/downloads has all of the Apple developer
downloads available.

Fixes Homebrew/homebrew#21812.
2013-08-10 22:05:18 -07:00
Samuel John
702b5e5ba2 doctor: Using Xcode-only is no longer experimental
In 10.9 we'll probably have to use that code path
anyways and by now we have adapted all formulae
to be able to build on Xcode-only.
2013-07-17 15:18:00 +02:00
Mike McQuaid
621c44dbd2 CLT is just CLT now; not "for Xcode".
References Homebrew/homebrew#17383.
2013-07-01 19:02:32 +01:00
Jack Nagel
5b75c73df6 Do this in a saner way 2013-06-29 21:36:04 -05:00
Jack Nagel
936f9487b1 doctor: don't pass pathnames to Formula.factory
Fixes Homebrew/homebrew#20908.
2013-06-29 21:26:49 -05:00
Adam Vandenberg
1cd3149677 Be explicit about passing formulae names or instances to Tab 2013-06-26 19:58:08 -07:00
Samuel John
d456d42813 doctor: share/python no longer needed in PATH
Check for HOMEBREW_PREFIX/share/python and python3
in PATH and tell about the new location and that
files from there can be removed. Also instructions
on how to upgrade python packages are given.
2013-06-19 12:27:50 +02:00
Jack Nagel
652e0982f0 Add doctor check for OS X > 10.8 2013-06-11 10:18:24 -05:00
Misty De Meo
ef054a2d02 doctor: add check for osx-gcc-installer
This might not detect all cases, but should detect the two most
common ones.
2013-06-11 08:13:24 -05:00
Jack Nagel
52d84ba7cf doctor: check git SSL settings on <= 10.5 2013-05-27 10:06:45 -05:00
Jack Nagel
00548b81ce doctor: combine git origin checks 2013-05-26 17:55:34 -05:00
Jack Nagel
255c6e7c3f doctor: combine git existence and version checks 2013-05-26 17:48:12 -05:00
Jack Nagel
6f6d4e5894 doctor: style nits 2013-05-24 19:53:39 -05:00
Jack Nagel
04d0cea01c Directory, not folder 2013-05-23 23:33:36 -05:00
Jack Nagel
8b98e83347 doctor: reorganize check_for_macgpg2 2013-05-23 23:28:16 -05:00
Jack Nagel
187b9c9d59 doctor: simplify trailing slash checks 2013-05-23 23:07:20 -05:00
Jack Nagel
6a020239d1 doctor: extract helper from stray file checks 2013-05-23 22:57:00 -05:00
Jack Nagel
1194880cf2 doctor: fix check_for_broken_symlinks
Fixes Homebrew/homebrew#20000.
2013-05-23 11:28:16 -05:00
Jack Nagel
42c02a894d doctor: remove stale OS version check
Closes Homebrew/homebrew#19959.
2013-05-22 23:33:22 -05:00
Jack Nagel
3755b33a97 Refactor Xcode/CLT version checks 2013-05-22 22:30:38 -05:00
Jack Nagel
46f8be1d9e Use Hash#each_value rather than discarding key 2013-05-11 16:06:18 -05:00
Jack Nagel
f61a4f8893 doctor: update ruby version check 2013-05-07 19:45:10 -05:00
Jack Nagel
14bc883750 doctor: update git version check 2013-05-07 19:45:10 -05:00
Misty De Meo
f4cf04b95e doctor: don't shell out in coreutils check 2013-04-25 18:23:43 -05:00
Misty De Meo
814b969963 doctor: add default-names findutils check
Fixes Homebrew/homebrew#19265.
2013-04-25 18:23:43 -05:00
Jack Nagel
010a1461f7 Avoid repeated interpolation here too 2013-04-14 23:48:20 -05:00
Jack Nagel
7f9bd7a067 doctor: 'raring' => 'ready'
It was pointed out that 'raring' is a rare word can be confusing to
non-native speakers.

Closes Homebrew/homebrew#18659, see that for details.
2013-04-12 19:32:23 -05:00
Jack Nagel
d25767b354 doctor: consolidate directory access checks
Also include a writability check for lib.

Closes Homebrew/homebrew#18571.
2013-04-12 19:32:02 -05:00
Geoff Petrie
79c745cc76 doctor: suggest brew update in outdated warning
Closes Homebrew/homebrew#19106.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2013-04-11 02:12:59 -05:00
Jack Nagel
62a0b3f18d Use #grep where it will suffice 2013-04-05 22:00:36 -05:00
Jack Nagel
ec7dc78ba4 Simplify destructuring this array 2013-03-30 15:16:44 -05:00
Jack Nagel
4a52bf1c31 Use each_key instead of keys.each 2013-03-29 21:59:02 -05:00
Adam Vandenberg
3320b15609 doctor: restore newlines between checks
Closes Homebrew/homebrew#18060.
2013-03-29 11:14:46 -07:00
Adam Vandenberg
d9f64a1574 doctor: check for all DYLD env vars 2013-03-26 16:19:55 -07:00
Samuel John
ac68de8a7e doctor: Tweak git-clean suggestion for empty dirs
git clean -f is not enough. Needs `-d` somtimes to
handle cases when we rename a dir.

Fixes Homebrew/homebrew#18544 and fixes Homebrew/homebrew#14224
2013-03-18 12:09:15 +01:00
Adam Vandenberg
69c8ed1a1e doctor: add check for coreutils in path 2013-03-13 10:22:09 -07:00
Adam Vandenberg
7b7268c065 doctor: mess with indentation 2013-03-13 09:45:55 -07:00
Misty De Meo
feb836e1ea doctor: skip git origin check without brew repo
Likely fixes Homebrew/homebrew#18324.
2013-03-11 10:30:08 -05:00
Misty De Meo
6b96102fad doctor: Update Mono pkg-config warning 2013-02-25 11:17:19 -06:00
Jack Nagel
f037be5148 Don't shadow outer local variables 2013-02-18 12:13:36 -06:00
Mike McQuaid
7766505348 brew-doctor: fix autocrlf warning (again).
Closes Homebrew/homebrew#17843.
2013-02-18 10:42:14 +00:00
Adam Vandenberg
37b28741f2 doctor: make brew link more clear
Closes Homebrew/homebrew#17805.
2013-02-12 22:30:49 -08:00