admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
22,820 Commits 15 Branches 471 Tags
Commit Graph

456 Commits

Author SHA1 Message Date
Mike McQuaid
1c176348ca doctor: add caveats to avoid scaring people. 
Sporadically people ask to whitelist doctor warnings or file issues when
there's nothing actually wrong. Help reassure such people with a
friendly message.

Closes Homebrew/homebrew#30230.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2014-06-20 11:14:35 +01:00
Jack Nagel
4f8be5bb66 Remove obsolete doctor check 
Both build environments remove MACOSX_DEPLOYMENT_TARGET by default.
 2014-06-19 19:32:37 -05:00
Jack Nagel
d9c586e201 Remove unnecessary string evals from doctor 2014-06-19 19:32:37 -05:00
Jack Nagel
b87f9b37d6 Pull requires out of methods 2014-06-19 17:55:04 -05:00
Jack Nagel
10a1952d2c Only "extend self" once on the Homebrew module 2014-06-19 13:10:36 -05:00
Jack Nagel
c0e0bd2984 Read df output in binary mode 
Fixes Homebrew/homebrew#30046.
 2014-06-11 00:42:51 -05:00
Misty De Meo
8cb980f7be doctor: Add check for install_name_tool 
Closes Homebrew/homebrew#29593.
 2014-06-03 22:50:37 -07:00
Jack Nagel
0e0bee9c50 Update ruby version doctor check 2014-06-03 11:04:07 -05:00
Jack Nagel
c5bcd99eb4 Re-enable Xcode-only support on 10.9 
Closes Homebrew/homebrew#29377.
 2014-05-19 14:41:03 -05:00
Jack Nagel
4676045bdd Less snark 2014-05-18 17:43:07 -05:00
Jack Nagel
1845b39d41 Separate Xcode and CLT doctor checks by OS X version 
Closes Homebrew/homebrew#29206.
 2014-05-12 18:59:52 -05:00
Jack Nagel
348d0eb05c doctor: use Xcode.bundle_path 2014-05-02 16:50:25 -05:00
Jack Nagel
273d580550 Apparently quiet_system isn't always quiet 
cf. Homebrew/homebrew#28918.
 2014-05-02 11:00:29 -05:00
Jack Nagel
cf5ecfc06d doctor: suppress warnings from git wrapper script 
Fixes Homebrew/homebrew#28901.
 2014-05-02 09:52:14 -05:00
Jack Nagel
86daf90700 Remove bad doctor check 2014-05-01 19:43:42 -05:00
Jack Nagel
aa5a5a526f Rename Xcode.folder to MacOS.active_developer_dir 
This reflects what Apple calls it in more recent versions of Xcode/OS X.
 2014-05-01 18:36:46 -05:00
Jack Nagel
9d02c39e23 Fix syntax error 2014-04-15 11:37:20 -05:00
Jack Nagel
a55e670a8a Remove yet another xcode-select check 2014-04-15 11:28:01 -05:00
Jack Nagel
a9461dd01b doctor: fix typo 
Fixes Homebrew/homebrew#28221.
 2014-04-07 10:03:44 -05:00
Jack Nagel
a2a75aca1a Mirror unlink logic when checking for linked keg-only formulae 2014-04-06 13:56:26 -05:00
Jack Nagel
0d3121f781 Batch up mdfind calls when possible 2014-04-01 20:47:26 -05:00
Mike McQuaid
6e86976920 Revert "doctor: use double quotes for setting PATH." 
I'm an idiot.

This reverts commit f890e4973840a66a522189c8e5530bff61d17162.
 2014-03-25 16:20:53 +00:00
Mike McQuaid
0d898edc37 doctor: use double quotes for setting PATH. 
Closes Homebrew/homebrew#27619.
 2014-03-25 16:02:19 +00:00
Adam Vandenberg
5c51c85564 Finesse doctor message for /Library Python 2014-03-05 21:29:36 -08:00
Adam Vandenberg
95d7776a90 add check for /Library Python 
Closes Homebrew/homebrew#24788.
 2014-03-01 23:19:36 -08:00
Mike McQuaid
09330dd83b doctor: tweak XQuartz check. 
Sometimes (e.g. Homebrew/homebrew#27014) it may find an installed version but no prefix.

In this case we still want to tell users if it's outdated.
 2014-02-26 12:40:25 +00:00
Adam Vandenberg
fab5e1d905 add doctor check for HOMEBREW_KEEP_INFO 2014-02-23 08:31:03 -08:00
Mike McQuaid
268e32e37c doctor: don't complain about unmigrated remote. 2013-12-17 23:40:21 +00:00
Mike McQuaid
4b7f435a00 doctor: fix autocrlf set command. 
Fixes Homebrew/homebrew#25282.
 2013-12-17 16:34:01 +00:00
Mike McQuaid
5751b9e66c doctor: add instructions for remote migration. 2013-12-17 16:25:51 +00:00
Chris Kampmeier
2635817ca8 doctor: don't let gitconfig break dirty-tree check 
`brew doctor` always complains about uncommitted modifications to
Homebrew when you have status.branch=true in your git config, because
the implicit --branch makes `git status -s` always print branch/tracking
info. The --porcelain mode is similar to -s/--short, but ignores most of
the user's config and should remain stable.

The --untracked-files option ensures we'll see untracked files even for
users with status.showUntrackedFiles=no, which is not suppressed by
--porcelain for some reason.

Closes Homebrew/homebrew#25230.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2013-12-15 17:20:45 +00:00
Mike McQuaid
a1728a8174 doctor: check for migrated origin Git remote. 
Closes Homebrew/homebrew#25211.
 2013-12-14 23:11:16 +00:00
Mike McQuaid
4c2e7b1659 Update docs, comment mxcl/homebrew refs. 2013-12-14 18:18:35 +00:00
Jack Nagel
c6c7b9b165 Extract HOMEBREW_TEMP constant 2013-12-14 09:35:58 -06:00
Misty De Meo
775406be91 brew: error out if bad xcode-select path given 
Since a bad xcode-select path can cause many brew commands to freeze,
it's worth warning users and bailing out as early as possible.

The doctor check wasn't good enough, since the doctor could freeze
before the warning about this was ever printed.
 2013-12-13 08:52:29 -08:00
Bovard Tiberi
569bd7c425 doctor: fix PATH issues in comments 
Closes Homebrew/homebrew#25170.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2013-12-12 20:07:39 -06:00
Jack Nagel
109e9dc58b Silence some Ruby 2.1 warnings 2013-12-09 13:44:45 -06:00
Jack Nagel
8b7ddc1fed XQuartz 2.7.5 released 
Closes Homebrew/homebrew#24173.
 2013-11-12 10:12:41 -06:00
Jack Nagel
4cbaeb6d61 Clarify XQuartz warning 
Closes Homebrew/homebrew#24094.
 2013-11-09 19:04:46 -06:00
William Entriken
0f87351a0e doctor: quoting fix 
The one liner should put `#{HOMEBREW_PREFIX}/bin:$PATH` into bash profile.
Previously it was being interpreted by the shell before being put in bash profile.

Closes Homebrew/homebrew#24008.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
 2013-11-06 06:29:36 -08:00
Misty De Meo
f643b84dc4 Doctor: fix check_access_logs 
Fixes Homebrew/homebrew#23936.
 2013-11-03 18:51:22 -08:00
Mike McQuaid
37e2005e79 Use HOMEBREW_LOGS more consistently. 2013-10-31 17:02:20 -07:00
Mike McQuaid
d9d2443d5d Cleanup use of some global constants. 2013-10-30 13:20:48 -07:00
Mike McQuaid
8e75e3e043 doctor: strengthen osx-gcc-installer warning. 
We hate it and we should tell people why.
Next step may be blocking it altogether.
 2013-10-30 11:28:38 -07:00
Mike McQuaid
a252c90a0d doctor: ensure git --version actually matches. 
Closes Homebrew/homebrew#23791.
 2013-10-30 10:34:04 -07:00
Mike McQuaid
ed3343565a doctor: require CLT on 10.9. 
Xcode-only setup is badly broken and will remain that way until fixed by
Apple. For many 10.9 issues this fixes things so let's tell the users.
 2013-10-25 21:33:26 +01:00
Mike McQuaid
9ebc527e49 Improve Xcode and CLT installation instructions. 2013-10-23 17:44:43 +01:00
Jack Nagel
df824a22a7 Avoid comparing MacOS.version to floats 2013-10-22 20:47:37 -05:00
Jack Nagel
ada07d07bf doctor: remove 10.9 warning 2013-10-22 13:36:07 -05:00
Jack Nagel
9bd507b7be Remove unused variable 2013-10-08 23:58:48 -05:00