1226 Commits

Author SHA1 Message Date
L. E. Segovia
36fe355159 Add tests for upgrade recovery 2017-11-13 08:46:08 -03:00
L. E. Segovia
8cc1aea5f0 Implement @reitermarkus's upgrade flow 2017-11-11 17:21:13 -03:00
Martin Schimandl
17e001bd30 Remove (soon to be) obsolete check
Fix small typo
2017-11-10 20:16:38 +01:00
Martin Schimandl
fea5350d52 Add line break to string 2017-11-10 20:16:38 +01:00
Martin Schimandl
4e4405e6d7 split string to stay below 80 characters per line 2017-11-10 20:16:38 +01:00
Martin Schimandl
2b261ad4a7 Refactor code to reduce characters per line 2017-11-10 20:16:38 +01:00
Martin Schimandl
5eab54f892 Reduce verbosity of artifacts hash 2017-11-10 20:16:38 +01:00
Martin Schimandl
52343142a7 Remove unused variables. Refactor code 2017-11-10 20:16:38 +01:00
Martin Schimandl
d03720320a adapt internal_stanza command to work with SortedSet of Artifacts 2017-11-10 20:16:38 +01:00
Martin Schimandl
587c5b07b3 Fix handling of artifact set 2017-11-10 20:16:38 +01:00
Martin Schimandl
255e991cc3 Remove obsolete code to fix tests. 2017-11-10 20:16:38 +01:00
Martin Schimandl
db2c86204b internal_stanza.rb: Remove obsolete code. Improve detection of missing stanzas
internal_stanza_spec.rb: change do ... end blocks to { } blocks
2017-11-10 20:16:38 +01:00
Martin Schimandl
dfe4e7641a combine errors to a single if-statement. fix spec test 2017-11-10 20:16:38 +01:00
Martin Schimandl
99b7636008 Fix 'brew style' issues 2017-11-10 20:16:38 +01:00
Martin Schimandl
ff2239509d Change behaviour of 'cask _stanza' command. Add tests for 'cask _stanza' command 2017-11-10 20:16:38 +01:00
Martin Schimandl
be68f3d7b4 Fix 'brew style' offenses 2017-11-10 20:16:38 +01:00
Martin Schimandl
b7a51eab6b improve 'brew cask _stanza' by checking for known stanzas 2017-11-10 20:16:38 +01:00
L. E. Segovia
72e673afae Fix reinstall/uninstall tests 2017-11-10 11:33:44 -03:00
L. E. Segovia
522a229dbb Fix upgrade tests and some upgrade? leftovers 2017-11-08 08:33:33 -03:00
L. E. Segovia
94d266e2d6 Rework uninstallation step
Now the artifacts get re-staged, and upon an uninstall/finalize_upgrade
they are deleted by purge_versioned_files instead
2017-11-06 21:27:02 -03:00
L. E. Segovia
84c128411f Fix style issues 2017-11-06 18:33:29 -03:00
Markus Reiter
bd0b763292 Refactor DependsOn with DelegateClass. 2017-11-06 21:13:39 +01:00
Markus Reiter
4eeac6f884
Merge pull request #3389 from amyspark/hacktoberfest-single-zap
Check that a single uninstall_* and zap stanza is defined
2017-11-03 13:23:08 +01:00
commitay
a8788015b6 Cask doctor: add macOS & Java versions 2017-11-03 08:37:10 +10:00
L. E. Segovia
eaae7f3a5b Fix last remaining style issues 2017-11-02 09:56:51 -03:00
L. E. Segovia
7f398d01b8 Turn ifs into multiple lines 2017-11-01 22:35:41 -03:00
L. E. Segovia
7f2e4f583a Finalize metadata handling and uninstall logic 2017-10-30 23:29:00 -03:00
L. E. Segovia
9b6b0bfed7 Use #count, rewrite warning, and add pre/postflight checks too 2017-10-30 20:47:22 -03:00
Markus Reiter
2eb366ff38 Fix SystemCommand without arguments. 2017-10-30 22:04:54 +01:00
L. E. Segovia
55727b7895 Hack a first working version of upgrade 2017-10-29 17:34:53 -03:00
L. E. Segovia
809e820388 Check that a single uninstall_* and zap stanzas is defined 2017-10-28 20:36:41 -03:00
Markus Reiter
632fdca2d4 Merge pull request #3306 from amyspark/hacktoberfest-quash-cask-help
Fixes querying Cask commands' help
2017-10-24 20:54:24 +02:00
L. E. Segovia
a8ee54a35f Actually check that the command name was set before adding it to args 2017-10-21 15:43:20 -03:00
L. E. Segovia
10cbc77af9 Fix brew style errors 2017-10-20 20:21:38 -03:00
L. E. Segovia
75de4db003 Let Cask handle the -h flag 2017-10-20 16:51:26 -03:00
L. E. Segovia
95a3d53125 Fix ternary condition style 2017-10-20 13:54:58 -03:00
L. E. Segovia
ec92cf6498 Print only the offending command instead of the whole Cask command 2017-10-20 10:35:13 -03:00
Markus Reiter
9bee9ca575 Use “squiggly” heredocs. 2017-10-18 14:39:09 +02:00
Markus Reiter
8c3c72ec00 Allow editing invalid Casks. 2017-10-15 22:04:20 +02:00
Markus Reiter
c931a1be38 Refactor SystemCommand. 2017-10-12 23:33:05 +02:00
L. E. Segovia
cc8e455911 Remove unknown_command variable 2017-10-12 07:39:53 -03:00
L. E. Segovia
d1262868a9 Fixes help querying
- If a non-existent command with a flag is queried to Cask, the latter
is printed instead of the command
 - If the help from a not-yet-tapped cask's command is queried, it
prints brew tap's help infinitely

Fixes caskroom/homebrew-cask#28977
2017-10-12 00:11:11 -03:00
Markus Reiter
04363b25a3 Properly handle special characters in file names. 2017-10-11 17:43:54 +02:00
Markus Reiter
cbd9715e5b Fix regexes in CaskLoader. 2017-10-08 15:21:04 +02:00
Markus Reiter
5cbf8bdaa7 Merge pull request #3283 from reitermarkus/cask-loader
Add helper method for Cask fixture paths and refactor CaskLoader.
2017-10-07 18:30:32 +02:00
Markus Reiter
97333df4cb Add helper method for Cask fixture paths and refactor CaskLoader. 2017-10-07 16:11:25 +02:00
Markus Reiter
62315e93f8 Merge pull request #3280 from commitay/cask-internal-audit
InternalAuditModifiedCask: audit renamed Casks
2017-10-07 15:55:02 +02:00
commitay
4fde8f56ce add pkg / binary comment 2017-10-07 23:10:59 +10:00
commitay
a7cf6c1ff0 Cask AbstractArtifact: fix install order 2017-10-07 22:06:39 +10:00
commitay
d5cc68fba3 InternalAuditModifiedCask: audit renamed Casks 2017-10-07 12:53:07 +10:00