admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
25,521 Commits 15 Branches 471 Tags
Commit Graph

25521 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Sam Ford
8869208a60
Merge pull request #10309 from samford/livecheck-dsl-avoid-url-symbol-conversion 
Livecheck#url: Don't convert URL symbol to string
 2021-01-15 14:23:31 -05:00
Seeker
ba6f75a249
Merge pull request #10322 from SeekingMeaning/on-os-resource 
rubocops: point to offending OS-specific block in resource blocks
 2021-01-15 06:59:25 -08:00
Dawid Dziurla
f7f72b1552
Merge pull request #10337 from dawidd6/cmd_dev-cmd_usages 
cmd,dev-cmd: indicate multiple named args in usage banner
 2021-01-15 15:56:52 +01:00
Dawid Dziurla
ce2dd731f7
deb-cmd/irb: remove named_args :none 
seems like this command takes named args somewhere
 2021-01-15 13:15:48 +01:00
Dawid Dziurla
f949d57437
cmd,dev-cmd: regenerate manpages and docs 2021-01-15 13:05:11 +01:00
Dawid Dziurla
cf654da251
dev-cmd: indicate multiple named args in usage banner 2021-01-15 13:04:07 +01:00
Dawid Dziurla
332372469f
cmd: indicate multiple named args in usage banner 2021-01-15 13:04:00 +01:00
Mike McQuaid
bca4804a9e
Merge pull request #10336 from MikeMcQuaid/keg-alias-realpath 
keg: check that alias_match_path exists before checking the `.realpath.
2.7.5 		2021-01-15 10:19:19 +00:00
Mike McQuaid
e9a061768f
Merge pull request #10335 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-0.5.6210 
build(deps): bump sorbet from 0.5.6206 to 0.5.6210 in /Library/Homebrew
 2021-01-15 09:42:53 +00:00
Mike McQuaid
1857dfcd2e
keg: check that alias path exists before checking realpath. 
Otherwise this can be a broken symlink which will raise an exception:
https://github.com/Homebrew/homebrew-core/runs/1704569542?check_suite_focus=true#step:6:47
 2021-01-15 08:58:06 +00:00
BrewTestBot
21b58c1064 brew vendor-gems: commit updates. 2021-01-15 06:23:44 +00:00
dependabot[bot]
fb57d3f843
build(deps): bump sorbet from 0.5.6206 to 0.5.6210 in /Library/Homebrew 
Bumps [sorbet](https://github.com/sorbet/sorbet) from 0.5.6206 to 0.5.6210.
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

Signed-off-by: dependabot[bot] <support@github.com>
 2021-01-15 06:19:13 +00:00
Seeker
053ca17b50
Merge pull request #10318 from SeekingMeaning/patch-legacy-cleanup 
patch: delete legacy code
 2021-01-14 19:53:43 -08:00
Rylan Polster
84af07f152
Merge pull request #10288 from Rylan12/refactor-named-args 
Add named_args DSL for commands
 2021-01-14 21:43:54 -05:00
Rylan Polster
4710be2fb3 parser: add some more tests 2021-01-14 20:45:26 -05:00
Rylan Polster
74c1010256 parser: add tests for named methods 2021-01-14 15:14:10 -05:00
Shaun Jackman
edfa340646
Merge pull request #10137 from sjackman/sj/governance 
Amend the governance document
 2021-01-14 12:09:22 -08:00
Mike McQuaid
e989a0fb01
Merge pull request #10327 from MikeMcQuaid/keg-fix-alias-handling 
Keg: fix alias and versioned symlink handling.
 2021-01-14 16:58:53 +00:00
Mike McQuaid
edc64177be
Merge pull request #10328 from MikeMcQuaid/delete-skip-test 
cask/cmd/info_spec: remove skipped test.
 2021-01-14 16:41:42 +00:00
Mike McQuaid
eaae52edb8
tab: return default values on existing, blank install receipt contents. 2021-01-14 16:26:58 +00:00
Mike McQuaid
2f018d1a98
cask/cmd/info_spec: remove skipped test. 
Unfortunately skipping this test makes it show up in the PR diff every
time. Let's just delete it for now instead.
 2021-01-14 16:10:07 +00:00
Mike McQuaid
128aeba3a4
Keg: fix alias and versioned symlink handling. 
Previously, `brew upgrade gcc@10` could get overzealous and remove the
`LinkedKeg` record for `gcc@9`. This is bad because we then think
`gcc@9` is unlinked when it is not and it causes a tonne of conflicts
when trying to link `gcc@9` again.

Instead, fix up the alias and versioned alias cleanup to be more
precise and only delete the symlinks that point to the current `rack`,
`opt_record` or `linked_keg_record` and unify the logic so it's
performed consistently.

While we're here:
- don't `remove_old_aliases` every time we try to unlink a directory
  but just perform it once per `unlink` operation
- remove the linked keg record on `uninstall`
 2021-01-14 16:02:06 +00:00
Mike McQuaid
9e26db3a55
Merge pull request #10323 from Homebrew/revert-10312-allow_overwriting_symlinks_from_the_same_formula 
Revert "Keg: allow overwriting same-formula conflicts"
 2021-01-14 12:33:43 +00:00
Markus Reiter
eee5b42b07
Merge pull request #10317 from Homebrew/sorbet-files-update 
sorbet: Update RBI files.
 2021-01-14 13:17:29 +01:00
Mike McQuaid
17a073b6cc
Revert "Keg: allow overwriting same-formula conflicts" 2021-01-14 12:04:59 +00:00
Mike McQuaid
5dd47609f8
Merge pull request #10324 from MikeMcQuaid/tap-new-branch 
dev-cmd/tap-new: fix output on newer versions of Git.
 2021-01-14 11:50:05 +00:00
Mike McQuaid
591e9d6a52
dev-cmd/tap-new: fix output on newer versions of Git. 
Otherwise this prints to `stderr` to ask for configuration of the branch
name:
https://github.com/Homebrew/brew/pull/10323/checks?check_run_id=1701105141#step:5:51
 2021-01-14 10:47:44 +00:00
Markus Reiter
1094e6dccb
Merge pull request #10321 from Homebrew/dependabot/bundler/Library/Homebrew/tapioca-0.4.12 
build(deps): bump tapioca from 0.4.11 to 0.4.12 in /Library/Homebrew
 2021-01-14 08:27:17 +01:00
Seeker
33edb9f901 rubocops: point to offending OS-specific block in resource blocks 2021-01-13 23:18:32 -08:00
Jonathan Chang
2e4b6c09f1
Merge pull request #10320 from jonchang/fix-mirror-in-os-resource-blocks 
rubocops: permit `mirror` in OS-specific resources
 2021-01-14 17:46:16 +11:00
BrewTestBot
2e11080c8f Update RBI files for tapioca. 2021-01-14 06:21:40 +00:00
BrewTestBot
b0da94b989 brew vendor-gems: commit updates. 2021-01-14 06:20:53 +00:00
dependabot[bot]
e8c5b63c09
build(deps): bump tapioca from 0.4.11 to 0.4.12 in /Library/Homebrew 
Bumps [tapioca](https://github.com/Shopify/tapioca) from 0.4.11 to 0.4.12.
- [Release notes](https://github.com/Shopify/tapioca/releases)
- [Commits](https://github.com/Shopify/tapioca/compare/v0.4.11...v0.4.12)

Signed-off-by: dependabot[bot] <support@github.com>
 2021-01-14 06:18:49 +00:00
Jonathan Chang
641afdd2de rubocops: permit mirror in OS-specific resources 2021-01-14 17:04:40 +11:00
Seeker
7a5a8baac5 patch: delete legacy code 
SoftwareSpec#add_legacy_patches and Patch#normalize_legacy_patches
were added almost 6 years ago; let's delete them

See commit 665b14c4a44c272b46b8559836e9fdbeee5d8a46

```
$ grep -r 'normalize_legacy_patches' Library/Homebrew
./software_spec.rb:    list = Patch.normalize_legacy_patches(list)
./patch.rb:  def self.normalize_legacy_patches(list)
```

```
$ grep -r 'add_legacy_patches' Library/Homebrew
./software_spec.rb:  def add_legacy_patches(list)
```
 2021-01-13 18:40:46 -08:00
BrewTestBot
7592f568f1 sorbet: Update RBI files. 
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
 2021-01-14 01:32:44 +00:00
Seeker
663b972f44
Merge pull request #10306 from SeekingMeaning/git-repo-pwd 
utils/git_repository: use `Pathname.pwd` if no `repo` specified
2.7.4 		2021-01-13 16:14:27 -08:00
Rylan Polster
da811373d3 Add named_args DSL for commands 2021-01-13 17:09:42 -05:00
Rylan Polster
701989968d
Merge pull request #10268 from Rylan12/completions-opt-out 
completions: make opt-in only
 2021-01-13 16:08:30 -05:00
Seeker
4f02c1c8a8 utils/git_repository: use Pathname.pwd if no repo specified 2021-01-13 13:02:37 -08:00
Misty De Meo
9f4105f325
Merge pull request #10312 from mistydemeo/allow_overwriting_symlinks_from_the_same_formula 
Keg: allow overwriting same-formula conflicts
 2021-01-13 12:45:26 -08:00
Misty De Meo
a2e0da89e4 Keg: only instantiate Keg.for if target exists 2021-01-13 12:18:49 -08:00
Mike McQuaid
66f0a35587 keg: remove trailing whitespace. 2021-01-13 12:18:49 -08:00
Mike McQuaid
e01fa7d2ae keg: tweak retry comment. 2021-01-13 12:18:49 -08:00
Misty De Meo
53fe6b518f Keg: allow overwriting same-formula conflicts 
This is weird. We're seeing some installs where formulae
have no opt prefix and no linked keg record, *but* still
ended up linked into the prefix. Upgrades will blow up in
this case because the old symlinks won't get deleted and
Homebrew will report a nonsensical error message about
not being able to link over another link from the same
formula!

Since the optpath is either missing or pointing to the
wrong destination at this point, the checks for conflict
linking above will have failed. We should instead be safe
to simply blow away these conflicting symlinks and replace
them with the new targets.

Fixes https://github.com/Homebrew/homebrew-core/issues/68866.
 2021-01-13 12:18:49 -08:00
Misty De Meo
8cf9a52b29
Merge pull request #10316 from Homebrew/fix_rubocop_warning_in_default_branch 
Popen spec: ensure Rubocop is happy
 2021-01-13 12:18:11 -08:00
Misty De Meo
847897fdac Popen spec: ensure Rubocop is happy 
These were introduced in #10305 but only started going red
after that PR was merged.
 2021-01-13 11:21:10 -08:00
Misty De Meo
c197e9a27d
Merge pull request #10315 from mistydemeo/cask_is_unavailable_hotfix 
Cask tests: temporarily disable broken test
 2021-01-13 11:14:33 -08:00
Seeker
be6dd72c16
Merge pull request #10305 from SeekingMeaning/safe-popen-tests 
utils/popen: add `safe` argument to `popen_read` and `popen_write`
 2021-01-13 10:51:46 -08:00
Misty De Meo
79aff82c39 Cask: skip test that is currently broken in master 2021-01-13 10:42:46 -08:00