Rylan Polster
7a0471f4c9
cask/cmd: fix tests
2021-01-23 17:50:41 -05:00
Rylan Polster
01e894e9c6
parser: create NumberOfNamedArgumentsError
...
And commit `brew man` changes
2021-01-23 15:26:21 -05:00
Rylan Polster
f295e36a22
extract: re-add named arg types
2021-01-23 15:10:14 -05:00
Rylan Polster
b7b624c9bf
parser: clarify errors for invalid number of args
2021-01-23 15:06:44 -05:00
Issy Long
49b9b6cf3f
dev-cmd/extract: Improve the usage instructions
...
- A friend got an error message when trying to use `brew extract` and it
wasn't immediately obvious to me why. The usage banner only mentioned
the "formula" argument, which they'd provided. This improves the error
message when there aren't enough arguments so that others have a
chance of figuring out how to use this command without having to look
at the code for `extract_args`.
Before:
```
➜ brew extract --version='1.4' libftdi
Usage: brew extract [--version=] [--force] formula ...
[...]
Error: Invalid usage: this command requires a formula argument
```
After:
```
➜ brew extract --version='1.4' libftdi
Usage: brew extract [options] formula tap
[...]
Error: Invalid usage: This command requires at least 2 named arguments.
```
- I don't like the "at least 2" phrasing here but that's a dive into the
arg parsing code that I don't have time for right now. An alternative
was `named_args [:formula, :destination_tap]`, but that gave the error
message "requires formula or destination_tap" which wasn't great
either. I also tried `min: 2, max: 2` and that was the same "at least
2" message.
2021-01-23 20:01:11 +00:00
Seeker
bf448def73
Merge pull request #10364 from SeekingMeaning/version-strict-typecheck
...
os/mac/version: update method signatures
2021-01-22 10:32:55 -08:00
Seeker
779f2fc6ef
os/mac/version: update method signatures
2021-01-22 09:58:01 -08:00
Mike McQuaid
2268e774a4
Merge pull request #10301 from hyuraku/cmd/cleanup_add_desc_about_all_to_prune
...
cmd/cleanup: add description about all to --prune
2021-01-22 14:57:13 +00:00
Mike McQuaid
ca2eccff38
Merge pull request #10387 from MikeMcQuaid/macos_tests_needs_syntax
...
tests: make macOS tests require a passing syntax job.
2021-01-22 13:55:39 +00:00
hyuraku
b4df0d5c10
cmd/cleanup: add desc about all to --prune
2021-01-22 20:53:48 +09:00
Mike McQuaid
60325a6f73
Merge pull request #10394 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-0.5.6225
...
build(deps): bump sorbet from 0.5.6223 to 0.5.6225 in /Library/Homebrew
2021-01-22 10:33:14 +00:00
Mike McQuaid
800ccb0163
Merge pull request #10395 from SeekingMeaning/bottle-spec-checksums
...
software_spec: change BottleSpecification#checksums to return array
2021-01-22 10:19:19 +00:00
Mike McQuaid
62c8f2b0ad
Merge pull request #10390 from MikeMcQuaid/bootsnap_fix
...
Fix HOMEBREW_BOOTSNAP setup
2021-01-22 09:38:03 +00:00
Seeker
8693ca4e4d
software_spec: change BottleSpecification#checksums to return array
2021-01-21 22:52:26 -08:00
Jonathan Chang
3c84e1fef3
Merge pull request #10381 from jonchang/fix-version-type
...
version: fix type signature
2021-01-22 17:33:21 +11:00
BrewTestBot
ef7dd714cd
brew vendor-gems: commit updates.
2021-01-22 06:21:12 +00:00
dependabot[bot]
eec1e39270
build(deps): bump sorbet from 0.5.6223 to 0.5.6225 in /Library/Homebrew
...
Bumps [sorbet](https://github.com/sorbet/sorbet ) from 0.5.6223 to 0.5.6225.
- [Release notes](https://github.com/sorbet/sorbet/releases )
- [Commits](https://github.com/sorbet/sorbet/commits )
Signed-off-by: dependabot[bot] <support@github.com>
2021-01-22 06:15:54 +00:00
Seeker
3f72d4033d
Merge pull request #10380 from SeekingMeaning/git-repo-branch-msg
...
utils/git_repository: add `::git_branch` and `::git_commit_message`
2021-01-21 20:00:27 -08:00
Rylan Polster
acede7315a
Merge pull request #10366 from Rylan12/auto-tap-fix
...
Don't tap user-untapped official taps
2021-01-21 15:47:07 -05:00
Mike McQuaid
dad1939142
Fix HOMEBREW_BOOTSNAP setup
...
- rename to `homebrew_bootsnap.rb` to avoid conflicting with the
`bootsnap.rb` we need to `require`
- if the `require` fails: run bundler (until we vendor this gem)
2021-01-21 17:35:13 +00:00
Mike McQuaid
b9b1cd8b2b
tests: make macOS tests require a passing syntax job.
...
The syntax job is quick (takes 1m) and this avoids running the long
macOS job (for which we have a limited number of workers) unless it
has passed.
2021-01-21 16:30:30 +00:00
Mike McQuaid
f6bc3efac6
Merge pull request #10389 from MikeMcQuaid/cleanup_raise
...
cleanup: raise failures and handle later.
2021-01-21 15:55:39 +00:00
Mike McQuaid
3acf92cdc7
Merge pull request #10388 from MikeMcQuaid/move_auto_update_secs
...
Move HOMEBREW_AUTO_UPDATE_SECS default definition
2021-01-21 15:55:31 +00:00
Mike McQuaid
7857993e07
Merge pull request #10374 from MikeMcQuaid/bootsnap
...
Add HOMEBREW_BOOTSNAP to optionally use Bootsnap
2021-01-21 15:31:39 +00:00
Rylan Polster
ecfad29347
tap: write untapped setting only on manual untap
2021-01-21 08:42:22 -05:00
Mike McQuaid
e2f998d3e6
Move HOMEBREW_AUTO_UPDATE_SECS default definition
...
This ensure it'll always be set to a value.
Fixes https://github.com/Homebrew/brew/issues/10386
2021-01-21 13:19:06 +00:00
Mike McQuaid
e11a008862
Merge pull request #10383 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-0.5.6223
...
build(deps): bump sorbet from 0.5.6216 to 0.5.6223 in /Library/Homebrew
2021-01-21 13:09:50 +00:00
Mike McQuaid
3df76251d8
Merge pull request #10382 from Homebrew/dependabot/bundler/Library/Homebrew/concurrent-ruby-1.1.8
...
build(deps): bump concurrent-ruby from 1.1.7 to 1.1.8 in /Library/Homebrew
2021-01-21 13:09:35 +00:00
Mike McQuaid
3f9b213e9c
Merge pull request #10349 from zgracem/fix-shellenv-fish
...
fix `brew shellenv` on fish
2021-01-21 13:07:00 +00:00
Mike McQuaid
15761a283d
cleanup: raise failures and handle later.
...
These are already handled and outputted as a group in `cmd/cleanup.rb`.
Fixes https://github.com/Homebrew/brew/issues/10379
2021-01-21 13:03:52 +00:00
Mike McQuaid
683ae7ff53
Add HOMEBREW_BOOTSNAP to optionally use Bootsnap
...
> Bootsnap is a library that plugs into Ruby, with optional support
> for ActiveSupport and YAML, to optimize and cache expensive
> computations.
https://github.com/Shopify/bootsnap
For our case that translates to "repeated calls to `brew` have
reductions in the time spend `require`ing speeding up the process
boot time".
For example:
```
$ hyperfine --warmup=2 "unset HOMEBREW_BOOTSNAP; brew info wget" "export HOMEBREW_BOOTSNAP=1; brew info wget"
Benchmark #1 : unset HOMEBREW_BOOTSNAP; brew info wget
Time (mean ± σ): 2.417 s ± 0.032 s [User: 659.0 ms, System: 855.5 ms]
Range (min … max): 2.382 s … 2.464 s 10 runs
Benchmark #2 : export HOMEBREW_BOOTSNAP=1; brew info wget
Time (mean ± σ): 1.862 s ± 0.064 s [User: 425.3 ms, System: 566.8 ms]
Range (min … max): 1.736 s … 1.952 s 10 runs
Summary
'export HOMEBREW_BOOTSNAP=1; brew info wget' ran
1.30 ± 0.05 times faster than 'unset HOMEBREW_BOOTSNAP; brew info wget'
```
2021-01-21 12:34:04 +00:00
Mike McQuaid
c7e9fdc839
Merge pull request #10384 from MikeMcQuaid/exceptions-termsig
...
exceptions: more handling of nil status.
2021-01-21 12:08:36 +00:00
Mike McQuaid
91759ac3c3
Merge pull request #10226 from hyuraku/completions/zsh_add-cask-option
...
completions/zsh: add-cask-option
2021-01-21 12:08:11 +00:00
Dawid Dziurla
75760977bd
Merge pull request #10385 from MikeMcQuaid/arm-install-bundler-gems
...
install-bundler-gem: allow on ARM.
2021-01-21 11:35:20 +01:00
Mike McQuaid
8cb2cc4bcc
install-bundler-gem: allow on ARM.
...
Needed for CI:
https://github.com/Homebrew/homebrew-core/pull/69460/checks?check_run_id=1740727396#step:6:32
2021-01-21 10:02:57 +00:00
hyuraku
7e2db0cd3d
completions/zsh: add-cask-option
2021-01-21 18:38:34 +09:00
Mike McQuaid
7360880780
Merge pull request #10375 from MikeMcQuaid/dev-cmd-arm
...
dev-cmd: disable when broken on Apple Silicon.
2021-01-21 09:01:16 +00:00
Mike McQuaid
e22f5f62d3
Merge pull request #10361 from tlk/patch-1
...
Clarification on the use of `:optional` and `:recommended`
2021-01-21 09:00:19 +00:00
Mike McQuaid
51b149b8ee
exceptions: more handling of nil status.
...
This was occurring on ARM CI.
2021-01-21 08:30:36 +00:00
BrewTestBot
7ba8809722
Update RBI files for sorbet.
2021-01-21 05:53:17 +00:00
BrewTestBot
6c85970435
brew vendor-gems: commit updates.
2021-01-21 05:52:29 +00:00
BrewTestBot
47db90603f
Update RBI files for concurrent-ruby.
2021-01-21 05:50:01 +00:00
BrewTestBot
3312767cd5
brew vendor-gems: commit updates.
2021-01-21 05:49:11 +00:00
dependabot[bot]
a395e8b5cd
build(deps): bump sorbet from 0.5.6216 to 0.5.6223 in /Library/Homebrew
...
Bumps [sorbet](https://github.com/sorbet/sorbet ) from 0.5.6216 to 0.5.6223.
- [Release notes](https://github.com/sorbet/sorbet/releases )
- [Commits](https://github.com/sorbet/sorbet/commits )
Signed-off-by: dependabot[bot] <support@github.com>
2021-01-21 05:47:19 +00:00
dependabot[bot]
bc54f1a7c9
build(deps): bump concurrent-ruby in /Library/Homebrew
...
Bumps [concurrent-ruby](https://github.com/ruby-concurrency/concurrent-ruby ) from 1.1.7 to 1.1.8.
- [Release notes](https://github.com/ruby-concurrency/concurrent-ruby/releases )
- [Changelog](https://github.com/ruby-concurrency/concurrent-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ruby-concurrency/concurrent-ruby/compare/v1.1.7...v1.1.8 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-01-21 05:47:05 +00:00
Jonathan Chang
1e04cce19b
version: fix type signature
...
Fixes type error:
Parameter 'val': Expected type T.any(String, Version), got type PkgVersion
2021-01-21 16:11:37 +11:00
Seeker
bd25e7da2a
utils/git_repository: add ::git_branch and ::git_commit_message
2021-01-20 17:34:54 -08:00
Seeker
4b5b1f61a3
Merge pull request #10365 from SeekingMeaning/git-repo-shared-examples
...
git_repository_spec: group together shared examples
2021-01-20 16:32:25 -08:00
Rylan Polster
64816651d0
Only tap homebrew/cask on CaskUnavailableError in brew install
2021-01-20 12:22:31 -05:00
Mike McQuaid
ea1affb658
Merge pull request #10373 from davidbailey00/patch-1
...
Suggest alternative method for enabling ZSH completions
2021-01-20 17:05:32 +00:00