Mike McQuaid
76543a99d3
Merge pull request #18206 from Homebrew/improve_github_check_for_duplicate_pull_requests
2024-08-30 16:08:06 +01:00
Mike McQuaid
fe909c41b8
Improve duplicate pull request handling
...
- change the messaging depending on how confident we are that we're
actually looking at duplicates i.e. we're not confident without a
version number supplied
- similarly, just warn instead of failing with an error (and no
override) if we're not confident that we're looking at duplicates
because a version wasn't supplied
- change `bump-cask-pr` and `bump-formula-pr` to always check for all
pull requests with the new version number (to allow failing on this)
rather than only checking closed pull requests with a version number
- change `bump` to check for definite/maybe duplicate PRs and only
exit if they are definitely duplicates
- cleanup some variable usage to DRY things up a bit
2024-08-30 14:21:42 +01:00
Mike McQuaid
decc109089
Merge pull request #18188 from Homebrew/better-shellenv
2024-08-30 11:56:07 +01:00
Mike McQuaid
85c9c17ddf
Merge pull request #18197 from xycabcd/patch-2
2024-08-30 07:58:56 +01:00
Ruoyu Zhong
2971755498
Merge pull request #18204 from Homebrew/maintainers.json
...
workflows: remove references to `maintainers.json`
2024-08-30 11:43:04 +08:00
Carlo Cabrera
e3d295ae12
Merge pull request #18203 from Homebrew/sponsorships-error
2024-08-30 11:13:29 +08:00
Carlo Cabrera
47430fb1cb
workflows: remove references to maintainers.json
...
This was removed in 7193dc09449f95a538f289807247e0c13d4c7474.
2024-08-30 11:06:23 +08:00
Carlo Cabrera
ed589c0a19
Merge pull request #18202 from Homebrew/fix-sponsorships-query
2024-08-30 11:02:28 +08:00
Carlo Cabrera
c740bef176
utils/github: improve sponsorships error handling
...
Let's make sure we get the opportunity to print the errors if the query
response doesn't have the form we expected it to take.
2024-08-30 11:00:53 +08:00
Carlo Cabrera
6b8a28bb05
Merge pull request #18201 from Homebrew/rm-graphql-debug
2024-08-30 10:56:39 +08:00
Carlo Cabrera
5897ed80d9
utils/github: fix sponsorships GraphQL query
...
This fixes the failure in our sponsorships workflow.
2024-08-30 10:50:59 +08:00
Carlo Cabrera
cabbb0b8e3
Remove GraphQL debug output
...
Let's get this ready to go since we don't want to accidentally leak
private information.
2024-08-30 10:45:19 +08:00
Patrick Linnane
1d71ee8f16
Merge pull request #18199 from Homebrew/remove-miccal-maintainer
2024-08-29 19:33:38 -07:00
Carlo Cabrera
ade587b455
Merge pull request #18200 from Homebrew/graphql-debug
...
utils/github/api: add debug output for `open_graphql`
2024-08-30 10:31:50 +08:00
Carlo Cabrera
7645484ac3
utils/github/api: add debug output for open_graphql
...
Our updating sponsors/maintainers/etc workflow is broken.
Let's add some debug output to help me fix it.
2024-08-30 10:15:56 +08:00
Ruoyu Zhong
67398c7728
Merge pull request #18189 from jrschumacher/patch-1
...
Add note about auditor to How-To-Open-a-Homebrew-Pull-Request.md
2024-08-30 08:45:42 +08:00
miccal
b8ec1bfd5b
Update README.md and manpage
2024-08-30 08:44:31 +08:00
Ryan Schumacher
ff6df8ee56
Update How-To-Open-a-Homebrew-Pull-Request.md
...
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
2024-08-29 18:45:10 -05:00
Patrick Linnane
46ec1aa4d9
Merge pull request #18193 from Homebrew/dependabot/bundler/Library/Homebrew/thor-1.3.2
2024-08-29 16:14:47 -07:00
BrewTestBot
6031ce22ff
Update RBI files for thor.
...
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml ) workflow.
2024-08-29 23:03:10 +00:00
BrewTestBot
f6af1e9d9b
brew vendor-gems: commit updates.
2024-08-29 23:02:56 +00:00
dependabot[bot]
abf98a4743
build(deps-dev): bump thor from 1.3.1 to 1.3.2 in /Library/Homebrew
...
Bumps [thor](https://github.com/rails/thor ) from 1.3.1 to 1.3.2.
- [Release notes](https://github.com/rails/thor/releases )
- [Commits](https://github.com/rails/thor/compare/v1.3.1...v1.3.2 )
---
updated-dependencies:
- dependency-name: thor
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-08-29 23:00:53 +00:00
Patrick Linnane
2d247f4642
Merge pull request #18192 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-0.5.11551
2024-08-29 15:54:35 -07:00
BrewTestBot
16b9b75c6a
brew vendor-gems: commit updates.
2024-08-29 22:42:33 +00:00
Ryan Schumacher
b31a9b922e
Apply suggestions from code review
...
Co-authored-by: Ruoyu Zhong <zhongruoyu@outlook.com>
2024-08-29 15:55:12 -05:00
Ryan Schumacher
e5a3f0e583
Update docs/How-To-Open-a-Homebrew-Pull-Request.md
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2024-08-29 15:54:32 -05:00
Eric Knibbe
1bf48e25e8
Merge pull request #18191 from Homebrew/dependabot/github_actions/github/codeql-action-3.26.6
...
build(deps): bump github/codeql-action from 3.26.5 to 3.26.6
2024-08-29 15:09:54 -04:00
xycabcd
147cfa46e4
Deleted the duplicated "PWD check"
2024-08-29 14:45:27 -04:00
dependabot[bot]
61c291fa5e
build(deps-dev): bump sorbet in /Library/Homebrew
...
Bumps [sorbet](https://github.com/sorbet/sorbet ) from 0.5.11549 to 0.5.11551.
- [Release notes](https://github.com/sorbet/sorbet/releases )
- [Commits](https://github.com/sorbet/sorbet/commits )
---
updated-dependencies:
- dependency-name: sorbet
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-08-29 18:30:38 +00:00
dependabot[bot]
c66e5023d3
build(deps): bump github/codeql-action from 3.26.5 to 3.26.6
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.26.5 to 3.26.6.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](2c779ab0d0...4dd16135b6
2024-08-29 18:11:07 +00:00
Ryan Schumacher
72f995599d
Update docs/How-To-Open-a-Homebrew-Pull-Request.md
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2024-08-29 08:48:45 -05:00
Ryan Schumacher
010304a9a1
Update docs/How-To-Open-a-Homebrew-Pull-Request.md
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2024-08-29 08:48:39 -05:00
Ryan Schumacher
f119b4a6d0
Added the block for casks
2024-08-29 08:28:18 -05:00
Ryan Schumacher
ff8b3f21f9
Move to appropriate section and resolve lint error
2024-08-29 08:19:34 -05:00
Ryan Schumacher
5fb6a8b8e3
Add link to Acceptable Formulae and slight wording change for more clarity.
2024-08-29 08:17:22 -05:00
Carlo Cabrera
6cd74705cb
shellenv: silence errors from writing to etc/paths file
...
Users don't need to see this error. We can just fall back silently
instead.
2024-08-29 19:12:23 +08:00
Ryan Schumacher
8c6aa176f6
Add note about auditor to How-To-Open-a-Homebrew-Pull-Request.md
2024-08-29 05:17:26 -05:00
Carlo Cabrera
04088b3e3c
shellenv: extract paths file to a variable
...
Let's follow the Rule of Three here.
2024-08-29 17:36:50 +08:00
Carlo Cabrera
6dc90cbf83
cmd/shellenv: improve for newer macOS using /usr/libexec/path_helper
...
On macOS 14 and newer, `/usr/libexec/path_helper` supports setting a
`PATH_HELPER_ROOT` environment variable.
With this set, `path_helper` checks `$PATH_HELPER_ROOT/etc/paths` and
`$PATH_HELPER_ROOT/etc/paths.d` in the same way it checks `/etc/paths`
and `/etc/paths.d`.
We can use this to simplify management of the user's `PATH` variable
when they do `brew shellenv`. In particular, if their system supports
it, we delegate setting the `PATH` environment variable to `path_helper`
instead of our own code. We also write a default `etc/paths` file if one
is not already present.
This is nicer because it simplifies management of the user's `PATH`
variable. For example, if a user wants a keg-only formula to be in their
`PATH`, they can simply add the necessary path to `/etc/paths` or
`/etc/paths.d` without having to do something like `brew link --force`
or adding to `PATH` themselves.
When `/usr/libexec/path_helper` is not available, we just fall back to
the existing code.
2024-08-29 17:00:43 +08:00
Mike McQuaid
638a3dc3a3
Merge pull request #18167 from Homebrew/fix-cask-formula-file-validation-v2
2024-08-29 08:50:44 +01:00
apainintheneck
60b8878f21
tap: share components of formula and cask file path regexes
...
The goal here is to make things easier to read by better
describing how different regexes are similar to each other.
2024-08-28 19:12:02 -07:00
Michael Cho
06fc2247c7
Merge pull request #18178 from cho-m/github-tag
...
utils/shared_audits: GitHub urls can have '.' in repo and '/' in tag
2024-08-28 21:55:29 -04:00
Patrick Linnane
81c4351fb5
Merge pull request #18185 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-0.5.11549
2024-08-28 08:41:34 -07:00
BrewTestBot
5d1db45b27
brew vendor-gems: commit updates.
2024-08-28 15:24:28 +00:00
dependabot[bot]
8fee9dc845
build(deps-dev): bump sorbet in /Library/Homebrew
...
Bumps [sorbet](https://github.com/sorbet/sorbet ) from 0.5.11547 to 0.5.11549.
- [Release notes](https://github.com/sorbet/sorbet/releases )
- [Commits](https://github.com/sorbet/sorbet/commits )
---
updated-dependencies:
- dependency-name: sorbet
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-08-28 15:21:32 +00:00
Bo Anderson
f5d39c82c3
Merge pull request #18183 from Homebrew/sandbox-fork-fix
...
Fix misuse of `fork` in sandbox causing crashes
2024-08-28 15:14:59 +01:00
Bo Anderson
6a0db5035f
Fix misuse of fork in sandbox causing crashes
2024-08-28 13:53:01 +01:00
Carlo Cabrera
01287a742a
Merge pull request #18153 from Homebrew/version-cache-handling
2024-08-28 19:37:15 +08:00
Carlo Cabrera
b63ecff52c
brew.sh: use git diff instead of git diff-index
2024-08-28 19:21:50 +08:00
Carlo Cabrera
a597a1eecb
Reverse order of if conditional
...
Checking for readability is a cheaper operation that `git diff-index`.
2024-08-28 18:58:27 +08:00
