362 Commits

Author SHA1 Message Date
ilovezfs
4e34f7b60e Merge pull request #2086 from MikeMcQuaid/audit-revision-remove-fix
audit: fix revision should be removed.
2017-02-21 14:09:58 -08:00
ilovezfs
b59bf2ff64 Revert "audit: check for version aliases." 2017-02-21 11:31:18 -08:00
Mike McQuaid
2f42dfc68a audit: fix revision should be removed.
Regression introduced in #1754 which meant that (due to storing the
current formula revision in `attributes_map`) `stable_revisions.empty?`
would never be `true`.
2017-02-21 18:50:07 +00:00
Mike McQuaid
606790d062 audit: check for version aliases.
Current version aliases should be provided for versioned formulae so
people can `brew install foo@1.2` to provide pin-like behaviour.
2017-02-21 15:36:49 +00:00
Mike McQuaid
96a695bc6d Merge pull request #2054 from zmwangx/bump-formula-pr-smarter-dupe
bump-formula-pr: improve duplicate detection
2017-02-20 22:54:51 +00:00
ilovezfs
c667a43b97 audit: fix insecure mirror check when stdout is empty 2017-02-20 07:51:04 -08:00
Zhiming Wang
81a7609213
bump-formula-pr: improve duplicate detection
Reduce the chance of false flagging by making sure that the existing pr
surfaced by GitHub.issues_for_formula actually contains the exact formula name
in its title.
2017-02-20 10:36:24 -05:00
Mike McQuaid
d24ac0555c Merge pull request #1722 from broder/insecure_audit
Added check for insecure mirror URLs
2017-02-20 11:26:41 +00:00
Mike McQuaid
b2dd6bc9b0 audit: fix brew style warning. 2017-02-15 14:41:06 +00:00
Mike McQuaid
9c3825fc77 Merge pull request #1997 from ilovezfs/block-duplicate-pull-requests
bump-formula-pr: block duplicate pull-requests
2017-02-15 14:39:13 +00:00
Viktor Szakats
64448834a6 fix existing rule for github.io homepages 2017-02-13 16:20:34 +00:00
Viktor Szakats
a09169f248 audit: enforce https for *.sourceforge.io urls 2017-02-13 14:58:28 +00:00
Mike McQuaid
7281cfaf63 Merge pull request #1972 from timotheecour/pr_brew_where_command
add `brew formula` command to show location of a formula
2017-02-13 08:32:35 +00:00
ilovezfs
539120143b bump-formula-pr: block duplicate pull-requests 2017-02-12 10:36:24 -08:00
Alyssa Ross
9e97eadccb rubocop: trailing comma in multiline method calls
Discussed in
https://github.com/Homebrew/brew/pull/1987/files#r100693581.

This was originally ommitted because it wasn't compatible with Ruby 1.8.
(See https://github.com/Homebrew/legacy-homebrew/pull/48144#r49928971).
2017-02-12 15:11:38 +00:00
Mike McQuaid
674e5f13f8 Merge pull request #1873 from GauthamGoli/audit_custom_cops
Custom Cops for `brew audit`
2017-02-12 13:09:28 +00:00
Markus Reiter
1292a4b219 Merge pull request #1955 from vszakats/patch-2
audit: enforce https://*.sourceforge.io/ homepages
2017-02-12 11:05:21 +01:00
Timothee Cour
0d715f90ea applied changes suggested in PR 2017-02-11 16:38:06 -08:00
Timothee Cour
ac091437e5 renamed where to formula 2017-02-11 16:38:06 -08:00
Timothee Cour
ae829ed229 add brew where command 2017-02-11 16:38:06 -08:00
Markus Reiter
c4ac308302 Allow brew tests to run specs. 2017-02-11 15:59:54 +01:00
Mike McQuaid
1413cd15ba Merge pull request #1958 from maveonair/tests-cli-help
Fix: Documentation of --only in tests cmd
2017-02-10 14:56:16 +00:00
Viktor Szakats
03253a8d8b audit: enforce https://*.sourceforge.io/ homepages
Ref: https://sourceforge.net/blog/introducing-https-for-project-websites/
2017-02-10 14:53:32 +00:00
Markus Reiter
2d05c9d80c Merge pull request #1961 from vszakats/githuburl
audit: enforce https for github.com urls
2017-02-09 06:24:56 +01:00
ilovezfs
79280826f5 pull: fix false positives for nonstandard bump subjects when untapped
If the formula's tap isn't tapped yet when running `brew pull`, a false
positive occurs for the nonstandard bump subject check, and a bogus
warning is printed, which claims the bump subject should refer to the
old version not the new version.
2017-02-08 00:58:20 -08:00
Viktor Szakats
11ebfdafb2 audit: enforce https for github.com urls 2017-02-07 00:19:58 +00:00
Fabian Mettler
ba2ec8abcc Fix: Documentation of --only in tests cmd
This pull request fixes the documentation for the —only flag of the
tests cmd.
2017-02-06 14:22:17 +01:00
Gautham Goli
1f5cf4fd40 Update docs and manpages to include --fix option 2017-02-06 12:46:26 +05:30
David Broder-Rodgers
64c83f3286 Use file checksum rather than file diffing 2017-02-02 21:25:29 +00:00
David Broder-Rodgers
d4aa98d230 Updated mirror checks to compare ETags, Content-Lengths and binary files 2017-01-30 21:49:42 +00:00
David Broder-Rodgers
13a3a57fa8 Merge remote-tracking branch 'origin/master' into insecure_audit 2017-01-30 18:31:52 +00:00
Mike McQuaid
eff70115b5 pull: better handle missing bottles.
If we make a PR in which we're building many formulae (e.g.
https://github.com/Homebrew/homebrew-core/pull/9249) then we may want
to pull those that built and publish their bottles and discard those
that did not. Instead of saying bottles will be published when they
won't and then blowing up just avoid publishing them and print a warning
instead.
2017-01-27 09:36:47 +00:00
Mike McQuaid
34e03532a0 audit: improve homepage audit reliability.
Try first with an (exact, actual) browser user agent from Safari and
then try again with the default Homebrew `curl` user agent.
2017-01-26 16:19:38 +00:00
Mike McQuaid
9293ca2cef Merge pull request #1901 from alyssais/patch-1
man: remove an unnecessary `else`
2017-01-25 09:35:17 +00:00
Mike McQuaid
da54f39556 Merge pull request #1877 from ilovezfs/audit-wine-deps-exemption
audit: exempt wine's deps from the universal deprecation
2017-01-23 21:17:00 +00:00
Alyssa Ross
4291476fa3 man: remove an unnecessary else
`odie` causes the process to exit immediately, so there's no need for the
`regenerate_man_pages` call to be conditional.
2017-01-23 21:16:49 +00:00
Alyssa Ross
2c1fbe1693 Merge pull request #1890 from alyssais/global_teardown_env
tests: automatically restore ENV in teardown
2017-01-23 17:54:31 +00:00
Alyssa Ross
19e61355b3 tests: remove with_git_env method
A common git environment is now used in all tests, so this is no longer
required.
2017-01-22 20:54:37 +00:00
Xu Cheng
22f294af90
bottle: fix regex
Noted that this is intended for the revision of this formula instead of
rebuild of a bottle.
2017-01-22 19:50:14 +08:00
ilovezfs
cebe137499 audit: exempt wine's deps from the universal deprecation
This can be reverted when wine's dependencies are all vendored.
2017-01-20 07:18:51 -08:00
Gautham Goli
0b3d9031e2 Add --fix option to brew audit command 2017-01-18 22:35:37 +05:30
Mike McQuaid
9f183be358 Merge pull request #1868 from zmwangx/bottle-add-improve-regexp
bottle: add: improve regexp to recognize comments
2017-01-18 08:02:45 +00:00
Mike McQuaid
4f0505f759 audit: only warn on versioned conflicts_with.
Rather than all versioned formulae regardless. Oops.
2017-01-17 19:09:41 +00:00
Zhiming Wang
42486c1181
bottle: add: improve regexp to recognize comments
This would have eliminated the need for Homebrew/homebrew-core#9000, for
instance.
2017-01-17 10:26:01 -05:00
Mike McQuaid
dac66c4ada Add keg_only :versioned_formula.
This is used to indicate a formula is a version of another formula.
This will be used to provide a consistent interface for older formulae
versions and replaces the use of `conflicts_with`.
2017-01-17 10:50:04 +00:00
Mike McQuaid
aa104137e5 Merge pull request #1844 from MikeMcQuaid/audit-universal
audit: don't allow universal for new formulae.
2017-01-17 10:08:44 +00:00
Mike McQuaid
feea90c0dd create: handle null versions.
Fixes #1821
2017-01-16 20:15:32 +00:00
Mike McQuaid
f4496e85e5 audit: don't allow universal for new formulae.
We're frowning on these now so may as well turn that into code.
2017-01-15 02:31:11 -08:00
ilovezfs
9dca10f9dc audit: whitelist unstable versions already in core
also allow higher stable versions with the same version prefix
2017-01-13 18:59:23 -08:00
Mike McQuaid
9cce3414fb Merge pull request #1806 from MikeMcQuaid/audit-virtualenv-setuptools
audit: check virtualenv and setuptools resource.
2017-01-09 14:08:30 +00:00