857 Commits

Author SHA1 Message Date
Caleb Xu
713aedb6ed Fix code review requests 2018-08-21 10:17:23 -04:00
Caleb Xu
260867627b Switch back to monkey-patching
Also gsub! some particular formula contents to work around older
formulae ("brewkit" isn't around anymore, and url is expected to
be a method, not an instance variable).
2018-08-21 10:17:23 -04:00
Caleb Xu
95abdf9662 Use refinements instead of general monkey-patching 2018-08-21 10:17:23 -04:00
Caleb Xu
ff8b5f8c5a extract: rework to search through old/deleted formulae
- Removed use of FormulaVersions - it's generally too brittle for our uses. We
  now interface directly with the Git repo via utils/git and monkeypatch the
  formula loading process where needed.

- Really old formulae (that specify fields as instance vars instead of methods)
  still need more work to be supported; they don't work here quite yet.

- Properly handles deleted/removed formulae from Homebrew/homebrew-core.
  Additional work is still needed to search through Homebrew/legacy-homebrew if
  this functionality is desired.
2018-08-21 10:17:23 -04:00
Caleb Xu
1003aa72c9 Additional fixups for extract command
- Rework command line options
- Make specifying a version optional
- Remove stdout option and require a tap to be specified
- Do not allow user to extract into homebrew/core
- Rework new class name generation to use existing Formulary tools
2018-08-21 10:17:23 -04:00
Caleb Xu
bd2ac70c0f Fix style issues in extract command 2018-08-21 10:17:23 -04:00
Caleb Xu
055460884b Fix up extract command
- Move from cmd to dev-cmd
- Add --stdout flag
- Add sanity checks for args/flags
- Minor rewording on error messages
2018-08-21 10:17:23 -04:00
Mike McQuaid
7df5b7057e
Revert "Use JSON to marshal errors from children" 2018-08-18 08:20:13 +01:00
William Woodruff
5c90833f0a
Use JSON to marshal errors from children 2018-08-17 15:23:08 -04:00
Jonathan Chang
2487345460 audit: fixes for test checks 2018-08-16 12:43:13 -04:00
Markus Reiter
55cde526a8 Deprecate brew cask cleanup. 2018-08-13 20:09:34 +02:00
Dominyk Tiller
20311aec15
audit: flag redundant shell_output() exit codes 2018-08-11 01:53:00 +01:00
Markus Reiter
771cf49352 Remove executable bit from ruby.rb and prof.rb. 2018-08-08 21:13:57 +02:00
Chongyu Zhu
3bce1c78bc
Merge pull request #4630 from lembacon/obsolete-github-env
Remove environment variables used by `hub`.
2018-08-09 00:01:09 +08:00
Mike McQuaid
daa3e415d6 Add/remove more maintainers.
And remove the Homebrew/homebrew-core lead maintainer role.
2018-08-08 09:41:26 +01:00
Chongyu Zhu
bd5b41ed94
Remove environment variables used by hub.
As of #3870, this is no longer needed.
2018-08-08 12:27:41 +08:00
Mike McQuaid
7461e94866
Merge pull request #4627 from MikeMcQuaid/add-new-maintainers
Add new maintainers
2018-08-07 11:07:04 +01:00
Mike McQuaid
ba410959c0 Add new maintainers
Also add some who were missing (sorry folks) and our Linux maintainers.
2018-08-07 10:51:16 +01:00
Markus Reiter
d33241bc11 Use -- for bottles. 2018-08-06 17:59:51 +02:00
Steven Peters
b387c09d0d linkage: test all kegs if none are specified 2018-08-03 12:07:45 -07:00
Markus Reiter
9db17ab5bc Allow forcing colored output. 2018-08-02 16:03:44 +02:00
Mike McQuaid
ee5a073b05 Add the SFC PLC to the README and manpage.
Let's document these so people know who the leadership team behind the
project is.
2018-08-02 13:26:02 +01:00
Markus Reiter
29182ad068 Remove non-existent download strategies. 2018-08-01 01:59:54 +02:00
commitay
fabb0931e3 audit: change the "unstable" spec message to devel/head 2018-07-29 09:32:46 +10:00
Mike McQuaid
0fe1f01e41 audit: output new formula issue comment failure message.
This should help debug when this fails to be created.
2018-07-23 19:33:59 +01:00
Mike McQuaid
44eeb59774 bottle: add --json and --merge docs.
Fixes #4519.
2018-07-23 14:51:47 +01:00
Mike McQuaid
b89e4c51ce man: improve messaging on no ronn output.
This can happen if your gems are messed up and it's a more helpful
error message than being unable to `gsub` on `nil`.
2018-07-20 09:47:28 +01:00
Markus Reiter
5841b992ac Refactor $LOAD_PATH. 2018-07-17 23:38:57 +02:00
Mike McQuaid
5c6ef3d920 Disable more deprecations.
- Turn more old `odeprecated` into `odisabled`
- Remove more old `odisabled`
- Remove code for older Ruby versions
2018-07-14 16:00:50 +01:00
commitay
1f115fa2f5
Merge pull request #4456 from commitay/optional-reqs
audit: check for optional and recommended requirements on new formulae
2018-07-13 10:04:15 +10:00
commitay
ee7c3ce7e3
Merge pull request #4420 from commitay/bottle
audit: ensure `bottle` is defined
2018-07-13 10:04:02 +10:00
Shaun Jackman
1b688a3a25 Relocate bottles on Linux using patchelf
Ensure patchelf is installed to pour bottles and build bottles.
2018-07-12 10:21:26 -07:00
commitay
ab8054482b audit: check for optional and recommended requirements on new formulae 2018-07-12 10:14:07 +10:00
Markus Reiter
7762ce32aa Use more descriptive heredoc names. 2018-07-11 18:15:30 +02:00
commitay
2c5f56d77d audit: ensure bottle is defined 2018-07-08 09:22:58 +10:00
commitay
a185f3272e audit: disallow unstable specs for versioned formulae 2018-07-04 11:39:11 +10:00
Mike McQuaid
0dcf753666
Merge pull request #4415 from MikeMcQuaid/tmp-cleanup
Cleanup HOMEBREW_TEMP handling
2018-07-03 15:59:44 +01:00
Mike McQuaid
f46e4596c0 Cleanup HOMEBREW_TEMP handling
- Ensure that `HOMEBREW_TEMP` is only displayed in `brew config` when
  it's non-default.
- Attempt to create a missing `HOMEBREW_TEMP` directory rather than
  failing to `realpath`. Note this will still fail on permissions errors
  which is to be expected.
2018-07-03 15:41:33 +01:00
ilovezfs
4b97b618df audit: exact match throttled formula names 2018-07-03 01:14:12 -07:00
commitay
6ca66d18e0 audit: exempt versioned formulae from new formula audit 2018-07-02 23:40:24 +10:00
Mike McQuaid
61a8c4d1fb
Merge pull request #4300 from apjanke/new-rubocop-version
Upgrade to Rubocop 0.57.2
2018-07-01 09:08:16 +01:00
Andrew Janke
e0a8a79921 Style fixes for Rubocop 0.57.1 2018-06-30 19:40:14 -04:00
Mike McQuaid
376f67bf2c
Merge pull request #4390 from MikeMcQuaid/linkage-cache-default
linkage: enable cache by default.
2018-06-29 20:35:13 +01:00
Mike McQuaid
1bf3aacc79
Merge pull request #4389 from MikeMcQuaid/bintray-portable-ruby
portable-ruby: respect HOMEBREW_BOTTLE_DOMAIN variable.
2018-06-29 20:07:11 +01:00
Mike McQuaid
6f5c8b8509 linkage: enable cache by default.
This has not been causing any issues in CI or for `master` users so
let's now enable it by default for everyone.
2018-06-29 19:57:39 +01:00
Mike McQuaid
facd76bc51 portable-ruby: respect HOMEBREW_BOTTLE_DOMAIN variable.
This was requested in:
https://discourse.brew.sh/t/adding-additional-download-sources-to-homebrew/2446

With this change you can use e.g. Artifactory for Homebrew's portable
ruby.
2018-06-29 19:51:18 +01:00
ilovezfs
3b46736820 mirror: use curl_executable instead of curl function 2018-06-25 06:33:44 -07:00
ilovezfs
49157dbf17 mirror: invoke correct curl
Remove remaining use of `system "curl"` in favor of the `curl` function.
2018-06-25 05:21:55 -07:00
Markus Reiter
18e46b3ec2 Fix usage of HOMEBREW_LOAD_PATH. 2018-06-18 16:23:35 +02:00
Mike McQuaid
f7d0c89c21
Merge pull request #4348 from errordeveloper/master
Ignore any version of Go, when it is a dependency of a bottle
2018-06-18 14:56:14 +01:00