10766 Commits

Author SHA1 Message Date
Alyssa Ross
6fc1747e05 tests: add a missing Tab cache clear
This was responsible for the sporadic failures I encountered in #1878.
2017-01-19 13:16:08 +00:00
Mike McQuaid
f0249643d4 formula_installer: use attr_accessor for installed_* 2017-01-18 16:10:28 +00:00
Mike McQuaid
5424db1263 upgrade: temporarily comment out for fix. 2017-01-18 15:25:17 +00:00
Mike McQuaid
89d8864b6b upgrade: tab installed_{as_dependency,on_request} 2017-01-18 11:23:22 +00:00
Mike McQuaid
ee43c09f7a install: set installed_{as_dependency,on_request}. 2017-01-18 11:23:21 +00:00
Mike McQuaid
16293c0a68 formula_installer: use installed_* variables.
Also, report formulae installed on request. This is useful in
differentiating between those formulae that are popular because they
are widely requested and those that are popular because they are widely
depended on.
2017-01-18 11:23:21 +00:00
Mike McQuaid
44f1c9752a formula: installed_{as_dependency,on_request} hash
Which, in turn, provides them for `brew info --json=v1` so other tools
such as e.g. `brew bundle` can make use of this information.
2017-01-18 11:23:21 +00:00
Mike McQuaid
b99fb56275 tab: store installed_{as_dependency,on_request}.
These are used to determine whether or not a formula’s install was
specifically requested by a user and/or pulled in as a dependency.
2017-01-18 11:23:21 +00:00
Mike McQuaid
4d2201b8be integration_command_test_case: improve fail output
Instead of `puts`ing when the failure occurs save it until the error
message and print a prose description of what the failure was and the
output from the command. This makes the output from failing tests
significantly easier to read.
2017-01-18 08:36:36 +00:00
Mike McQuaid
9f183be358 Merge pull request #1868 from zmwangx/bottle-add-improve-regexp
bottle: add: improve regexp to recognize comments
2017-01-18 08:02:45 +00:00
Mike McQuaid
950e27927b Merge pull request #1869 from MikeMcQuaid/versioned_formula_conflicts_fix
audit: only warn on versioned conflicts_with.
2017-01-17 21:12:37 +00:00
Mike McQuaid
ffa5ebde53 Merge pull request #1863 from alyssais/uses_ignore_untapped
uses: properly handle untapped formulae in recursive dependency expansion (again!)
2017-01-17 19:58:52 +00:00
Mike McQuaid
1497dfaced Merge pull request #1862 from alyssais/uses_include_optional
uses: fix recursive requirement resolution
2017-01-17 19:58:30 +00:00
Zhiming Wang
f0e5ebce06
rubocop_todo: bump max module length to 400 2017-01-17 14:55:00 -05:00
Mike McQuaid
4f0505f759 audit: only warn on versioned conflicts_with.
Rather than all versioned formulae regardless. Oops.
2017-01-17 19:09:41 +00:00
Zhiming Wang
42486c1181
bottle: add: improve regexp to recognize comments
This would have eliminated the need for Homebrew/homebrew-core#9000, for
instance.
2017-01-17 10:26:01 -05:00
Mike McQuaid
a5019d281e Merge pull request #1851 from MikeMcQuaid/keg-only-version
Add `keg_only :versioned_formula`.
2017-01-17 14:22:03 +00:00
Mike McQuaid
fa3d459f5b suite_test: skip flaky test. 2017-01-17 11:18:45 +00:00
Mike McQuaid
dac66c4ada Add keg_only :versioned_formula.
This is used to indicate a formula is a version of another formula.
This will be used to provide a consistent interface for older formulae
versions and replaces the use of `conflicts_with`.
2017-01-17 10:50:04 +00:00
Mike McQuaid
eece7706d1 Merge pull request #1815 from MikeMcQuaid/dependency_to_formula
requirement: get formula from satisfy.
2017-01-17 10:09:05 +00:00
Mike McQuaid
aa104137e5 Merge pull request #1844 from MikeMcQuaid/audit-universal
audit: don't allow universal for new formulae.
2017-01-17 10:08:44 +00:00
Mike McQuaid
052d6077dd Merge pull request #1859 from MikeMcQuaid/brew-create-null-version
create: handle null versions.
2017-01-17 10:07:40 +00:00
Mike McQuaid
85a3940dfa Merge pull request #1861 from MikeMcQuaid/unset-grep-options
Unset GREP_OPTIONS.
2017-01-17 10:07:29 +00:00
Mike McQuaid
3d37e3b67f Merge pull request #1849 from alyssais/requirement_tests
tests: test Formula#recursive_requirements
2017-01-17 09:12:47 +00:00
Alyssa Ross
9475622c07 uses: restore formula-level exception handler
This is a temporary measure until:

- #1862 is merged
- I can a test on `brew uses` against every formula in the official
  taps to verify that exceptions are no longer raised.
2017-01-16 23:28:26 +00:00
Alyssa Ross
0b216798bb Revert "Revert "uses: properly handle untapped fo…
…rmulae in recursive dependency expansion""

This reverts commit dc9819b86c60b5c6fd10373ff318d8ef60f97d52.
2017-01-16 23:28:26 +00:00
Alyssa Ross
36c1c8e9b0 uses: fix recursive requirement resolution
Fixes #1848 by sharing recursive dependency resolution between
dependencies and requirements.

Coincidentally, this also fixes the errors introduced by #1784 that
necessitated it being reverted in #1797.
2017-01-16 23:04:26 +00:00
Alyssa Ross
33b955a3f2 tests: fix style of recursive_requirements tests 2017-01-16 21:58:59 +00:00
Mike McQuaid
6040456ea9 Unset GREP_OPTIONS.
Users may have this set, breaking grep's output.

Fixes #1430.
2017-01-16 20:35:56 +00:00
Mike McQuaid
feea90c0dd create: handle null versions.
Fixes #1821
2017-01-16 20:15:32 +00:00
Mike McQuaid
133e59724a Merge pull request #1763 from minamijoyo/add-feature-github-release-download-strategy
New feature: Allow download from private GitHub repository
2017-01-16 18:52:47 +00:00
Mike McQuaid
02b7ffd89d formula: runtime_dependencies contains requirement formulae.
When a Requirement is converted to a Formula it should be listed under
the runtime dependencies.
2017-01-15 21:04:59 +00:00
Mike McQuaid
c6d7c85d4f Merge pull request #1826 from MikeMcQuaid/remove-to-uninstall-manpage
brew.1: use uninstall instead of remove.
2017-01-15 20:42:52 +00:00
Mike McQuaid
8f88b4c8e6 Merge pull request #1846 from MikeMcQuaid/fix-head-upgrade-man
Fix documentation for HEAD upgrades.
2017-01-15 20:42:23 +00:00
Alyssa Ross
0d9020838f tests: test Formula#recursive_requirements 2017-01-15 19:50:07 +00:00
Mike McQuaid
feddacf829 formula_installer: set specified_path on pour.
This means that a `brew install $ALIAS` records the path accordingly
so  e.g. `Formula#full_installed_specified_name` returns the correct
path.
2017-01-15 14:26:07 +00:00
Mike McQuaid
f4496e85e5 audit: don't allow universal for new formulae.
We're frowning on these now so may as well turn that into code.
2017-01-15 02:31:11 -08:00
Mike McQuaid
7c15944991 Fix documentation for HEAD upgrades.
These can now be done with just `brew upgrade`, like other upgrades.

Fixes #1818.
2017-01-15 02:25:51 -08:00
ilovezfs
9dca10f9dc audit: whitelist unstable versions already in core
also allow higher stable versions with the same version prefix
2017-01-13 18:59:23 -08:00
ilovezfs
1442a0aa7f Merge pull request #1830 from ilovezfs/InreplaceError-fix-undefined-method
InreplaceError: fix undefined method crash
2017-01-13 00:27:18 -08:00
Andrew Janke
62d48b4f9d brew deps --tree: fix gap in line between reqs and deps 2017-01-12 16:08:41 -05:00
ilovezfs
ac7a593730 InreplaceError: fix undefined method crash
When the first parameter to inreplace was an array, and the replacement
failed, InreplaceError would end up crashing with an undefined method
exception because the order of operations resulted in super not being
passed the value of the entire inject block.
2017-01-12 07:22:34 -08:00
Mike McQuaid
3ccbfa72a2 brew.1: use uninstall instead of remove.
Fixes #1817.
2017-01-11 14:19:56 -08:00
Mike McQuaid
5821572b9b formula_installer: don't assume requirement dependency is default formula. 2017-01-11 12:01:08 -08:00
Mike McQuaid
0158cc2e23 build: don't assume requirement dependency is default formula. 2017-01-11 12:01:08 -08:00
Mike McQuaid
fe117bf79b requirement: get formula from satisfy.
If satisfy returns a `Pathname` from `which` then we can use that to
infer a formula dependency from that `Requirement`.
2017-01-11 12:01:08 -08:00
Mike McQuaid
ebf3d939d1 Merge pull request #1808 from MikeMcQuaid/deprecate-linkapps
Deprecate brew (un)linkapps.
2017-01-11 11:13:26 -08:00
Mike McQuaid
0a7e69173d Merge pull request #1816 from MikeMcQuaid/xcode-xquartz-default-path
xcode, xquartz: use default location when possible.
2017-01-11 11:08:52 -08:00
Mike McQuaid
6d13c31fa4 Merge pull request #1814 from MikeMcQuaid/json_runtime_dependencies
formula: return runtime_dependencies in to_hash.
2017-01-11 11:06:49 -08:00
Mike McQuaid
a17f38dd36 xcode: use default location when possible.
Xcode can be installed anywhere but for most people it's in
`/Applications/Xcode.app` so just look there if `xcode-select` isn't
helpful before looking at Spotlight which can return weird results on
e.g. backup disks.

Fixes #1587.
2017-01-09 21:10:55 -08:00