Turns out that this doesn't really work at all. `brew install` _never_
reuses options in the first place, and using this option with `brew
upgrade` results in some nasty corner cases in passing options to
dependencies.
Previously, with nested arrays, the Symbol#to_proc would iterate over
the first item in the nested array instead of the array itself, e.g.:
[[1,2], [3,4]].map(&:first) #=>
NoMethodError: undefined method `first' for 1:Fixnum
With that option iterate only over `Formula.installed`, otherwise
iterate over `Formula`. This is faster than iterating over all the
formulae and checking if it's installed.
FixesHomebrew/homebrew#27259.
ClosesHomebrew/homebrew#27295.
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
In order to allow kegs built with the same version but differing formula
revisions to coexist, we must encode the revision as part of the keg's
name. This is necessary to actually perform an upgrade, as we cannot
upgrade a keg in-place, and temporarily moving it pending the result of
the upgrade is error-prone and potentially slow.
To accomplish this, we introduce a new Formula#pkg_version method that
concatenates the active_spec version with the formula revision. An
exception is made for a formula that has no revision: the tag is
omitted. This preserves compatibility with existing installations.
It is useful to be able to prompt upgrades in response to events other
than a version update; for example, when a dependency is updated and its
library version changes, dependents need to be rebuilt to link against
the new library.
Currently we cannot do this automatically, which means a flood of
tickets whenever the library version of a popular library changes.
To address this, we need to track an additional piece of metadata, the
"revision" of the formula, which can be incremented when appropriate to
prompt an upgrade. It can then be reset to zero when the next version
change occurs.
Change EC2_HOME's value from 'export EC2_HOME="/usr/local/Cellar/ec2-api-tools/1.6.12.0/"'
to 'export EC2_HOME="/usr/local/Cellar/ec2-api-tools/1.6.12.0/libexec"'
Avoide the wrong value of EC_HOME caused by
024208466bfb4ffb479d48709caecc6a1e85ba4d
ClosesHomebrew/homebrew#25918.
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
