35804 Commits

Author SHA1 Message Date
Douglas Eichelberger
79f6c7c7da brew style --fix 2023-04-03 17:35:47 -07:00
Douglas Eichelberger
f3a8241e69 Remove useless T.unsafe wrappers 2023-04-03 17:34:39 -07:00
JBYoshi
8c4f29d983
Don't remove cask directories when upgrading.
Fixes Homebrew/homebrew-cask#102721.
2023-04-03 18:48:24 -05:00
Markus Reiter
cf3054526a
Use select instead of flat_map. 2023-04-03 20:47:15 +02:00
Douglas Eichelberger
c7db55d01b Include prof gem group in sorbet workflow 2023-04-03 11:43:24 -07:00
Carlo Cabrera
4cb50a38c7
Improve versioned macOS test 2023-04-04 02:42:14 +08:00
Carlo Cabrera
839b7d44cc
determine-test-runners: test failure modes 2023-04-04 02:30:13 +08:00
Carlo Cabrera
3d7d4c60f7
determine-test-runners_spec: hardcode fewer things 2023-04-04 02:13:35 +08:00
Carlo Cabrera
a2e97fe1ad
Improve type-checking style
Co-authored-by: Douglas Eichelberger <dduugg@users.noreply.github.com>
2023-04-04 01:54:12 +08:00
Carlo Cabrera
3dc66fae9f
determine-test-runners: add non-trivial tests 2023-04-04 01:46:33 +08:00
Carlo Cabrera
140e751ec6
Fix brew style 2023-04-04 01:12:05 +08:00
Carlo Cabrera
d5dc9ee5e0
determine-test-runners: test --dependents 2023-04-04 01:02:47 +08:00
Carlo Cabrera
4dc370ca24
Add some more tests 2023-04-04 00:45:54 +08:00
Carlo Cabrera
ae63b23472
determine-test-runners: add a test
I'll add more substantial tests shortly, but let's start with this one.
2023-04-03 22:42:00 +08:00
Carlo Cabrera
45fdbbd1c1
determine-test-runners: add type-checking 2023-04-03 22:27:46 +08:00
Carlo Cabrera
dbdff020c0
determine-test-runners: avoid reopening Formula 2023-04-03 21:32:57 +08:00
BrewTestBot
2c920fa614
Update manpage and completions.
Autogenerated by the [sponsors-maintainers-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sponsors-maintainers-man-completions.yml) workflow.
2023-04-03 12:43:09 +00:00
Carlo Cabrera
89cd55c287
dev-cmd/determine-test-runners: add command to set test runners
This is based on feedback from Homebrew/homebrew-core#127236.
2023-04-03 20:36:45 +08:00
Mike McQuaid
a88397096d
Merge pull request #15121 from singingwolfboy/pip-no-build-isolation
Python: allow --no-build-isolation for pip install
2023-04-03 13:14:19 +01:00
Mike McQuaid
6fef708b17
Merge pull request #15120 from apainintheneck/handle-service-run-cmd-string
service: handle string run cmd
2023-04-03 13:02:54 +01:00
Mike McQuaid
7b4c09f41f
Merge pull request #15124 from dduugg/enable-types
Enable types in extensions, etc.
2023-04-03 12:42:21 +01:00
Mike McQuaid
aa894fbfcd
Merge pull request #15127 from issyl0/tap-workflows-bump-actions-cache-version
dev-cmd/tap-new: Use `actions/cache@v3` as v1 is very deprecated
2023-04-03 08:47:16 +01:00
Mike McQuaid
b10ba24c80
Merge pull request #15123 from carlocab/only_dependencies_earlier
install: check for `--only-dependencies` flag earlier
2023-04-03 08:44:38 +01:00
Mike McQuaid
85a1b79154
service: fix typo. 2023-04-03 08:41:21 +01:00
Mike McQuaid
830ec2847b
Merge pull request #15114 from dduugg/ignorable-type
Enable typing in Ignorable
2023-04-03 08:37:34 +01:00
Markus Reiter
6e5ab67838
Consider version of .apps containing installers. 2023-04-03 04:56:37 +02:00
Markus Reiter
cf7a9df923
Include screen savers in :extract_plist strategy. 2023-04-03 03:56:04 +02:00
Douglas Eichelberger
bc588cc04f Fix tests 2023-04-02 16:38:30 -07:00
Issy Long
28f8cbe8da
Handle when the URL has interpolation: use source not str_content
- We see this a lot in real Casks.
2023-04-02 23:39:43 +01:00
Issy Long
41c35986f8
Simplify the 'should not start with https?://' message wording
Co-authored-by: Markus Reiter <me@reitermark.us>
2023-04-02 22:43:57 +01:00
Issy Long
21da074346
Only 'verified' stanzas with 0 or >1 path components should end with "/"
Handle good things like:

```ruby
url "https://example.org/download",
    verified: "example.org/download" # This is fine.
```

And bad things like:

```ruby
url "https://example.org/",
    verified: "example.org" # This should end with a slash.
```
2023-04-02 22:26:23 +01:00
Douglas Eichelberger
4df5a80c73 brew style --fix 2023-04-02 12:25:55 -07:00
Douglas Eichelberger
0079cefc95 Enable types in remaining untyped extensions 2023-04-02 12:24:11 -07:00
Issy Long
17c0eaab25
Fix indentation of verified in url stanza examples 2023-04-02 16:41:29 +01:00
Issy Long
09ce7a1da6
dev-cmd/tap-new: Use actions/cache@v3 as v1 is very deprecated
- We forgot about this workflow when we bumped the versions of our
  actual workflows as part of issue 14692.
2023-04-02 15:43:24 +01:00
Issy Long
b586d97f84
rubocops/cask: Ensure that "verified" URLs with paths end with "/"
- These were being fixed manually[1], so let's make a RuboCop for any
  further occurrences since this is a good rule to enforce[2].

[1] - https://github.com/Homebrew/homebrew-cask/pull/144179#issuecomment-1489857249
[2] - https://github.com/Homebrew/homebrew-cask/pull/80965#issuecomment-616232313
2023-04-02 15:29:53 +01:00
Douglas Eichelberger
6397229f68 Enable types in extensions, etc. 2023-04-01 18:56:42 -07:00
Carlo Cabrera
6c3361e80f
install: check for --only-dependencies flag earlier
Currently, doing `brew install --only-dependencies` with an unlinked
formula does nothing and returns a message saying the formula is already
installed but just not linked.

I think that we should just install the dependencies as requested here
instead of complaining that the formula isn't linked.

Before:

    ❯ brew unlink adplug
    Unlinking /usr/local/Cellar/adplug/2.3.3... 8 symlinks removed.
    ❯ brew install --only-dependencies adplug
    Warning: adplug 2.3.3 is already installed, it's just not linked.
    To link this version, run:
      brew link adplug

After:

    ❯ brew install --only-dependencies adplug
    ==> Fetching dependencies for adplug: libbinio
    ==> Fetching libbinio
    ==> Downloading https://ghcr.io/v2/homebrew/core/libbinio/manifests/1.5
    [snip]

See Homebrew/homebrew-core#127133 for additional context.
2023-04-02 01:39:23 +08:00
Issy Long
c240cf81a4
tests: Remove --display-failures-only from brew audit cmd 2023-04-01 13:44:26 +01:00
David Baumgold
64ff386744 fix tests 2023-04-01 14:32:27 +02:00
David Baumgold
a62543f304 forgot splat 2023-04-01 13:36:58 +02:00
David Baumgold
5f51e1549c unless 2023-04-01 12:36:58 +02:00
David Baumgold
38a2703aa7 Python: allow --no-build-isolation for pip install 2023-04-01 11:31:29 +02:00
apainintheneck
39092fa629 service: handle string run cmd
This was not handled at all during deserialization.
The string argument gets turned into an array internally
but we skip that to preserve all args in the @run_params
variable. That means that we have to handle strings when
deserializing too.
2023-03-31 20:33:21 -07:00
Razvan Azamfirei
dfa7a60038
Feat 2023-03-31 21:23:09 -04:00
Issy Long
e9f233e333
Remove unused output_warnings? Cask audit method 2023-04-01 02:02:23 +01:00
Issy Long
df8e97fef6
Consolidate add_{warning,error} methods into one
- Specify `strictish: true` in `add_error` to specify that it's not a
  super big critical error.
- These will be shown only if `brew audit --strict` is requested.
2023-04-01 01:56:47 +01:00
Issy Long
2b8127d518
Turn cask warnings into errors when --strict is passed (or implied)
- Ignore them and don't show them otherwise.
- Part three of issue 15074:
  > As a result, I propose that all current cask audit warnings are never
  > displayed as warnings but the underlying audit checks turned into
  > errors displayed only with --strict (or one of the other relevant
  > flags).
2023-04-01 01:56:46 +01:00
Issy Long
a4e8f9e22b
audit: Make --display-failures-only the default for Casks
- Cask warnings are really noisy and numerous. Let's only show them if
  the user passes `--strict` or something implying `--strict`, like
  `--new-cask`.
- Additionally remove `display_passes` since we would like silence if
  nothing is wrong with the cask, the same as with formula audits.
2023-04-01 01:56:45 +01:00
Razvan Azamfirei
540a5b9d30
temp 2023-03-31 18:01:34 -04:00